[PR PATCH] inkscape: fix update-check

[PR PATCH] inkscape: fix update-check

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

There is a new pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages inkscape
https://github.com/void-linux/void-packages/pull/44859

inkscape: fix update-check
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

The old Regex also detects development releases (1.3), although it's not an official release yet. (Current should be 1.2.2).

A patch file from https://github.com/void-linux/void-packages/pull/44859.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-inkscape-44859.patch --]
[-- Type: text/x-diff, Size: 560 bytes --]

From 0b3984bf3068b33285af4ec7784a298ba5c65911 Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Wed, 5 Jul 2023 13:26:39 +0200
Subject: [PATCH] inkscape: fix update-check

---
 srcpkgs/inkscape/update | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/inkscape/update b/srcpkgs/inkscape/update
index 2a649bb0bbef..0d1faee432dc 100644
--- a/srcpkgs/inkscape/update
+++ b/srcpkgs/inkscape/update
@@ -1,2 +1,2 @@
 site="https://inkscape.org/release/"
-pattern='release/inkscape-\K[0-9.]+(?=/)'
+pattern='Inkscape \K[0-9.]+'

Re: inkscape: fix update-check

[atk]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New comment by atk on void-packages repository

https://github.com/void-linux/void-packages/pull/44859#issuecomment-1621570051

Comment:
Thanks, I haven't had the time to fix this.

Re: inkscape: fix update-check

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/44859#issuecomment-1621693980

Comment:
It's probably a good idea to mark PRs that just change "update" files as [ci skip], because there's no reason to rebuild the packages.

Re: inkscape: fix update-check

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/44859#issuecomment-1621696505

Comment:
True, makes sense.
It doesn't seem to rebuild the package though, seems to be detected automatically (CI only took 40s for each, but even that could be skipped)

Re: inkscape: fix update-check

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/44859#issuecomment-1621704600

Comment:
Ah, I wasn't aware of that, I thought even changing the update file was enough to make CI rebuild the package. Good to know. :)

Re: [PR PATCH] [Merged]: inkscape: fix update-check

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

There's a merged pull request on the void-packages repository

inkscape: fix update-check
https://github.com/void-linux/void-packages/pull/44859

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

The old Regex also detects development releases (1.3), although it's not an official release yet. (Current should be 1.2.2).

cc @atk