[PR PATCH] xbps-src: add default build option description

[PR PATCH] xbps-src: add default build option description

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

There is a new pull request by Duncaen against master on the void-packages repository

https://github.com/Duncaen/void-packages default-buildopt-description
https://github.com/void-linux/void-packages/pull/45580

xbps-src: add default build option description
Most descriptions already just use this format anyways.

[ci skip]


A patch file from https://github.com/void-linux/void-packages/pull/45580.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-default-buildopt-description-45580.patch --]
[-- Type: text/x-diff, Size: 1174 bytes --]

From a075bbec7a220ae7441e86d019b7bb77e60d7495 Mon Sep 17 00:00:00 2001
From: Duncaen <duncaen@voidlinux.org>
Date: Sun, 13 Aug 2023 16:59:46 +0200
Subject: [PATCH] xbps-src: add default build option description

Most descriptions already just use this format anyways.
---
 common/xbps-src/shutils/show.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/common/xbps-src/shutils/show.sh b/common/xbps-src/shutils/show.sh
index 6ae0f4e6d7df2..606396d2b4b1a 100644
--- a/common/xbps-src/shutils/show.sh
+++ b/common/xbps-src/shutils/show.sh
@@ -129,15 +129,16 @@ show_pkg_makedepends() {
 }
 
 show_pkg_build_options() {
-    local f opt desc
+    local f
 
     [ -z "$PKG_BUILD_OPTIONS" ] && return 0
 
     source $XBPS_COMMONDIR/options.description
     msg_normal "$pkgver: the following build options are set:\n"
     for f in ${PKG_BUILD_OPTIONS}; do
-        opt="${f#\~}"
-        eval desc="\${desc_option_${opt}}"
+        local opt="${f#\~}"
+        local descref="desc_option_${opt}"
+        local desc="${!descref-Enable support for $opt}"
         if [[ ${f:0:1} == '~' ]]; then
             echo "   $opt: $desc (OFF)"
         else

Re: [PR REVIEW] xbps-src: add default build option description

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45580#discussion_r1292808713

Comment:
is `${foo-default}` different from `${foo:-default}`?

Re: [PR REVIEW] xbps-src: add default build option description

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/45580#discussion_r1292814373

Comment:
> Omitting the colon results in a test only for a parameter that is unset.

I guess I can change it to `:-` setting an empty description doesn't make much sense.

Re: [PR REVIEW] xbps-src: add default build option description

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45580#discussion_r1292814539

Comment:
ok just checking, I'm more used to posix parameter expansion

Re: [PR REVIEW] xbps-src: add default build option description

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45580#discussion_r1292814539

Comment:
ok just checking

Re: xbps-src: add default build option description

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/45580#issuecomment-1806971311

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Merged]: xbps-src: add default build option description

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

There's a merged pull request on the void-packages repository

xbps-src: add default build option description
https://github.com/void-linux/void-packages/pull/45580

Description:
Most descriptions already just use this format anyways.

[ci skip]