* Re: [PR PATCH] [Updated] Nim: update to v2.0.0, adopt
2023-08-14 3:59 [PR PATCH] Nim: update to v2.0.0, adopt adigitoleo
@ 2023-08-14 4:01 ` adigitoleo
2023-08-14 5:30 ` Bnyro
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: adigitoleo @ 2023-08-14 4:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
There is an updated pull request by adigitoleo against master on the void-packages repository
https://github.com/adigitoleo/void-packages nim-v2
https://github.com/void-linux/void-packages/pull/45597
Nim: update to v2.0.0, adopt
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64 glibc)
- I built this PR locally for these architectures:
- aarch64
- armv6l
- x86_64-musl
#### Notes
Other than version bumps, the only change is adding `git` as hostmakedepends. The new version of `kock` (Nim build script) clones some extra dependencies for bootstrapping the Nim `libffi`. See <https://github.com/nim-lang/Nim/commit/14bc3f32683c87f971bf23ae30d500dc89cdebb8>.
I'm not sure if I should find a way to patch/disable it instead, or if that is OK.
A patch file from https://github.com/void-linux/void-packages/pull/45597.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nim-v2-45597.patch --]
[-- Type: text/x-diff, Size: 3316 bytes --]
From 631405130fb2a14982df0eda9a631b4ffbc188be Mon Sep 17 00:00:00 2001
From: adigitoleo <adigitoleo@posteo.net>
Date: Mon, 14 Aug 2023 13:34:46 +1000
Subject: [PATCH 1/2] Nim: update to v2.0.0, adopt
---
srcpkgs/nim/template | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/srcpkgs/nim/template b/srcpkgs/nim/template
index 175dcbaea8439..ee04540015153 100644
--- a/srcpkgs/nim/template
+++ b/srcpkgs/nim/template
@@ -1,24 +1,25 @@
# Template file for 'nim'
pkgname=nim
-version=1.6.14
+version=2.0.0
revision=1
-_c1version=561b417c65791cd8356b5f73620914ceff845d10
-_nimbleversion=0.13.1
+_c2version=86742fb02c6606ab01a532a0085784effb2e753e
+_nimbleversion=0.14.2
build_wrksrc="Nim-$version"
depends="gcc openssl-devel"
+hostmakedepends="git"
short_desc="Nim programming language"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Leon (adigitoleo) <adigitoleo@posteo.net>"
license="MIT"
homepage="https://nim-lang.org/"
distfiles="https://github.com/nim-lang/Nim/archive/v${version}.tar.gz
- https://github.com/nim-lang/csources_v1/archive/${_c1version}.tar.gz>csources_v1-${_c1version}.tar.gz
+ https://github.com/nim-lang/csources_v2/archive/${_c2version}.tar.gz>csources_v2-${_c2version}.tar.gz
https://github.com/nim-lang/nimble/archive/v${_nimbleversion}.tar.gz>nimble-${_nimbleversion}.tar.gz"
-checksum="0a31586a6194545be2cfb159189d0f39c8ced2ec134119f3d517dcada9b4aeea
- 71c823444c794a12da9027d19d6a717dd7759521ecbbe28190b08372142607ec
- e6aa8d9ee4b3ed0321dca329b4a38fa546771b9729984482fb50fe73d3777f5d"
+checksum="2d33e3a75fe6d26726de432eb236657b3eadef5727e9c08101a91e06cb0c2dc5
+ 9c2be306011e0c953bd63a565a4bd6a094e22d3944ca201977c1d03560d0a25c
+ d94f11c592d49aed6c5a492289f187010eb8c103b2b653252763d2f65a82abac"
post_extract() {
- mv csources_v1-$_c1version $build_wrksrc/csources_v1
+ mv csources_v2-$_c2version $build_wrksrc/csources_v2
mkdir $build_wrksrc/dist
mv nimble-$_nimbleversion $build_wrksrc/dist/nimble
}
@@ -27,13 +28,13 @@ do_build() {
case "$XBPS_TARGET_MACHINE" in
i686*)
CC=cc LD=cc CFLAGS="-Os -pipe" LDFLAGS= \
- make -C csources_v1 ucpu=i686 ${makejobs};;
+ make -C csources_v2 ucpu=i686 ${makejobs};;
ppc|ppc-musl)
CC=cc LD=cc CFLAGS="-Os -pipe" LDFLAGS= \
- make -C csources_v1 ucpu=powerpc ${makejobs};;
+ make -C csources_v2 ucpu=powerpc ${makejobs};;
*)
CC=cc LD=cc CFLAGS="-Os -pipe" LDFLAGS= \
- make -C csources_v1 ${makejobs};;
+ make -C csources_v2 ${makejobs};;
esac
bin/nim c koch
From dd1ee7c25281d91809e2c25840f51ae86f93bee7 Mon Sep 17 00:00:00 2001
From: adigitoleo <adigitoleo@posteo.net>
Date: Mon, 14 Aug 2023 14:00:47 +1000
Subject: [PATCH 2/2] fix: Place depends= after hostmakedepends=
---
srcpkgs/nim/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/nim/template b/srcpkgs/nim/template
index ee04540015153..0f19e0d9971f2 100644
--- a/srcpkgs/nim/template
+++ b/srcpkgs/nim/template
@@ -5,8 +5,8 @@ revision=1
_c2version=86742fb02c6606ab01a532a0085784effb2e753e
_nimbleversion=0.14.2
build_wrksrc="Nim-$version"
-depends="gcc openssl-devel"
hostmakedepends="git"
+depends="gcc openssl-devel"
short_desc="Nim programming language"
maintainer="Leon (adigitoleo) <adigitoleo@posteo.net>"
license="MIT"
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Nim: update to v2.0.0, adopt
2023-08-14 3:59 [PR PATCH] Nim: update to v2.0.0, adopt adigitoleo
2023-08-14 4:01 ` [PR PATCH] [Updated] " adigitoleo
@ 2023-08-14 5:30 ` Bnyro
2023-08-14 5:30 ` Bnyro
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Bnyro @ 2023-08-14 5:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 313 bytes --]
New comment by Bnyro on void-packages repository
https://github.com/void-linux/void-packages/pull/45597#issuecomment-1676704023
Comment:
Please squash your commits, and the message should be `Nim: update to 2.0.0.`. See [Contributing.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md)
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Nim: update to v2.0.0, adopt
2023-08-14 3:59 [PR PATCH] Nim: update to v2.0.0, adopt adigitoleo
2023-08-14 4:01 ` [PR PATCH] [Updated] " adigitoleo
2023-08-14 5:30 ` Bnyro
@ 2023-08-14 5:30 ` Bnyro
2023-08-14 5:41 ` [PR PATCH] [Updated] " adigitoleo
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Bnyro @ 2023-08-14 5:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
New comment by Bnyro on void-packages repository
https://github.com/void-linux/void-packages/pull/45597#issuecomment-1676704023
Comment:
Please squash your commits, and the message should be `Nim: update to 2.0.0, adopt.` without the "v". See [Contributing.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md)
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PR PATCH] [Updated] Nim: update to v2.0.0, adopt
2023-08-14 3:59 [PR PATCH] Nim: update to v2.0.0, adopt adigitoleo
` (2 preceding siblings ...)
2023-08-14 5:30 ` Bnyro
@ 2023-08-14 5:41 ` adigitoleo
2023-08-14 6:53 ` icp1994
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: adigitoleo @ 2023-08-14 5:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
There is an updated pull request by adigitoleo against master on the void-packages repository
https://github.com/adigitoleo/void-packages nim-v2
https://github.com/void-linux/void-packages/pull/45597
Nim: update to v2.0.0, adopt
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64 glibc)
- I built this PR locally for these architectures:
- aarch64
- armv6l
- x86_64-musl
#### Notes
Other than version bumps, the only change is adding `git` as hostmakedepends. The new version of `kock` (Nim build script) clones some extra dependencies for bootstrapping the Nim `libffi`. See <https://github.com/nim-lang/Nim/commit/14bc3f32683c87f971bf23ae30d500dc89cdebb8>.
I'm not sure if I should find a way to patch/disable it instead, or if that is OK.
A patch file from https://github.com/void-linux/void-packages/pull/45597.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nim-v2-45597.patch --]
[-- Type: text/x-diff, Size: 2539 bytes --]
From 87daa35a2e879945612739bdcbe6607e3b4cb228 Mon Sep 17 00:00:00 2001
From: adigitoleo <adigitoleo@posteo.net>
Date: Mon, 14 Aug 2023 13:34:46 +1000
Subject: [PATCH] Nim: update to 2.0.0, adopt.
---
srcpkgs/nim/template | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/srcpkgs/nim/template b/srcpkgs/nim/template
index 175dcbaea8439..0f19e0d9971f2 100644
--- a/srcpkgs/nim/template
+++ b/srcpkgs/nim/template
@@ -1,24 +1,25 @@
# Template file for 'nim'
pkgname=nim
-version=1.6.14
+version=2.0.0
revision=1
-_c1version=561b417c65791cd8356b5f73620914ceff845d10
-_nimbleversion=0.13.1
+_c2version=86742fb02c6606ab01a532a0085784effb2e753e
+_nimbleversion=0.14.2
build_wrksrc="Nim-$version"
+hostmakedepends="git"
depends="gcc openssl-devel"
short_desc="Nim programming language"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Leon (adigitoleo) <adigitoleo@posteo.net>"
license="MIT"
homepage="https://nim-lang.org/"
distfiles="https://github.com/nim-lang/Nim/archive/v${version}.tar.gz
- https://github.com/nim-lang/csources_v1/archive/${_c1version}.tar.gz>csources_v1-${_c1version}.tar.gz
+ https://github.com/nim-lang/csources_v2/archive/${_c2version}.tar.gz>csources_v2-${_c2version}.tar.gz
https://github.com/nim-lang/nimble/archive/v${_nimbleversion}.tar.gz>nimble-${_nimbleversion}.tar.gz"
-checksum="0a31586a6194545be2cfb159189d0f39c8ced2ec134119f3d517dcada9b4aeea
- 71c823444c794a12da9027d19d6a717dd7759521ecbbe28190b08372142607ec
- e6aa8d9ee4b3ed0321dca329b4a38fa546771b9729984482fb50fe73d3777f5d"
+checksum="2d33e3a75fe6d26726de432eb236657b3eadef5727e9c08101a91e06cb0c2dc5
+ 9c2be306011e0c953bd63a565a4bd6a094e22d3944ca201977c1d03560d0a25c
+ d94f11c592d49aed6c5a492289f187010eb8c103b2b653252763d2f65a82abac"
post_extract() {
- mv csources_v1-$_c1version $build_wrksrc/csources_v1
+ mv csources_v2-$_c2version $build_wrksrc/csources_v2
mkdir $build_wrksrc/dist
mv nimble-$_nimbleversion $build_wrksrc/dist/nimble
}
@@ -27,13 +28,13 @@ do_build() {
case "$XBPS_TARGET_MACHINE" in
i686*)
CC=cc LD=cc CFLAGS="-Os -pipe" LDFLAGS= \
- make -C csources_v1 ucpu=i686 ${makejobs};;
+ make -C csources_v2 ucpu=i686 ${makejobs};;
ppc|ppc-musl)
CC=cc LD=cc CFLAGS="-Os -pipe" LDFLAGS= \
- make -C csources_v1 ucpu=powerpc ${makejobs};;
+ make -C csources_v2 ucpu=powerpc ${makejobs};;
*)
CC=cc LD=cc CFLAGS="-Os -pipe" LDFLAGS= \
- make -C csources_v1 ${makejobs};;
+ make -C csources_v2 ${makejobs};;
esac
bin/nim c koch
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Nim: update to v2.0.0, adopt
2023-08-14 3:59 [PR PATCH] Nim: update to v2.0.0, adopt adigitoleo
` (3 preceding siblings ...)
2023-08-14 5:41 ` [PR PATCH] [Updated] " adigitoleo
@ 2023-08-14 6:53 ` icp1994
2023-08-14 7:45 ` [PR PATCH] [Updated] " adigitoleo
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: icp1994 @ 2023-08-14 6:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
New comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/45597#issuecomment-1676775385
Comment:
It it's only using `git clone`, you can probably get away with
```
PATH=/usr/libexec/chroot-git:$PATH ./koch boot -d:release -d:danger
```
without adding git to depends
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PR PATCH] [Updated] Nim: update to v2.0.0, adopt
2023-08-14 3:59 [PR PATCH] Nim: update to v2.0.0, adopt adigitoleo
` (4 preceding siblings ...)
2023-08-14 6:53 ` icp1994
@ 2023-08-14 7:45 ` adigitoleo
2023-08-14 12:23 ` mhmdanas
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: adigitoleo @ 2023-08-14 7:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
There is an updated pull request by adigitoleo against master on the void-packages repository
https://github.com/adigitoleo/void-packages nim-v2
https://github.com/void-linux/void-packages/pull/45597
Nim: update to v2.0.0, adopt
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64 glibc)
- I built this PR locally for these architectures:
- aarch64
- armv6l
- x86_64-musl
#### Notes
Other than version bumps, the only change is adding `git` as hostmakedepends. The new version of `koch` (Nim build script) clones some extra dependencies for bootstrapping the Nim `libffi`. See <https://github.com/nim-lang/Nim/commit/14bc3f32683c87f971bf23ae30d500dc89cdebb8>.
I'm not sure if I should find a way to patch/disable it instead, or if that is OK.
A patch file from https://github.com/void-linux/void-packages/pull/45597.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nim-v2-45597.patch --]
[-- Type: text/x-diff, Size: 3125 bytes --]
From f25fcf94fc666c373765377830cfa3fd95bdc7a6 Mon Sep 17 00:00:00 2001
From: adigitoleo <adigitoleo@posteo.net>
Date: Mon, 14 Aug 2023 13:34:46 +1000
Subject: [PATCH] Nim: update to 2.0.0, adopt.
---
srcpkgs/nim/template | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/srcpkgs/nim/template b/srcpkgs/nim/template
index 175dcbaea8439..950dd799cfbdf 100644
--- a/srcpkgs/nim/template
+++ b/srcpkgs/nim/template
@@ -1,24 +1,24 @@
# Template file for 'nim'
pkgname=nim
-version=1.6.14
+version=2.0.0
revision=1
-_c1version=561b417c65791cd8356b5f73620914ceff845d10
-_nimbleversion=0.13.1
+_c2version=86742fb02c6606ab01a532a0085784effb2e753e
+_nimbleversion=0.14.2
build_wrksrc="Nim-$version"
depends="gcc openssl-devel"
short_desc="Nim programming language"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Leon (adigitoleo) <adigitoleo@posteo.net>"
license="MIT"
homepage="https://nim-lang.org/"
distfiles="https://github.com/nim-lang/Nim/archive/v${version}.tar.gz
- https://github.com/nim-lang/csources_v1/archive/${_c1version}.tar.gz>csources_v1-${_c1version}.tar.gz
+ https://github.com/nim-lang/csources_v2/archive/${_c2version}.tar.gz>csources_v2-${_c2version}.tar.gz
https://github.com/nim-lang/nimble/archive/v${_nimbleversion}.tar.gz>nimble-${_nimbleversion}.tar.gz"
-checksum="0a31586a6194545be2cfb159189d0f39c8ced2ec134119f3d517dcada9b4aeea
- 71c823444c794a12da9027d19d6a717dd7759521ecbbe28190b08372142607ec
- e6aa8d9ee4b3ed0321dca329b4a38fa546771b9729984482fb50fe73d3777f5d"
+checksum="2d33e3a75fe6d26726de432eb236657b3eadef5727e9c08101a91e06cb0c2dc5
+ 9c2be306011e0c953bd63a565a4bd6a094e22d3944ca201977c1d03560d0a25c
+ d94f11c592d49aed6c5a492289f187010eb8c103b2b653252763d2f65a82abac"
post_extract() {
- mv csources_v1-$_c1version $build_wrksrc/csources_v1
+ mv csources_v2-$_c2version $build_wrksrc/csources_v2
mkdir $build_wrksrc/dist
mv nimble-$_nimbleversion $build_wrksrc/dist/nimble
}
@@ -27,17 +27,17 @@ do_build() {
case "$XBPS_TARGET_MACHINE" in
i686*)
CC=cc LD=cc CFLAGS="-Os -pipe" LDFLAGS= \
- make -C csources_v1 ucpu=i686 ${makejobs};;
+ make -C csources_v2 ucpu=i686 ${makejobs};;
ppc|ppc-musl)
CC=cc LD=cc CFLAGS="-Os -pipe" LDFLAGS= \
- make -C csources_v1 ucpu=powerpc ${makejobs};;
+ make -C csources_v2 ucpu=powerpc ${makejobs};;
*)
CC=cc LD=cc CFLAGS="-Os -pipe" LDFLAGS= \
- make -C csources_v1 ${makejobs};;
+ make -C csources_v2 ${makejobs};;
esac
bin/nim c koch
- ./koch boot -d:release -d:danger
+ PATH=/usr/libexec/chroot-git:$PATH ./koch boot -d:release -d:danger
case "$XBPS_TARGET_MACHINE" in
aarch64*) _arch=arm64;;
@@ -56,10 +56,10 @@ do_build() {
$_arch.linux.gcc.linkerexe = "$CC"
EDIT
bin/nim c -d:release -d:danger --os:linux --cpu:$_arch --listCmd compiler/nim
- ./koch tools --os:linux --cpu:$_arch --listCmd
+ PATH=/usr/libexec/chroot-git:$PATH ./koch tools --os:linux --cpu:$_arch --listCmd
vsed -i config/nim.cfg -e '/^# VOIDLINUX TEMP$/,$d'
;; *)
- ./koch tools
+ PATH=/usr/libexec/chroot-git:$PATH ./koch tools
esac
}
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Nim: update to v2.0.0, adopt
2023-08-14 3:59 [PR PATCH] Nim: update to v2.0.0, adopt adigitoleo
` (5 preceding siblings ...)
2023-08-14 7:45 ` [PR PATCH] [Updated] " adigitoleo
@ 2023-08-14 12:23 ` mhmdanas
2023-08-14 12:30 ` mhmdanas
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: mhmdanas @ 2023-08-14 12:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/45597#issuecomment-1677220948
Comment:
@adigitoleo this seems to be your first contribution to void-packages, so the team will probably be hesitant to have you adopt the package right now, until you demonstrate a longer history of contributions. From https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#adopting-a-template:
> To ensure a template gets the care it needs, template adopters should be familiar with the package and have an established history of contributions to Void. Those who have contributed several updates, especially for the template in question, are good candidates for template maintainership.
Also, the package name is `nim`, not `Nim`, so please update your commit message and PR title accordingly.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Nim: update to v2.0.0, adopt
2023-08-14 3:59 [PR PATCH] Nim: update to v2.0.0, adopt adigitoleo
` (6 preceding siblings ...)
2023-08-14 12:23 ` mhmdanas
@ 2023-08-14 12:30 ` mhmdanas
2023-08-14 16:50 ` adigitoleo
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: mhmdanas @ 2023-08-14 12:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/45597#issuecomment-1677220948
Comment:
@adigitoleo this seems to be your first contribution to void-packages, so the team will probably be hesitant to have you adopt the package right now, until you demonstrate a longer history of contributions. From https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#adopting-a-template:
> To ensure a template gets the care it needs, template adopters should be familiar with the package and have an established history of contributions to Void. Those who have contributed several updates, especially for the template in question, are good candidates for template maintainership.
Also, the package name is `nim`, not `Nim`, so please update your commit message and PR title accordingly.
Edit: I was tricked by you lacking a "Contributor" badge (not sure why it's missing...), you did have one PR merged before. Pardon my misunderstanding.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Nim: update to v2.0.0, adopt
2023-08-14 3:59 [PR PATCH] Nim: update to v2.0.0, adopt adigitoleo
` (7 preceding siblings ...)
2023-08-14 12:30 ` mhmdanas
@ 2023-08-14 16:50 ` adigitoleo
2023-08-17 10:43 ` IcedQuinn
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: adigitoleo @ 2023-08-14 16:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
New comment by adigitoleo on void-packages repository
https://github.com/void-linux/void-packages/pull/45597#issuecomment-1677696273
Comment:
@mhmdanas Happy to leave as orphaned if preferrable. Lack of badge could be due to changing git email recently (my old mail provider proved unreliable). Let me know if I should leave as orphaned and I'll update as requested.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Nim: update to v2.0.0, adopt
2023-08-14 3:59 [PR PATCH] Nim: update to v2.0.0, adopt adigitoleo
` (8 preceding siblings ...)
2023-08-14 16:50 ` adigitoleo
@ 2023-08-17 10:43 ` IcedQuinn
2023-08-20 11:51 ` adigitoleo
2023-08-20 11:51 ` [PR PATCH] [Closed]: " adigitoleo
11 siblings, 0 replies; 13+ messages in thread
From: IcedQuinn @ 2023-08-17 10:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 434 bytes --]
New comment by IcedQuinn on void-packages repository
https://github.com/void-linux/void-packages/pull/45597#issuecomment-1682055495
Comment:
I stepped on this particular face rake the last time we had to update Nim. The package lords did not like network calls during a build.
I worked around the problem in #45627 by downloading the subrepositories through the Github zip service and positioning the files where they should be.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Nim: update to v2.0.0, adopt
2023-08-14 3:59 [PR PATCH] Nim: update to v2.0.0, adopt adigitoleo
` (9 preceding siblings ...)
2023-08-17 10:43 ` IcedQuinn
@ 2023-08-20 11:51 ` adigitoleo
2023-08-20 11:51 ` [PR PATCH] [Closed]: " adigitoleo
11 siblings, 0 replies; 13+ messages in thread
From: adigitoleo @ 2023-08-20 11:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
New comment by adigitoleo on void-packages repository
https://github.com/void-linux/void-packages/pull/45597#issuecomment-1685264112
Comment:
@IcedQuinn thanks, that does seem like a better solution. I see that your template also installs `atlas` which I missed here. I'll close this in favour of #45627 in that case.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PR PATCH] [Closed]: Nim: update to v2.0.0, adopt
2023-08-14 3:59 [PR PATCH] Nim: update to v2.0.0, adopt adigitoleo
` (10 preceding siblings ...)
2023-08-20 11:51 ` adigitoleo
@ 2023-08-20 11:51 ` adigitoleo
11 siblings, 0 replies; 13+ messages in thread
From: adigitoleo @ 2023-08-20 11:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
There's a closed pull request on the void-packages repository
Nim: update to v2.0.0, adopt
https://github.com/void-linux/void-packages/pull/45597
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64 glibc)
- I built this PR locally for these architectures:
- aarch64
- armv6l
- x86_64-musl
#### Notes
Other than version bumps, the only change is adding `git` as hostmakedepends. The new version of `koch` (Nim build script) clones some extra dependencies for bootstrapping the Nim `libffi`. See <https://github.com/nim-lang/Nim/commit/14bc3f32683c87f971bf23ae30d500dc89cdebb8>.
I'm not sure if I should find a way to patch/disable it instead, or if that is OK.
^ permalink raw reply [flat|nested] 13+ messages in thread