[PR PATCH] metalog: fix bleeding logs onto tty1

[PR PATCH] metalog: fix bleeding logs onto tty1

[shahab-vahedi]

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

There is a new pull request by shahab-vahedi against master on the void-packages repository

https://github.com/shahab-vahedi/void-packages fix-metalog-bleeding
https://github.com/void-linux/void-packages/pull/45700

metalog: fix bleeding logs onto tty1
This fixes issue #45653 [1].

[1]
https://github.com/void-linux/void-packages/issues/45653

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/45700.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-metalog-bleeding-45700.patch --]
[-- Type: text/x-diff, Size: 1165 bytes --]

From dd818adeb1091a0fc72bd217d09cbdba809b4597 Mon Sep 17 00:00:00 2001
From: Shahab Vahedi <16524902+shahab-vahedi@users.noreply.github.com>
Date: Mon, 21 Aug 2023 10:41:28 +0200
Subject: [PATCH] metalog: fix bleeding logs onto tty1

This fixes issue #45653 [1].

[1]
https://github.com/void-linux/void-packages/issues/45653
---
 srcpkgs/metalog/files/metalog/run | 1 -
 srcpkgs/metalog/template          | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/srcpkgs/metalog/files/metalog/run b/srcpkgs/metalog/files/metalog/run
index 5b7ff14eba605..0f801d171017e 100755
--- a/srcpkgs/metalog/files/metalog/run
+++ b/srcpkgs/metalog/files/metalog/run
@@ -1,5 +1,4 @@
 #!/bin/sh
-exec 2>&1
 exec 1>&2
 [ -r conf ] && . ./conf
 exec metalog ${OPTS=-v}
diff --git a/srcpkgs/metalog/template b/srcpkgs/metalog/template
index 1f1a4c5c9496f..ed5e4435a6213 100644
--- a/srcpkgs/metalog/template
+++ b/srcpkgs/metalog/template
@@ -1,7 +1,7 @@
 # Template file for 'metalog'
 pkgname=metalog
 version=20230719
-revision=1
+revision=2
 build_style=gnu-configure
 conf_files="/etc/metalog.conf"
 hostmakedepends="autoconf autoconf-archive automake pkg-config"

Re: [PR PATCH] [Updated] metalog: fix bleeding logs onto tty1

[shahab-vahedi]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

There is an updated pull request by shahab-vahedi against master on the void-packages repository

https://github.com/shahab-vahedi/void-packages fix-metalog-bleeding
https://github.com/void-linux/void-packages/pull/45700

metalog: fix bleeding logs onto tty1
This fixes issue #45653 [1].

[1]
https://github.com/void-linux/void-packages/issues/45653

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/45700.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-metalog-bleeding-45700.patch --]
[-- Type: text/x-diff, Size: 1140 bytes --]

From b4b4ebfd16287bad307feb0c6561e17a62c2a028 Mon Sep 17 00:00:00 2001
From: Shahab Vahedi <shahabvahedi@gmail.com>
Date: Mon, 21 Aug 2023 13:46:03 +0200
Subject: [PATCH] metalog: fix bleeding logs onto tty1

This fixes issue #45653 [1].

[1]
https://github.com/void-linux/void-packages/issues/45653
---
 srcpkgs/metalog/files/metalog/run | 1 -
 srcpkgs/metalog/template          | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/srcpkgs/metalog/files/metalog/run b/srcpkgs/metalog/files/metalog/run
index 5b7ff14eba605..0f801d171017e 100755
--- a/srcpkgs/metalog/files/metalog/run
+++ b/srcpkgs/metalog/files/metalog/run
@@ -1,5 +1,4 @@
 #!/bin/sh
-exec 2>&1
 exec 1>&2
 [ -r conf ] && . ./conf
 exec metalog ${OPTS=-v}
diff --git a/srcpkgs/metalog/template b/srcpkgs/metalog/template
index 1f1a4c5c9496f..ed5e4435a6213 100644
--- a/srcpkgs/metalog/template
+++ b/srcpkgs/metalog/template
@@ -1,7 +1,7 @@
 # Template file for 'metalog'
 pkgname=metalog
 version=20230719
-revision=1
+revision=2
 build_style=gnu-configure
 conf_files="/etc/metalog.conf"
 hostmakedepends="autoconf autoconf-archive automake pkg-config"

Re: metalog: fix bleeding logs onto tty1

[aryandb]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by aryandb on void-packages repository

https://github.com/void-linux/void-packages/pull/45700#issuecomment-1686563601

Comment:
I think running it az deamon should fix the tty problem. Just add `-B` option.

Re: metalog: fix bleeding logs onto tty1

[aryandb]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by aryandb on void-packages repository

https://github.com/void-linux/void-packages/pull/45700#issuecomment-1686563601

Comment:
I think running it as deamon should fix the tty problem. Just add `-B` option.

Re: metalog: fix bleeding logs onto tty1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/45700#issuecomment-1686577804

Comment:
> I think running it as deamon should fix the tty problem. Just add `-B` option.

No runit services are required to run in the foreground.


Just removing this line is probably not the right solution, output redirected to `stdout` will be written to the commandline of the `runsvdir` process as fallback logging mechanism.

This fallback mechanism shouldn't be used as general logging target where everything is logged to, its already bad user experience, but duplicating all syslog messages into it just makes it even more useless.

Re: metalog: fix bleeding logs onto tty1

[shahab-vahedi]

[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]

New comment by shahab-vahedi on void-packages repository

https://github.com/void-linux/void-packages/pull/45700#issuecomment-1686804956

Comment:
I agree with your points @Duncaen . There are a few things to note here:

1. Currently, both `exec 2>&1` and `exec 1>&2` exist in the `run` script.
2. There is a default `-v` passed to the program, which I think is unnecessary. The maintainer [thinks](https://github.com/void-linux/void-packages/issues/45653#issuecomment-1683718365) the same.
3. The `log` part of this daemon is [removed](https://github.com/void-linux/void-packages/blob/master/srcpkgs/metalog/template#L26).

If you help me in the right direction, I want to address them all.

Should I put back the `exec 2>&1` and remove `exec 1>&2`, while replacing `-v` with `-B` as the default parameter as @aryandb [suggested](https://github.com/void-linux/void-packages/pull/45700#issuecomment-1686563601)? Should I put the logging part back in? As it is, it does stop a user from logging into the system.

Re: metalog: fix bleeding logs onto tty1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/45700#issuecomment-1686820684

Comment:
Seems like the solution is to discard `stdout` where metalog prints every log line it receives https://github.com/hvisage/metalog/blob/bb7c007cbc0815fd08e9259b26dcef26020217d0/src/metalog.c#L1412.

And to keep the error messges from `err(3)`, either keep stderr open and leave it there so the error messages end up in the fallback mechanism, or redirect them to stdout which makes them end up in `/dev/console` without having a log service.

```
#!/bin/sh
[ -r conf ] && . ./conf
exec metalog ${OPTS} >/dev/null
```

Re: metalog: fix bleeding logs onto tty1

[shahab-vahedi]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

New comment by shahab-vahedi on void-packages repository

https://github.com/void-linux/void-packages/pull/45700#issuecomment-1686829278

Comment:
I've tried this and everything seems to work fine, I even put back the `log` facility.

```
#!/bin/sh
exec 2>&1
[ -r conf ] && . ./conf
exec metalog ${OPTS=-B}
```

If you agree, I'll push my latest changes.

Re: [PR PATCH] [Updated] metalog: fix bleeding logs onto tty1

[shahab-vahedi]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

There is an updated pull request by shahab-vahedi against master on the void-packages repository

https://github.com/shahab-vahedi/void-packages fix-metalog-bleeding
https://github.com/void-linux/void-packages/pull/45700

metalog: fix bleeding logs onto tty1
This fixes issue #45653 [1].

[1]
https://github.com/void-linux/void-packages/issues/45653

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/45700.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-metalog-bleeding-45700.patch --]
[-- Type: text/x-diff, Size: 1613 bytes --]

From ab6e9d7bc257635438666bc69c5d08e5d5d94963 Mon Sep 17 00:00:00 2001
From: Shahab Vahedi <shahabvahedi@gmail.com>
Date: Mon, 21 Aug 2023 13:46:03 +0200
Subject: [PATCH] metalog: fix bleeding logs onto tty1

This fixes issue #45653 [1]. There are 3 changes involved:

1. Daemonize the process (thanks Aryan DB) and drop the verbosity.
2. Keep "exec 2>&1" and drop the "exec 1>&2" (thanks Duncaen)
3. Put the log facility back

[1]
https://github.com/void-linux/void-packages/issues/45653
---
 srcpkgs/metalog/files/metalog/run | 3 +--
 srcpkgs/metalog/template          | 6 +-----
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/metalog/files/metalog/run b/srcpkgs/metalog/files/metalog/run
index 5b7ff14eba605..ed330dd85974b 100755
--- a/srcpkgs/metalog/files/metalog/run
+++ b/srcpkgs/metalog/files/metalog/run
@@ -1,5 +1,4 @@
 #!/bin/sh
 exec 2>&1
-exec 1>&2
 [ -r conf ] && . ./conf
-exec metalog ${OPTS=-v}
+exec metalog ${OPTS=-B}
diff --git a/srcpkgs/metalog/template b/srcpkgs/metalog/template
index 1f1a4c5c9496f..9e080d7e19388 100644
--- a/srcpkgs/metalog/template
+++ b/srcpkgs/metalog/template
@@ -1,7 +1,7 @@
 # Template file for 'metalog'
 pkgname=metalog
 version=20230719
-revision=1
+revision=2
 build_style=gnu-configure
 conf_files="/etc/metalog.conf"
 hostmakedepends="autoconf autoconf-archive automake pkg-config"
@@ -20,8 +20,4 @@ pre_configure() {
 
 post_install() {
 	vsv metalog
-
-	# Disable logging for metaloga to avoid any issues
-	# https://github.com/void-linux/void-packages/pull/44912#issuecomment-1625625388
-	rm -rf "${DESTDIR}/etc/sv/metalog/log"
 }

Re: metalog: fix bleeding logs onto tty1

[shahab-vahedi]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

New comment by shahab-vahedi on void-packages repository

https://github.com/void-linux/void-packages/pull/45700#issuecomment-1686829278

Comment:
I've tried this and everything seems to work fine, I even put back the `log` facility.

```
#!/bin/sh
exec 2>&1
[ -r conf ] && . ./conf
exec metalog ${OPTS=-B}
```

If you agree, I'll push my latest changes.

EDIT: just forced push, so you could see the whole commit.

Re: metalog: fix bleeding logs onto tty1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/45700#issuecomment-1686849912

Comment:
`-B` is completely wrong, do not use `-B` at all.

Re: metalog: fix bleeding logs onto tty1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/45700#issuecomment-1686852253

Comment:
Do not bring back the log service it makes no sense, if `metalog` writes error messages, then there is probably a bigger issue, sending them back to metalog most likely doesn't work.

Re: metalog: fix bleeding logs onto tty1

[aryandb]

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

New comment by aryandb on void-packages repository

https://github.com/void-linux/void-packages/pull/45700#issuecomment-1686869756

Comment:
> `-B` is completely wrong, do not use `-B` at all.

@shahab-vahedi 
Yes it's true. i was completely wrong and sorry for confusion. If you add `-B` runit just keep spawning `metalog`. do not add that.

Re: [PR PATCH] [Updated] metalog: fix bleeding logs onto tty1

[shahab-vahedi]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

There is an updated pull request by shahab-vahedi against master on the void-packages repository

https://github.com/shahab-vahedi/void-packages fix-metalog-bleeding
https://github.com/void-linux/void-packages/pull/45700

metalog: fix bleeding logs onto tty1
This fixes issue #45653 [1].

[1]
https://github.com/void-linux/void-packages/issues/45653

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/45700.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-metalog-bleeding-45700.patch --]
[-- Type: text/x-diff, Size: 1323 bytes --]

From 29cb35175ff0fdf92ecad7a2bf7faadcd0123223 Mon Sep 17 00:00:00 2001
From: Shahab Vahedi <shahabvahedi@gmail.com>
Date: Mon, 21 Aug 2023 13:46:03 +0200
Subject: [PATCH] metalog: fix bleeding logs onto tty1

This fixes issue #45653 [1]. There are 2 changes involved:

1. Drop the verbosity.
2. Redirect stdout to void (pun intented).

This patch is practically Duncaen's suggestion.

[1]
https://github.com/void-linux/void-packages/issues/45653
---
 srcpkgs/metalog/files/metalog/run | 4 +---
 srcpkgs/metalog/template          | 2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/metalog/files/metalog/run b/srcpkgs/metalog/files/metalog/run
index 5b7ff14eba605..04b457baae764 100755
--- a/srcpkgs/metalog/files/metalog/run
+++ b/srcpkgs/metalog/files/metalog/run
@@ -1,5 +1,3 @@
 #!/bin/sh
-exec 2>&1
-exec 1>&2
 [ -r conf ] && . ./conf
-exec metalog ${OPTS=-v}
+exec metalog ${OPTS} >/dev/null
diff --git a/srcpkgs/metalog/template b/srcpkgs/metalog/template
index 1f1a4c5c9496f..ed5e4435a6213 100644
--- a/srcpkgs/metalog/template
+++ b/srcpkgs/metalog/template
@@ -1,7 +1,7 @@
 # Template file for 'metalog'
 pkgname=metalog
 version=20230719
-revision=1
+revision=2
 build_style=gnu-configure
 conf_files="/etc/metalog.conf"
 hostmakedepends="autoconf autoconf-archive automake pkg-config"

Re: metalog: fix bleeding logs onto tty1

[shahab-vahedi]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by shahab-vahedi on void-packages repository

https://github.com/void-linux/void-packages/pull/45700#issuecomment-1686946152

Comment:
OK @Duncaen I practically took your changes.

Re: metalog: fix bleeding logs onto tty1

[shahab-vahedi]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by shahab-vahedi on void-packages repository

https://github.com/void-linux/void-packages/pull/45700#issuecomment-1694495134

Comment:
Ping.

Re: metalog: fix bleeding logs onto tty1

[shahab-vahedi]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by shahab-vahedi on void-packages repository

https://github.com/void-linux/void-packages/pull/45700#issuecomment-1700901169

Comment:
Ping.

Re: [PR PATCH] [Merged]: metalog: fix bleeding logs onto tty1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

There's a merged pull request on the void-packages repository

metalog: fix bleeding logs onto tty1
https://github.com/void-linux/void-packages/pull/45700

Description:
This fixes issue #45653 [1].

[1]
https://github.com/void-linux/void-packages/issues/45653

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-glibc