Github messages for voidlinux
 help / color / mirror / Atom feed
From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: sagemath: use cython 3
Date: Sun, 03 Sep 2023 03:24:14 +0200	[thread overview]
Message-ID: <20230903012414.V9bCLl8ry3YdPYhWIWcF_TP98jZT2CDHGK_a9KhnJ5A@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45887@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/45887#issuecomment-1703979657

Comment:
> What is the benefit of building with Cython 3 in advance of an official Sage release that includes these changes?

Mainly that I can install cython 3 together with sagemath, which is quite useful for me to test beta releases of sagemath and proposed PRs in advance. But that's just me and I can build this locally myself.

Running this PR through CI is a way to make sure everything works fine for us, which is good feedback to give upstream before they do the next release, in particular https://github.com/sagemath/sage/pull/36110 is still not given positive review and the fact that we have tested it onthree different architectures is useful (unfortunately some deps are nocross).

I noticed that you made it so cython 3 can replace cython 0.29, but some  I'm now runing tests under this scenario, and there are a couple of failures (mainly because a mismatch in the type of cython functions between version 0.29 and 3.x).

  parent reply	other threads:[~2023-09-03  1:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-02 22:32 [PR PATCH] " tornaria
2023-09-02 22:37 ` [PR PATCH] [Updated] " tornaria
2023-09-02 23:33 ` ahesford
2023-09-03  1:24 ` tornaria [this message]
2023-09-03  1:59 ` ahesford
2023-09-03  2:00 ` ahesford
2023-09-04 13:21 ` tornaria
2023-09-05 11:57 ` [PR PATCH] [Updated] " tornaria
2023-09-06 14:50 ` ahesford
2023-09-07  1:32 ` ahesford
2023-09-09 15:33 ` tornaria
2023-09-11  0:02 ` ahesford
2023-10-09 21:55 ` [PR PATCH] [Updated] " tornaria
2023-10-09 22:01 ` tornaria
2023-10-10 12:42 ` [PR PATCH] [Updated] " tornaria
2023-10-10 12:43 ` tornaria
2023-10-22 14:50 ` tornaria
2023-10-22 14:50 ` [PR PATCH] [Closed]: " tornaria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230903012414.V9bCLl8ry3YdPYhWIWcF_TP98jZT2CDHGK_a9KhnJ5A@z \
    --to=tornaria@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).