Github messages for voidlinux
 help / color / mirror / Atom feed
From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: sagemath: use cython 3
Date: Sat, 09 Sep 2023 17:33:10 +0200	[thread overview]
Message-ID: <20230909153310.wSxQN9NduIZlttedrNhXnwXB8JL328WBlCBtwNCwi8A@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45887@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/45887#issuecomment-1712538236

Comment:
> After an out-of-band discussion about this PR, I am less concerned about carrying these patches.

After thinking it thoroughly I don't think there is a rush to have sagemath with cython 3 merged (even if I believe the patches to be pretty safe). Since nothing in the repo depends on `python-Cython`, there is no conflict at all in that sagemath depends on `python-Cython0.29`. Functionally there should be no difference (for the time being... cython 3 unlocks some features that will eventually be used in sagemath).

I'm happy to either close or move to draft this PR. In any case this will stay available for whoever needs to run sagemath on cython3.

> That said, is there any argument in favor of just bumping `sagemath` to 10.2.beta1 rather than patching 10.1?

We've tried to stick with releases rather than betas. The problem with betas is that sometimes there are features that are "half-merged" so I wouldn't be confident. I much prefer cherry-picking PRs that have been already merged and beta-released. I also try to only use patches I personally review (the 9k lines patch I actually read line by line and positive review myself).

OTOH, sometimes I consider having some package "sagemath-next" which previews the future sagemath (carrying the latest beta / rc) in a way that it can coexist with "sagemath".

  parent reply	other threads:[~2023-09-09 15:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-02 22:32 [PR PATCH] " tornaria
2023-09-02 22:37 ` [PR PATCH] [Updated] " tornaria
2023-09-02 23:33 ` ahesford
2023-09-03  1:24 ` tornaria
2023-09-03  1:59 ` ahesford
2023-09-03  2:00 ` ahesford
2023-09-04 13:21 ` tornaria
2023-09-05 11:57 ` [PR PATCH] [Updated] " tornaria
2023-09-06 14:50 ` ahesford
2023-09-07  1:32 ` ahesford
2023-09-09 15:33 ` tornaria [this message]
2023-09-11  0:02 ` ahesford
2023-10-09 21:55 ` [PR PATCH] [Updated] " tornaria
2023-10-09 22:01 ` tornaria
2023-10-10 12:42 ` [PR PATCH] [Updated] " tornaria
2023-10-10 12:43 ` tornaria
2023-10-22 14:50 ` tornaria
2023-10-22 14:50 ` [PR PATCH] [Closed]: " tornaria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230909153310.wSxQN9NduIZlttedrNhXnwXB8JL328WBlCBtwNCwi8A@z \
    --to=tornaria@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).