Github messages for voidlinux
 help / color / mirror / Atom feed
From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: sagemath: use cython 3
Date: Sun, 22 Oct 2023 16:50:49 +0200	[thread overview]
Message-ID: <20231022145049.BfW4PBIPXBktx4Av0j89VvF-RaD__5toMJA4J9VRJqc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45887@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2275 bytes --]

There's a closed pull request on the void-packages repository

sagemath: use cython 3
https://github.com/void-linux/void-packages/pull/45887

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

Since https://github.com/sagemath/sage/pull/36109 was merged upstream, it's now almost trivial to build sagemath with cython 3. This PR is pretty straightforward to understand:

 - commit 7f8e6514ffa54449a80e01fbae7f9355a7739a46 rebuilds `python3-pplpy` using cython 3. Nothing fancy here and this commit was already tested and only dropped since it turned out it had to be built with the same version of cython as sagemath itself.
 - commit df0d21871ce850efea3fc01f19a3d9e8c0d5f0d4 is just adding a few patches to sagemath, switching to cython 3, and bumping.

Description of added patches:
1. patch `36109-00pre.patch`: this is hand picked trivial patch that allows us to apply https://github.com/sagemath/sage/pull/36109 cleanly on 10.1 (since that PR is based on 10.1.beta0). All changes are comments!
2. patch `36109-prepare_for_cython_3.0.patch`: this is long, taken verbatim from https://github.com/sagemath/sage/pull/36109.diff, and is already merged.
3. patch `build-cython3.patch`: this is 2 lines changed plus 4 legacy build options added to cython setup.
4. patch `fix-doctest-cython3.patch`: this is a few fixes in doctests to accomodate minor changes in cython output (`__repr__` for cython classes, functions, and generators).

CC: @ahesford 

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


  parent reply	other threads:[~2023-10-22 14:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-02 22:32 [PR PATCH] " tornaria
2023-09-02 22:37 ` [PR PATCH] [Updated] " tornaria
2023-09-02 23:33 ` ahesford
2023-09-03  1:24 ` tornaria
2023-09-03  1:59 ` ahesford
2023-09-03  2:00 ` ahesford
2023-09-04 13:21 ` tornaria
2023-09-05 11:57 ` [PR PATCH] [Updated] " tornaria
2023-09-06 14:50 ` ahesford
2023-09-07  1:32 ` ahesford
2023-09-09 15:33 ` tornaria
2023-09-11  0:02 ` ahesford
2023-10-09 21:55 ` [PR PATCH] [Updated] " tornaria
2023-10-09 22:01 ` tornaria
2023-10-10 12:42 ` [PR PATCH] [Updated] " tornaria
2023-10-10 12:43 ` tornaria
2023-10-22 14:50 ` tornaria [this message]
2023-10-22 14:50 ` tornaria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231022145049.BfW4PBIPXBktx4Av0j89VvF-RaD__5toMJA4J9VRJqc@z \
    --to=tornaria@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).