[PR PATCH] wf-recorder: update to 0.4.0.

[PR PATCH] wf-recorder: update to 0.4.0.

[jony255]

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

There is a new pull request by jony255 against master on the void-packages repository

https://github.com/jony255/void-packages wf-recorder
https://github.com/void-linux/void-packages/pull/45884

wf-recorder: update to 0.4.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: briefly

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64
  - aarch64
  - aarch64-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/45884.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wf-recorder-45884.patch --]
[-- Type: text/x-diff, Size: 1363 bytes --]

From 6c1101df193fd4903cccc9944f06c4fca6528212 Mon Sep 17 00:00:00 2001
From: Jony <maybe-one-day-ubermensch@protonmail.com>
Date: Sun, 27 Aug 2023 15:57:14 -0700
Subject: [PATCH] wf-recorder: update to 0.4.0.

---
 srcpkgs/wf-recorder/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/wf-recorder/template b/srcpkgs/wf-recorder/template
index e278eb001600f..e09941ec52916 100644
--- a/srcpkgs/wf-recorder/template
+++ b/srcpkgs/wf-recorder/template
@@ -1,17 +1,17 @@
 # Template file for 'wf-recorder'
 pkgname=wf-recorder
-version=0.3.0
+version=0.4.0
 revision=1
 build_style=meson
 hostmakedepends="pkg-config scdoc wayland-devel"
-makedepends="wayland-protocols wayland-devel ffmpeg-devel x264-devel
+makedepends="wayland-protocols wayland-devel ffmpeg-devel libgbm-devel x264-devel
 	pulseaudio-devel"
 short_desc="Screen recorder for wlroots-based compositors"
 maintainer="Jony <maybe-one-day-ubermensch@protonmail.com>"
 license="MIT"
 homepage="https://github.com/ammen99/wf-recorder"
 distfiles="https://github.com/ammen99/${pkgname}/archive/v${version}.tar.gz"
-checksum=3af1e933872653233d87167bab73d96f984d00e995385190b586be4d89dbbfdf
+checksum=2b2750e3a0f776ae87f65e82b9aefc3ab0947f17e234ed3b366ff4a0f76e6c08
 
 # silly workaround to prevent vector/bool/etc from being defined
 case "$XBPS_TARGET_MACHINE" in

Re: wf-recorder: update to 0.4.0.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/45884#issuecomment-1703919185

Comment:
The issue here is that CI contains `git` in path, introduced in https://github.com/void-linux/void-packages/commit/e0c8a977c48443e8e412b4e3e4d8673661ac9c8b. But since $wrksrc is not a git checkout the meson commands fail.

Re: wf-recorder: update to 0.4.0.

[jony255]

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

New comment by jony255 on void-packages repository

https://github.com/void-linux/void-packages/pull/45884#issuecomment-1705919847

Comment:
I see

That was added in October of last year but there was an update to `sway` some time after that, which uses the same `git` commands that `wf-recorder` uses, and [it](https://github.com/void-linux/void-packages/pull/42236) passed

the `git` commands in question:
https://github.com/ammen99/wf-recorder/blob/master/meson.build#L25
https://github.com/swaywm/sway/blob/68d620a8fd70d70eb91c58dcfafc4af16c58379d/meson.build#L161

This PR should have also prevented this error: https://github.com/ammen99/wf-recorder/pull/226

The docs talking about `check: {true,false}`: https://mesonbuild.com/External-commands.html#external-commands
However, the relevant lines from the link are:
```If check: true is given, meson will error out if command returns with a non-zero exit code. Alternatively, you can set check: false and get the exit code with r.returncode().```

Re: wf-recorder: update to 0.4.0.

[jony255]

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

New comment by jony255 on void-packages repository

https://github.com/void-linux/void-packages/pull/45884#issuecomment-1705919847

Comment:
I see

That was added in October of last year but there was an update to `sway` some time after that, which uses the same `git` commands that `wf-recorder` uses, and [it](https://github.com/void-linux/void-packages/pull/42236) passed

the `git` commands in question:
https://github.com/ammen99/wf-recorder/blob/master/meson.build#L25
https://github.com/swaywm/sway/blob/68d620a8fd70d70eb91c58dcfafc4af16c58379d/meson.build#L161

This PR should have also prevented this error: https://github.com/ammen99/wf-recorder/pull/226

The docs talking about `check: {true,false}`: https://mesonbuild.com/External-commands.html#external-commands

However, the relevant lines from the link are:
```If check: true is given, meson will error out if command returns with a non-zero exit code. Alternatively, you can set check: false and get the exit code with r.returncode().```

Re: wf-recorder: update to 0.4.0.

[jony255]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New comment by jony255 on void-packages repository

https://github.com/void-linux/void-packages/pull/45884#issuecomment-1705921032

Comment:
Oh, they added that `check: false` change right after cutting the `0.4` release, sorry about that!

Re: [PR PATCH] [Updated] wf-recorder: update to 0.4.0.

[jony255]

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

There is an updated pull request by jony255 against master on the void-packages repository

https://github.com/jony255/void-packages wf-recorder
https://github.com/void-linux/void-packages/pull/45884

wf-recorder: update to 0.4.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: briefly

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64
  - aarch64
  - aarch64-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/45884.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wf-recorder-45884.patch --]
[-- Type: text/x-diff, Size: 1363 bytes --]

From 7168790b48fcfa7bb5366cd7e2585dc4f3502f06 Mon Sep 17 00:00:00 2001
From: Jony <maybe-one-day-ubermensch@protonmail.com>
Date: Sun, 27 Aug 2023 15:57:14 -0700
Subject: [PATCH] wf-recorder: update to 0.4.1.

---
 srcpkgs/wf-recorder/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/wf-recorder/template b/srcpkgs/wf-recorder/template
index e278eb001600f..cdf8d26dcb8e1 100644
--- a/srcpkgs/wf-recorder/template
+++ b/srcpkgs/wf-recorder/template
@@ -1,17 +1,17 @@
 # Template file for 'wf-recorder'
 pkgname=wf-recorder
-version=0.3.0
+version=0.4.1
 revision=1
 build_style=meson
 hostmakedepends="pkg-config scdoc wayland-devel"
-makedepends="wayland-protocols wayland-devel ffmpeg-devel x264-devel
+makedepends="wayland-protocols wayland-devel ffmpeg-devel libgbm-devel x264-devel
 	pulseaudio-devel"
 short_desc="Screen recorder for wlroots-based compositors"
 maintainer="Jony <maybe-one-day-ubermensch@protonmail.com>"
 license="MIT"
 homepage="https://github.com/ammen99/wf-recorder"
 distfiles="https://github.com/ammen99/${pkgname}/archive/v${version}.tar.gz"
-checksum=3af1e933872653233d87167bab73d96f984d00e995385190b586be4d89dbbfdf
+checksum=486e9c03693026e7e287e9cddda5b78488b22706aed1ab789e19ffd09e4adfda
 
 # silly workaround to prevent vector/bool/etc from being defined
 case "$XBPS_TARGET_MACHINE" in

Re: wf-recorder: update to 0.4.0.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/45884#issuecomment-1730320467

Comment:
Tested this, can confirm it's working fine.

P.S. the version in the PR title is outdated :D

Re: [PR PATCH] [Merged]: wf-recorder: update to 0.4.0.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

There's a merged pull request on the void-packages repository

wf-recorder: update to 0.4.0.
https://github.com/void-linux/void-packages/pull/45884

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: briefly

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64
  - aarch64
  - aarch64-musl
-->