Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] tuxpaint: remove python 2 scripts
@ 2023-10-10  3:42 classabbyamp
  2023-10-10  3:48 ` [PR PATCH] [Updated] " classabbyamp
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: classabbyamp @ 2023-10-10  3:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]

There is a new pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages tuxpaint
https://github.com/void-linux/void-packages/pull/46542

tuxpaint: remove python 2 scripts
- `maketuxfont.py` is impossible to easily port to python 3 because there is no equivalent to `string.letters` (set of all letters, locale-dependent). It is also probably not very useful in the modern era; it was created in 2005 when a "more then 13 MB" font file was considered huge.
- `mkTuxpaintIM.py` seems to be just for updating documentation (so probably not useful for users ever)

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

@Chocimier 


A patch file from https://github.com/void-linux/void-packages/pull/46542.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tuxpaint-46542.patch --]
[-- Type: text/x-diff, Size: 1704 bytes --]

From aeba24757a40605d9aed94281eff478462d7bf76 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Mon, 9 Oct 2023 23:34:55 -0400
Subject: [PATCH] tuxpaint: remove python 2 scripts

- `maketuxfont.py` is impossible to easily port to python 3 because there is
  no equivalent to `string.letters` (set of all letters, locale-dependent)
  It is also probably not very useful in the modern era; it was created in 2005
  when a "more then 13 MB" font file was considered huge.
- `mkTuxpaintIM.py` seems to be just for updating documentation (so
  probably not useful for users ever)
---
 srcpkgs/tuxpaint/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tuxpaint/template b/srcpkgs/tuxpaint/template
index bacbfa432cb66..1950bf7444c20 100644
--- a/srcpkgs/tuxpaint/template
+++ b/srcpkgs/tuxpaint/template
@@ -1,7 +1,7 @@
 # Template file for 'tuxpaint'
 pkgname=tuxpaint
 version=0.9.31
-revision=1
+revision=2
 build_style=gnu-makefile
 conf_files="/etc/tuxpaint/tuxpaint.conf"
 hostmakedepends="gettext gperf pkg-config ImageMagick"
@@ -15,7 +15,6 @@ homepage="https://www.tuxpaint.org/"
 distfiles="${SOURCEFORGE_SITE}/tuxpaint/${version}/tuxpaint-${version}.tar.gz"
 checksum=1a85c04fa5c9ae6b3ffd2ca8fa86a84c0c8b462b5059fa1fc2c445b5cfa857ee
 replaces="tuxpaint-data>=0"
-python_version=2
 CFLAGS="-D_GNU_SOURCE -D_POSIX_PRIORITY_SCHEDULING"
 
 pre_build() {
@@ -24,4 +23,7 @@ pre_build() {
 
 post_install() {
 	vinstall src/tuxpaint.desktop 644 usr/share/applications
+	# python 2
+	rm "${DESTDIR}/usr/share/doc/tuxpaint-0.9.28/outdated/zh_tw/mkTuxpaintIM.py" \
+		"${DESTDIR}/usr/share/tuxpaint/fonts/locale/zh_tw_docs/maketuxfont.py"
 }

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Updated] tuxpaint: remove python 2 scripts
  2023-10-10  3:42 [PR PATCH] tuxpaint: remove python 2 scripts classabbyamp
@ 2023-10-10  3:48 ` classabbyamp
  2023-10-11 18:56 ` Chocimier
  2023-10-11 18:56 ` [PR PATCH] [Merged]: " Chocimier
  2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2023-10-10  3:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages tuxpaint
https://github.com/void-linux/void-packages/pull/46542

tuxpaint: remove python 2 scripts
- `maketuxfont.py` is impossible to easily port to python 3 because there is no equivalent to `string.letters` (set of all letters, locale-dependent). It is also probably not very useful in the modern era; it was created in 2005 when a "more then 13 MB" font file was considered huge.
- `mkTuxpaintIM.py` seems to be just for updating documentation (so probably not useful for users ever)

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

@Chocimier 


A patch file from https://github.com/void-linux/void-packages/pull/46542.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tuxpaint-46542.patch --]
[-- Type: text/x-diff, Size: 1708 bytes --]

From 8a233adc970a032f3dc45c3ba32371c6741d9de7 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Mon, 9 Oct 2023 23:34:55 -0400
Subject: [PATCH] tuxpaint: remove python 2 scripts

- `maketuxfont.py` is impossible to easily port to python 3 because there is
  no equivalent to `string.letters` (set of all letters, locale-dependent)
  It is also probably not very useful in the modern era; it was created in 2005
  when a "more then 13 MB" font file was considered huge.
- `mkTuxpaintIM.py` seems to be just for updating documentation (so
  probably not useful for users ever)
---
 srcpkgs/tuxpaint/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tuxpaint/template b/srcpkgs/tuxpaint/template
index bacbfa432cb66..1113f084e117c 100644
--- a/srcpkgs/tuxpaint/template
+++ b/srcpkgs/tuxpaint/template
@@ -1,7 +1,7 @@
 # Template file for 'tuxpaint'
 pkgname=tuxpaint
 version=0.9.31
-revision=1
+revision=2
 build_style=gnu-makefile
 conf_files="/etc/tuxpaint/tuxpaint.conf"
 hostmakedepends="gettext gperf pkg-config ImageMagick"
@@ -15,7 +15,6 @@ homepage="https://www.tuxpaint.org/"
 distfiles="${SOURCEFORGE_SITE}/tuxpaint/${version}/tuxpaint-${version}.tar.gz"
 checksum=1a85c04fa5c9ae6b3ffd2ca8fa86a84c0c8b462b5059fa1fc2c445b5cfa857ee
 replaces="tuxpaint-data>=0"
-python_version=2
 CFLAGS="-D_GNU_SOURCE -D_POSIX_PRIORITY_SCHEDULING"
 
 pre_build() {
@@ -24,4 +23,7 @@ pre_build() {
 
 post_install() {
 	vinstall src/tuxpaint.desktop 644 usr/share/applications
+	# python 2
+	rm "${DESTDIR}/usr/share/doc/tuxpaint-${version}/outdated/zh_tw/mkTuxpaintIM.py" \
+		"${DESTDIR}/usr/share/tuxpaint/fonts/locale/zh_tw_docs/maketuxfont.py"
 }

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: tuxpaint: remove python 2 scripts
  2023-10-10  3:42 [PR PATCH] tuxpaint: remove python 2 scripts classabbyamp
  2023-10-10  3:48 ` [PR PATCH] [Updated] " classabbyamp
@ 2023-10-11 18:56 ` Chocimier
  2023-10-11 18:56 ` [PR PATCH] [Merged]: " Chocimier
  2 siblings, 0 replies; 4+ messages in thread
From: Chocimier @ 2023-10-11 18:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/46542#issuecomment-1758319266

Comment:
Right, these are build tools.
Thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Merged]: tuxpaint: remove python 2 scripts
  2023-10-10  3:42 [PR PATCH] tuxpaint: remove python 2 scripts classabbyamp
  2023-10-10  3:48 ` [PR PATCH] [Updated] " classabbyamp
  2023-10-11 18:56 ` Chocimier
@ 2023-10-11 18:56 ` Chocimier
  2 siblings, 0 replies; 4+ messages in thread
From: Chocimier @ 2023-10-11 18:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

There's a merged pull request on the void-packages repository

tuxpaint: remove python 2 scripts
https://github.com/void-linux/void-packages/pull/46542

Description:
- `maketuxfont.py` is impossible to easily port to python 3 because there is no equivalent to `string.letters` (set of all letters, locale-dependent). It is also probably not very useful in the modern era; it was created in 2005 when a "more then 13 MB" font file was considered huge.
- `mkTuxpaintIM.py` seems to be just for updating documentation (so probably not useful for users ever)

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

@Chocimier 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-10-11 18:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-10  3:42 [PR PATCH] tuxpaint: remove python 2 scripts classabbyamp
2023-10-10  3:48 ` [PR PATCH] [Updated] " classabbyamp
2023-10-11 18:56 ` Chocimier
2023-10-11 18:56 ` [PR PATCH] [Merged]: " Chocimier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).