[PR PATCH] guake: backport fix for double click opens new tab from 3.8.5

[PR PATCH] guake: backport fix for double click opens new tab from 3.8.5

[hrzlgnm]

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

There is a new pull request by hrzlgnm against master on the void-packages repository

https://github.com/hrzlgnm/void-packages guake-double-click-fix-backport
https://github.com/void-linux/void-packages/pull/47072

guake: backport fix for double click opens new tab from 3.8.5
The issue has been fixed in upstream with 3.8.5

See upstream changes for more details :
* https://github.com/Guake/guake/pull/1721/files
* https://github.com/Guake/guake/pull/2010/files


#### Testing the changes
- I tested the changes in this PR: YES

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-libc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/47072.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-guake-double-click-fix-backport-47072.patch --]
[-- Type: text/x-diff, Size: 2470 bytes --]

From a0696b2d92ec5e92a44dd2f599a67a4324fb71d0 Mon Sep 17 00:00:00 2001
From: hrzlgnm <hrzlgnm@users.noreply.github.com>
Date: Sun, 5 Nov 2023 14:32:14 +0100
Subject: [PATCH] guake: backport fix for double click opens new tab from 3.8.5

The issue has been fixed in upstream with 3.8.5

See upstream changes for more details :
* https://github.com/Guake/guake/pull/1721/files
* https://github.com/Guake/guake/pull/2010/files
---
 .../0001-Fix-double-click-opens-new-tab.patch | 30 +++++++++++++++++++
 srcpkgs/guake/template                        |  2 +-
 2 files changed, 31 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/guake/patches/0001-Fix-double-click-opens-new-tab.patch

diff --git a/srcpkgs/guake/patches/0001-Fix-double-click-opens-new-tab.patch b/srcpkgs/guake/patches/0001-Fix-double-click-opens-new-tab.patch
new file mode 100644
index 0000000000000..cab2d2e346acd
--- /dev/null
+++ b/srcpkgs/guake/patches/0001-Fix-double-click-opens-new-tab.patch
@@ -0,0 +1,30 @@
+From 9e6cd487b5acc66c4a7d36df4bb1e202f93990a0 Mon Sep 17 00:00:00 2001
+From: hrzlgnm <hrzlgnm@users.noreply.github.com>
+Date: Sun, 5 Nov 2023 14:37:31 +0100
+Subject: [PATCH] Fix double click opens new tab
+
+---
+ guake/notebook.py | 7 ++++++-
+ 1 file changed, 6 insertions(+), 1 deletion(-)
+
+diff --git a/guake/notebook.py b/guake/notebook.py
+index eb1fd5e..447588f 100644
+--- a/guake/notebook.py
++++ b/guake/notebook.py
+@@ -115,7 +115,12 @@ class TerminalNotebook(Gtk.Notebook):
+                 # Gtk 3.18 fallback ("'Menu' object has no attribute 'popup_at_pointer'")
+                 menu.popup(None, None, None, None, event.button, event.time)
+ 
+-        elif event.type == Gdk.EventType.DOUBLE_BUTTON_PRESS and event.button == 1:
++        elif (
++            event.type == Gdk.EventType.DOUBLE_BUTTON_PRESS
++            and event.button == 1
++            and event.window.get_height() < 60
++        ):
++            # event.window.get_height() reports the height of the clicked frame
+             self.new_page_with_focus()
+ 
+         return False
+-- 
+2.42.0
+
diff --git a/srcpkgs/guake/template b/srcpkgs/guake/template
index 53a6a2c5ff45e..86fdbcc1218fb 100644
--- a/srcpkgs/guake/template
+++ b/srcpkgs/guake/template
@@ -1,7 +1,7 @@
 # Template file for 'guake'
 pkgname=guake
 version=3.7.0
-revision=4
+revision=5
 build_style=python3-module
 hostmakedepends="gettext python3-setuptools python3-pbr"
 makedepends="python3-devel python3-pbr"

Re: guake: backport fix for double click opens new tab from 3.8.5

[hrzlgnm]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

New comment by hrzlgnm on void-packages repository

https://github.com/void-linux/void-packages/pull/47072#issuecomment-1793749109

Comment:
On the other hand, instead of backporting fixes from 3.8.5, I would rather consider updating to 3.8.5. Which should also fix other issues like a scrollbar being added if you do a vertical split and disappears again when you hide and show guake again.

Re: [PR PATCH] [Closed]: guake: backport fix for double click opens new tab from 3.8.5

[hrzlgnm]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

There's a closed pull request on the void-packages repository

guake: backport fix for double click opens new tab from 3.8.5
https://github.com/void-linux/void-packages/pull/47072

Description:
The issue has been fixed in upstream with 3.8.5

See upstream changes for more details :
* https://github.com/Guake/guake/pull/1721/files
* https://github.com/Guake/guake/pull/2010/files


#### Testing the changes
- I tested the changes in this PR: YES

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-libc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl

Re: guake: backport fix for double click opens new tab from 3.8.5

[hrzlgnm]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New comment by hrzlgnm on void-packages repository

https://github.com/void-linux/void-packages/pull/47072#issuecomment-1793772655

Comment:
I created #47075 instead, where i updated guake to 3.10