[PR PATCH] New package: libresprite-1.0

[PR PATCH] New package: libresprite-1.0

[moheb2000]

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

There is a new pull request by moheb2000 against master on the void-packages repository

https://github.com/moheb2000/void-packages libresprite
https://github.com/void-linux/void-packages/pull/45457

New package: libresprite-1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/45457.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libresprite-45457.patch --]
[-- Type: text/x-diff, Size: 1524 bytes --]

From 82d07587915eae3a54c35227ea1e76624e95e2f0 Mon Sep 17 00:00:00 2001
From: Mohammad <moh.ebrahimi2000@gmail.com>
Date: Sun, 6 Aug 2023 22:30:41 +0330
Subject: [PATCH] New package: libresprite-1.0

---
 srcpkgs/libresprite/template | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 srcpkgs/libresprite/template

diff --git a/srcpkgs/libresprite/template b/srcpkgs/libresprite/template
new file mode 100644
index 0000000000000..6be6fdc628de6
--- /dev/null
+++ b/srcpkgs/libresprite/template
@@ -0,0 +1,29 @@
+# Template file for 'libresprite'
+pkgname=libresprite
+version=1.0
+revision=1
+archs="x86_64"
+create_wrksrc=yes
+build_style=cmake
+configure_args="-DCMAKE_BUILD_TYPE:STRING=Release -DWITH_DESKTOP_INTEGRATION=ON"
+hostmakedepends="git zlib-devel libpng-devel freetype-devel giflib-devel gtest-devel libjpeg-turbo-devel libcurl-devel SDL2-devel SDL2_image-devel lua-devel pixman-devel tinyxml-devel nodejs-devel"
+short_desc="Animated sprite editor & pixel art tool"
+maintainer="Mohammad Ebrahimi <moh.ebrahimi2000@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://libresprite.github.io"
+
+do_fetch() {
+	git clone --recursive https://github.com/LibreSprite/LibreSprite.git $wrksrc
+	cd $wrksrc
+	git reset --hard v1.0
+}
+
+post_install() {
+	vdoc ${wrksrc}/docs/files/ase.txt
+	vdoc ${wrksrc}/docs/files/fli.txt
+	vdoc ${wrksrc}/docs/files/msk.txt
+	vdoc ${wrksrc}/docs/files/pic.txt
+	vdoc ${wrksrc}/docs/files/picpro.txt
+	vlicense ${wrksrc}/LICENSE.txt
+}
+

Re: [PR REVIEW] New package: libresprite-1.0

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#discussion_r1285989441

Comment:
As xlint point out, no need to include GPL.

Re: [PR REVIEW] New package: libresprite-1.0

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#discussion_r1285986479

Comment:
We want fast rebuild without cloning every time. List submodules like in ppsspp does or ask upstream for combined tarball.

Re: [PR REVIEW] New package: libresprite-1.0

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#discussion_r1285987458

Comment:
CMAKE_BUILD_TYPE:STRING=Release disables debug symbols, anything wrong with void's default?

Re: [PR REVIEW] New package: libresprite-1.0

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#discussion_r1285986414

Comment:
Nope. Unmark, rename hostmakedepends to makedepends and let's then look how to fix musl, i686 and arm.

Re: [PR PATCH] [Updated] New package: libresprite-1.0

[moheb2000]

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

There is an updated pull request by moheb2000 against master on the void-packages repository

https://github.com/moheb2000/void-packages libresprite
https://github.com/void-linux/void-packages/pull/45457

New package: libresprite-1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/45457.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libresprite-45457.patch --]
[-- Type: text/x-diff, Size: 3395 bytes --]

From 515fb6a65e0fad6f69de64b860c7c477b3826f48 Mon Sep 17 00:00:00 2001
From: Mohammad <moh.ebrahimi2000@gmail.com>
Date: Sun, 6 Aug 2023 22:30:41 +0330
Subject: [PATCH] New package: libresprite-1.0

---
 srcpkgs/libresprite/template | 62 ++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)
 create mode 100644 srcpkgs/libresprite/template

diff --git a/srcpkgs/libresprite/template b/srcpkgs/libresprite/template
new file mode 100644
index 0000000000000..7fdf7ef9e6a62
--- /dev/null
+++ b/srcpkgs/libresprite/template
@@ -0,0 +1,62 @@
+# Template file for 'libresprite'
+pkgname=libresprite
+version=1.0
+revision=1
+create_wrksrc=yes
+build_style=cmake
+configure_args="-DWITH_DESKTOP_INTEGRATION=ON"
+makedepends="zlib-devel libpng-devel freetype-devel giflib-devel gtest-devel libjpeg-turbo-devel libcurl-devel SDL2-devel SDL2_image-devel lua-devel pixman-devel tinyxml-devel"
+short_desc="Animated sprite editor & pixel art tool"
+maintainer="Mohammad Ebrahimi <moh.ebrahimi2000@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://libresprite.github.io"
+_clip_commit=a65a9e543e9a270bb7c58789d15d027bbd8efb2a
+_flic_commit=65a6072fa0aa611c383b44d21b87d41e2ea8b523
+_observable_commit=89c97405025c17fbce5b147aae86fe35b00f98e5
+_undo_commit=f39b188e29d0f9adaa49c8705c0f492939d967a9
+_duktape_commit=6f715553e706b61e611aa4ae8e6fe90626800dae
+_simpleini_commit=0687587cef1816a04307d632e517be9803bbdca6
+distfiles="
+ https://github.com/LibreSprite/LibreSprite/archive/refs/tags/v${version}.tar.gz
+ https://github.com/aseprite/clip/archive/${_clip_commit}.tar.gz
+ https://github.com/aseprite/flic/archive/${_flic_commit}.tar.gz
+ https://github.com/dacap/observable/archive/${_observable_commit}.tar.gz
+ https://github.com/aseprite/undo/archive/${_undo_commit}.tar.gz
+ https://github.com/LibreSprite/duktape/archive/${_duktape_commit}.tar.gz
+ https://github.com/aseprite/simpleini/archive/${_simpleini_commit}.tar.gz"
+checksum="7f1fc58ba3c1c7dae384a2e893d0b9d821c6213a5121f263d0964deabd07708e
+ f08780c5c49cbeb560967016e0c653d68c673a8101f7a175b79cbf0f19ec1fae
+ 5bf8341c01ddbd872aadd372827d2bbd191455abde9693aca867e23075c1286a
+ e26e26e3068a4f0f79b1c3f76dc5a5c825a2f7748db4d38594453e7fdf4cb82a
+ 8881e3d4c7d9d29c91640649ad8d292be5646fa3fd26be6b49bba1d00e38acba
+ 711a5cb7e3d663d7673d635a11a3b38fe67cf63b1c9f7eb406ebd107a25b7004
+ 0c00c28a2d85ca9f7cee2462988643b1b6b9c34b692f4f8740c93c988c1e446d"
+
+if [[ "$XBPS_TARGET_MACHINE" != "armv"[67]* ]]
+then
+	makedepends+=" nodejs-devel"
+fi
+
+post_extract() {
+	mv ${wrksrc}/LibreSprite-${version}/* ${wrksrc}
+	rmdir -v ${wrksrc}/src/clip
+	mv ${wrksrc}/clip-${_clip_commit} ${wrksrc}/src/clip
+	rmdir -v ${wrksrc}/src/flic
+	mv ${wrksrc}/flic-${_flic_commit} ${wrksrc}/src/flic
+	rmdir -v ${wrksrc}/src/observable
+	mv ${wrksrc}/observable-${_observable_commit} ${wrksrc}/src/observable
+	rmdir -v ${wrksrc}/src/undo
+	mv ${wrksrc}/undo-${_undo_commit} ${wrksrc}/src/undo
+	rmdir -v ${wrksrc}/third_party/duktape
+	mv ${wrksrc}/duktape-${_duktape_commit} ${wrksrc}/third_party/duktape
+	rmdir -v ${wrksrc}/third_party/simpleini
+	mv ${wrksrc}/simpleini-${_simpleini_commit} ${wrksrc}/third_party/simpleini
+}
+
+post_install() {
+	vdoc ${wrksrc}/docs/files/ase.txt
+	vdoc ${wrksrc}/docs/files/fli.txt
+	vdoc ${wrksrc}/docs/files/msk.txt
+	vdoc ${wrksrc}/docs/files/pic.txt
+	vdoc ${wrksrc}/docs/files/picpro.txt
+}

Re: New package: libresprite-1.0

[moheb2000]

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

New comment by moheb2000 on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#issuecomment-1668291192

Comment:
Thanks!

I fixed the problems but there are some other problems that I want to say here:

- clip test units will fail but clipboard functionality works just fine like the official libresprite AppImage.
- I tried to cross compile this package for armv6l but nodejs-devel package isn't in void official repositories. it's not required based on what I understood from cmake config but I still can't cross compile it because of this error:
```
[307/723] Generating brush_slot_params.xml.h
FAILED: src/app/brush_slot_params.xml.h /builddir/libresprite-1.0/build/src/app/brush_slot_params.xml.h 
cd /builddir/libresprite-1.0/build/src/app && /builddir/libresprite-1.0/build/bin/gen --input /builddir/libresprite-1.0/data/widgets/brush_slot_params.xml --widgetid brush_slot_params > /builddir/libresprite-1.0/build/src/app/brush_slot_params.xml.h.tmp && /usr/bin/cmake -E copy_if_different /builddir/libresprite-1.0/build/src/app/brush_slot_params.xml.h.tmp /builddir/libresprite-1.0/build/src/app/brush_slot_params.xml.h
/bin/sh: line 1: /builddir/libresprite-1.0/build/bin/gen: cannot execute binary file: Exec format error
[308/723] Generating canvas_size.xml.h
```
So if compiling for arm is necessary, I need to figure out what's the problem with this error.

Re: New package: libresprite-1.0

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#issuecomment-1670022190

Comment:
Tests aren't run in upstream CI and are marginal, so we can disable them.
Cross compilation fails due to building generator along final app, and cmake don't support building parts with host compiler. Generated data seems target-independent, so we could add it into native-built package, depend on self in hostmakedepends and patch cross build to get from there instead of generate, sorta like `plplot`, but there upstream enables carring over generator.

Re: New package: libresprite-1.0

[moheb2000]

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New comment by moheb2000 on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#issuecomment-1670031936

Comment:
The clip tests depended to `xvfb-run` package and I fixed them. I will fix cross compilation problem and then I will commit it. Thanks a lot.

Re: [PR PATCH] [Updated] New package: libresprite-1.0

[moheb2000]

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

There is an updated pull request by moheb2000 against master on the void-packages repository

https://github.com/moheb2000/void-packages libresprite
https://github.com/void-linux/void-packages/pull/45457

New package: libresprite-1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/45457.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libresprite-45457.patch --]
[-- Type: text/x-diff, Size: 6774 bytes --]

From 242e7646da8c3902dd3602a39acd2542bfa9c144 Mon Sep 17 00:00:00 2001
From: Mohammad <moh.ebrahimi2000@gmail.com>
Date: Sun, 6 Aug 2023 22:30:41 +0330
Subject: [PATCH] New package: libresprite-1.0

---
 srcpkgs/libresprite/files/CMakeLists.txt      | 23 +++++
 srcpkgs/libresprite/files/src/CMakeLists.txt  | 15 +++
 .../files/third_party/CMakeLists.txt          |  3 +
 srcpkgs/libresprite/template                  | 92 +++++++++++++++++++
 4 files changed, 133 insertions(+)
 create mode 100644 srcpkgs/libresprite/files/CMakeLists.txt
 create mode 100644 srcpkgs/libresprite/files/src/CMakeLists.txt
 create mode 100644 srcpkgs/libresprite/files/third_party/CMakeLists.txt
 create mode 100644 srcpkgs/libresprite/template

diff --git a/srcpkgs/libresprite/files/CMakeLists.txt b/srcpkgs/libresprite/files/CMakeLists.txt
new file mode 100644
index 0000000000000..0108c181867c7
--- /dev/null
+++ b/srcpkgs/libresprite/files/CMakeLists.txt
@@ -0,0 +1,23 @@
+cmake_minimum_required(VERSION 3.4)
+
+project(generator C CXX)
+
+set(BUILD_SHARED_LIBS off)
+
+set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib")
+set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib")
+set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin")
+
+set(MODP_B64_DIR        ${CMAKE_SOURCE_DIR}/third_party/modp_b64)
+
+set(LIBRARY_OUTPUT_PATH ${CMAKE_BINARY_DIR}/lib)
+
+add_definitions(-DNDEBUG)
+
+find_library(TINYXML_LIBRARY NAMES tinyxml)
+find_path(TINYXML_INCLUDE_DIR NAMES tinyxml.h)
+include_directories(${TINYXML_INCLUDE_DIR})
+
+add_subdirectory(src)
+
+add_subdirectory(third_party)
diff --git a/srcpkgs/libresprite/files/src/CMakeLists.txt b/srcpkgs/libresprite/files/src/CMakeLists.txt
new file mode 100644
index 0000000000000..8bd3168ff026e
--- /dev/null
+++ b/srcpkgs/libresprite/files/src/CMakeLists.txt
@@ -0,0 +1,15 @@
+add_definitions(-DHAVE_CONFIG_H)
+
+include_directories(. .. ../third_party)
+
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wno-switch -std=gnu++11")
+
+set(OBSERVABLE_TESTS OFF CACHE BOOL "Compile observable tests")
+add_subdirectory(observable)
+include_directories(observable)
+
+add_subdirectory(base)
+
+include_directories(${BASE_INCLUDE_DIR})
+
+add_subdirectory(gen)
diff --git a/srcpkgs/libresprite/files/third_party/CMakeLists.txt b/srcpkgs/libresprite/files/third_party/CMakeLists.txt
new file mode 100644
index 0000000000000..8d56e877c00d3
--- /dev/null
+++ b/srcpkgs/libresprite/files/third_party/CMakeLists.txt
@@ -0,0 +1,3 @@
+include_directories(.)
+
+add_subdirectory(modp_b64)
diff --git a/srcpkgs/libresprite/template b/srcpkgs/libresprite/template
new file mode 100644
index 0000000000000..42176613fed05
--- /dev/null
+++ b/srcpkgs/libresprite/template
@@ -0,0 +1,92 @@
+# Template file for 'libresprite'
+pkgname=libresprite
+version=1.0
+revision=1
+create_wrksrc=yes
+build_style=cmake
+configure_args="-DWITH_DESKTOP_INTEGRATION=ON"
+hostmakedepends="tinyxml-devel"
+makedepends="zlib-devel libpng-devel freetype-devel giflib-devel gtest-devel libjpeg-turbo-devel libcurl-devel SDL2-devel SDL2_image-devel lua-devel pixman-devel tinyxml-devel"
+checkdepends="xvfb-run"
+short_desc="Animated sprite editor & pixel art tool"
+maintainer="Mohammad Ebrahimi <moh.ebrahimi2000@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://libresprite.github.io"
+_clip_commit=a65a9e543e9a270bb7c58789d15d027bbd8efb2a
+_flic_commit=65a6072fa0aa611c383b44d21b87d41e2ea8b523
+_observable_commit=89c97405025c17fbce5b147aae86fe35b00f98e5
+_undo_commit=f39b188e29d0f9adaa49c8705c0f492939d967a9
+_duktape_commit=6f715553e706b61e611aa4ae8e6fe90626800dae
+_simpleini_commit=0687587cef1816a04307d632e517be9803bbdca6
+distfiles="
+ https://github.com/LibreSprite/LibreSprite/archive/refs/tags/v${version}.tar.gz
+ https://github.com/aseprite/clip/archive/${_clip_commit}.tar.gz
+ https://github.com/aseprite/flic/archive/${_flic_commit}.tar.gz
+ https://github.com/dacap/observable/archive/${_observable_commit}.tar.gz
+ https://github.com/aseprite/undo/archive/${_undo_commit}.tar.gz
+ https://github.com/LibreSprite/duktape/archive/${_duktape_commit}.tar.gz
+ https://github.com/aseprite/simpleini/archive/${_simpleini_commit}.tar.gz"
+checksum="7f1fc58ba3c1c7dae384a2e893d0b9d821c6213a5121f263d0964deabd07708e
+ f08780c5c49cbeb560967016e0c653d68c673a8101f7a175b79cbf0f19ec1fae
+ 5bf8341c01ddbd872aadd372827d2bbd191455abde9693aca867e23075c1286a
+ e26e26e3068a4f0f79b1c3f76dc5a5c825a2f7748db4d38594453e7fdf4cb82a
+ 8881e3d4c7d9d29c91640649ad8d292be5646fa3fd26be6b49bba1d00e38acba
+ 711a5cb7e3d663d7673d635a11a3b38fe67cf63b1c9f7eb406ebd107a25b7004
+ 0c00c28a2d85ca9f7cee2462988643b1b6b9c34b692f4f8740c93c988c1e446d"
+make_check_pre="xvfb-run"
+
+if [[ "$XBPS_TARGET_MACHINE" != "armv"[67]* ]]
+then
+	makedepends+=" nodejs-devel"
+fi
+
+post_extract() {
+	mv ${wrksrc}/LibreSprite-${version}/* ${wrksrc}
+	rmdir -v ${wrksrc}/src/clip
+	mv ${wrksrc}/clip-${_clip_commit} ${wrksrc}/src/clip
+	rmdir -v ${wrksrc}/src/flic
+	mv ${wrksrc}/flic-${_flic_commit} ${wrksrc}/src/flic
+	rmdir -v ${wrksrc}/src/observable
+	mv ${wrksrc}/observable-${_observable_commit} ${wrksrc}/src/observable
+	rmdir -v ${wrksrc}/src/undo
+	mv ${wrksrc}/undo-${_undo_commit} ${wrksrc}/src/undo
+	rmdir -v ${wrksrc}/third_party/duktape
+	mv ${wrksrc}/duktape-${_duktape_commit} ${wrksrc}/third_party/duktape
+	rmdir -v ${wrksrc}/third_party/simpleini
+	mv ${wrksrc}/simpleini-${_simpleini_commit} ${wrksrc}/third_party/simpleini
+
+	if [[ "$CROSS_BUILD" ]]
+	then
+		mv ${wrksrc}/CMakeLists.txt ${wrksrc}/CMakeLists.txt.old
+		cp ${FILESDIR}/CMakeLists.txt ${wrksrc}/CMakeLists.txt
+		mv ${wrksrc}/src/CMakeLists.txt ${wrksrc}/src/CMakeLists.txt.old
+		cp ${FILESDIR}/src/CMakeLists.txt ${wrksrc}/src/CMakeLists.txt
+		mv ${wrksrc}/third_party/CMakeLists.txt ${wrksrc}/third_party/CMakeLists.txt.old
+		cp ${FILESDIR}/third_party/CMakeLists.txt ${wrksrc}/third_party/CMakeLists.txt
+
+		mkdir -p ${wrksrc}/build/${XBPS_MACHINE}
+		cd ${wrksrc}/build/${XBPS_MACHINE}
+		cmake -G Ninja ../..
+		ninja
+
+		sed -i "s/bin\/gen/${XBPS_MACHINE}\/bin\/gen/g" ${wrksrc}/src/app/CMakeLists.txt
+		sed -r "s/DEPENDS gen//g" ${wrksrc}/src/app/CMakeLists.txt
+		
+		rm ${wrksrc}/CMakeLists.txt
+		mv ${wrksrc}/CMakeLists.txt.old ${wrksrc}/CMakeLists.txt
+		rm ${wrksrc}/src/CMakeLists.txt
+		mv ${wrksrc}/src/CMakeLists.txt.old ${wrksrc}/src/CMakeLists.txt
+		rm ${wrksrc}/third_party/CMakeLists.txt
+		mv ${wrksrc}/third_party/CMakeLists.txt.old ${wrksrc}/third_party/CMakeLists.txt
+
+		sed -r "s/add_subdirectory(gen)//g" ${wrksrc}/src/CMakeLists.txt
+	fi
+}
+
+post_install() {
+	vdoc ${wrksrc}/docs/files/ase.txt
+	vdoc ${wrksrc}/docs/files/fli.txt
+	vdoc ${wrksrc}/docs/files/msk.txt
+	vdoc ${wrksrc}/docs/files/pic.txt
+	vdoc ${wrksrc}/docs/files/picpro.txt
+}

Re: New package: libresprite-1.0

[moheb2000]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New comment by moheb2000 on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#issuecomment-1671292973

Comment:
It's still **not** ready for build!
I changed some makefiles and build generator code in post_extract function but still I get that error. native compiling has no problem!

Re: New package: libresprite-1.0

[moheb2000]

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

New comment by moheb2000 on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#issuecomment-1671292973

Comment:
It's still **not** ready for build!
I changed some makefiles and build generator code in post_extract function but still I get that error. native compiling has no problem!
I will appreciated if someone can help me about compiling code generator with host architecture and then compile the program itself with target architecture.

Re: New package: libresprite-1.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#issuecomment-1800871242

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: libresprite-1.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

There's a closed pull request on the void-packages repository

New package: libresprite-1.0
https://github.com/void-linux/void-packages/pull/45457

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

Re: New package: LibreSprite-1.0

[MIvanchev]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

New comment by MIvanchev on void-packages repository

https://github.com/void-linux/void-packages/pull/48030#issuecomment-1951327470

Comment:
> FYI this package is no longer compiling on `1.0`. it needs to be patched

Thanks for reporting, @sug0, it's fixed now!

Re: New package: LibreSprite-1.0

[MIvanchev]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by MIvanchev on void-packages repository

https://github.com/void-linux/void-packages/pull/48030#issuecomment-1951327470

Comment:
> FYI this package is no longer compiling on `1.0`. it needs to be patched

Thanks for reporting, it's fixed now!

Re: New package: LibreSprite-1.0

[sug0]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New comment by sug0 on void-packages repository

https://github.com/void-linux/void-packages/pull/48030#issuecomment-1951255546

Comment:
FYI this package is no longer compiling on `1.0`. it needs to be patched

Re: New package: LibreSprite-1.0

[MIvanchev]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

New comment by MIvanchev on void-packages repository

https://github.com/void-linux/void-packages/pull/48030#issuecomment-1875513424

Comment:
@sgn what did you change and could you fix the linter error?

P.S.
I get it now, you've changed the command so it refers to the target and applies the emulator directly. Let me just add a small comment to expain that.

Re: New package: LibreSprite-1.0

[MIvanchev]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by MIvanchev on void-packages repository

https://github.com/void-linux/void-packages/pull/48030#issuecomment-1875513424

Comment:
@sgn what did you change and could you fix the linter error?

Re: New package: LibreSprite-1.0

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/48030#issuecomment-1874765705

Comment:
@MIvanchev 

add to your template

```
post_patch() {
	vsed -i src/app/CMakeLists.txt -e 's|${CMAKE_BINARY_DIR}/bin/gen|${CMAKE_CROSSCOMPILING_EMULATOR} &|g'
}
```

Re: New package: LibreSprite-1.0

[MIvanchev]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New comment by MIvanchev on void-packages repository

https://github.com/void-linux/void-packages/pull/48030#issuecomment-1874646577

Comment:
Maybe somebody with more experience knows why `build_helper=qemu` doesn't do it's job here?

Re: New package: LibreSprite-1.0

[MIvanchev]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

New comment by MIvanchev on void-packages repository

https://github.com/void-linux/void-packages/pull/48030#issuecomment-1874206060

Comment:
This is a second attempt at releasing LibreSprite after #34654.

Optional features depending on `libv8` disabled because Void doesn't provide a package.

Most recent commits of dependencies used, sometimes older are preferred where the commit was `verified`.

Re: New package: LibreSprite-1.0

[MIvanchev]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New comment by MIvanchev on void-packages repository

https://github.com/void-linux/void-packages/pull/48030#issuecomment-1874206060

Comment:
This is a second attempt at releasing LibreSprite after #34654.

Optional features depending on libv8 disabled because Void doesn't provide a package.

Re: New package: LibreSprite-1.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/34654#issuecomment-1178461554

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: New package: LibreSprite-1.0

[illusioon]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New comment by illusioon on void-packages repository

https://github.com/void-linux/void-packages/pull/34654#issuecomment-1093522560

Comment:
Any news on this one?

Re: New package: LibreSprite-1.0

[notthewave]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New comment by notthewave on void-packages repository

https://github.com/void-linux/void-packages/pull/34654#issuecomment-999223798

Comment:
~~.desktop seems to be missing~~

Re: New package: LibreSprite-1.0

[notthewave]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by notthewave on void-packages repository

https://github.com/void-linux/void-packages/pull/34654#issuecomment-1000501924

Comment:
how can I fix those failing checks? the checks that fail are from the submoudule

Re: New package: LibreSprite-1.0

[notthewave]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by notthewave on void-packages repository

https://github.com/void-linux/void-packages/pull/34654#issuecomment-1000501924

Comment:
how can I fix those failing checks?

Re: New package: LibreSprite-1.0

[notthewave]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New comment by notthewave on void-packages repository

https://github.com/void-linux/void-packages/pull/34654#issuecomment-999226831

Comment:
worked totally fine locally

Re: New package: LibreSprite-1.0

[notthewave]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New comment by notthewave on void-packages repository

https://github.com/void-linux/void-packages/pull/34654#issuecomment-999226831

Comment:
worked totally fine locally

Re: New package: LibreSprite-1.0

[notthewave]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New comment by notthewave on void-packages repository

https://github.com/void-linux/void-packages/pull/34654#issuecomment-999223798

Comment:
.desktop seems to be missing