Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: libresprite-1.0
@ 2023-08-06 19:04 moheb2000
  2023-08-07 14:50 ` [PR REVIEW] " Chocimier
                   ` (12 more replies)
  0 siblings, 13 replies; 16+ messages in thread
From: moheb2000 @ 2023-08-06 19:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

There is a new pull request by moheb2000 against master on the void-packages repository

https://github.com/moheb2000/void-packages libresprite
https://github.com/void-linux/void-packages/pull/45457

New package: libresprite-1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/45457.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libresprite-45457.patch --]
[-- Type: text/x-diff, Size: 1524 bytes --]

From 82d07587915eae3a54c35227ea1e76624e95e2f0 Mon Sep 17 00:00:00 2001
From: Mohammad <moh.ebrahimi2000@gmail.com>
Date: Sun, 6 Aug 2023 22:30:41 +0330
Subject: [PATCH] New package: libresprite-1.0

---
 srcpkgs/libresprite/template | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 srcpkgs/libresprite/template

diff --git a/srcpkgs/libresprite/template b/srcpkgs/libresprite/template
new file mode 100644
index 0000000000000..6be6fdc628de6
--- /dev/null
+++ b/srcpkgs/libresprite/template
@@ -0,0 +1,29 @@
+# Template file for 'libresprite'
+pkgname=libresprite
+version=1.0
+revision=1
+archs="x86_64"
+create_wrksrc=yes
+build_style=cmake
+configure_args="-DCMAKE_BUILD_TYPE:STRING=Release -DWITH_DESKTOP_INTEGRATION=ON"
+hostmakedepends="git zlib-devel libpng-devel freetype-devel giflib-devel gtest-devel libjpeg-turbo-devel libcurl-devel SDL2-devel SDL2_image-devel lua-devel pixman-devel tinyxml-devel nodejs-devel"
+short_desc="Animated sprite editor & pixel art tool"
+maintainer="Mohammad Ebrahimi <moh.ebrahimi2000@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://libresprite.github.io"
+
+do_fetch() {
+	git clone --recursive https://github.com/LibreSprite/LibreSprite.git $wrksrc
+	cd $wrksrc
+	git reset --hard v1.0
+}
+
+post_install() {
+	vdoc ${wrksrc}/docs/files/ase.txt
+	vdoc ${wrksrc}/docs/files/fli.txt
+	vdoc ${wrksrc}/docs/files/msk.txt
+	vdoc ${wrksrc}/docs/files/pic.txt
+	vdoc ${wrksrc}/docs/files/picpro.txt
+	vlicense ${wrksrc}/LICENSE.txt
+}
+

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New package: libresprite-1.0
  2023-08-06 19:04 [PR PATCH] New package: libresprite-1.0 moheb2000
  2023-08-07 14:50 ` [PR REVIEW] " Chocimier
@ 2023-08-07 14:50 ` Chocimier
  2023-08-07 14:50 ` Chocimier
                   ` (10 subsequent siblings)
  12 siblings, 0 replies; 16+ messages in thread
From: Chocimier @ 2023-08-07 14:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#discussion_r1285989441

Comment:
As xlint point out, no need to include GPL.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New package: libresprite-1.0
  2023-08-06 19:04 [PR PATCH] New package: libresprite-1.0 moheb2000
@ 2023-08-07 14:50 ` Chocimier
  2023-08-07 14:50 ` Chocimier
                   ` (11 subsequent siblings)
  12 siblings, 0 replies; 16+ messages in thread
From: Chocimier @ 2023-08-07 14:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#discussion_r1285986479

Comment:
We want fast rebuild without cloning every time. List submodules like in ppsspp does or ask upstream for combined tarball.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New package: libresprite-1.0
  2023-08-06 19:04 [PR PATCH] New package: libresprite-1.0 moheb2000
  2023-08-07 14:50 ` [PR REVIEW] " Chocimier
  2023-08-07 14:50 ` Chocimier
@ 2023-08-07 14:50 ` Chocimier
  2023-08-07 14:50 ` Chocimier
                   ` (9 subsequent siblings)
  12 siblings, 0 replies; 16+ messages in thread
From: Chocimier @ 2023-08-07 14:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#discussion_r1285987458

Comment:
CMAKE_BUILD_TYPE:STRING=Release disables debug symbols, anything wrong with void's default?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New package: libresprite-1.0
  2023-08-06 19:04 [PR PATCH] New package: libresprite-1.0 moheb2000
                   ` (2 preceding siblings ...)
  2023-08-07 14:50 ` Chocimier
@ 2023-08-07 14:50 ` Chocimier
  2023-08-07 17:16 ` [PR PATCH] [Updated] " moheb2000
                   ` (8 subsequent siblings)
  12 siblings, 0 replies; 16+ messages in thread
From: Chocimier @ 2023-08-07 14:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#discussion_r1285986414

Comment:
Nope. Unmark, rename hostmakedepends to makedepends and let's then look how to fix musl, i686 and arm.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] New package: libresprite-1.0
  2023-08-06 19:04 [PR PATCH] New package: libresprite-1.0 moheb2000
                   ` (3 preceding siblings ...)
  2023-08-07 14:50 ` Chocimier
@ 2023-08-07 17:16 ` moheb2000
  2023-08-07 17:22 ` moheb2000
                   ` (7 subsequent siblings)
  12 siblings, 0 replies; 16+ messages in thread
From: moheb2000 @ 2023-08-07 17:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

There is an updated pull request by moheb2000 against master on the void-packages repository

https://github.com/moheb2000/void-packages libresprite
https://github.com/void-linux/void-packages/pull/45457

New package: libresprite-1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/45457.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libresprite-45457.patch --]
[-- Type: text/x-diff, Size: 3395 bytes --]

From 515fb6a65e0fad6f69de64b860c7c477b3826f48 Mon Sep 17 00:00:00 2001
From: Mohammad <moh.ebrahimi2000@gmail.com>
Date: Sun, 6 Aug 2023 22:30:41 +0330
Subject: [PATCH] New package: libresprite-1.0

---
 srcpkgs/libresprite/template | 62 ++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)
 create mode 100644 srcpkgs/libresprite/template

diff --git a/srcpkgs/libresprite/template b/srcpkgs/libresprite/template
new file mode 100644
index 0000000000000..7fdf7ef9e6a62
--- /dev/null
+++ b/srcpkgs/libresprite/template
@@ -0,0 +1,62 @@
+# Template file for 'libresprite'
+pkgname=libresprite
+version=1.0
+revision=1
+create_wrksrc=yes
+build_style=cmake
+configure_args="-DWITH_DESKTOP_INTEGRATION=ON"
+makedepends="zlib-devel libpng-devel freetype-devel giflib-devel gtest-devel libjpeg-turbo-devel libcurl-devel SDL2-devel SDL2_image-devel lua-devel pixman-devel tinyxml-devel"
+short_desc="Animated sprite editor & pixel art tool"
+maintainer="Mohammad Ebrahimi <moh.ebrahimi2000@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://libresprite.github.io"
+_clip_commit=a65a9e543e9a270bb7c58789d15d027bbd8efb2a
+_flic_commit=65a6072fa0aa611c383b44d21b87d41e2ea8b523
+_observable_commit=89c97405025c17fbce5b147aae86fe35b00f98e5
+_undo_commit=f39b188e29d0f9adaa49c8705c0f492939d967a9
+_duktape_commit=6f715553e706b61e611aa4ae8e6fe90626800dae
+_simpleini_commit=0687587cef1816a04307d632e517be9803bbdca6
+distfiles="
+ https://github.com/LibreSprite/LibreSprite/archive/refs/tags/v${version}.tar.gz
+ https://github.com/aseprite/clip/archive/${_clip_commit}.tar.gz
+ https://github.com/aseprite/flic/archive/${_flic_commit}.tar.gz
+ https://github.com/dacap/observable/archive/${_observable_commit}.tar.gz
+ https://github.com/aseprite/undo/archive/${_undo_commit}.tar.gz
+ https://github.com/LibreSprite/duktape/archive/${_duktape_commit}.tar.gz
+ https://github.com/aseprite/simpleini/archive/${_simpleini_commit}.tar.gz"
+checksum="7f1fc58ba3c1c7dae384a2e893d0b9d821c6213a5121f263d0964deabd07708e
+ f08780c5c49cbeb560967016e0c653d68c673a8101f7a175b79cbf0f19ec1fae
+ 5bf8341c01ddbd872aadd372827d2bbd191455abde9693aca867e23075c1286a
+ e26e26e3068a4f0f79b1c3f76dc5a5c825a2f7748db4d38594453e7fdf4cb82a
+ 8881e3d4c7d9d29c91640649ad8d292be5646fa3fd26be6b49bba1d00e38acba
+ 711a5cb7e3d663d7673d635a11a3b38fe67cf63b1c9f7eb406ebd107a25b7004
+ 0c00c28a2d85ca9f7cee2462988643b1b6b9c34b692f4f8740c93c988c1e446d"
+
+if [[ "$XBPS_TARGET_MACHINE" != "armv"[67]* ]]
+then
+	makedepends+=" nodejs-devel"
+fi
+
+post_extract() {
+	mv ${wrksrc}/LibreSprite-${version}/* ${wrksrc}
+	rmdir -v ${wrksrc}/src/clip
+	mv ${wrksrc}/clip-${_clip_commit} ${wrksrc}/src/clip
+	rmdir -v ${wrksrc}/src/flic
+	mv ${wrksrc}/flic-${_flic_commit} ${wrksrc}/src/flic
+	rmdir -v ${wrksrc}/src/observable
+	mv ${wrksrc}/observable-${_observable_commit} ${wrksrc}/src/observable
+	rmdir -v ${wrksrc}/src/undo
+	mv ${wrksrc}/undo-${_undo_commit} ${wrksrc}/src/undo
+	rmdir -v ${wrksrc}/third_party/duktape
+	mv ${wrksrc}/duktape-${_duktape_commit} ${wrksrc}/third_party/duktape
+	rmdir -v ${wrksrc}/third_party/simpleini
+	mv ${wrksrc}/simpleini-${_simpleini_commit} ${wrksrc}/third_party/simpleini
+}
+
+post_install() {
+	vdoc ${wrksrc}/docs/files/ase.txt
+	vdoc ${wrksrc}/docs/files/fli.txt
+	vdoc ${wrksrc}/docs/files/msk.txt
+	vdoc ${wrksrc}/docs/files/pic.txt
+	vdoc ${wrksrc}/docs/files/picpro.txt
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: libresprite-1.0
  2023-08-06 19:04 [PR PATCH] New package: libresprite-1.0 moheb2000
                   ` (4 preceding siblings ...)
  2023-08-07 17:16 ` [PR PATCH] [Updated] " moheb2000
@ 2023-08-07 17:22 ` moheb2000
  2023-08-08 17:26 ` Chocimier
                   ` (6 subsequent siblings)
  12 siblings, 0 replies; 16+ messages in thread
From: moheb2000 @ 2023-08-07 17:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

New comment by moheb2000 on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#issuecomment-1668291192

Comment:
Thanks!

I fixed the problems but there are some other problems that I want to say here:

- clip test units will fail but clipboard functionality works just fine like the official libresprite AppImage.
- I tried to cross compile this package for armv6l but nodejs-devel package isn't in void official repositories. it's not required based on what I understood from cmake config but I still can't cross compile it because of this error:
```
[307/723] Generating brush_slot_params.xml.h
FAILED: src/app/brush_slot_params.xml.h /builddir/libresprite-1.0/build/src/app/brush_slot_params.xml.h 
cd /builddir/libresprite-1.0/build/src/app && /builddir/libresprite-1.0/build/bin/gen --input /builddir/libresprite-1.0/data/widgets/brush_slot_params.xml --widgetid brush_slot_params > /builddir/libresprite-1.0/build/src/app/brush_slot_params.xml.h.tmp && /usr/bin/cmake -E copy_if_different /builddir/libresprite-1.0/build/src/app/brush_slot_params.xml.h.tmp /builddir/libresprite-1.0/build/src/app/brush_slot_params.xml.h
/bin/sh: line 1: /builddir/libresprite-1.0/build/bin/gen: cannot execute binary file: Exec format error
[308/723] Generating canvas_size.xml.h
```
So if compiling for arm is necessary, I need to figure out what's the problem with this error.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: libresprite-1.0
  2023-08-06 19:04 [PR PATCH] New package: libresprite-1.0 moheb2000
                   ` (5 preceding siblings ...)
  2023-08-07 17:22 ` moheb2000
@ 2023-08-08 17:26 ` Chocimier
  2023-08-08 17:34 ` moheb2000
                   ` (5 subsequent siblings)
  12 siblings, 0 replies; 16+ messages in thread
From: Chocimier @ 2023-08-08 17:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#issuecomment-1670022190

Comment:
Tests aren't run in upstream CI and are marginal, so we can disable them.
Cross compilation fails due to building generator along final app, and cmake don't support building parts with host compiler. Generated data seems target-independent, so we could add it into native-built package, depend on self in hostmakedepends and patch cross build to get from there instead of generate, sorta like `plplot`, but there upstream enables carring over generator.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: libresprite-1.0
  2023-08-06 19:04 [PR PATCH] New package: libresprite-1.0 moheb2000
                   ` (6 preceding siblings ...)
  2023-08-08 17:26 ` Chocimier
@ 2023-08-08 17:34 ` moheb2000
  2023-08-09 13:03 ` [PR PATCH] [Updated] " moheb2000
                   ` (4 subsequent siblings)
  12 siblings, 0 replies; 16+ messages in thread
From: moheb2000 @ 2023-08-08 17:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New comment by moheb2000 on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#issuecomment-1670031936

Comment:
The clip tests depended to `xvfb-run` package and I fixed them. I will fix cross compilation problem and then I will commit it. Thanks a lot.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] New package: libresprite-1.0
  2023-08-06 19:04 [PR PATCH] New package: libresprite-1.0 moheb2000
                   ` (7 preceding siblings ...)
  2023-08-08 17:34 ` moheb2000
@ 2023-08-09 13:03 ` moheb2000
  2023-08-09 13:05 ` moheb2000
                   ` (3 subsequent siblings)
  12 siblings, 0 replies; 16+ messages in thread
From: moheb2000 @ 2023-08-09 13:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

There is an updated pull request by moheb2000 against master on the void-packages repository

https://github.com/moheb2000/void-packages libresprite
https://github.com/void-linux/void-packages/pull/45457

New package: libresprite-1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/45457.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libresprite-45457.patch --]
[-- Type: text/x-diff, Size: 6774 bytes --]

From 242e7646da8c3902dd3602a39acd2542bfa9c144 Mon Sep 17 00:00:00 2001
From: Mohammad <moh.ebrahimi2000@gmail.com>
Date: Sun, 6 Aug 2023 22:30:41 +0330
Subject: [PATCH] New package: libresprite-1.0

---
 srcpkgs/libresprite/files/CMakeLists.txt      | 23 +++++
 srcpkgs/libresprite/files/src/CMakeLists.txt  | 15 +++
 .../files/third_party/CMakeLists.txt          |  3 +
 srcpkgs/libresprite/template                  | 92 +++++++++++++++++++
 4 files changed, 133 insertions(+)
 create mode 100644 srcpkgs/libresprite/files/CMakeLists.txt
 create mode 100644 srcpkgs/libresprite/files/src/CMakeLists.txt
 create mode 100644 srcpkgs/libresprite/files/third_party/CMakeLists.txt
 create mode 100644 srcpkgs/libresprite/template

diff --git a/srcpkgs/libresprite/files/CMakeLists.txt b/srcpkgs/libresprite/files/CMakeLists.txt
new file mode 100644
index 0000000000000..0108c181867c7
--- /dev/null
+++ b/srcpkgs/libresprite/files/CMakeLists.txt
@@ -0,0 +1,23 @@
+cmake_minimum_required(VERSION 3.4)
+
+project(generator C CXX)
+
+set(BUILD_SHARED_LIBS off)
+
+set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib")
+set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib")
+set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin")
+
+set(MODP_B64_DIR        ${CMAKE_SOURCE_DIR}/third_party/modp_b64)
+
+set(LIBRARY_OUTPUT_PATH ${CMAKE_BINARY_DIR}/lib)
+
+add_definitions(-DNDEBUG)
+
+find_library(TINYXML_LIBRARY NAMES tinyxml)
+find_path(TINYXML_INCLUDE_DIR NAMES tinyxml.h)
+include_directories(${TINYXML_INCLUDE_DIR})
+
+add_subdirectory(src)
+
+add_subdirectory(third_party)
diff --git a/srcpkgs/libresprite/files/src/CMakeLists.txt b/srcpkgs/libresprite/files/src/CMakeLists.txt
new file mode 100644
index 0000000000000..8bd3168ff026e
--- /dev/null
+++ b/srcpkgs/libresprite/files/src/CMakeLists.txt
@@ -0,0 +1,15 @@
+add_definitions(-DHAVE_CONFIG_H)
+
+include_directories(. .. ../third_party)
+
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wno-switch -std=gnu++11")
+
+set(OBSERVABLE_TESTS OFF CACHE BOOL "Compile observable tests")
+add_subdirectory(observable)
+include_directories(observable)
+
+add_subdirectory(base)
+
+include_directories(${BASE_INCLUDE_DIR})
+
+add_subdirectory(gen)
diff --git a/srcpkgs/libresprite/files/third_party/CMakeLists.txt b/srcpkgs/libresprite/files/third_party/CMakeLists.txt
new file mode 100644
index 0000000000000..8d56e877c00d3
--- /dev/null
+++ b/srcpkgs/libresprite/files/third_party/CMakeLists.txt
@@ -0,0 +1,3 @@
+include_directories(.)
+
+add_subdirectory(modp_b64)
diff --git a/srcpkgs/libresprite/template b/srcpkgs/libresprite/template
new file mode 100644
index 0000000000000..42176613fed05
--- /dev/null
+++ b/srcpkgs/libresprite/template
@@ -0,0 +1,92 @@
+# Template file for 'libresprite'
+pkgname=libresprite
+version=1.0
+revision=1
+create_wrksrc=yes
+build_style=cmake
+configure_args="-DWITH_DESKTOP_INTEGRATION=ON"
+hostmakedepends="tinyxml-devel"
+makedepends="zlib-devel libpng-devel freetype-devel giflib-devel gtest-devel libjpeg-turbo-devel libcurl-devel SDL2-devel SDL2_image-devel lua-devel pixman-devel tinyxml-devel"
+checkdepends="xvfb-run"
+short_desc="Animated sprite editor & pixel art tool"
+maintainer="Mohammad Ebrahimi <moh.ebrahimi2000@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://libresprite.github.io"
+_clip_commit=a65a9e543e9a270bb7c58789d15d027bbd8efb2a
+_flic_commit=65a6072fa0aa611c383b44d21b87d41e2ea8b523
+_observable_commit=89c97405025c17fbce5b147aae86fe35b00f98e5
+_undo_commit=f39b188e29d0f9adaa49c8705c0f492939d967a9
+_duktape_commit=6f715553e706b61e611aa4ae8e6fe90626800dae
+_simpleini_commit=0687587cef1816a04307d632e517be9803bbdca6
+distfiles="
+ https://github.com/LibreSprite/LibreSprite/archive/refs/tags/v${version}.tar.gz
+ https://github.com/aseprite/clip/archive/${_clip_commit}.tar.gz
+ https://github.com/aseprite/flic/archive/${_flic_commit}.tar.gz
+ https://github.com/dacap/observable/archive/${_observable_commit}.tar.gz
+ https://github.com/aseprite/undo/archive/${_undo_commit}.tar.gz
+ https://github.com/LibreSprite/duktape/archive/${_duktape_commit}.tar.gz
+ https://github.com/aseprite/simpleini/archive/${_simpleini_commit}.tar.gz"
+checksum="7f1fc58ba3c1c7dae384a2e893d0b9d821c6213a5121f263d0964deabd07708e
+ f08780c5c49cbeb560967016e0c653d68c673a8101f7a175b79cbf0f19ec1fae
+ 5bf8341c01ddbd872aadd372827d2bbd191455abde9693aca867e23075c1286a
+ e26e26e3068a4f0f79b1c3f76dc5a5c825a2f7748db4d38594453e7fdf4cb82a
+ 8881e3d4c7d9d29c91640649ad8d292be5646fa3fd26be6b49bba1d00e38acba
+ 711a5cb7e3d663d7673d635a11a3b38fe67cf63b1c9f7eb406ebd107a25b7004
+ 0c00c28a2d85ca9f7cee2462988643b1b6b9c34b692f4f8740c93c988c1e446d"
+make_check_pre="xvfb-run"
+
+if [[ "$XBPS_TARGET_MACHINE" != "armv"[67]* ]]
+then
+	makedepends+=" nodejs-devel"
+fi
+
+post_extract() {
+	mv ${wrksrc}/LibreSprite-${version}/* ${wrksrc}
+	rmdir -v ${wrksrc}/src/clip
+	mv ${wrksrc}/clip-${_clip_commit} ${wrksrc}/src/clip
+	rmdir -v ${wrksrc}/src/flic
+	mv ${wrksrc}/flic-${_flic_commit} ${wrksrc}/src/flic
+	rmdir -v ${wrksrc}/src/observable
+	mv ${wrksrc}/observable-${_observable_commit} ${wrksrc}/src/observable
+	rmdir -v ${wrksrc}/src/undo
+	mv ${wrksrc}/undo-${_undo_commit} ${wrksrc}/src/undo
+	rmdir -v ${wrksrc}/third_party/duktape
+	mv ${wrksrc}/duktape-${_duktape_commit} ${wrksrc}/third_party/duktape
+	rmdir -v ${wrksrc}/third_party/simpleini
+	mv ${wrksrc}/simpleini-${_simpleini_commit} ${wrksrc}/third_party/simpleini
+
+	if [[ "$CROSS_BUILD" ]]
+	then
+		mv ${wrksrc}/CMakeLists.txt ${wrksrc}/CMakeLists.txt.old
+		cp ${FILESDIR}/CMakeLists.txt ${wrksrc}/CMakeLists.txt
+		mv ${wrksrc}/src/CMakeLists.txt ${wrksrc}/src/CMakeLists.txt.old
+		cp ${FILESDIR}/src/CMakeLists.txt ${wrksrc}/src/CMakeLists.txt
+		mv ${wrksrc}/third_party/CMakeLists.txt ${wrksrc}/third_party/CMakeLists.txt.old
+		cp ${FILESDIR}/third_party/CMakeLists.txt ${wrksrc}/third_party/CMakeLists.txt
+
+		mkdir -p ${wrksrc}/build/${XBPS_MACHINE}
+		cd ${wrksrc}/build/${XBPS_MACHINE}
+		cmake -G Ninja ../..
+		ninja
+
+		sed -i "s/bin\/gen/${XBPS_MACHINE}\/bin\/gen/g" ${wrksrc}/src/app/CMakeLists.txt
+		sed -r "s/DEPENDS gen//g" ${wrksrc}/src/app/CMakeLists.txt
+		
+		rm ${wrksrc}/CMakeLists.txt
+		mv ${wrksrc}/CMakeLists.txt.old ${wrksrc}/CMakeLists.txt
+		rm ${wrksrc}/src/CMakeLists.txt
+		mv ${wrksrc}/src/CMakeLists.txt.old ${wrksrc}/src/CMakeLists.txt
+		rm ${wrksrc}/third_party/CMakeLists.txt
+		mv ${wrksrc}/third_party/CMakeLists.txt.old ${wrksrc}/third_party/CMakeLists.txt
+
+		sed -r "s/add_subdirectory(gen)//g" ${wrksrc}/src/CMakeLists.txt
+	fi
+}
+
+post_install() {
+	vdoc ${wrksrc}/docs/files/ase.txt
+	vdoc ${wrksrc}/docs/files/fli.txt
+	vdoc ${wrksrc}/docs/files/msk.txt
+	vdoc ${wrksrc}/docs/files/pic.txt
+	vdoc ${wrksrc}/docs/files/picpro.txt
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: libresprite-1.0
  2023-08-06 19:04 [PR PATCH] New package: libresprite-1.0 moheb2000
                   ` (8 preceding siblings ...)
  2023-08-09 13:03 ` [PR PATCH] [Updated] " moheb2000
@ 2023-08-09 13:05 ` moheb2000
  2023-08-09 13:07 ` moheb2000
                   ` (2 subsequent siblings)
  12 siblings, 0 replies; 16+ messages in thread
From: moheb2000 @ 2023-08-09 13:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New comment by moheb2000 on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#issuecomment-1671292973

Comment:
It's still **not** ready for build!
I changed some makefiles and build generator code in post_extract function but still I get that error. native compiling has no problem!

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: libresprite-1.0
  2023-08-06 19:04 [PR PATCH] New package: libresprite-1.0 moheb2000
                   ` (9 preceding siblings ...)
  2023-08-09 13:05 ` moheb2000
@ 2023-08-09 13:07 ` moheb2000
  2023-11-08  1:46 ` github-actions
  2023-11-22  1:47 ` [PR PATCH] [Closed]: " github-actions
  12 siblings, 0 replies; 16+ messages in thread
From: moheb2000 @ 2023-08-09 13:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

New comment by moheb2000 on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#issuecomment-1671292973

Comment:
It's still **not** ready for build!
I changed some makefiles and build generator code in post_extract function but still I get that error. native compiling has no problem!
I will appreciated if someone can help me about compiling code generator with host architecture and then compile the program itself with target architecture.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: libresprite-1.0
  2023-08-06 19:04 [PR PATCH] New package: libresprite-1.0 moheb2000
                   ` (10 preceding siblings ...)
  2023-08-09 13:07 ` moheb2000
@ 2023-11-08  1:46 ` github-actions
  2023-11-22  1:47 ` [PR PATCH] [Closed]: " github-actions
  12 siblings, 0 replies; 16+ messages in thread
From: github-actions @ 2023-11-08  1:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/45457#issuecomment-1800871242

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Closed]: New package: libresprite-1.0
  2023-08-06 19:04 [PR PATCH] New package: libresprite-1.0 moheb2000
                   ` (11 preceding siblings ...)
  2023-11-08  1:46 ` github-actions
@ 2023-11-22  1:47 ` github-actions
  12 siblings, 0 replies; 16+ messages in thread
From: github-actions @ 2023-11-22  1:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

There's a closed pull request on the void-packages repository

New package: libresprite-1.0
https://github.com/void-linux/void-packages/pull/45457

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PR PATCH] New package: LibreSprite-1.0
@ 2024-01-02 15:52 MIvanchev
  0 siblings, 0 replies; 16+ messages in thread
From: MIvanchev @ 2024-01-02 15:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

There is a new pull request by MIvanchev against master on the void-packages repository

https://github.com/MIvanchev/void-packages libresprite
https://github.com/void-linux/void-packages/pull/48030

New package: LibreSprite-1.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/48030.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libresprite-48030.patch --]
[-- Type: text/x-diff, Size: 3263 bytes --]

From 991502fcea658267ab35fe6e563dcb787e86fec8 Mon Sep 17 00:00:00 2001
From: Mihail Ivanchev <contact@ivanchev.net>
Date: Tue, 2 Jan 2024 16:47:39 +0100
Subject: [PATCH] New package: LibreSprite-1.0

---
 srcpkgs/LibreSprite/template | 46 ++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 srcpkgs/LibreSprite/template

diff --git a/srcpkgs/LibreSprite/template b/srcpkgs/LibreSprite/template
new file mode 100644
index 0000000000000..a13986b335681
--- /dev/null
+++ b/srcpkgs/LibreSprite/template
@@ -0,0 +1,46 @@
+# Template file for 'LibreSprite'
+pkgname=LibreSprite
+_clipcommit=8175b5b941e93313d093dba7c68a905773e9e76b
+_fliccommit=876ef60df5fec606f8eb0638ee893e4967db4673
+# TODO: Using older commit here due to incompatiblity with the current version
+# Check upon every new version!
+_observablecommit=f5e79fefd465ad722f1ab98705d16e8af8b6a5df
+_undocommit=c868a0238973f04564253133c1cd3689f9aa3913
+_simpleinicommit=9fa7622f41e36105a4c767a7765bb24afec4d6be
+_duktapecommit=6f715553e706b61e611aa4ae8e6fe90626800dae
+version=1.0
+revision=1
+build_style=cmake
+configure_args="-DWITH_DESKTOP_INTEGRATION=ON"
+hostmakedepends="pkg-config git"
+makedepends="libpng-devel pixman-devel libcurl-devel SDL2_image-devel tinyxml-devel zlib-devel SDL2-devel freetype-devel lua54-devel giflib-devel libjpeg-turbo-devel gtest-devel"
+depends="desktop-file-utils hicolor-icon-theme"
+short_desc="Animated sprite editor & pixel art tool -- Fork of the last GPLv2 commit of Aseprite"
+maintainer="Mihail Ivanchev <contact@ivanchev.net>"
+license="GPL-2.0-only"
+homepage="https://libresprite.github.io/"
+distfiles="https://github.com/LibreSprite/LibreSprite/archive/refs/tags/v${version}.tar.gz
+https://github.com/aseprite/clip/archive/${_clipcommit}.zip
+https://github.com/aseprite/flic/archive/${_fliccommit}.zip
+https://github.com/dacap/observable/archive/${_observablecommit}.zip
+https://github.com/aseprite/undo/archive/${_undocommit}.zip
+https://github.com/aseprite/simpleini/archive/${_simpleinicommit}.zip
+https://github.com/LibreSprite/duktape/archive/${_duktapecommit}.zip"
+checksum="7f1fc58ba3c1c7dae384a2e893d0b9d821c6213a5121f263d0964deabd07708e
+ 5d07e4e2102dc3bd073aab2f6e217981f8ccbf3b944a31768ac774dd652f12a5
+ 05861274a408e4c75afba5096e9c6dc0f8e8cde54ea2c005c34ce47e1485d468
+ c5e62c9dabee7b7c2448eb0f612ddd3c26a0007bb32095ca294d77f39629e409
+ bd151d5e0482b704eda33f91dc74c2de5c6339522a2a837ab29100aef796c552
+ d19e2498aa8d55a616e0621c0d59343f59a80e6789edc144915271b874dd887f
+ e736c47b942028680654fb55633ec7efda617324a5f032be44c05f5060a7a796"
+
+post_extract() {
+	mv -T ${wrksrc}/clip-${_clipcommit} ${wrksrc}/${pkgname}-${version}/src/clip
+	mv -T ${wrksrc}/flic-${_fliccommit} ${wrksrc}/${pkgname}-${version}/src/flic
+	mv -T ${wrksrc}/observable-${_observablecommit} ${wrksrc}/${pkgname}-${version}/src/observable
+	mv -T ${wrksrc}/undo-${_undocommit} ${wrksrc}/${pkgname}-${version}/src/undo
+	mv -T ${wrksrc}/simpleini-${_simpleinicommit} ${wrksrc}/${pkgname}-${version}/third_party/simpleini
+	mv -T ${wrksrc}/duktape-${_duktapecommit} ${wrksrc}/${pkgname}-${version}/third_party/duktape
+        mv ${wrksrc}/${pkgname}-${version}/{*,.[!.]*} ${wrksrc}/
+	rmdir ${wrksrc}/${pkgname}-${version}
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PR PATCH] New package: LibreSprite-1.0
@ 2021-12-22  1:54 notthewave
  0 siblings, 0 replies; 16+ messages in thread
From: notthewave @ 2021-12-22  1:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

There is a new pull request by notthewave against master on the void-packages repository

https://github.com/notthewave/void-packages LibreSprite
https://github.com/void-linux/void-packages/pull/34654

New package: LibreSprite-1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - NO.

closes https://github.com/void-linux/void-packages/issues/34594 and potentially https://github.com/void-linux/void-packages/issues/24800

A patch file from https://github.com/void-linux/void-packages/pull/34654.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-LibreSprite-34654.patch --]
[-- Type: text/x-diff, Size: 3003 bytes --]

From 26a0ec6bda50fd8356a950b2383e9f9e9f6d15f7 Mon Sep 17 00:00:00 2001
From: notthewave <winklbauer_m@zoho.eu>
Date: Wed, 22 Dec 2021 02:51:36 +0100
Subject: [PATCH] New package: LibreSprite-1.0

---
 srcpkgs/LibreSprite/template | 48 ++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)
 create mode 100644 srcpkgs/LibreSprite/template

diff --git a/srcpkgs/LibreSprite/template b/srcpkgs/LibreSprite/template
new file mode 100644
index 000000000000..6de4136ce700
--- /dev/null
+++ b/srcpkgs/LibreSprite/template
@@ -0,0 +1,48 @@
+# Template file for 'LibreSprite'
+pkgname=LibreSprite
+_clipcommit=a65a9e543e9a270bb7c58789d15d027bbd8efb2a
+_fliccommit=65a6072fa0aa611c383b44d21b87d41e2ea8b523
+_observablecommit=89c97405025c17fbce5b147aae86fe35b00f98e5
+_undocommit=f39b188e29d0f9adaa49c8705c0f492939d967a9
+_simpleinicommit=0687587cef1816a04307d632e517be9803bbdca6
+_duktapecommit=6f715553e706b61e611aa4ae8e6fe90626800dae
+version=1.0
+revision=1
+#archs="i686 x86_64"
+#wrksrc=
+#create_wrksrc=yes
+build_style=cmake
+#configure_args=""
+#make_build_args=""
+#make_install_args=""
+#conf_files=""
+#make_dirs="/var/log/dir 0755 root root"
+hostmakedepends="pkg-config"
+makedepends="libpng-devel pixman-devel libcurl-devel nodejs-devel SDL2_image-devel tinyxml-devel zlib-devel SDL2-devel freetype-devel lua-devel giflib-devel libjpeg-turbo-devel gtest-devel"
+short_desc="Animated sprite editor & pixel art tool - GPL2 Aseprite fork"
+maintainer="notthewave <winklbauer_m@zoho.eu>"
+license="GPL-2.0-only"
+homepage="https://libresprite.github.io/"
+distfiles="https://github.com/LibreSprite/LibreSprite/archive/refs/tags/v${version}.tar.gz
+https://github.com/aseprite/clip/archive/${_clipcommit}.zip
+https://github.com/aseprite/flic/archive/${_fliccommit}.zip
+https://github.com/dacap/observable/archive/${_observablecommit}.zip
+https://github.com/aseprite/undo/archive/${_undocommit}.zip
+https://github.com/aseprite/simpleini/archive/${_simpleinicommit}.zip
+https://github.com/LibreSprite/duktape/archive/${_duktapecommit}.zip"
+checksum="7f1fc58ba3c1c7dae384a2e893d0b9d821c6213a5121f263d0964deabd07708e
+ eafc2435d03d4660edeaa6c89087abe8a6dfe0003cfcda1560b1a3296ea408f5
+ 0ef2ef3c3cd7b7e48c9df3e1af134059c53e295f1f82a23c91e92dae7eb602a2
+ 5df61dc43fc5c7491fa261502a4e547c33dbfab53b52965613235961e63f65bb
+ f870af42e3f9983862545c24f8ee9a0dff5a30415a1be06b68445d6ea4c3bc62
+ f72bd22ccca908ec0c61f2517fed8402af1ace1b07c4d111688bc9ee95789dcb
+ e736c47b942028680654fb55633ec7efda617324a5f032be44c05f5060a7a796"
+
+post_extract() {
+	mv -T ${XBPS_BUILDDIR}/clip-${_clipcommit} ${wrksrc}/src/clip
+	mv -T ${XBPS_BUILDDIR}/flic-${_fliccommit} ${wrksrc}/src/flic
+	mv -T ${XBPS_BUILDDIR}/observable-${_observablecommit} ${wrksrc}/src/observable
+	mv -T ${XBPS_BUILDDIR}/undo-${_undocommit} ${wrksrc}/src/undo
+	mv -T ${XBPS_BUILDDIR}/simpleini-${_simpleinicommit} ${wrksrc}/third_party/simpleini
+	mv -T ${XBPS_BUILDDIR}/duktape-${_duktapecommit} ${wrksrc}/third_party/duktape
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2024-01-02 15:52 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-06 19:04 [PR PATCH] New package: libresprite-1.0 moheb2000
2023-08-07 14:50 ` [PR REVIEW] " Chocimier
2023-08-07 14:50 ` Chocimier
2023-08-07 14:50 ` Chocimier
2023-08-07 14:50 ` Chocimier
2023-08-07 17:16 ` [PR PATCH] [Updated] " moheb2000
2023-08-07 17:22 ` moheb2000
2023-08-08 17:26 ` Chocimier
2023-08-08 17:34 ` moheb2000
2023-08-09 13:03 ` [PR PATCH] [Updated] " moheb2000
2023-08-09 13:05 ` moheb2000
2023-08-09 13:07 ` moheb2000
2023-11-08  1:46 ` github-actions
2023-11-22  1:47 ` [PR PATCH] [Closed]: " github-actions
  -- strict thread matches above, loose matches on Subject: below --
2024-01-02 15:52 [PR PATCH] New package: LibreSprite-1.0 MIvanchev
2021-12-22  1:54 notthewave

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).