[PR PATCH] Add libedit option

[PR PATCH] Add libedit option

[TakodaNotDakota]

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

There is a new pull request by TakodaNotDakota against master on the void-packages repository

https://github.com/TakodaNotDakota/void-packages dash
https://github.com/void-linux/void-packages/pull/47408

Add libedit option
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl

This change allows dash to be compiled with libedit support, which gives it vi-like and emacs-like line editing.
This change DOES NOT set it to compile with that automatically, it only adds the xbps-src build option.

A patch file from https://github.com/void-linux/void-packages/pull/47408.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dash-47408.patch --]
[-- Type: text/x-diff, Size: 1058 bytes --]

From b748c685ee9172a58ab675def9f1aabc949d3e21 Mon Sep 17 00:00:00 2001
From: Takoda <150498532+TakodaNotDakota@users.noreply.github.com>
Date: Sat, 25 Nov 2023 19:07:19 -0600
Subject: [PATCH] Add libedit option

---
 srcpkgs/dash/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/dash/template b/srcpkgs/dash/template
index 7ab7edeacd5f3..abd4e122e1876 100644
--- a/srcpkgs/dash/template
+++ b/srcpkgs/dash/template
@@ -3,8 +3,8 @@ pkgname=dash
 version=0.5.12
 revision=1
 build_style=gnu-configure
-configure_args="$(vopt_enable static)"
-hostmakedepends="bison"
+configure_args="$(vopt_enable static) $(vopt_with libedit)"
+hostmakedepends="bison $(vopt_if libedit libedit-devel)"
 short_desc="POSIX-compliant Unix shell, much smaller than GNU bash"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="BSD-3-Clause"
@@ -17,7 +17,7 @@ alternatives="
  sh:sh:/usr/bin/dash
  sh:sh.1:/usr/share/man/man1/dash.1"
 
-build_options="static"
+build_options="static libedit"
 
 post_install() {
 	 vlicense COPYING

Re: [PR PATCH] [Updated] dash: Add libedit option

[TakodaNotDakota]

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

There is an updated pull request by TakodaNotDakota against master on the void-packages repository

https://github.com/TakodaNotDakota/void-packages dash
https://github.com/void-linux/void-packages/pull/47408

dash: Add libedit option
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl

This change allows dash to be compiled with libedit support, which gives it vi-like and emacs-like line editing.
This change DOES NOT set it to compile with that automatically, it only adds the xbps-src build option.

A patch file from https://github.com/void-linux/void-packages/pull/47408.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dash-47408.patch --]
[-- Type: text/x-diff, Size: 1095 bytes --]

From e7b3dc42f04784e4b5640274ba64f38e3ced3fb2 Mon Sep 17 00:00:00 2001
From: TakodaNotDakota <takodanotdakota@posteo.org>
Date: Sat, 25 Nov 2023 20:45:14 -0600
Subject: [PATCH] dash: Add libedit support

---
 srcpkgs/dash/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/dash/template b/srcpkgs/dash/template
index 7ab7edeacd5f3..eae9e66424dff 100644
--- a/srcpkgs/dash/template
+++ b/srcpkgs/dash/template
@@ -1,10 +1,10 @@
 # Template file for 'dash'
 pkgname=dash
 version=0.5.12
-revision=1
+revision=2
 build_style=gnu-configure
-configure_args="$(vopt_enable static)"
-hostmakedepends="bison"
+configure_args="$(vopt_enable static) $(vopt_with libedit)"
+hostmakedepends="bison $(vopt_if libedit libedit-devel)"
 short_desc="POSIX-compliant Unix shell, much smaller than GNU bash"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="BSD-3-Clause"
@@ -17,7 +17,7 @@ alternatives="
  sh:sh:/usr/bin/dash
  sh:sh.1:/usr/share/man/man1/dash.1"
 
-build_options="static"
+build_options="static libedit"
 
 post_install() {
 	 vlicense COPYING

Re: dash: Add libedit option

[TakodaNotDakota]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New comment by TakodaNotDakota on void-packages repository

https://github.com/void-linux/void-packages/pull/47408#issuecomment-1826473421

Comment:
I apologize for that! I did not follow the contribution guidelines, so I redid the commit.

Re: [PR REVIEW] dash: Add libedit option

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/47408#discussion_r1405388205

Comment:
This doesn't need a revbump, since when the `libedit` option is disabled (the default), the build is the same as before.

Re: [PR PATCH] [Updated] dash: add libedit option

[TakodaNotDakota]

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

There is an updated pull request by TakodaNotDakota against master on the void-packages repository

https://github.com/TakodaNotDakota/void-packages dash
https://github.com/void-linux/void-packages/pull/47408

dash: add libedit option
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl

This change allows dash to be compiled with libedit support, which gives it vi-like and emacs-like line editing.
This change DOES NOT set it to compile with that automatically, it only adds the xbps-src build option.

A patch file from https://github.com/void-linux/void-packages/pull/47408.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dash-47408.patch --]
[-- Type: text/x-diff, Size: 1050 bytes --]

From dbc35b8c6bc6fda6070e38b47b6ffcbc6580f359 Mon Sep 17 00:00:00 2001
From: TakodaNotDakota <takodanotdakota@posteo.org>
Date: Sat, 25 Nov 2023 20:45:14 -0600
Subject: [PATCH] dash: add libedit support

---
 srcpkgs/dash/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/dash/template b/srcpkgs/dash/template
index 7ab7edeacd5f3..abd4e122e1876 100644
--- a/srcpkgs/dash/template
+++ b/srcpkgs/dash/template
@@ -3,8 +3,8 @@ pkgname=dash
 version=0.5.12
 revision=1
 build_style=gnu-configure
-configure_args="$(vopt_enable static)"
-hostmakedepends="bison"
+configure_args="$(vopt_enable static) $(vopt_with libedit)"
+hostmakedepends="bison $(vopt_if libedit libedit-devel)"
 short_desc="POSIX-compliant Unix shell, much smaller than GNU bash"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="BSD-3-Clause"
@@ -17,7 +17,7 @@ alternatives="
  sh:sh:/usr/bin/dash
  sh:sh.1:/usr/share/man/man1/dash.1"
 
-build_options="static"
+build_options="static libedit"
 
 post_install() {
 	 vlicense COPYING

Re: dash: add libedit option

[sgn]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/47408#issuecomment-1838620862

Comment:
I think a `dash-libedit` package that `provides=dash-${version}_${revision}` and `conflicts=dash-${version}_${revision}` is better. See `emacs` or `busybox`.

Re: [PR PATCH] [Closed]: dash: add libedit option

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

There's a closed pull request on the void-packages repository

dash: add libedit option
https://github.com/void-linux/void-packages/pull/47408

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl

This change allows dash to be compiled with libedit support, which gives it vi-like and emacs-like line editing.
This change DOES NOT set it to compile with that automatically, it only adds the xbps-src build option.

Re: dash: add libedit option

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/47408#issuecomment-1838689415

Comment:
I agree that, if we are going to offer users the option of dash with libedit, it should come as a separate package instead of a non-default build option. Build options are generally lousy because they are not easily discoverable and burden the user. Closing in favor of https://github.com/void-linux/void-packages/pull/47564.