Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] spectrwm: update to 3.5.1, orphan
@ 2023-12-06 23:33 tmtrucco
  2023-12-07  1:47 ` [PR REVIEW] " mhmdanas
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: tmtrucco @ 2023-12-06 23:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

There is a new pull request by tmtrucco against master on the void-packages repository

https://github.com/tmtrucco/void-packages PRforspectrwm
https://github.com/void-linux/void-packages/pull/47629

spectrwm: update to 3.5.1, orphan
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
I tested the changes in this PR: YES

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
I built this PR locally for my native architecture, (ARCH-LIBC)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/47629.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-PRforspectrwm-47629.patch --]
[-- Type: text/x-diff, Size: 1367 bytes --]

From ff2173ebd3ced6a115748f9f47c8c12988ee9c75 Mon Sep 17 00:00:00 2001
From: tmtrucco <tmtrucco8@gmail.com>
Date: Wed, 6 Dec 2023 20:23:59 -0300
Subject: [PATCH] spectrwm: update to 3.5.1, orphan

---
 srcpkgs/spectrwm/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/spectrwm/template b/srcpkgs/spectrwm/template
index fc1803855eacb..a1c2a912ab44f 100644
--- a/srcpkgs/spectrwm/template
+++ b/srcpkgs/spectrwm/template
@@ -1,7 +1,7 @@
 # Template file for 'spectrwm'
 pkgname=spectrwm
-version=3.4.1
-revision=3
+version=3.5.1
+revision=4
 _distname=SPECTRWM_${version//./_}
 build_style=gnu-makefile
 make_build_args='-C linux SYSCONFDIR=/etc'
@@ -10,11 +10,11 @@ hostmakedepends="pkg-config"
 makedepends="libXcursor-devel libXft-devel libXrandr-devel libXt-devel
  xcb-util-keysyms-devel xcb-util-wm-devel"
 short_desc="Small dynamic tiling window manager for X11"
-maintainer="Jakub Skrzypnik <jot.skrzyp@gmail.com>"
+maintainer=" Orphaned <orphan@voidlinux.org>"
 license="ISC"
 homepage="http://spectrwm.org"
 distfiles="https://github.com/conformal/spectrwm/archive/${_distname}.tar.gz"
-checksum=c030ef30bd11bbdfce3d4a1daf51f0c1358821ba95ebdc4cdb32d3944c8ce03c
+checksum=7fe4260208a52d9fb844291d0afe6af18887c5452df0b921ed780af7b9223f0f
 conf_files="/etc/spectrwm.conf"
 
 if [ "$XBPS_TARGET_LIBC" = "musl" ]; then

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] spectrwm: update to 3.5.1, orphan
  2023-12-06 23:33 [PR PATCH] spectrwm: update to 3.5.1, orphan tmtrucco
@ 2023-12-07  1:47 ` mhmdanas
  2023-12-07  1:47 ` mhmdanas
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: mhmdanas @ 2023-12-07  1:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/47629#discussion_r1418197319

Comment:
`revision` should be reset to 1 on version bumps.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] spectrwm: update to 3.5.1, orphan
  2023-12-06 23:33 [PR PATCH] spectrwm: update to 3.5.1, orphan tmtrucco
  2023-12-07  1:47 ` [PR REVIEW] " mhmdanas
@ 2023-12-07  1:47 ` mhmdanas
  2023-12-07  2:11 ` [PR PATCH] [Updated] " tmtrucco
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: mhmdanas @ 2023-12-07  1:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/47629#discussion_r1418197372

Comment:
Remove the extra space

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] spectrwm: update to 3.5.1, orphan
  2023-12-06 23:33 [PR PATCH] spectrwm: update to 3.5.1, orphan tmtrucco
  2023-12-07  1:47 ` [PR REVIEW] " mhmdanas
  2023-12-07  1:47 ` mhmdanas
@ 2023-12-07  2:11 ` tmtrucco
  2023-12-07  2:16 ` tmtrucco
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: tmtrucco @ 2023-12-07  2:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]

There is an updated pull request by tmtrucco against master on the void-packages repository

https://github.com/tmtrucco/void-packages PRforspectrwm
https://github.com/void-linux/void-packages/pull/47629

spectrwm: update to 3.5.1, orphan
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
I tested the changes in this PR: YES

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/47629.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-PRforspectrwm-47629.patch --]
[-- Type: text/x-diff, Size: 1366 bytes --]

From a1c4f4c352981ec30e6f245ff69b53e44ebba9a5 Mon Sep 17 00:00:00 2001
From: tmtrucco <tmtrucco8@gmail.com>
Date: Wed, 6 Dec 2023 20:23:59 -0300
Subject: [PATCH] spectrwm: update to 3.5.1, orphan

---
 srcpkgs/spectrwm/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/spectrwm/template b/srcpkgs/spectrwm/template
index fc1803855eacb..fdeca6ac3e943 100644
--- a/srcpkgs/spectrwm/template
+++ b/srcpkgs/spectrwm/template
@@ -1,7 +1,7 @@
 # Template file for 'spectrwm'
 pkgname=spectrwm
-version=3.4.1
-revision=3
+version=3.5.1
+revision=1
 _distname=SPECTRWM_${version//./_}
 build_style=gnu-makefile
 make_build_args='-C linux SYSCONFDIR=/etc'
@@ -10,11 +10,11 @@ hostmakedepends="pkg-config"
 makedepends="libXcursor-devel libXft-devel libXrandr-devel libXt-devel
  xcb-util-keysyms-devel xcb-util-wm-devel"
 short_desc="Small dynamic tiling window manager for X11"
-maintainer="Jakub Skrzypnik <jot.skrzyp@gmail.com>"
+maintainer="Orphaned <orphan@voidlinux.org>"
 license="ISC"
 homepage="http://spectrwm.org"
 distfiles="https://github.com/conformal/spectrwm/archive/${_distname}.tar.gz"
-checksum=c030ef30bd11bbdfce3d4a1daf51f0c1358821ba95ebdc4cdb32d3944c8ce03c
+checksum=7fe4260208a52d9fb844291d0afe6af18887c5452df0b921ed780af7b9223f0f
 conf_files="/etc/spectrwm.conf"
 
 if [ "$XBPS_TARGET_LIBC" = "musl" ]; then

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: spectrwm: update to 3.5.1, orphan
  2023-12-06 23:33 [PR PATCH] spectrwm: update to 3.5.1, orphan tmtrucco
                   ` (2 preceding siblings ...)
  2023-12-07  2:11 ` [PR PATCH] [Updated] " tmtrucco
@ 2023-12-07  2:16 ` tmtrucco
  2023-12-10  2:34 ` mhmdanas
  2023-12-19 15:41 ` [PR PATCH] [Merged]: " leahneukirchen
  5 siblings, 0 replies; 7+ messages in thread
From: tmtrucco @ 2023-12-07  2:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2081 bytes --]

New comment by tmtrucco on void-packages repository

https://github.com/void-linux/void-packages/pull/47629#issuecomment-1844090377

Comment:
Sorry for the PR spam! I made the first PR with just the web and couldn't
figure out how to ammend the commit. I started all over again from terminal
with git so I can finally push the ammend. It should be good to go now,
sorry for the inconveniences

On Wed, Dec 6, 2023, 10:47 PM Mohammed Anas ***@***.***>
wrote:

> ***@***.**** requested changes on this pull request.
>
> Thanks for your PR! Please don't keep closing your PRs and opening new
> ones just to make changes to them; instead, amend your commits and
> force-push to the existing PR branch (see
> https://www.atlassian.com/git/tutorials/rewriting-history).
> ------------------------------
>
> In srcpkgs/spectrwm/template
> <https://github.com/void-linux/void-packages/pull/47629#discussion_r1418197319>
> :
>
> > @@ -1,7 +1,7 @@
>  # Template file for 'spectrwm'
>  pkgname=spectrwm
> -version=3.4.1
> -revision=3
> +version=3.5.1
> +revision=4
>
> revision should be reset to 1 on version bumps.
> ------------------------------
>
> In srcpkgs/spectrwm/template
> <https://github.com/void-linux/void-packages/pull/47629#discussion_r1418197372>
> :
>
> > @@ -10,11 +10,11 @@ hostmakedepends="pkg-config"
>  makedepends="libXcursor-devel libXft-devel libXrandr-devel libXt-devel
>   xcb-util-keysyms-devel xcb-util-wm-devel"
>  short_desc="Small dynamic tiling window manager for X11"
> -maintainer="Jakub Skrzypnik ***@***.***>"
> +maintainer=" Orphaned ***@***.***>"
>
> Remove the extra space
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/void-linux/void-packages/pull/47629#pullrequestreview-1768953838>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BDOOIZH46AKCGLWTNVJSGTDYIEN3ZAVCNFSM6AAAAABAKFNONGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONRYHE2TGOBTHA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: spectrwm: update to 3.5.1, orphan
  2023-12-06 23:33 [PR PATCH] spectrwm: update to 3.5.1, orphan tmtrucco
                   ` (3 preceding siblings ...)
  2023-12-07  2:16 ` tmtrucco
@ 2023-12-10  2:34 ` mhmdanas
  2023-12-19 15:41 ` [PR PATCH] [Merged]: " leahneukirchen
  5 siblings, 0 replies; 7+ messages in thread
From: mhmdanas @ 2023-12-10  2:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/47629#issuecomment-1848838354

Comment:
No worries, looks good to me now.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Merged]: spectrwm: update to 3.5.1, orphan
  2023-12-06 23:33 [PR PATCH] spectrwm: update to 3.5.1, orphan tmtrucco
                   ` (4 preceding siblings ...)
  2023-12-10  2:34 ` mhmdanas
@ 2023-12-19 15:41 ` leahneukirchen
  5 siblings, 0 replies; 7+ messages in thread
From: leahneukirchen @ 2023-12-19 15:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]

There's a merged pull request on the void-packages repository

spectrwm: update to 3.5.1, orphan
https://github.com/void-linux/void-packages/pull/47629

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
I tested the changes in this PR: YES

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-12-19 15:41 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-06 23:33 [PR PATCH] spectrwm: update to 3.5.1, orphan tmtrucco
2023-12-07  1:47 ` [PR REVIEW] " mhmdanas
2023-12-07  1:47 ` mhmdanas
2023-12-07  2:11 ` [PR PATCH] [Updated] " tmtrucco
2023-12-07  2:16 ` tmtrucco
2023-12-10  2:34 ` mhmdanas
2023-12-19 15:41 ` [PR PATCH] [Merged]: " leahneukirchen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).