[ISSUE] 7zip errors when compressing directories containing broken symlinks

[ISSUE] 7zip errors when compressing directories containing broken symlinks

[Samueru-sama]

[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]

New issue by Samueru-sama on void-packages repository

https://github.com/void-linux/void-packages/issues/47938

Description:
### Is this a new report?

Yes

### System Info

Void 6.6.8_1 x86_64 GenuineIntel uptodate rrrmFFFF

### Package(s) Affected

7zip-23.01_1

### Does a report exist for this bug with the project's home (upstream) and/or another distro?

_No response_

### Expected behaviour

Compressing any directory should just work even if it contains a broken symlink

### Actual behaviour

7zip throws file not found errors for the broken symlink that causes file-roller to not create the compressed file while xarchiver gives a warning. 

### Steps to reproduce

For this I used thunar with thunar-archive-plugin and file-roller and xarchiver:

Make a directory, place a broken symlink inside and then try to compress it to 7zip.


This entire reddit thread has video demonstration of the issue on void and also a comparison with the same steps on arch. 

https://old.reddit.com/r/voidlinux/comments/18s3hf0/cant_compress_directories_to_7zip_if_they_contain/

In the end I tested using the 7zip binaries from arch on void and the issue went away. 

Re: [ISSUE] [CLOSED] 7zip errors when compressing directories containing broken symlinks

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]

Closed issue by Samueru-sama on void-packages repository

https://github.com/void-linux/void-packages/issues/47938

Description:
### Is this a new report?

Yes

### System Info

Void 6.6.8_1 x86_64 GenuineIntel uptodate rrrmFFFF

### Package(s) Affected

7zip-23.01_1

### Does a report exist for this bug with the project's home (upstream) and/or another distro?

_No response_

### Expected behaviour

Compressing any directory should just work even if it contains a broken symlink

### Actual behaviour

7zip throws file not found errors for the broken symlink that causes file-roller to not create the compressed file while xarchiver gives a warning. 

### Steps to reproduce

For this I used thunar with thunar-archive-plugin and file-roller and xarchiver:

Make a directory, place a broken symlink inside and then try to compress it to 7zip.


This entire reddit thread has video demonstration of the issue on void and also a comparison with the same steps on arch. 

https://old.reddit.com/r/voidlinux/comments/18s3hf0/cant_compress_directories_to_7zip_if_they_contain/

In the end I tested using the 7zip binaries from arch on void and the issue went away. 

Re: 7zip errors when compressing directories containing broken symlinks

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/issues/47938#issuecomment-1872084696

Comment:
Comparing to Arch is moot because Arch uses a completely different upstream project.

Rejecting compression when attempting to follow broken symlinks is entirely reasonable. In any case, this is an issue that should be taken upstream.

Re: 7zip errors when compressing directories containing broken symlinks

[Samueru-sama]

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

New comment by Samueru-sama on void-packages repository

https://github.com/void-linux/void-packages/issues/47938#issuecomment-1872093408

Comment:
> Comparing to Arch is moot because Arch uses a completely different upstream project.
> 
> Rejecting compression when attempting to follow broken symlinks is entirely reasonable. In any case, this is an issue that should be taken upstream.

It is not only arch, void is the only distro that I've ever encountered that has this issue. 

And it is not reasonable if it breaks file-roller and xarchiver. Also why does it need to follow the symlink? Is it going to try to take everything in the symlink to compress?

Say I have my steam directory symlinked in home and I try to compress my home dir for backup, I really hope it will not try to compress my entire steam library in the process. 

Re: 7zip errors when compressing directories containing broken symlinks

[Samueru-sama]

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

New comment by Samueru-sama on void-packages repository

https://github.com/void-linux/void-packages/issues/47938#issuecomment-1872093408

Comment:
> Comparing to Arch is moot because Arch uses a completely different upstream project.
> 
> Rejecting compression when attempting to follow broken symlinks is entirely reasonable. In any case, this is an issue that should be taken upstream.

It is not only arch, void is the only distro that I've ever encountered that has this issue. 

And it is not reasonable if it breaks file-roller and xarchiver. Also why does it need to follow the symlink? Is it going to try to take everything in the symlink to compress?

Say I have my steam directory symlinked in home and I try to compress my home dir for backup, I really hope it will not try to compress my entire steam library in the process. 

edit: In fact if I want to store what the symlinks 7z has the -l which does exactly that, it is something you need to tell to do and it does not come by default, and xarchiver is not passing that flag.

Re: 7zip errors when compressing directories containing broken symlinks

[Samueru-sama]

[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]

New comment by Samueru-sama on void-packages repository

https://github.com/void-linux/void-packages/issues/47938#issuecomment-1872093408

Comment:
> Comparing to Arch is moot because Arch uses a completely different upstream project.
> 
> Rejecting compression when attempting to follow broken symlinks is entirely reasonable. In any case, this is an issue that should be taken upstream.

It is not only arch, void is the only distro that I've ever encountered that has this issue. 

And it is not reasonable if it breaks file-roller and xarchiver. Also why does it need to follow the symlink? Is it going to try to take everything in the symlink to compress?

Say I have my steam directory symlinked in home and I try to compress my home dir for backup, I really hope it will not try to compress my entire steam library in the process. 

edit: In fact if I want to store what the symlinks point to 7z has the -l which does exactly that, it is something you need to tell to do instad of being a default and xarchiver is not passing that flag.

Re: 7zip errors when compressing directories containing broken symlinks

[Samueru-sama]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

New comment by Samueru-sama on void-packages repository

https://github.com/void-linux/void-packages/issues/47938#issuecomment-1872093408

Comment:
> Comparing to Arch is moot because Arch uses a completely different upstream project.
> 
> Rejecting compression when attempting to follow broken symlinks is entirely reasonable. In any case, this is an issue that should be taken upstream.

It is not only arch, void is the only distro that I've ever encountered that has this issue. 

And it is not reasonable if it breaks file-roller and xarchiver. Also why does it need to follow the symlink? Is it going to try to take everything in the symlink to compress?

Say I have my steam directory symlinked in home and I try to compress my home dir for backup, I really hope it will not try to compress my entire steam library in the process. 

edit: In fact if I want to store what the symlinks point to 7z has the -l flag which does exactly that, it is something you need to tell it to do instead of being a default and xarchiver is not passing that flag.

Re: 7zip errors when compressing directories containing broken symlinks

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/issues/47938#issuecomment-1872151928

Comment:
There is no `-l` option in 7zip. You aren't looking at the right command. There *is*, however, an `-snl` switch to "store symbolic links as links", which is probably what you want. This isn't even a bug, it's an error in your expectation.

Re: 7zip errors when compressing directories containing broken symlinks

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/issues/47938#issuecomment-1872152676

Comment:
7zip does not have `-l`. You are confusing p7zip and 7zip, Void does not have p7zip anymore.
https://gitlab.gnome.org/GNOME/file-roller/-/issues/148#note_1382009

With 7zip, you can can use `-snl` to not follow symlinks.

Re: 7zip errors when compressing directories containing broken symlinks

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/issues/47938#issuecomment-1872152676

Comment:
7zip does not have `-l`. You are confusing p7zip and 7zip, Void does not have p7zip anymore.
https://gitlab.gnome.org/GNOME/file-roller/-/issues/148#note_1382009

With 7zip, you can can use `-snl` to not follow symlinks.
There is also a patch suggested in the thread to fix the issue with file-roller.

Re: 7zip errors when compressing directories containing broken symlinks

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/issues/47938#issuecomment-1872152676

Comment:
As mentioned above, 7zip does not have `-l`, that is specific to p7zip, Void does not have p7zip anymore.
https://gitlab.gnome.org/GNOME/file-roller/-/issues/148#note_1382009

There is also a patch suggested in the thread to fix the issue with file-roller.

Re: 7zip errors when compressing directories containing broken symlinks

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/issues/47938#issuecomment-1872152676

Comment:
As mentioned above, 7zip does not have `-l`, that is specific to p7zip, Void does not have p7zip anymore.
https://gitlab.gnome.org/GNOME/file-roller/-/issues/148#note_1382009

There is a patch suggested in the thread to fix the issue with file-roller.

Re: 7zip errors when compressing directories containing broken symlinks

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/issues/47938#issuecomment-1872157782

Comment:
we should probably patch file-roller and other software that call 7z assuming it's p7z because of the switch we made

Re: 7zip errors when compressing directories containing broken symlinks

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/issues/47938#issuecomment-1872152676

Comment:
As mentioned above, 7zip does not have `-l`, that is specific to p7zip, Void does not have p7zip anymore.
https://gitlab.gnome.org/GNOME/file-roller/-/issues/148#note_1382009

There is a patch suggested in the thread to fix the issue with file-roller.

Edit: I created a PR https://github.com/void-linux/void-packages/pull/47978

Re: 7zip errors when compressing directories containing broken symlinks

[Samueru-sama]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

New comment by Samueru-sama on void-packages repository

https://github.com/void-linux/void-packages/issues/47938#issuecomment-1872173675

Comment:
> There is no `-l` option in 7zip. You aren't looking at the right command. There _is_, however, an `-snl` switch to "store symbolic links as links", which is probably what you want. This isn't even a bug, it's an error in your expectation.

Oh I see now, sorry I did `man 7z` on arch but forgot that arch points to p7zip instead.