* Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.
2024-02-03 15:56 [PR PATCH] protonmail-bridge: update to 3.8.2 jbenden
@ 2024-02-04 8:01 ` oreo639
2024-02-04 8:02 ` oreo639
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: oreo639 @ 2024-02-04 8:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
New review comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/48508#discussion_r1477202390
Comment:
Don't add `noverifyrdeps=yes` here, this causes *all* rundeps to not be discovered.
The missing rdeps are for qt6-webview, which isn't packaged currently, the fix would be to package the dependency.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.
2024-02-03 15:56 [PR PATCH] protonmail-bridge: update to 3.8.2 jbenden
2024-02-04 8:01 ` [PR REVIEW] " oreo639
@ 2024-02-04 8:02 ` oreo639
2024-02-04 8:03 ` oreo639
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: oreo639 @ 2024-02-04 8:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
New review comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/48508#discussion_r1477202390
Comment:
Don't add `noverifyrdeps=yes` here, this causes *all* rundeps to not be discovered.
The missing rdeps are for qt6-webview, which isn't packaged currently. The fix would be to package the dependency.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.
2024-02-03 15:56 [PR PATCH] protonmail-bridge: update to 3.8.2 jbenden
2024-02-04 8:01 ` [PR REVIEW] " oreo639
2024-02-04 8:02 ` oreo639
@ 2024-02-04 8:03 ` oreo639
2024-02-04 14:25 ` jbenden
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: oreo639 @ 2024-02-04 8:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
New review comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/48508#discussion_r1477202390
Comment:
Don't add `noverifyrdeps=yes` here, this causes *all* rundeps to not be discovered and added to the `depends`.
The missing rdeps are for qt6-webview, which isn't packaged currently. The fix would be to package the dependency.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.
2024-02-03 15:56 [PR PATCH] protonmail-bridge: update to 3.8.2 jbenden
` (2 preceding siblings ...)
2024-02-04 8:03 ` oreo639
@ 2024-02-04 14:25 ` jbenden
2024-02-04 15:30 ` oreo639
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: jbenden @ 2024-02-04 14:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 236 bytes --]
New review comment by jbenden on void-packages repository
https://github.com/void-linux/void-packages/pull/48508#discussion_r1477331635
Comment:
This is propriety software which bundles all dependencies. We cannot substitute our own.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.
2024-02-03 15:56 [PR PATCH] protonmail-bridge: update to 3.8.2 jbenden
` (3 preceding siblings ...)
2024-02-04 14:25 ` jbenden
@ 2024-02-04 15:30 ` oreo639
2024-02-04 15:30 ` oreo639
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: oreo639 @ 2024-02-04 15:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 378 bytes --]
New review comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/48508#discussion_r1477202390
Comment:
Don't add `noverifyrdeps=yes` here, this causes *all* rundeps to not be discovered and added to the `depends`.
The missing rdeps are for qt6-webview, which isn't packaged currently. ~~The fix would be to package the dependency.~~
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.
2024-02-03 15:56 [PR PATCH] protonmail-bridge: update to 3.8.2 jbenden
` (4 preceding siblings ...)
2024-02-04 15:30 ` oreo639
@ 2024-02-04 15:30 ` oreo639
2024-02-04 15:32 ` oreo639
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: oreo639 @ 2024-02-04 15:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
New review comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/48508#discussion_r1477344394
Comment:
Ah, yeah, qt6-webview plugin is bundled. However `noverifyrdeps=yes` also causes dependencies like glibc, libxcb, glib, etc to not get pulled in, which are not bundled.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.
2024-02-03 15:56 [PR PATCH] protonmail-bridge: update to 3.8.2 jbenden
` (5 preceding siblings ...)
2024-02-04 15:30 ` oreo639
@ 2024-02-04 15:32 ` oreo639
2024-02-04 15:33 ` oreo639
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: oreo639 @ 2024-02-04 15:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 415 bytes --]
New review comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/48508#discussion_r1477344394
Comment:
Ah, yeah, qt6-webview plugin is bundled. However `noverifyrdeps=yes` also causes dependencies like glibc, libxcb, glib, etc to not get pulled in, which are not bundled.
You can use, for example, `noverifyrdeps="libQt6WebViewQuick.so.6 libQt6WebView.so.6"` instead.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.
2024-02-03 15:56 [PR PATCH] protonmail-bridge: update to 3.8.2 jbenden
` (6 preceding siblings ...)
2024-02-04 15:32 ` oreo639
@ 2024-02-04 15:33 ` oreo639
2024-02-04 15:36 ` oreo639
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: oreo639 @ 2024-02-04 15:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 318 bytes --]
New review comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/48508#discussion_r1477344394
Comment:
Ah, yeah, qt6-webview plugin is bundled. However `noverifyrdeps=yes` also causes dependencies like glibc, libxcb, glib, etc to not get pulled in, which are not bundled.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.
2024-02-03 15:56 [PR PATCH] protonmail-bridge: update to 3.8.2 jbenden
` (7 preceding siblings ...)
2024-02-04 15:33 ` oreo639
@ 2024-02-04 15:36 ` oreo639
2024-02-05 5:23 ` classabbyamp
2024-05-06 1:46 ` github-actions
10 siblings, 0 replies; 12+ messages in thread
From: oreo639 @ 2024-02-04 15:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
New review comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/48508#discussion_r1477344394
Comment:
Ah, yeah, qt6 plugins are bundled. However `noverifyrdeps=yes` also causes dependencies like glibc, libxcb, glib, etc to not get pulled in, which are not bundled.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.
2024-02-03 15:56 [PR PATCH] protonmail-bridge: update to 3.8.2 jbenden
` (8 preceding siblings ...)
2024-02-04 15:36 ` oreo639
@ 2024-02-05 5:23 ` classabbyamp
2024-05-06 1:46 ` github-actions
10 siblings, 0 replies; 12+ messages in thread
From: classabbyamp @ 2024-02-05 5:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/48508#discussion_r1477678042
Comment:
> This is propriety software which bundles all dependencies. We cannot substitute our own.
isn't the source here?
https://github.com/ProtonMail/proton-bridge
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: protonmail-bridge: update to 3.8.2.
2024-02-03 15:56 [PR PATCH] protonmail-bridge: update to 3.8.2 jbenden
` (9 preceding siblings ...)
2024-02-05 5:23 ` classabbyamp
@ 2024-05-06 1:46 ` github-actions
10 siblings, 0 replies; 12+ messages in thread
From: github-actions @ 2024-05-06 1:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/48508#issuecomment-2095064979
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 12+ messages in thread