[PR PATCH] protonmail-bridge: update to 3.8.2.

[PR PATCH] protonmail-bridge: update to 3.8.2.

[jbenden]

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

There is a new pull request by jbenden against master on the void-packages repository

https://github.com/jbenden/void-packages protonmail-bridge-3.8.2
https://github.com/void-linux/void-packages/pull/48508

protonmail-bridge: update to 3.8.2.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64`-`glibc`)


A patch file from https://github.com/void-linux/void-packages/pull/48508.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-protonmail-bridge-3.8.2-48508.patch --]
[-- Type: text/x-diff, Size: 1832 bytes --]

From fde1e7aa63b2aeb369c15f65e9e54b25552f7092 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Sat, 3 Feb 2024 08:03:56 -0700
Subject: [PATCH] protonmail-bridge: update to 3.8.2.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/protonmail-bridge/template | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/protonmail-bridge/template b/srcpkgs/protonmail-bridge/template
index ff08aee8720d7..b7696038b7637 100644
--- a/srcpkgs/protonmail-bridge/template
+++ b/srcpkgs/protonmail-bridge/template
@@ -1,28 +1,25 @@
 # Template file for 'protonmail-bridge'
 pkgname=protonmail-bridge
-version=3.3.0
-revision=2
+version=3.8.2
+revision=1
 archs="x86_64"
 create_wrksrc=yes
 depends="desktop-file-utils"
 short_desc="ProtonMail Bridge for use with E-mail software"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Joseph Benden <joe@benden.us>"
 license="GPL-3.0-or-later"
 homepage="https://proton.me/mail/bridge"
 distfiles="https://proton.me/download/bridge/protonmail-bridge_${version}-1_amd64.deb"
-checksum=4541f8aa145097ee171889b0c9d058450d09dc23be10231c83d6659789a27627
+checksum=410258231ac5df2f4896e9aa1c39cf6b7449fef79541ed31706ad4d8e134b545
 
 restricted=yes
+noverifyrdeps=yes
 nopie=yes
 
 do_install() {
 	rm -f usr/lib/protonmail/bridge/plugins/sqldrivers/libqsqlmysql.so
 	rm -f usr/lib/protonmail/bridge/plugins/sqldrivers/libqsqlodbc.so
 	rm -f usr/lib/protonmail/bridge/plugins/sqldrivers/libqsqlpsql.so
-	rm -rf usr/lib/protonmail/bridge/plugins/designer
-	rm -rf usr/lib/protonmail/bridge/plugins/qmltooling
-	rm -rf usr/lib/protonmail/bridge/qml/QtTest
-	rm -rf usr/lib/protonmail/bridge/qml/Qt/labs
 	rm -rf usr/lib/protonmail/bridge/lib/cmake
 	rm -rf usr/lib/protonmail/bridge/lib/pkgconfig
 	rm -rf usr/lib/protonmail/bridge/lib/*.a

Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/48508#discussion_r1477202390

Comment:
Don't add `noverifyrdeps=yes` here, this causes *all* rundeps to not be discovered.
The missing rdeps are for qt6-webview, which isn't packaged currently, the fix would be to package the dependency.

Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/48508#discussion_r1477202390

Comment:
Don't add `noverifyrdeps=yes` here, this causes *all* rundeps to not be discovered.
The missing rdeps are for qt6-webview, which isn't packaged currently. The fix would be to package the dependency.

Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/48508#discussion_r1477202390

Comment:
Don't add `noverifyrdeps=yes` here, this causes *all* rundeps to not be discovered and added to the `depends`.
The missing rdeps are for qt6-webview, which isn't packaged currently. The fix would be to package the dependency.

Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.

[jbenden]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New review comment by jbenden on void-packages repository

https://github.com/void-linux/void-packages/pull/48508#discussion_r1477331635

Comment:
This is propriety software which bundles all dependencies. We cannot substitute our own.

Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/48508#discussion_r1477202390

Comment:
Don't add `noverifyrdeps=yes` here, this causes *all* rundeps to not be discovered and added to the `depends`.
The missing rdeps are for qt6-webview, which isn't packaged currently. ~~The fix would be to package the dependency.~~

Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/48508#discussion_r1477344394

Comment:
Ah, yeah, qt6-webview plugin is bundled. However `noverifyrdeps=yes` also causes dependencies like glibc, libxcb, glib, etc to not get pulled in, which are not bundled.

Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/48508#discussion_r1477344394

Comment:
Ah, yeah, qt6-webview plugin is bundled. However `noverifyrdeps=yes` also causes dependencies like glibc, libxcb, glib, etc to not get pulled in, which are not bundled.

You can use, for example, `noverifyrdeps="libQt6WebViewQuick.so.6 libQt6WebView.so.6"` instead.

Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/48508#discussion_r1477344394

Comment:
Ah, yeah, qt6-webview plugin is bundled. However `noverifyrdeps=yes` also causes dependencies like glibc, libxcb, glib, etc to not get pulled in, which are not bundled.

Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/48508#discussion_r1477344394

Comment:
Ah, yeah, qt6 plugins are bundled. However `noverifyrdeps=yes` also causes dependencies like glibc, libxcb, glib, etc to not get pulled in, which are not bundled.

Re: [PR REVIEW] protonmail-bridge: update to 3.8.2.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/48508#discussion_r1477678042

Comment:
> This is propriety software which bundles all dependencies. We cannot substitute our own.

isn't the source here? 
https://github.com/ProtonMail/proton-bridge

Re: protonmail-bridge: update to 3.8.2.

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/48508#issuecomment-2095064979

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.