Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] common/xbps-src/shutils/update_check.sh: fix rx for gitlab
@ 2024-03-23 10:48 icp1994
  2024-03-23 11:42 ` [PR PATCH] [Closed]: " ahesford
  0 siblings, 1 reply; 2+ messages in thread
From: icp1994 @ 2024-03-23 10:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages fix-gl-update-check
https://github.com/void-linux/void-packages/pull/49475

common/xbps-src/shutils/update_check.sh: fix rx for gitlab
If you `View Source` on `https://gitlab.com/timvisee/prs/-/tags` or any other GitLab packages the archive links end with `&quot` instead of `"` - breaking `update-check` for multiple packages.

A patch file from https://github.com/void-linux/void-packages/pull/49475.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-gl-update-check-49475.patch --]
[-- Type: text/x-diff, Size: 1052 bytes --]

From fa07fa3f2f6fbd963356b1566013ee5cade91964 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 23 Mar 2024 16:13:09 +0530
Subject: [PATCH] common/xbps-src/shutils/update_check.sh: fix rx for gitlab

---
 common/xbps-src/shutils/update_check.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/xbps-src/shutils/update_check.sh b/common/xbps-src/shutils/update_check.sh
index 8bae017bbe4225..b7de9fd6cee5db 100644
--- a/common/xbps-src/shutils/update_check.sh
+++ b/common/xbps-src/shutils/update_check.sh
@@ -138,7 +138,7 @@ update_check() {
                     *) pkgurlname="$(printf %s "$url" | cut -d / -f 1-5)";;
                 esac
                 url="$pkgurlname/-/tags"
-                rx='/archive/[^/]+/\Q'"$pkgname"'\E-v?\K[\d.]+(?=\.tar\.gz")';;
+                rx='/archive/[^/]+/\Q'"$pkgname"'\E-v?\K[\d.]+(?=\.tar\.gz)';;
             *bitbucket.org*)
                 pkgurlname="$(printf %s "$url" | cut -d/ -f4,5)"
                 url="https://bitbucket.org/$pkgurlname/downloads"

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Closed]: common/xbps-src/shutils/update_check.sh: fix rx for gitlab
  2024-03-23 10:48 [PR PATCH] common/xbps-src/shutils/update_check.sh: fix rx for gitlab icp1994
@ 2024-03-23 11:42 ` ahesford
  0 siblings, 0 replies; 2+ messages in thread
From: ahesford @ 2024-03-23 11:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

There's a closed pull request on the void-packages repository

common/xbps-src/shutils/update_check.sh: fix rx for gitlab
https://github.com/void-linux/void-packages/pull/49475

Description:
If you `View Source` on `https://gitlab.com/timvisee/prs/-/tags` or any other GitLab packages the archive links end with `&quot` instead of `"` - breaking `update-check` for multiple packages.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-23 11:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-23 10:48 [PR PATCH] common/xbps-src/shutils/update_check.sh: fix rx for gitlab icp1994
2024-03-23 11:42 ` [PR PATCH] [Closed]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).