[PR PATCH] librsvg: update to 2.58.0.

[PR PATCH] librsvg: update to 2.58.0.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages librsvg
https://github.com/void-linux/void-packages/pull/49755

librsvg: update to 2.58.0.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

A patch file from https://github.com/void-linux/void-packages/pull/49755.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-librsvg-49755.patch --]
[-- Type: text/x-diff, Size: 1303 bytes --]

From 836cd300efa2140d97b2660e3e5c26a8c99180a1 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 6 Apr 2024 01:00:53 +0530
Subject: [PATCH] librsvg: update to 2.58.0.

---
 srcpkgs/librsvg/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/librsvg/template b/srcpkgs/librsvg/template
index 551805317bb728..96fd1d958b46d0 100644
--- a/srcpkgs/librsvg/template
+++ b/srcpkgs/librsvg/template
@@ -1,6 +1,6 @@
 # Template file for 'librsvg'
 pkgname=librsvg
-version=2.57.1
+version=2.58.0
 revision=1
 build_style=gnu-configure
 build_helper="gir rust"
@@ -14,9 +14,9 @@ maintainer="Érico Nogueira <ericonr@disroot.org>"
 license="LGPL-2.1-or-later"
 homepage="https://wiki.gnome.org/Projects/LibRsvg"
 # update changelog when release series changes
-changelog="https://gitlab.gnome.org/GNOME/librsvg/-/raw/librsvg-2.57/NEWS"
+changelog="https://gitlab.gnome.org/GNOME/librsvg/-/raw/librsvg-2.58/NEWS"
 distfiles="${GNOME_SITE}/librsvg/${version%.*}/librsvg-${version}.tar.xz"
-checksum=074671a3ed6fbcd67cae2a40e539107f4f097ca8a4ab1a894c05e2524ff340ef
+checksum=d7c444a926406b59790be0deae196e18ed26059da573fa1aa9ec9ca7658a559c
 
 # reference files are for specific pango and harfbuzz versions
 # the test suite isn't designed to be run by distros

Re: [PR REVIEW] librsvg: update to 2.58.0.

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New review comment by tranzystorekk on void-packages repository

https://github.com/void-linux/void-packages/pull/49755#discussion_r1555388885

Comment:
could automate this with `${version%.*}`

Re: [PR REVIEW] librsvg: update to 2.58.0.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/49755#discussion_r1555437175

Comment:
I think the informal policy is to have no variable in `changelog`

Re: [PR REVIEW] librsvg: update to 2.58.0.

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New review comment by tranzystorekk on void-packages repository

https://github.com/void-linux/void-packages/pull/49755#discussion_r1555442980

Comment:
I'm fine either way but it feels like duplicating the version here is more error-prone

Re: [PR REVIEW] librsvg: update to 2.58.0.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/49755#discussion_r1615327521

Comment:
@icp1994 please use the variable

Re: [PR REVIEW] librsvg: update to 2.58.0.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/49755#discussion_r1615612793

Comment:
Are you sure though? There has been strong pushback against using variables in places like homepage, changelog etc by other maintainers in the past.

Re: [PR REVIEW] librsvg: update to 2.58.0.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/49755#discussion_r1616024022

Comment:
i don't see validity of "strong pushback" claim. The only thing in this regard i can remember was https://github.com/void-linux/void-packages/issues/27735 and yes, it's still unsettled

* `homepage` is usually free of variables for parsing reasons (i think)
* `distfiles` don't make sense without variables (especially `$version`)
* `changelog` is preferred to point to the active branch if there is one. if there is no such thing, the next best thing is to point to the versioned hyperlink.

if not following an idiom (regardless of its justification) leads to less error-prone maintenance overhead, do it.

Re: [PR PATCH] [Updated] librsvg: update to 2.58.0.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages librsvg
https://github.com/void-linux/void-packages/pull/49755

librsvg: update to 2.58.0.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

A patch file from https://github.com/void-linux/void-packages/pull/49755.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-librsvg-49755.patch --]
[-- Type: text/x-diff, Size: 1312 bytes --]

From b9a720554fa868340eb63043a18031a8533dea36 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 6 Apr 2024 01:00:53 +0530
Subject: [PATCH] librsvg: update to 2.58.1.

---
 srcpkgs/librsvg/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/librsvg/template b/srcpkgs/librsvg/template
index 551805317bb728..cc9c176713b04f 100644
--- a/srcpkgs/librsvg/template
+++ b/srcpkgs/librsvg/template
@@ -1,6 +1,6 @@
 # Template file for 'librsvg'
 pkgname=librsvg
-version=2.57.1
+version=2.58.1
 revision=1
 build_style=gnu-configure
 build_helper="gir rust"
@@ -14,9 +14,9 @@ maintainer="Érico Nogueira <ericonr@disroot.org>"
 license="LGPL-2.1-or-later"
 homepage="https://wiki.gnome.org/Projects/LibRsvg"
 # update changelog when release series changes
-changelog="https://gitlab.gnome.org/GNOME/librsvg/-/raw/librsvg-2.57/NEWS"
+changelog="https://gitlab.gnome.org/GNOME/librsvg/-/raw/librsvg-${version%.*}/NEWS"
 distfiles="${GNOME_SITE}/librsvg/${version%.*}/librsvg-${version}.tar.xz"
-checksum=074671a3ed6fbcd67cae2a40e539107f4f097ca8a4ab1a894c05e2524ff340ef
+checksum=3728596290a8576d305d06ec8afdf473516feee9dff22e03235eac433d56824e
 
 # reference files are for specific pango and harfbuzz versions
 # the test suite isn't designed to be run by distros

Re: [PR REVIEW] librsvg: update to 2.58.1.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/49755#discussion_r1616306046

Comment:
Fine by me then.

Re: [PR PATCH] [Merged]: librsvg: update to 2.58.1.

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

There's a merged pull request on the void-packages repository

librsvg: update to 2.58.1.
https://github.com/void-linux/void-packages/pull/49755

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**