Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] librsvg: update to 2.58.0.
@ 2024-04-07 19:02 icp1994
  2024-04-08  8:01 ` [PR REVIEW] " tranzystorekk
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: icp1994 @ 2024-04-07 19:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages librsvg
https://github.com/void-linux/void-packages/pull/49755

librsvg: update to 2.58.0.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

A patch file from https://github.com/void-linux/void-packages/pull/49755.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-librsvg-49755.patch --]
[-- Type: text/x-diff, Size: 1303 bytes --]

From 836cd300efa2140d97b2660e3e5c26a8c99180a1 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 6 Apr 2024 01:00:53 +0530
Subject: [PATCH] librsvg: update to 2.58.0.

---
 srcpkgs/librsvg/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/librsvg/template b/srcpkgs/librsvg/template
index 551805317bb728..96fd1d958b46d0 100644
--- a/srcpkgs/librsvg/template
+++ b/srcpkgs/librsvg/template
@@ -1,6 +1,6 @@
 # Template file for 'librsvg'
 pkgname=librsvg
-version=2.57.1
+version=2.58.0
 revision=1
 build_style=gnu-configure
 build_helper="gir rust"
@@ -14,9 +14,9 @@ maintainer="Érico Nogueira <ericonr@disroot.org>"
 license="LGPL-2.1-or-later"
 homepage="https://wiki.gnome.org/Projects/LibRsvg"
 # update changelog when release series changes
-changelog="https://gitlab.gnome.org/GNOME/librsvg/-/raw/librsvg-2.57/NEWS"
+changelog="https://gitlab.gnome.org/GNOME/librsvg/-/raw/librsvg-2.58/NEWS"
 distfiles="${GNOME_SITE}/librsvg/${version%.*}/librsvg-${version}.tar.xz"
-checksum=074671a3ed6fbcd67cae2a40e539107f4f097ca8a4ab1a894c05e2524ff340ef
+checksum=d7c444a926406b59790be0deae196e18ed26059da573fa1aa9ec9ca7658a559c
 
 # reference files are for specific pango and harfbuzz versions
 # the test suite isn't designed to be run by distros

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR REVIEW] librsvg: update to 2.58.0.
  2024-04-07 19:02 [PR PATCH] librsvg: update to 2.58.0 icp1994
@ 2024-04-08  8:01 ` tranzystorekk
  2024-04-08  8:32 ` icp1994
  2024-04-08  8:37 ` tranzystorekk
  2 siblings, 0 replies; 4+ messages in thread
From: tranzystorekk @ 2024-04-08  8:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New review comment by tranzystorekk on void-packages repository

https://github.com/void-linux/void-packages/pull/49755#discussion_r1555388885

Comment:
could automate this with `${version%.*}`

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR REVIEW] librsvg: update to 2.58.0.
  2024-04-07 19:02 [PR PATCH] librsvg: update to 2.58.0 icp1994
  2024-04-08  8:01 ` [PR REVIEW] " tranzystorekk
@ 2024-04-08  8:32 ` icp1994
  2024-04-08  8:37 ` tranzystorekk
  2 siblings, 0 replies; 4+ messages in thread
From: icp1994 @ 2024-04-08  8:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/49755#discussion_r1555437175

Comment:
I think the informal policy is to have no variable in `changelog`

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR REVIEW] librsvg: update to 2.58.0.
  2024-04-07 19:02 [PR PATCH] librsvg: update to 2.58.0 icp1994
  2024-04-08  8:01 ` [PR REVIEW] " tranzystorekk
  2024-04-08  8:32 ` icp1994
@ 2024-04-08  8:37 ` tranzystorekk
  2 siblings, 0 replies; 4+ messages in thread
From: tranzystorekk @ 2024-04-08  8:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New review comment by tranzystorekk on void-packages repository

https://github.com/void-linux/void-packages/pull/49755#discussion_r1555442980

Comment:
I'm fine either way but it feels like duplicating the version here is more error-prone

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-04-08  8:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-07 19:02 [PR PATCH] librsvg: update to 2.58.0 icp1994
2024-04-08  8:01 ` [PR REVIEW] " tranzystorekk
2024-04-08  8:32 ` icp1994
2024-04-08  8:37 ` tranzystorekk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).