[ISSUE] Package request: tcl-snack

[ISSUE] Package request: tcl-snack

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

New issue by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/issues/49825

Description:
### Package name

tcl-snack

### Package homepage

http://www.speech.kth.se/snack/

### Description

Sound toolkit for scripting languages (tcl).

[scid_vs_pc](https://github.com/void-linux/void-packages/tree/master/srcpkgs/scid_vs_pc) uses it for sound:

> Initializing Sound...
   Snack sound package not found.

### Does the requested package meet the package requirements?

System, Compiled, Required

### Is the requested package released?

Yes

Re: Package request: tcl-snack

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2053734376

Comment:
Maybe https://github.com/scottypitcher/tcl-snack instead

Re: Package request: tcl-snack

[MechDR]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by MechDR on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2072072044

Comment:
I could probably give what @Eloitor suggested a shot... if you'd like.

Re: Package request: tcl-snack

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2072088430

Comment:
It would be great, thanks!

Re: Package request: tcl-snack

[MechDR]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New comment by MechDR on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2072427075

Comment:
OK, I'll try.

Re: Package request: tcl-snack

[MechDR]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

New comment by MechDR on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2077799034

Comment:
A little help, I did get to building, but it suddenly exits xbps-src, haven't checked why.

````
# Template file for 'tcl-snack
pkgname=tcl-snack
version=2.2.10
revision=1
build_style=gnu-makefile
hostmakedepends=""
makedepends="tcl-devel tk-devel vorbis-tools libvorbis-devel alsa-lib-devel"
short_desc="Snack is a powerfull multi-platform library for audio playback, recording, etc. using Tcl/Tk or Python."
maintainer="someone <someone@some.one>"
license="GPL-2.0-only"
homepage="https://www.speech.kth.se/snack/"
distfiles="https://web.archive.org/web/20230819212652/https://www.speech.kth.se/snack/dist/snack${version}.tar.gz"
checksum="4bfe764547ab92ba58f43b77366dbb7c7b3512d65a27cdbf9e585a9cb64ce81e"

post_extract () {
	# Minor code corrections, missing include.
	sed -i '/#include <stdlib.h>/a #include <math.h>' ${wrksrc}/generic/jkFormatMP3.c
}

do_configure () {
	cd ${wrksrc}/unix
	./configure \
		--enable-alsa \
		--with-tcl=/usr/lib/ \
		--with-tk=/usr/lib \
		--with-ogg-include=/usr/lib \
		--with-ogg-lib=/usr/lib

}

do_build () {
	cd ${wrksrc}/unix
	make
}
````

Re: Package request: tcl-snack

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2078113264

Comment:
I think you can use the `cmake_builddir` variable

Re: Package request: tcl-snack

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2078113264

Comment:
I think you can use the `cmake_builddir` variable

and `configure_args`

Re: Package request: tcl-snack

[MechDR]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

New comment by MechDR on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2078273537

Comment:
I don't think the builddir is the problem, though it is preferable to have one. The makefile runs an if statement and the if statement ends, and then it just exits (xbps, like quits entirely). I still haven't tried echoing to see at which point it does that, but could you take a look at the makefile and see if anything strikes you as odd?

Re: Package request: tcl-snack

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

New comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2078774016

Comment:
I think it is fine. It just ends building.  after that I get

=> tcl-snack-2.2.10_1: skipping check (XBPS_CHECK_PKGS is disabled) ...
=> tcl-snack-2.2.10_1: running pre-install hook: 00-libdir ...
=> tcl-snack-2.2.10_1: running pre-install hook: 02-script-wrapper ...
=> tcl-snack-2.2.10_1: running pre-install hook: 98-fixup-gir-path ...
=> tcl-snack-2.2.10_1: running do_install ...
make: *** No rule to make target 'install'.  Stop.

Re: Package request: tcl-snack

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

New comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2078778604

Comment:
```
# Template file for 'tcl-snack
pkgname=tcl-snack
version=2.2.10
revision=1
build_style=gnu-makefile
build_wrksrc=unix
hostmakedepends=""
makedepends="tcl-devel tk-devel vorbis-tools libvorbis-devel alsa-lib-devel"
short_desc="Snack is a powerfull multi-platform library for audio playback, recording, etc. using Tcl/Tk or Python."
maintainer="someone <someone@some.one>"
license="GPL-2.0-only"
homepage="https://www.speech.kth.se/snack/"
distfiles="https://web.archive.org/web/20230819212652/https://www.speech.kth.se/snack/dist/snack${version}.tar.gz"
checksum="4bfe764547ab92ba58f43b77366dbb7c7b3512d65a27cdbf9e585a9cb64ce81e"


post_extract () {
	# Minor code corrections, missing include.
	sed -i '/#include <stdlib.h>/a #include <math.h>' ${wrksrc}/generic/jkFormatMP3.c
}

do_configure () {
	./configure \
		--enable-alsa \
		--with-tcl=/usr/lib/ \
		--with-tk=/usr/lib \
		--with-ogg-include=/usr/lib \
		--with-ogg-lib=/usr/lib
}
```

Re: Package request: tcl-snack

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]

New comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2078800416

Comment:
```
# Template file for 'tcl-snack
pkgname=tcl-snack
version=2.2.10
revision=1
build_style=gnu-makefile
build_wrksrc=unix
hostmakedepends=""
makedepends="tcl-devel tk-devel vorbis-tools libvorbis-devel alsa-lib-devel"
short_desc="Snack is a powerfull multi-platform library for audio playback, recording, etc. using Tcl/Tk or Python."
maintainer="someone <someone@some.one>"
license="GPL-2.0-only"
homepage="https://www.speech.kth.se/snack/"
distfiles="https://web.archive.org/web/20230819212652/https://www.speech.kth.se/snack/dist/snack${version}.tar.gz"
checksum="4bfe764547ab92ba58f43b77366dbb7c7b3512d65a27cdbf9e585a9cb64ce81e"


post_extract () {
	# Minor code corrections, missing include.
	sed -i '/#include <stdlib.h>/a #include <math.h>' ${wrksrc}/generic/jkFormatMP3.c
	sed -i '/#include "snack.h"/a #include <stdint.h>' ${wrksrc}/generic/jkSoundFile.c
}

do_configure () {
	./configure \
		--enable-alsa \
		--with-tcl=/usr/lib/ \
		--with-tk=/usr/lib \
		--with-ogg-include=/usr/lib \
		--with-ogg-lib=/usr/lib
}
```
Now I'm getting the error:

./../unix/jkAudIO_alsa.c:23:10: fatal error: jkAudIO.h: No such file or directory
   23 | #include "jkAudIO.h"
      |          ^~~~~~~~~~~
compilation terminated.

Re: Package request: tcl-snack

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2078829023

Comment:
using gnu-configure solved the issue

Re: Package request: tcl-snack

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2078829023

Comment:
using `build-styl=gnu-configure` solved the issue

Re: Package request: tcl-snack

[MechDR]

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

New comment by MechDR on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2078831440

Comment:
> I think it is fine. It just ends building. 

Not for me... I will try on a clean git clone.

> Now I'm getting the error...

That's because the makefile needs to exit the `unix` dir and enter the `generic` dir, but with `build_wrksrc=unix`, we're limiting xbps-src to build in that dir and not exit it. I tried copying a few files "missing" from the `unix` dir and it does get past the files I copied, but of course gets stuck on other missing files.

There are 2 options. We either copy everything from `generic` to `unix`, which might overwrite something that doesn't need to be overwritten, or two, we don't define `build_wrksrc` at all and just do `do_build` manually, like in my original script.

> make: *** No rule to make target 'install'. Stop.

I think that is because it actually builds in the same dir as the source, there is no separate dir... don't know how xbps-src solves this regarding what files it should take from the build... my guess is, it has to have a separate build dir, so it will just copy everything to `destdir`.

Re: Package request: tcl-snack

[MechDR]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by MechDR on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2078833939

Comment:
> using `build-styl=gnu-configure` solved the issue

Just that change in your last template? OK, will try.

Re: Package request: tcl-snack

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 2221 bytes --]

New comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2078838126

Comment:
```
# Template file for 'tcl-snack
pkgname=tcl-snack
version=2.2.10
revision=1
build_style=gnu-configure
build_wrksrc=unix
configure_args="--enable-alsa --with-tcl=/usr/lib/ --with-tk=/usr/lib --with-ogg-include=/usr/lib --with-ogg-lib=/usr/lib"
hostmakedepends=""
makedepends="tcl-devel tk-devel vorbis-tools libvorbis-devel alsa-lib-devel"
short_desc="Snack is a powerfull multi-platform library for audio playback, recording, etc. using Tcl/Tk or Python."
maintainer="someone <someone@some.one>"
license="GPL-2.0-only"
homepage="https://www.speech.kth.se/snack/"
distfiles="https://web.archive.org/web/20230819212652/https://www.speech.kth.se/snack/dist/snack${version}.tar.gz"
checksum="4bfe764547ab92ba58f43b77366dbb7c7b3512d65a27cdbf9e585a9cb64ce81e"

post_extract () {
	# Minor code corrections, missing include.
	sed -i '/#include <stdlib.h>/a #include <math.h>' ${wrksrc}/generic/jkFormatMP3.c
}
```

=> tcl-snack-2.2.10_1: running post-install hook: 99-pkglint-warn-cross-cruft ...
=> tcl-snack-2.2.10_1: running pre-pkg hook: 03-rewrite-python-shebang ...
=> tcl-snack-2.2.10_1: running pre-pkg hook: 04-generate-runtime-deps ...
   SONAME: libc.so.6 <-> glibc>=2.39_1
   SONAME: libasound.so.2 <-> alsa-lib>=1.0.20_1
   SONAME: libvorbisenc.so.2 <-> libvorbis>=1.2.1rc1_1
   SONAME: libvorbis.so.0 <-> libvorbis>=1.2.1rc1_1
   SONAME: libogg.so.0 <-> libogg>=1.3.0_1
   SONAME: libX11.so.6 <-> libX11>=1.2_1
   SONAME: libtcl8.6.so <-> tcl>=8.6.0_1
   SONAME: libm.so.6 <-> glibc>=2.39_1
=> tcl-snack-2.2.10_1: running pre-pkg hook: 05-generate-32bit-runtime-deps ...
=> tcl-snack-2.2.10_1: running pre-pkg hook: 90-set-timestamps ...
=> tcl-snack-2.2.10_1: setting mtimes to Fri Apr 26 07:56:09 AM UTC 2024
=> tcl-snack-2.2.10_1: running pre-pkg hook: 99-pkglint-subpkgs ...
=> tcl-snack-2.2.10_1: running pre-pkg hook: 99-pkglint ...
=> ERROR: tcl-snack-2.2.10_1: /lib64 must not exist.
=> ERROR: tcl-snack-2.2.10_1: cannot continue with installation!


The problem now it is that it install things in the wrong place...

Re: Package request: tcl-snack

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2078844114

Comment:
Also, I think that snack can be used from other scripting languages. Maybe we should call it just "snack".

Re: Package request: tcl-snack

[MechDR]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New comment by MechDR on void-packages repository

https://github.com/void-linux/void-packages/issues/49825#issuecomment-2078847272

Comment:
Yeah, there is no other package called "snack". OK, go for it.