[PR PATCH] ladspa-sdk: remove archs=noarch

[PR PATCH] ladspa-sdk: remove archs=noarch

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

There is a new pull request by newbluemoon against master on the void-packages repository

https://github.com/newbluemoon/void-packages ladspa-sdk
https://github.com/void-linux/void-packages/pull/23533

ladspa-sdk: remove archs=noarch
The main package ladspa-sdk contains only a header file, but ladspa-sdk-example-plugins and ladspa-sdk-progs subpackages contain arch dependent binaries. Trying to load a plugin fails e.g. on i686.

I think the case where the main package is `noarch`, but some subpackages aren’t isn’t covered (yet) by xbps-src without having to add every available arch to the subpackage (which wouldn’t make sense, anyway). Or is it and I just don’t see it? :)


A patch file from https://github.com/void-linux/void-packages/pull/23533.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ladspa-sdk-23533.patch --]
[-- Type: text/x-diff, Size: 816 bytes --]

From c8a044fade043e0cf8d1da84cc50c597249aec50 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Sun, 12 Jul 2020 10:02:39 +0200
Subject: [PATCH] ladspa-sdk: remove archs=noarch

The ladspa-sdk-example-plugins and
ladspa-sdk-progs subpackages contain
arch dependent binaries.
---
 srcpkgs/ladspa-sdk/template | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/srcpkgs/ladspa-sdk/template b/srcpkgs/ladspa-sdk/template
index 28f27fe0300..b94f86c2fbb 100644
--- a/srcpkgs/ladspa-sdk/template
+++ b/srcpkgs/ladspa-sdk/template
@@ -1,8 +1,7 @@
 # Template file for 'ladspa-sdk'
 pkgname=ladspa-sdk
 version=1.15
-revision=1
-archs=noarch
+revision=2
 wrksrc="ladspa_sdk_${version}"
 makedepends="libsndfile-progs"
 short_desc="Linux Audio Developer's Simple Plugin API (LADSPA)"

Re: ladspa-sdk: remove archs=noarch

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/23533#issuecomment-657731135

Comment:
> main package is `noarch`, but some subpackages aren’t isn’t covered

Manual explains how to do it.

Re: [PR PATCH] [Updated] ladspa-sdk: remove archs=noarch

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

There is an updated pull request by newbluemoon against master on the void-packages repository

https://github.com/newbluemoon/void-packages ladspa-sdk
https://github.com/void-linux/void-packages/pull/23533

ladspa-sdk: remove archs=noarch
The main package ladspa-sdk contains only a header file, but ladspa-sdk-example-plugins and ladspa-sdk-progs subpackages contain arch dependent binaries. Trying to load a plugin fails e.g. on i686.

I think the case where the main package is `noarch`, but some subpackages aren’t isn’t covered (yet) by xbps-src without having to add every available arch to the subpackage (which wouldn’t make sense, anyway). Or is it and I just don’t see it? :)


A patch file from https://github.com/void-linux/void-packages/pull/23533.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ladspa-sdk-23533.patch --]
[-- Type: text/x-diff, Size: 1186 bytes --]

From 0f5ebb73e1f7df16f85847ab52995fc269d50e40 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Sun, 12 Jul 2020 10:02:39 +0200
Subject: [PATCH] ladspa-sdk: not all subpackages are noarch

The ladspa-sdk-example-plugins and
ladspa-sdk-progs subpackages contain
arch dependent binaries.
---
 srcpkgs/ladspa-sdk/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/ladspa-sdk/template b/srcpkgs/ladspa-sdk/template
index 28f27fe0300..792663a5c1f 100644
--- a/srcpkgs/ladspa-sdk/template
+++ b/srcpkgs/ladspa-sdk/template
@@ -1,7 +1,7 @@
 # Template file for 'ladspa-sdk'
 pkgname=ladspa-sdk
 version=1.15
-revision=1
+revision=2
 archs=noarch
 wrksrc="ladspa_sdk_${version}"
 makedepends="libsndfile-progs"
@@ -36,6 +36,7 @@ ladspa-sdk-doc_package() {
 
 ladspa-sdk-example-plugins_package() {
 	short_desc+=" - Example plugins"
+	archs="*"
 	pkg_install() {
 		vmkdir usr/lib/ladspa
 		vcopy "${wrksrc}/plugins/*.so*" usr/lib/ladspa
@@ -44,6 +45,7 @@ ladspa-sdk-example-plugins_package() {
 
 ladspa-sdk-progs_package() {
 	short_desc+=" - Example programs"
+	archs="*"
 	pkg_install() {
 		vmkdir usr
 		vcopy ${wrksrc}/bin usr

Re: ladspa-sdk: not all subpackages are noarch

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/23533#issuecomment-657755197

Comment:
Thanks for the hint. Forgot that wildcards are an option, too. ;)

Re: [PR PATCH] [Merged]: ladspa-sdk: not all subpackages are noarch

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

There's a merged pull request on the void-packages repository

ladspa-sdk: not all subpackages are noarch
https://github.com/void-linux/void-packages/pull/23533

Description:
The main package ladspa-sdk contains only a header file, but ladspa-sdk-example-plugins and ladspa-sdk-progs subpackages contain arch dependent binaries. Trying to load a plugin fails e.g. on i686.

I think the case where the main package is `noarch`, but some subpackages aren’t isn’t covered (yet) by xbps-src without having to add every available arch to the subpackage (which wouldn’t make sense, anyway). Or is it and I just don’t see it? :)