Github messages for voidlinux
 help / color / Atom feed
* [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
@ 2020-07-16 17:46 Hoshpak
  2020-07-16 18:29 ` pullmoll
                   ` (15 more replies)
  0 siblings, 16 replies; 17+ messages in thread
From: Hoshpak @ 2020-07-16 17:46 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

There is a new pull request by Hoshpak against master on the void-packages repository

https://github.com/Hoshpak/void-packages allow_usr_share_exceptions
https://github.com/void-linux/void-packages/pull/23601

[RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
This will allow to explicitely ignore files in the hook where it otherwise would create false positives like in the case of qemu.

@void-linux/pkg-committers

A patch file from https://github.com/void-linux/void-packages/pull/23601.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-allow_usr_share_exceptions-23601.patch --]
[-- Type: text/x-diff, Size: 1218 bytes --]

From 3676be6e4d5e14014baceed5b6fcf135a2ecee82 Mon Sep 17 00:00:00 2001
From: Helmut Pozimski <helmut@pozimski.eu>
Date: Thu, 16 Jul 2020 19:44:01 +0200
Subject: [PATCH] 11-pkglint-elf-in-usrshare: allow explicit setting of
 exceptions

---
 common/hooks/post-install/11-pkglint-elf-in-usrshare.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/common/hooks/post-install/11-pkglint-elf-in-usrshare.sh b/common/hooks/post-install/11-pkglint-elf-in-usrshare.sh
index ff4f7789e86..02ca1c11bee 100644
--- a/common/hooks/post-install/11-pkglint-elf-in-usrshare.sh
+++ b/common/hooks/post-install/11-pkglint-elf-in-usrshare.sh
@@ -18,7 +18,11 @@ hook() {
         case "${mime}" in
             # Note application/x-executable is missing which is present in most Electron apps
             application/x-sharedlib*|application/x-pie-executable*)
-                matches+=" ${file#$PKGDESTDIR}" ;;
+                if ! [[ ${ignore_in_usr_share} =~ $(basename ${file#$PKGDESTDIR}) ]]
+                then
+                    matches+=" ${file#$PKGDESTDIR}"
+                fi
+                ;;
         esac
     done < <(find $PKGDESTDIR/usr/share -type f | file --mime-type --files-from -)
 

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
@ 2020-07-16 18:29 ` pullmoll
  2020-07-16 18:30 ` [PR REVIEW] " ahesford
                   ` (14 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: pullmoll @ 2020-07-16 18:29 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/23601#issuecomment-659591721

Comment:
Clean solution LGTM

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
  2020-07-16 18:29 ` pullmoll
@ 2020-07-16 18:30 ` ahesford
  2020-07-16 19:09 ` [PR PATCH] [Updated] " Hoshpak
                   ` (13 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: ahesford @ 2020-07-16 18:30 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/23601#discussion_r455987384

Comment:
A test like
```
[[ ${ignore_in_usr_share} != *$(basename "$I")* ]]
```
to the match operator would be consistent with with match tests in the build-helpers.

Regardless, the argument to `basename` should be quoted in case the file has spaces in the name.

Also, why bother stripping out `PKGDESTDIR` from `file` if we are feeding it to basename anyway?

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
  2020-07-16 18:29 ` pullmoll
  2020-07-16 18:30 ` [PR REVIEW] " ahesford
@ 2020-07-16 19:09 ` Hoshpak
  2020-07-16 19:18 ` Hoshpak
                   ` (12 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: Hoshpak @ 2020-07-16 19:09 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

There is an updated pull request by Hoshpak against master on the void-packages repository

https://github.com/Hoshpak/void-packages allow_usr_share_exceptions
https://github.com/void-linux/void-packages/pull/23601

[RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
This will allow to explicitely ignore files in the hook where it otherwise would create false positives like in the case of qemu.

@void-linux/pkg-committers

A patch file from https://github.com/void-linux/void-packages/pull/23601.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-allow_usr_share_exceptions-23601.patch --]
[-- Type: text/x-diff, Size: 1208 bytes --]

From 859353d1b27965898f905ece4747d686ebbb77a5 Mon Sep 17 00:00:00 2001
From: Helmut Pozimski <helmut@pozimski.eu>
Date: Thu, 16 Jul 2020 19:44:01 +0200
Subject: [PATCH] 11-pkglint-elf-in-usrshare: allow explicit setting of
 exceptions

---
 common/hooks/post-install/11-pkglint-elf-in-usrshare.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/common/hooks/post-install/11-pkglint-elf-in-usrshare.sh b/common/hooks/post-install/11-pkglint-elf-in-usrshare.sh
index ff4f7789e86..91f38600e02 100644
--- a/common/hooks/post-install/11-pkglint-elf-in-usrshare.sh
+++ b/common/hooks/post-install/11-pkglint-elf-in-usrshare.sh
@@ -18,7 +18,11 @@ hook() {
         case "${mime}" in
             # Note application/x-executable is missing which is present in most Electron apps
             application/x-sharedlib*|application/x-pie-executable*)
-                matches+=" ${file#$PKGDESTDIR}" ;;
+                if [[ ${ignore_in_usr_share} != *$(basename "${file}")* ]]
+                then
+                    matches+=" ${file#$PKGDESTDIR}"
+                fi
+                ;;
         esac
     done < <(find $PKGDESTDIR/usr/share -type f | file --mime-type --files-from -)
 

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
                   ` (2 preceding siblings ...)
  2020-07-16 19:09 ` [PR PATCH] [Updated] " Hoshpak
@ 2020-07-16 19:18 ` Hoshpak
  2020-07-16 19:20 ` Hoshpak
                   ` (11 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: Hoshpak @ 2020-07-16 19:18 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 1927 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/23601#issuecomment-659617133

Comment:
Am 16.07.20 um 20:30 schrieb Andrew J. Hesford:
> *@ahesford* requested changes on this pull request.
> 
> I think we will always have difficulty with files that might contain spaces in 
> the name, because we will not be able to distinguish a file named |File with 
> spaces| in |$ignore_in_usr_share| and three separate files named |File|, |with| 
> and |spaces|. Using an array instead of space-separated strings avoids this, but 
> gets clumsy in the template (if we allow arrays in |ignore_in_usr_share|, why 
> not for any other variables?).

I think the general consensus up to know was to keep arrays out of
xbps-src. It will make the code less portable but we use a lot of
bashims already and the general assumption is that it will be run with
bash. Personally I just dislike how arrays are handled in bash and
usually tend to rather rewrite a script in python than having to deal
with them.

> It might also be nice to support directories in |ignore_in_usr_share| so we can 
> do things like |usr/share/qemu/firmware| instead of listing each file, but that 
> involves a second test and a bit of thought.

In the case of qemu there are just two files which make the hook fail. I
don't know if there are packages with a lot of files which would require
exceptions though.

> |[[ ${ignore_in_usr_share} != *$(basename "$I")* ]] |
> 
> to the match operator would be consistent with with match tests in the 
> build-helpers.
> 
> Regardless, the argument to |basename| should be quoted in case the file has 
> spaces in the name.

Thanks, I changed the check as you suggested and verified that it now
works for files with spaces.

> Also, why bother stripping out |PKGDESTDIR| from |file| if we are feeding it to 
> basename anyway?

Just an oversight on my part. I removed it.



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
                   ` (3 preceding siblings ...)
  2020-07-16 19:18 ` Hoshpak
@ 2020-07-16 19:20 ` Hoshpak
  2020-07-16 23:28 ` [PR REVIEW] " Johnnynator
                   ` (10 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: Hoshpak @ 2020-07-16 19:20 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 1918 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/23601#issuecomment-659617133

Comment:
> *@ahesford* requested changes on this pull request.
> 
> I think we will always have difficulty with files that might contain spaces in 
> the name, because we will not be able to distinguish a file named |File with 
> spaces| in |$ignore_in_usr_share| and three separate files named |File|, |with| 
> and |spaces|. Using an array instead of space-separated strings avoids this, but 
> gets clumsy in the template (if we allow arrays in |ignore_in_usr_share|, why 
> not for any other variables?).

I think the general consensus up to now was to keep arrays out of
xbps-src. It will make the code less portable but we use a lot of
bashims already and the general assumption is that it will be run with
bash. Personally I just dislike how arrays are handled in bash and
usually tend to rather rewrite a script in python than having to deal
with them.

> It might also be nice to support directories in |ignore_in_usr_share| so we can 
> do things like |usr/share/qemu/firmware| instead of listing each file, but that 
> involves a second test and a bit of thought.

In the case of qemu there are just two files which make the hook fail. I
don't know if there are packages with a lot of files which would require
exceptions though.

> |[[ ${ignore_in_usr_share} != *$(basename "$I")* ]] |
> 
> to the match operator would be consistent with with match tests in the 
> build-helpers.
> 
> Regardless, the argument to |basename| should be quoted in case the file has 
> spaces in the name.

Thanks, I changed the check as you suggested and verified that it now
works for files with spaces.

> Also, why bother stripping out |PKGDESTDIR| from |file| if we are feeding it to 
> basename anyway?

Just an oversight on my part. I removed it.



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
                   ` (4 preceding siblings ...)
  2020-07-16 19:20 ` Hoshpak
@ 2020-07-16 23:28 ` Johnnynator
  2020-07-16 23:29 ` Johnnynator
                   ` (9 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: Johnnynator @ 2020-07-16 23:28 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/23601#discussion_r456133358

Comment:
Can't you just compare it to `${file##/*}`, is faster but should give the same output as basename. (find does afaik never give you a path with a trailing `/`)

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
                   ` (5 preceding siblings ...)
  2020-07-16 23:28 ` [PR REVIEW] " Johnnynator
@ 2020-07-16 23:29 ` Johnnynator
  2020-07-17 10:56 ` Piraty
                   ` (8 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: Johnnynator @ 2020-07-16 23:29 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/23601#discussion_r456133358

Comment:
Can't you just compare it to `${file##*/}`, is faster but should give the same output as basename. (find does afaik never give you a path with a trailing `/`)

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
                   ` (6 preceding siblings ...)
  2020-07-16 23:29 ` Johnnynator
@ 2020-07-17 10:56 ` Piraty
  2020-07-20 19:27 ` [PR PATCH] [Updated] " Hoshpak
                   ` (7 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: Piraty @ 2020-07-17 10:56 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/23601#issuecomment-660040163

Comment:
> In the case of qemu there are just two files which make the hook fail. I don't know if there are packages with a lot of files which would require exceptions though.

yes there are, i remember some microctrontroller firmware development package had to work around the hook really hard

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
                   ` (7 preceding siblings ...)
  2020-07-17 10:56 ` Piraty
@ 2020-07-20 19:27 ` Hoshpak
  2020-07-20 19:29 ` Hoshpak
                   ` (6 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: Hoshpak @ 2020-07-20 19:27 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

There is an updated pull request by Hoshpak against master on the void-packages repository

https://github.com/Hoshpak/void-packages allow_usr_share_exceptions
https://github.com/void-linux/void-packages/pull/23601

[RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
This will allow to explicitely ignore files in the hook where it otherwise would create false positives like in the case of qemu.

@void-linux/pkg-committers

A patch file from https://github.com/void-linux/void-packages/pull/23601.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-allow_usr_share_exceptions-23601.patch --]
[-- Type: text/x-diff, Size: 1298 bytes --]

From f3154626a14ce9130b99b945ab98c3841419cac8 Mon Sep 17 00:00:00 2001
From: Helmut Pozimski <helmut@pozimski.eu>
Date: Thu, 16 Jul 2020 19:44:01 +0200
Subject: [PATCH] 11-pkglint-elf-in-usrshare: allow explicit setting of
 exceptions

---
 common/hooks/post-install/11-pkglint-elf-in-usrshare.sh | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/common/hooks/post-install/11-pkglint-elf-in-usrshare.sh b/common/hooks/post-install/11-pkglint-elf-in-usrshare.sh
index ff4f7789e86..41c6af5456d 100644
--- a/common/hooks/post-install/11-pkglint-elf-in-usrshare.sh
+++ b/common/hooks/post-install/11-pkglint-elf-in-usrshare.sh
@@ -18,7 +18,12 @@ hook() {
         case "${mime}" in
             # Note application/x-executable is missing which is present in most Electron apps
             application/x-sharedlib*|application/x-pie-executable*)
-                matches+=" ${file#$PKGDESTDIR}" ;;
+                directory=${file%/*}
+                if [[ ${ignore_usrshare_files} != *"${file##*/}"* ]] && [[ ${ignore_usrshare_dirs} != *"${directory##*/}"* ]]
+                then
+                    matches+=" ${file#$PKGDESTDIR}"
+                fi
+                ;;
         esac
     done < <(find $PKGDESTDIR/usr/share -type f | file --mime-type --files-from -)
 

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
                   ` (8 preceding siblings ...)
  2020-07-20 19:27 ` [PR PATCH] [Updated] " Hoshpak
@ 2020-07-20 19:29 ` Hoshpak
  2020-07-20 19:31 ` Hoshpak
                   ` (5 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: Hoshpak @ 2020-07-20 19:29 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/23601#issuecomment-661288545

Comment:
> +                if [[ ${ignore_in_usr_share} != *$(basename "${file}")* ]]
> 
> Can't you just compare it to |${file##/*}|, is faster but should give the same 
> output as basename. (find does afaik never give you a path with a trailing |/|)

That works as well. I changed it.



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
                   ` (9 preceding siblings ...)
  2020-07-20 19:29 ` Hoshpak
@ 2020-07-20 19:31 ` Hoshpak
  2020-07-20 19:53 ` ahesford
                   ` (4 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: Hoshpak @ 2020-07-20 19:31 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/23601#issuecomment-661289627

Comment:
>     In the case of qemu there are just two files which make the hook fail. I
>     don't know if there are packages with a lot of files which would require
>     exceptions though.
> 
> yes there are, i remember some microctrontroller firmware development package 
> had to work around the hook really hard

Then it is definitely beneficial to be able to exclude directories. I
split it into two variable `ignore_usrshare_files` and
`ignore_usrshare_dirs` in the lates iteration so we can either ignore
individual files or the directory containing the files.


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
                   ` (10 preceding siblings ...)
  2020-07-20 19:31 ` Hoshpak
@ 2020-07-20 19:53 ` ahesford
  2020-07-22 22:07 ` Chocimier
                   ` (3 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: ahesford @ 2020-07-20 19:53 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/23601#issuecomment-661299884

Comment:
Now that I'm thinking about this again, I wonder if looking at the basename is the right choice. Maybe it should just compare `${file#$PKGDESTDIR}` to the contents of `$ignore_usrshare_files` so we can differentiate files like
```
/usr/share/elf-allowed/myfile
/usr/share/elf-bad/myfile
```
The same should probably hold with `$ignore_usrshare_dirs`: require the full path (wrt `$PKGDESTDIR`) be specified instead of just the basename.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
                   ` (11 preceding siblings ...)
  2020-07-20 19:53 ` ahesford
@ 2020-07-22 22:07 ` Chocimier
  2020-07-23 16:34 ` Hoshpak
                   ` (2 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: Chocimier @ 2020-07-22 22:07 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/23601#issuecomment-662722062

Comment:
Hook operates on usr/share so paths relative to usr/share feels natural. Then we can go crazy and not pass files in ignored directories to file(1). https://github.com/void-linux/void-packages/commit/da030cf5cffe3b845d24cbb9f29f5d12777a9eec

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
                   ` (12 preceding siblings ...)
  2020-07-22 22:07 ` Chocimier
@ 2020-07-23 16:34 ` Hoshpak
  2020-07-29 20:54 ` Chocimier
  2020-07-30 15:07 ` Hoshpak
  15 siblings, 0 replies; 17+ messages in thread
From: Hoshpak @ 2020-07-23 16:34 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/23601#issuecomment-663107934

Comment:
> Hook operates on usr/share so paths relative to usr/share feels natural. Then we can go crazy and not pass files in ignored directories to file(1). https://github.com/void-linux/void-packages/commit/da030cf5cffe3b845d24cbb9f29f5d12777a9eec
> 

Looks good, please got for it.


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
                   ` (13 preceding siblings ...)
  2020-07-23 16:34 ` Hoshpak
@ 2020-07-29 20:54 ` Chocimier
  2020-07-30 15:07 ` Hoshpak
  15 siblings, 0 replies; 17+ messages in thread
From: Chocimier @ 2020-07-29 20:54 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/23601#issuecomment-665921695

Comment:
There was idea to forbid elfs anywhere for noarch packages. In that case, full path would fit better.

> Looks good, please got for it.

When showing changes, I expected you take them into PR if liked them. Do you want me to overtake this PR instead?

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
  2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
                   ` (14 preceding siblings ...)
  2020-07-29 20:54 ` Chocimier
@ 2020-07-30 15:07 ` Hoshpak
  15 siblings, 0 replies; 17+ messages in thread
From: Hoshpak @ 2020-07-30 15:07 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/23601#issuecomment-666435690

Comment:
>     Looks good, please got for it.
> 
> When showing changes, I expected you take them into PR if liked them. Do you 
> want me to overtake this PR instead?

Yes, please do so.


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, back to index

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-16 17:46 [PR PATCH] [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions Hoshpak
2020-07-16 18:29 ` pullmoll
2020-07-16 18:30 ` [PR REVIEW] " ahesford
2020-07-16 19:09 ` [PR PATCH] [Updated] " Hoshpak
2020-07-16 19:18 ` Hoshpak
2020-07-16 19:20 ` Hoshpak
2020-07-16 23:28 ` [PR REVIEW] " Johnnynator
2020-07-16 23:29 ` Johnnynator
2020-07-17 10:56 ` Piraty
2020-07-20 19:27 ` [PR PATCH] [Updated] " Hoshpak
2020-07-20 19:29 ` Hoshpak
2020-07-20 19:31 ` Hoshpak
2020-07-20 19:53 ` ahesford
2020-07-22 22:07 ` Chocimier
2020-07-23 16:34 ` Hoshpak
2020-07-29 20:54 ` Chocimier
2020-07-30 15:07 ` Hoshpak

Github messages for voidlinux

Archives are clonable: git clone --mirror http://inbox.vuxu.org/voidlinux-github

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git