Github messages for voidlinux
 help / color / Atom feed
* [PR PATCH] nodejs build style
@ 2020-07-30  9:19 selfisekai
  2020-08-03 20:08 ` Chocimier
  0 siblings, 1 reply; 2+ messages in thread
From: selfisekai @ 2020-07-30  9:19 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There is a new pull request by selfisekai against master on the void-packages repository

https://github.com/selfisekai/void-packages node-build-style
https://github.com/void-linux/void-packages/pull/23947

nodejs build style


A patch file from https://github.com/void-linux/void-packages/pull/23947.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-node-build-style-23947.patch --]
[-- Type: text/x-diff, Size: 1355 bytes --]

From cf172217b1ea17856a70f669733a411fe0daf6f1 Mon Sep 17 00:00:00 2001
From: selfisekai <laura@selfisekai.rocks>
Date: Thu, 30 Jul 2020 11:19:10 +0200
Subject: [PATCH] nodejs build style

---
 common/build-style/nodejs.sh | 37 ++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 common/build-style/nodejs.sh

diff --git a/common/build-style/nodejs.sh b/common/build-style/nodejs.sh
new file mode 100644
index 00000000000..c9e749d3342
--- /dev/null
+++ b/common/build-style/nodejs.sh
@@ -0,0 +1,37 @@
+#
+# This helper is for templates for Node.js packages (including Electron.js)
+#
+
+do_configure() {
+    if [ -f "yarn.lock" ]; then
+        : ${nodejs_packager:=yarn}
+    else
+        : ${nodejs_packager:=npm}
+    fi
+
+    $nodejs_packager install
+}
+
+do_build() {
+    if [ -f "yarn.lock" ]; then
+        : ${nodejs_packager:=yarn}
+    else
+        : ${nodejs_packager:=npm}
+    fi
+
+    : ${nodejs_build_script:=build}
+
+    $nodejs_packager run $nodejs_build_script
+}
+
+do_install() {
+    if [ -f "yarn.lock" ]; then
+        : ${nodejs_packager:=yarn}
+    else
+        : ${nodejs_packager:=npm}
+    fi
+
+    : ${nodejs_install_script:=pack}  # name suggested by https://github.com/electron-userland/electron-builder#quick-setup-guide
+
+    $nodejs_packager run $nodejs_install_script
+}

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: nodejs build style
  2020-07-30  9:19 [PR PATCH] nodejs build style selfisekai
@ 2020-08-03 20:08 ` Chocimier
  0 siblings, 0 replies; 2+ messages in thread
From: Chocimier @ 2020-08-03 20:08 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/23947#issuecomment-668217287

Comment:
I do not want it as long as it install precompiled binaries, i. e. until #21758 is done and build style uses that.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30  9:19 [PR PATCH] nodejs build style selfisekai
2020-08-03 20:08 ` Chocimier

Github messages for voidlinux

Archives are clonable: git clone --mirror http://inbox.vuxu.org/voidlinux-github

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git