[PR PATCH] xen: use makejobs in make install

[PR PATCH] xen: use makejobs in make install

[ashpooljh]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

There is a new pull request by ashpooljh against master on the void-packages repository

https://github.com/ashpooljh/void-packages xen-install-use-makejobs
https://github.com/void-linux/void-packages/pull/24140

xen: use makejobs in make install
It compiles something during `make install`, so use `$(makejobs) to allow speeding it up.

A patch file from https://github.com/void-linux/void-packages/pull/24140.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xen-install-use-makejobs-24140.patch --]
[-- Type: text/x-diff, Size: 806 bytes --]

From cd0999b70a575e90c6a8d8551461217c43fd6e82 Mon Sep 17 00:00:00 2001
From: Artem Zhurikhin <ashpool@xecut.net>
Date: Sat, 8 Aug 2020 13:59:53 +0300
Subject: [PATCH] xen: use makejobs in make install

[ci skip]
---
 srcpkgs/xen/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/xen/template b/srcpkgs/xen/template
index ae8f5e246fc..1ccddcbfc43 100644
--- a/srcpkgs/xen/template
+++ b/srcpkgs/xen/template
@@ -145,7 +145,7 @@ do_build() {
 do_install() {
 	rm -f ${XBPS_WRAPPERDIR}/strip
 	unset CC LD AR AS RANLIB CPP CFLAGS CXXFLAGS CPPFLAGS LDFLAGS
-	make DESTDIR=${DESTDIR} NO_WERROR=1 install install-docs
+	make ${makejobs} DESTDIR=${DESTDIR} NO_WERROR=1 install install-docs
 
 	# Move example config files into correct directory.
 	vmkdir usr/share/examples/xen

Re: xen: use makejobs in make install

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24140#issuecomment-670936366

Comment:
There's a chance those install steps weren't parallelized for a reason, have you tested the build locally to be sure?

Ideally, it would be nice to avoid building anything in `do_install`, so perhaps the issue is that it's building the docs target for `make install-docs`? Could you investigate that?

Re: xen: use makejobs in make install

[ashpooljh]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

New comment by ashpooljh on void-packages repository

https://github.com/void-linux/void-packages/pull/24140#issuecomment-670951497

Comment:
@ericonr I verified that it builds and runs correctly on my system (also having applied the changes from #24139).

I'll see what I can do to delegate all the building to the build phase.

Re: xen: use makejobs in make install

[ashpooljh]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

New comment by ashpooljh on void-packages repository

https://github.com/void-linux/void-packages/pull/24140#issuecomment-670951497

Comment:
@ericonr I verified that it builds and runs correctly on my system (also having applied the changes from #24139). I did in on a server with multiple CPU cores, so I made sure `XBPS_MAKEJOBS` was set accordingly.

I'll see what I can do to delegate all the building to the build phase.

Re: [PR PATCH] [Merged]: xen: use makejobs in make install

[jnbr]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

There's a merged pull request on the void-packages repository

xen: use makejobs in make install
https://github.com/void-linux/void-packages/pull/24140

Description:
It compiles something during `make install`, so use `${makejobs}` to allow speeding it up.