Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] dovecot: fix size of time_t for 64-bit cross.
@ 2020-09-16  0:19 ericonr
  2020-09-16  0:20 ` [PR PATCH] [Updated] " ericonr
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: ericonr @ 2020-09-16  0:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages dove
https://github.com/void-linux/void-packages/pull/24934

dovecot: fix size of time_t for 64-bit cross.
configure_args hard coded the size of the time_t type, which means
64-bit cross compiled archs, such as aarch64, were using the wrong type.
For little-endian, it would just break 2038-proofness, but BE machines
could have bigger issues.

A comment and commented out code were added to prepare for musl's time64
update.

A patch file from https://github.com/void-linux/void-packages/pull/24934.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dove-24934.patch --]
[-- Type: text/x-diff, Size: 1732 bytes --]

From 8ca6ba3f1d6fcac484eaa6465fcf38c542c5667b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Tue, 15 Sep 2020 21:12:15 -0300
Subject: [PATCH] dovecot: fix size of time_t for 64-bit cross.

configure_args hard coded the size of the time_t type, which means
64-bit cross compiled archs, such as aarch64, were using the wrong type.
For little-endian, it would just break 2038-proofness, but BE machines
could have bigger issues.

A comment and commented out code were added to prepare for musl's time64
update.
---
 srcpkgs/dovecot/template | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/dovecot/template b/srcpkgs/dovecot/template
index 03501d0aebf..a60a823c1ac 100644
--- a/srcpkgs/dovecot/template
+++ b/srcpkgs/dovecot/template
@@ -2,7 +2,7 @@
 # revbump dovecot-plugin-pigeonhole when updating dovecot!
 pkgname=dovecot
 version=2.3.11.3
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--with-moduledir=/usr/lib/dovecot/modules --with-sql=plugin
  --disable-static --with-pam --with-mysql --with-pgsql --with-lucene
@@ -22,14 +22,16 @@ distfiles="${homepage}/releases/2.3/${pkgname}-${version}.tar.gz"
 checksum=d3d9ea9010277f57eb5b9f4166a5d2ba539b172bd6d5a2b2529a6db524baafdc
 keep_libtool_archives=yes
 
-
 if [ "$CROSS_BUILD" ]; then
+	tsize=${XBPS_TARGET_WORDSIZE}
+	# FIXME: remove for time64 rebuild
+	#[ "$XBPS_TARGET_LIBC" = "musl" ] && tsize=64
 	configure_args+="
 		i_cv_epoll_works=yes
 		i_cv_inotify_works=yes
 		i_cv_posix_fallocate_works=yes
 		i_cv_signed_size_t=no
-		i_cv_gmtime_max_time_t=32
+		i_cv_gmtime_max_time_t=${tsize}
 		i_cv_signed_time_t=yes
 		i_cv_mmap_plays_with_write=yes
 		i_cv_fd_passing=yes

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] dovecot: fix size of time_t for 64-bit cross.
  2020-09-16  0:19 [PR PATCH] dovecot: fix size of time_t for 64-bit cross ericonr
@ 2020-09-16  0:20 ` ericonr
  2020-09-16  0:22 ` ericonr
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-09-16  0:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages dove
https://github.com/void-linux/void-packages/pull/24934

dovecot: fix size of time_t for 64-bit cross.
configure_args hard coded the size of the time_t type, which means
64-bit cross compiled archs, such as aarch64, were using the wrong type.
For little-endian, it would just break 2038-proofness, but BE machines
could have bigger issues.

A comment and commented out code were added to prepare for musl's time64
update.

A patch file from https://github.com/void-linux/void-packages/pull/24934.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dove-24934.patch --]
[-- Type: text/x-diff, Size: 1735 bytes --]

From 2bd0735d68aa5e1e8e814acb58e03feedef073ec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Tue, 15 Sep 2020 21:12:15 -0300
Subject: [PATCH] dovecot: fix size of time_t for 64-bit cross.

configure_args hard coded the size of the time_t type, which means
64-bit cross compiled archs, such as aarch64, were using the wrong type.
For little-endian, it would just break 2038-proofness, but BE machines
could have bigger issues.

A comment and commented out code were added to prepare for musl's time64
update.
---
 srcpkgs/dovecot/template | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/dovecot/template b/srcpkgs/dovecot/template
index 03501d0aebf..6c2ad93efd4 100644
--- a/srcpkgs/dovecot/template
+++ b/srcpkgs/dovecot/template
@@ -2,7 +2,7 @@
 # revbump dovecot-plugin-pigeonhole when updating dovecot!
 pkgname=dovecot
 version=2.3.11.3
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--with-moduledir=/usr/lib/dovecot/modules --with-sql=plugin
  --disable-static --with-pam --with-mysql --with-pgsql --with-lucene
@@ -22,14 +22,16 @@ distfiles="${homepage}/releases/2.3/${pkgname}-${version}.tar.gz"
 checksum=d3d9ea9010277f57eb5b9f4166a5d2ba539b172bd6d5a2b2529a6db524baafdc
 keep_libtool_archives=yes
 
-
 if [ "$CROSS_BUILD" ]; then
+	_tsize=${XBPS_TARGET_WORDSIZE}
+	# FIXME: remove for time64 rebuild
+	#[ "$XBPS_TARGET_LIBC" = "musl" ] && _tsize=64
 	configure_args+="
 		i_cv_epoll_works=yes
 		i_cv_inotify_works=yes
 		i_cv_posix_fallocate_works=yes
 		i_cv_signed_size_t=no
-		i_cv_gmtime_max_time_t=32
+		i_cv_gmtime_max_time_t=${_tsize}
 		i_cv_signed_time_t=yes
 		i_cv_mmap_plays_with_write=yes
 		i_cv_fd_passing=yes

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: dovecot: fix size of time_t for 64-bit cross.
  2020-09-16  0:19 [PR PATCH] dovecot: fix size of time_t for 64-bit cross ericonr
  2020-09-16  0:20 ` [PR PATCH] [Updated] " ericonr
@ 2020-09-16  0:22 ` ericonr
  2020-09-16  0:28 ` q66
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-09-16  0:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24934#issuecomment-693097584

Comment:
@leahneukirchen I should probably revbump `dovecot-plugin-pigeonhole` as well, right?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: dovecot: fix size of time_t for 64-bit cross.
  2020-09-16  0:19 [PR PATCH] dovecot: fix size of time_t for 64-bit cross ericonr
  2020-09-16  0:20 ` [PR PATCH] [Updated] " ericonr
  2020-09-16  0:22 ` ericonr
@ 2020-09-16  0:28 ` q66
  2020-09-16  9:13 ` leahneukirchen
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: q66 @ 2020-09-16  0:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/24934#issuecomment-693099211

Comment:
lgtm, i'll let leah review merge since i don't use this

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: dovecot: fix size of time_t for 64-bit cross.
  2020-09-16  0:19 [PR PATCH] dovecot: fix size of time_t for 64-bit cross ericonr
                   ` (2 preceding siblings ...)
  2020-09-16  0:28 ` q66
@ 2020-09-16  9:13 ` leahneukirchen
  2020-09-16 12:02 ` [PR PATCH] [Updated] " ericonr
  2020-09-16 12:06 ` [PR PATCH] [Merged]: " leahneukirchen
  5 siblings, 0 replies; 7+ messages in thread
From: leahneukirchen @ 2020-09-16  9:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/24934#issuecomment-693280435

Comment:
@ericonr yes, please bump the other package too.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] dovecot: fix size of time_t for 64-bit cross.
  2020-09-16  0:19 [PR PATCH] dovecot: fix size of time_t for 64-bit cross ericonr
                   ` (3 preceding siblings ...)
  2020-09-16  9:13 ` leahneukirchen
@ 2020-09-16 12:02 ` ericonr
  2020-09-16 12:06 ` [PR PATCH] [Merged]: " leahneukirchen
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-09-16 12:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages dove
https://github.com/void-linux/void-packages/pull/24934

dovecot: fix size of time_t for 64-bit cross.
configure_args hard coded the size of the time_t type, which means
64-bit cross compiled archs, such as aarch64, were using the wrong type.
For little-endian, it would just break 2038-proofness, but BE machines
could have bigger issues.

A comment and commented out code were added to prepare for musl's time64
update.

A patch file from https://github.com/void-linux/void-packages/pull/24934.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dove-24934.patch --]
[-- Type: text/x-diff, Size: 2573 bytes --]

From 2bd0735d68aa5e1e8e814acb58e03feedef073ec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Tue, 15 Sep 2020 21:12:15 -0300
Subject: [PATCH 1/2] dovecot: fix size of time_t for 64-bit cross.

configure_args hard coded the size of the time_t type, which means
64-bit cross compiled archs, such as aarch64, were using the wrong type.
For little-endian, it would just break 2038-proofness, but BE machines
could have bigger issues.

A comment and commented out code were added to prepare for musl's time64
update.
---
 srcpkgs/dovecot/template | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/dovecot/template b/srcpkgs/dovecot/template
index 03501d0aebf..6c2ad93efd4 100644
--- a/srcpkgs/dovecot/template
+++ b/srcpkgs/dovecot/template
@@ -2,7 +2,7 @@
 # revbump dovecot-plugin-pigeonhole when updating dovecot!
 pkgname=dovecot
 version=2.3.11.3
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--with-moduledir=/usr/lib/dovecot/modules --with-sql=plugin
  --disable-static --with-pam --with-mysql --with-pgsql --with-lucene
@@ -22,14 +22,16 @@ distfiles="${homepage}/releases/2.3/${pkgname}-${version}.tar.gz"
 checksum=d3d9ea9010277f57eb5b9f4166a5d2ba539b172bd6d5a2b2529a6db524baafdc
 keep_libtool_archives=yes
 
-
 if [ "$CROSS_BUILD" ]; then
+	_tsize=${XBPS_TARGET_WORDSIZE}
+	# FIXME: remove for time64 rebuild
+	#[ "$XBPS_TARGET_LIBC" = "musl" ] && _tsize=64
 	configure_args+="
 		i_cv_epoll_works=yes
 		i_cv_inotify_works=yes
 		i_cv_posix_fallocate_works=yes
 		i_cv_signed_size_t=no
-		i_cv_gmtime_max_time_t=32
+		i_cv_gmtime_max_time_t=${_tsize}
 		i_cv_signed_time_t=yes
 		i_cv_mmap_plays_with_write=yes
 		i_cv_fd_passing=yes

From 249b5966bb7b580e8ee00e5f73f20bac4300501b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 16 Sep 2020 09:02:01 -0300
Subject: [PATCH 2/2] dovecot-plugin-pigeonhole: revbump for dovecot time_t
 size.

---
 srcpkgs/dovecot-plugin-pigeonhole/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/dovecot-plugin-pigeonhole/template b/srcpkgs/dovecot-plugin-pigeonhole/template
index 92806ae3384..93c98a48a51 100644
--- a/srcpkgs/dovecot-plugin-pigeonhole/template
+++ b/srcpkgs/dovecot-plugin-pigeonhole/template
@@ -1,7 +1,7 @@
 # Template file for 'dovecot-plugin-pigeonhole'
 pkgname=dovecot-plugin-pigeonhole
 version=0.5.11
-revision=1
+revision=2
 wrksrc="dovecot-2.3-pigeonhole-${version}"
 build_style=gnu-configure
 configure_args="--prefix=/usr

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Merged]: dovecot: fix size of time_t for 64-bit cross.
  2020-09-16  0:19 [PR PATCH] dovecot: fix size of time_t for 64-bit cross ericonr
                   ` (4 preceding siblings ...)
  2020-09-16 12:02 ` [PR PATCH] [Updated] " ericonr
@ 2020-09-16 12:06 ` leahneukirchen
  5 siblings, 0 replies; 7+ messages in thread
From: leahneukirchen @ 2020-09-16 12:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

There's a merged pull request on the void-packages repository

dovecot: fix size of time_t for 64-bit cross.
https://github.com/void-linux/void-packages/pull/24934

Description:
configure_args hard coded the size of the time_t type, which means
64-bit cross compiled archs, such as aarch64, were using the wrong type.
For little-endian, it would just break 2038-proofness, but BE machines
could have bigger issues.

A comment and commented out code were added to prepare for musl's time64
update.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-09-16 12:06 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16  0:19 [PR PATCH] dovecot: fix size of time_t for 64-bit cross ericonr
2020-09-16  0:20 ` [PR PATCH] [Updated] " ericonr
2020-09-16  0:22 ` ericonr
2020-09-16  0:28 ` q66
2020-09-16  9:13 ` leahneukirchen
2020-09-16 12:02 ` [PR PATCH] [Updated] " ericonr
2020-09-16 12:06 ` [PR PATCH] [Merged]: " leahneukirchen

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git