* [PR PATCH] picard: update to 2.4.4
@ 2020-09-19 17:38 the-eater
2020-09-19 17:55 ` [PR PATCH] [Updated] " the-eater
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: the-eater @ 2020-09-19 17:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 549 bytes --]
There is a new pull request by the-eater against master on the void-packages repository
https://github.com/the-eater/neo-void-packages update/picard/2.4.4
https://github.com/void-linux/void-packages/pull/24984
picard: update to 2.4.4
There's a issue open in relation to provided patch
https://tickets.metabrainz.org/browse/PICARD-1948
only result of patch is that your scaling will be rounded up or down to a integer (e.g. 110% = 100%, 150% = 200%)
A patch file from https://github.com/void-linux/void-packages/pull/24984.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update/picard/2.4.4-24984.patch --]
[-- Type: text/x-diff, Size: 2709 bytes --]
From 174143ed2c50bf03f54ed2036c9d2f77525605d3 Mon Sep 17 00:00:00 2001
From: eater <=@eater.me>
Date: Sat, 19 Sep 2020 19:30:19 +0200
Subject: [PATCH] picard: update to 2.4.4
---
...emove-hidpi-scale-factor-rounding-policy.patch | 15 +++++++++++++++
srcpkgs/picard/template | 8 ++++----
2 files changed, 19 insertions(+), 4 deletions(-)
create mode 100644 srcpkgs/picard/patches/remove-hidpi-scale-factor-rounding-policy.patch
diff --git a/srcpkgs/picard/patches/remove-hidpi-scale-factor-rounding-policy.patch b/srcpkgs/picard/patches/remove-hidpi-scale-factor-rounding-policy.patch
new file mode 100644
index 00000000000..b1c11c114d6
--- /dev/null
+++ b/srcpkgs/picard/patches/remove-hidpi-scale-factor-rounding-policy.patch
@@ -0,0 +1,15 @@
+--- picard/tagger.py
++++ picard/tagger.py
+@@ -916,11 +916,6 @@ def main(localedir=None, autoupdate=True):
+ # Allow High DPI Support
+ QtWidgets.QApplication.setAttribute(QtCore.Qt.AA_UseHighDpiPixmaps)
+ QtWidgets.QApplication.setAttribute(QtCore.Qt.AA_EnableHighDpiScaling)
+- # HighDpiScaleFactorRoundingPolicy is available since Qt 5.14. This is
+- # required to support fractional scaling properly.
+- if hasattr(QtGui.QGuiApplication, 'setHighDpiScaleFactorRoundingPolicy'):
+- QtGui.QGuiApplication.setHighDpiScaleFactorRoundingPolicy(
+- QtCore.Qt.HighDpiScaleFactorRoundingPolicy.PassThrough)
+
+ # Enable mnemonics on all platforms, even macOS
+ QtGui.qt_set_sequence_auto_mnemonic(True)
+
diff --git a/srcpkgs/picard/template b/srcpkgs/picard/template
index ca1f29c11de..63d3ff3274c 100644
--- a/srcpkgs/picard/template
+++ b/srcpkgs/picard/template
@@ -1,6 +1,6 @@
# Template file for 'picard'
pkgname=picard
-version=2.3.2
+version=2.4.4
revision=1
archs=noarch
wrksrc="${pkgname}-release-${version}"
@@ -8,12 +8,12 @@ build_style=python3-module
make_install_args="--disable-autoupdate"
hostmakedepends="gettext python3-setuptools"
makedepends="python3-devel"
-depends="python3-PyQt5 chromaprint python3-mutagen
- desktop-file-utils hicolor-icon-theme"
+depends="python3-PyQt5 python3-PyQt5-multimedia chromaprint python3-mutagen
+ desktop-file-utils hicolor-icon-theme python3-discid"
short_desc="MusicBrainz's audio tagger"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="GPL-2.0-or-later"
homepage="https://picard.musicbrainz.org/"
changelog="https://picard.musicbrainz.org/changelog/"
distfiles="http://ftp.musicbrainz.org/pub/musicbrainz/${pkgname}/${pkgname}-${version%.0}.tar.gz"
-checksum=a91d9f11f2e5a6a0c579e0749e3a3919694ddeef0f251c1dded32e9331b1b0b7
+checksum=3e6a1abb886c859a20c164bec76e65a90b6b8d5a0c303a39d1432a39483cb4b0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] picard: update to 2.4.4
2020-09-19 17:38 [PR PATCH] picard: update to 2.4.4 the-eater
@ 2020-09-19 17:55 ` the-eater
2020-09-22 0:51 ` ahesford
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: the-eater @ 2020-09-19 17:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
There is an updated pull request by the-eater against master on the void-packages repository
https://github.com/the-eater/neo-void-packages update/picard/2.4.4
https://github.com/void-linux/void-packages/pull/24984
picard: update to 2.4.4
There's a issue open in relation to provided patch
https://tickets.metabrainz.org/browse/PICARD-1948
only result of patch is that your scaling will be rounded up or down to a integer (e.g. 110% = 100%, 150% = 200%)
A patch file from https://github.com/void-linux/void-packages/pull/24984.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update/picard/2.4.4-24984.patch --]
[-- Type: text/x-diff, Size: 2695 bytes --]
From bcf7932d5683bfc22beefb797dd013969a80f9b3 Mon Sep 17 00:00:00 2001
From: eater <=@eater.me>
Date: Sat, 19 Sep 2020 19:30:19 +0200
Subject: [PATCH] picard: update to 2.4.4
---
...emove-hidpi-scale-factor-rounding-policy.patch | 15 +++++++++++++++
srcpkgs/picard/template | 9 ++++-----
2 files changed, 19 insertions(+), 5 deletions(-)
create mode 100644 srcpkgs/picard/patches/remove-hidpi-scale-factor-rounding-policy.patch
diff --git a/srcpkgs/picard/patches/remove-hidpi-scale-factor-rounding-policy.patch b/srcpkgs/picard/patches/remove-hidpi-scale-factor-rounding-policy.patch
new file mode 100644
index 00000000000..b1c11c114d6
--- /dev/null
+++ b/srcpkgs/picard/patches/remove-hidpi-scale-factor-rounding-policy.patch
@@ -0,0 +1,15 @@
+--- picard/tagger.py
++++ picard/tagger.py
+@@ -916,11 +916,6 @@ def main(localedir=None, autoupdate=True):
+ # Allow High DPI Support
+ QtWidgets.QApplication.setAttribute(QtCore.Qt.AA_UseHighDpiPixmaps)
+ QtWidgets.QApplication.setAttribute(QtCore.Qt.AA_EnableHighDpiScaling)
+- # HighDpiScaleFactorRoundingPolicy is available since Qt 5.14. This is
+- # required to support fractional scaling properly.
+- if hasattr(QtGui.QGuiApplication, 'setHighDpiScaleFactorRoundingPolicy'):
+- QtGui.QGuiApplication.setHighDpiScaleFactorRoundingPolicy(
+- QtCore.Qt.HighDpiScaleFactorRoundingPolicy.PassThrough)
+
+ # Enable mnemonics on all platforms, even macOS
+ QtGui.qt_set_sequence_auto_mnemonic(True)
+
diff --git a/srcpkgs/picard/template b/srcpkgs/picard/template
index ca1f29c11de..fa7f68b9b21 100644
--- a/srcpkgs/picard/template
+++ b/srcpkgs/picard/template
@@ -1,19 +1,18 @@
# Template file for 'picard'
pkgname=picard
-version=2.3.2
+version=2.4.4
revision=1
-archs=noarch
wrksrc="${pkgname}-release-${version}"
build_style=python3-module
make_install_args="--disable-autoupdate"
hostmakedepends="gettext python3-setuptools"
makedepends="python3-devel"
-depends="python3-PyQt5 chromaprint python3-mutagen
- desktop-file-utils hicolor-icon-theme"
+depends="python3-PyQt5 python3-PyQt5-multimedia chromaprint python3-mutagen
+ desktop-file-utils hicolor-icon-theme python3-discid"
short_desc="MusicBrainz's audio tagger"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="GPL-2.0-or-later"
homepage="https://picard.musicbrainz.org/"
changelog="https://picard.musicbrainz.org/changelog/"
distfiles="http://ftp.musicbrainz.org/pub/musicbrainz/${pkgname}/${pkgname}-${version%.0}.tar.gz"
-checksum=a91d9f11f2e5a6a0c579e0749e3a3919694ddeef0f251c1dded32e9331b1b0b7
+checksum=3e6a1abb886c859a20c164bec76e65a90b6b8d5a0c303a39d1432a39483cb4b0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: picard: update to 2.4.4
2020-09-19 17:38 [PR PATCH] picard: update to 2.4.4 the-eater
2020-09-19 17:55 ` [PR PATCH] [Updated] " the-eater
@ 2020-09-22 0:51 ` ahesford
2020-09-22 8:29 ` the-eater
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2020-09-22 0:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/24984#issuecomment-696456405
Comment:
This patch should wait until upstream weighs in on the issue.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: picard: update to 2.4.4
2020-09-19 17:38 [PR PATCH] picard: update to 2.4.4 the-eater
2020-09-19 17:55 ` [PR PATCH] [Updated] " the-eater
2020-09-22 0:51 ` ahesford
@ 2020-09-22 8:29 ` the-eater
2020-09-22 11:35 ` ahesford
2020-10-03 14:50 ` [PR PATCH] [Closed]: " the-eater
4 siblings, 0 replies; 6+ messages in thread
From: the-eater @ 2020-09-22 8:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
New comment by the-eater on void-packages repository
https://github.com/void-linux/void-packages/pull/24984#issuecomment-696582195
Comment:
we currently have a functionally broken package in our repo, having a minimally intrusive fix sounds better to than just keeping it around broken
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: picard: update to 2.4.4
2020-09-19 17:38 [PR PATCH] picard: update to 2.4.4 the-eater
` (2 preceding siblings ...)
2020-09-22 8:29 ` the-eater
@ 2020-09-22 11:35 ` ahesford
2020-10-03 14:50 ` [PR PATCH] [Closed]: " the-eater
4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2020-09-22 11:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/24984#issuecomment-696665008
Comment:
Sure it sounds better. But I see one random user on the internet claiming breakage (two, if you didn't also file the upstream report). How do I know you didn't misconfigure something? How do I know your patch doesn't have side effects? I've never used picard and hadn't even heard about it until reading your report.
Void defers to upstream. Whenever possible, we try not to maintain unofficial patches because it gets unwieldy. Either wait until upstream sanctions the patch by merging it (we will patch with upstream fixes that haven't yet been released, if they fix known issues), or hope another package committer uses picard and is willing to sign off on the unofficial patch.
You can maintain the patched package in your own repo until then.
> On Sep 22, 2020, at 4:29 AM, eater <notifications@github.com> wrote:
>
>
> we currently have a functionally broken package in our repo, having a minimally intrusive fix sounds better to than just keeping it around broken
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or unsubscribe.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Closed]: picard: update to 2.4.4
2020-09-19 17:38 [PR PATCH] picard: update to 2.4.4 the-eater
` (3 preceding siblings ...)
2020-09-22 11:35 ` ahesford
@ 2020-10-03 14:50 ` the-eater
4 siblings, 0 replies; 6+ messages in thread
From: the-eater @ 2020-10-03 14:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 378 bytes --]
There's a closed pull request on the void-packages repository
picard: update to 2.4.4
https://github.com/void-linux/void-packages/pull/24984
Description:
There's a issue open in relation to provided patch
https://tickets.metabrainz.org/browse/PICARD-1948
only result of patch is that your scaling will be rounded up or down to a integer (e.g. 110% = 100%, 150% = 200%)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-03 14:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-19 17:38 [PR PATCH] picard: update to 2.4.4 the-eater
2020-09-19 17:55 ` [PR PATCH] [Updated] " the-eater
2020-09-22 0:51 ` ahesford
2020-09-22 8:29 ` the-eater
2020-09-22 11:35 ` ahesford
2020-10-03 14:50 ` [PR PATCH] [Closed]: " the-eater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).