Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Manual.md: relax and clarify the "no sripts" policy
@ 2020-10-18 14:24 ahesford
  2020-10-18 14:33 ` [PR REVIEW] " sgn
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: ahesford @ 2020-10-18 14:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 759 bytes --]

There is a new pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages manual
https://github.com/void-linux/void-packages/pull/25707

Manual.md: relax and clarify the "no sripts" policy
I think our "no scripts" policy is too strict and precludes the inclusion of useful administrative tools. These are helpful to have packaged because it makes deploying new Void systems easier by keeping tools in one place. Based on a discussion in #xbps, I propose the following relaxed language that still gives us a reasonable justification for rejecting apparently useless scripts while admitting some more useful ones.

A patch file from https://github.com/void-linux/void-packages/pull/25707.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-manual-25707.patch --]
[-- Type: text/x-diff, Size: 1271 bytes --]

From 622b070a21b9af212ac431988b2222ebf7e6ee6a Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Sun, 18 Oct 2020 10:22:39 -0400
Subject: [PATCH] Manual.md: relax and clarify the "no sripts" policy

---
 Manual.md | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Manual.md b/Manual.md
index 4af3a7b78d9..f0a537aeba7 100644
--- a/Manual.md
+++ b/Manual.md
@@ -136,10 +136,11 @@ the Void packages system.
 1. Required: Another package either within the repository or pending inclusion
    requires the package.
 
-In particular, new themes and small shell scripts are highly unlikely
-to be accepted. New fonts are welcome if they provide value beyond
-aesthetics (e.g. they contain glyphs for a script missing in already
-packaged fonts).
+In particular, new themes are highly unlikely to be accepted. Simple shell
+scripts are unlikly to be accepted unless they provide considerable value to a
+broad user base.  New fonts are welcome if they provide value beyond
+aesthetics (e.g. they contain glyphs for a script missing in already packaged
+fonts).
 
 Browser forks, including those based on Chromium and Firefox, are generally not
 accepted. Such forks require heavy patching, maintenance and hours of build time.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] Manual.md: relax and clarify the "no sripts" policy
  2020-10-18 14:24 [PR PATCH] Manual.md: relax and clarify the "no sripts" policy ahesford
@ 2020-10-18 14:33 ` sgn
  2020-10-18 14:35 ` [PR PATCH] [Updated] " ahesford
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2020-10-18 14:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/25707#discussion_r507170258

Comment:
s/unlikly/unlikely

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] Manual.md: relax and clarify the "no sripts" policy
  2020-10-18 14:24 [PR PATCH] Manual.md: relax and clarify the "no sripts" policy ahesford
  2020-10-18 14:33 ` [PR REVIEW] " sgn
@ 2020-10-18 14:35 ` ahesford
  2020-11-02 20:51 ` ahesford
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2020-10-18 14:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

There is an updated pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages manual
https://github.com/void-linux/void-packages/pull/25707

Manual.md: relax and clarify the "no sripts" policy
I think our "no scripts" policy is too strict and precludes the inclusion of useful administrative tools. These are helpful to have packaged because it makes deploying new Void systems easier by keeping tools in one place. Based on a discussion in #xbps, I propose the following relaxed language that still gives us a reasonable justification for rejecting apparently useless scripts while admitting some more useful ones.

A patch file from https://github.com/void-linux/void-packages/pull/25707.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-manual-25707.patch --]
[-- Type: text/x-diff, Size: 1269 bytes --]

From 653686e289283263c0a19561670bf0eaf501f3f0 Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Sun, 18 Oct 2020 10:22:39 -0400
Subject: [PATCH] Manual.md: relax and clarify the "no sripts" policy

---
 Manual.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Manual.md b/Manual.md
index 4af3a7b78d9..e14ef201d16 100644
--- a/Manual.md
+++ b/Manual.md
@@ -136,10 +136,10 @@ the Void packages system.
 1. Required: Another package either within the repository or pending inclusion
    requires the package.
 
-In particular, new themes and small shell scripts are highly unlikely
-to be accepted. New fonts are welcome if they provide value beyond
-aesthetics (e.g. they contain glyphs for a script missing in already
-packaged fonts).
+In particular, new themes are highly unlikely to be accepted. Simple shell
+scripts are unlikely to be accepted unless they provide considerable value to a
+broad user base. New fonts are welcome if they provide value beyond aesthetics
+(e.g. they contain glyphs for a script missing in already packaged fonts).
 
 Browser forks, including those based on Chromium and Firefox, are generally not
 accepted. Such forks require heavy patching, maintenance and hours of build time.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] Manual.md: relax and clarify the "no sripts" policy
  2020-10-18 14:24 [PR PATCH] Manual.md: relax and clarify the "no sripts" policy ahesford
  2020-10-18 14:33 ` [PR REVIEW] " sgn
  2020-10-18 14:35 ` [PR PATCH] [Updated] " ahesford
@ 2020-11-02 20:51 ` ahesford
  2020-11-03 18:18 ` [PR REVIEW] " the-maldridge
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2020-11-02 20:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

There is an updated pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages manual
https://github.com/void-linux/void-packages/pull/25707

Manual.md: relax and clarify the "no sripts" policy
I think our "no scripts" policy is too strict and precludes the inclusion of useful administrative tools. These are helpful to have packaged because it makes deploying new Void systems easier by keeping tools in one place. Based on a discussion in #xbps, I propose the following relaxed language that still gives us a reasonable justification for rejecting apparently useless scripts while admitting some more useful ones.

A patch file from https://github.com/void-linux/void-packages/pull/25707.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-manual-25707.patch --]
[-- Type: text/x-diff, Size: 1270 bytes --]

From 108e73ea3cf755187a7e40a0523471ca80970421 Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Sun, 18 Oct 2020 10:22:39 -0400
Subject: [PATCH] Manual.md: relax and clarify the "no scripts" policy

---
 Manual.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Manual.md b/Manual.md
index 5b1266ba715..bf7291d83fc 100644
--- a/Manual.md
+++ b/Manual.md
@@ -136,10 +136,10 @@ the Void packages system.
 1. Required: Another package either within the repository or pending inclusion
    requires the package.
 
-In particular, new themes and small shell scripts are highly unlikely
-to be accepted. New fonts are welcome if they provide value beyond
-aesthetics (e.g. they contain glyphs for a script missing in already
-packaged fonts).
+In particular, new themes are highly unlikely to be accepted. Simple shell
+scripts are unlikely to be accepted unless they provide considerable value to a
+broad user base. New fonts are welcome if they provide value beyond aesthetics
+(e.g. they contain glyphs for a script missing in already packaged fonts).
 
 Browser forks, including those based on Chromium and Firefox, are generally not
 accepted. Such forks require heavy patching, maintenance and hours of build time.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] Manual.md: relax and clarify the "no sripts" policy
  2020-10-18 14:24 [PR PATCH] Manual.md: relax and clarify the "no sripts" policy ahesford
                   ` (2 preceding siblings ...)
  2020-11-02 20:51 ` ahesford
@ 2020-11-03 18:18 ` the-maldridge
  2020-11-04  1:27 ` [PR PATCH] [Updated] " ahesford
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: the-maldridge @ 2020-11-03 18:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New review comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/25707#discussion_r516867257

Comment:
New fonts are not welcome, but might be accepted.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] Manual.md: relax and clarify the "no sripts" policy
  2020-10-18 14:24 [PR PATCH] Manual.md: relax and clarify the "no sripts" policy ahesford
                   ` (3 preceding siblings ...)
  2020-11-03 18:18 ` [PR REVIEW] " the-maldridge
@ 2020-11-04  1:27 ` ahesford
  2020-11-13 23:17 ` [PR PATCH] [Closed]: " ahesford
  2020-11-13 23:18 ` ahesford
  6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2020-11-04  1:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

There is an updated pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages manual
https://github.com/void-linux/void-packages/pull/25707

Manual.md: relax and clarify the "no sripts" policy
I think our "no scripts" policy is too strict and precludes the inclusion of useful administrative tools. These are helpful to have packaged because it makes deploying new Void systems easier by keeping tools in one place. Based on a discussion in #xbps, I propose the following relaxed language that still gives us a reasonable justification for rejecting apparently useless scripts while admitting some more useful ones.

A patch file from https://github.com/void-linux/void-packages/pull/25707.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-manual-25707.patch --]
[-- Type: text/x-diff, Size: 1276 bytes --]

From cfa45cb1baca79a93180607e26c36db246f3e75f Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Sun, 18 Oct 2020 10:22:39 -0400
Subject: [PATCH] Manual.md: relax and clarify the "no scripts" policy

---
 Manual.md | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Manual.md b/Manual.md
index 5b1266ba715..55b1ae9192f 100644
--- a/Manual.md
+++ b/Manual.md
@@ -136,10 +136,11 @@ the Void packages system.
 1. Required: Another package either within the repository or pending inclusion
    requires the package.
 
-In particular, new themes and small shell scripts are highly unlikely
-to be accepted. New fonts are welcome if they provide value beyond
-aesthetics (e.g. they contain glyphs for a script missing in already
-packaged fonts).
+In particular, new themes are highly unlikely to be accepted. Simple shell
+scripts are unlikely to be accepted unless they provide considerable value to a
+broad user base. New fonts may be accepted if they provide value beyond
+aesthetics (e.g. they contain glyphs for a script missing in already packaged
+fonts).
 
 Browser forks, including those based on Chromium and Firefox, are generally not
 accepted. Such forks require heavy patching, maintenance and hours of build time.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Closed]: Manual.md: relax and clarify the "no sripts" policy
  2020-10-18 14:24 [PR PATCH] Manual.md: relax and clarify the "no sripts" policy ahesford
                   ` (4 preceding siblings ...)
  2020-11-04  1:27 ` [PR PATCH] [Updated] " ahesford
@ 2020-11-13 23:17 ` ahesford
  2020-11-13 23:18 ` ahesford
  6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2020-11-13 23:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

There's a closed pull request on the void-packages repository

Manual.md: relax and clarify the "no sripts" policy
https://github.com/void-linux/void-packages/pull/25707

Description:
I think our "no scripts" policy is too strict and precludes the inclusion of useful administrative tools. These are helpful to have packaged because it makes deploying new Void systems easier by keeping tools in one place. Based on a discussion in #xbps, I propose the following relaxed language that still gives us a reasonable justification for rejecting apparently useless scripts while admitting some more useful ones.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Manual.md: relax and clarify the "no sripts" policy
  2020-10-18 14:24 [PR PATCH] Manual.md: relax and clarify the "no sripts" policy ahesford
                   ` (5 preceding siblings ...)
  2020-11-13 23:17 ` [PR PATCH] [Closed]: " ahesford
@ 2020-11-13 23:18 ` ahesford
  6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2020-11-13 23:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/25707#issuecomment-727080985

Comment:
I've seen no objections except for rewording suggestions that have been accommodated, so merging seems appropriate.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-11-13 23:18 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-18 14:24 [PR PATCH] Manual.md: relax and clarify the "no sripts" policy ahesford
2020-10-18 14:33 ` [PR REVIEW] " sgn
2020-10-18 14:35 ` [PR PATCH] [Updated] " ahesford
2020-11-02 20:51 ` ahesford
2020-11-03 18:18 ` [PR REVIEW] " the-maldridge
2020-11-04  1:27 ` [PR PATCH] [Updated] " ahesford
2020-11-13 23:17 ` [PR PATCH] [Closed]: " ahesford
2020-11-13 23:18 ` ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).