[PR PATCH] pipewire: update to 0.3.17

[PR PATCH] pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

There is a new pull request by st3r4g against master on the void-packages repository

https://github.com/st3r4g/void-packages pipewire-0.3.17
https://github.com/void-linux/void-packages/pull/26822

pipewire: update to 0.3.17
Basic instructions to have pipewire replace pulseaudio that worked on my system with this version:
https://gist.github.com/st3r4g/6c681a28b0403b3b02636f510ff68039

A patch file from https://github.com/void-linux/void-packages/pull/26822.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.17-26822.patch --]
[-- Type: text/x-diff, Size: 1149 bytes --]

From cc5b151a021674c39330e99f6c8e2757c2b64c37 Mon Sep 17 00:00:00 2001
From: Stefano Ragni <st3r4g@protonmail.com>
Date: Mon, 30 Nov 2020 10:40:34 +0100
Subject: [PATCH] pipewire: update to 0.3.17

---
 srcpkgs/pipewire/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 930e4b6a0af..375dd76b3df 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.12
+version=0.3.17
 revision=1
 build_style=meson
 configure_args="-Dman=true -Dgstreamer=true -Ddocs=true -Dsystemd=false
@@ -15,7 +15,7 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=98c71228aad2f8443e73a524106f32ca9a74e13c2bf55b65b1e06b72325892cd
+checksum=46d2f597506ef56b0be54498ab26b58bacdd7cae30f87f47836f1f717a0d05ac
 conf_files="/etc/pipewire/pipewire.conf"
 
 if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then

Re: pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-735756777

Comment:
Also, the alsa backend doesn't work atm because the config is installed in `/usr/share/alsa/alsa.conf.d` which is not included by void's `/usr/share/alsa/alsa.conf`. According to it, the configs should be in `/usr/etc/alsa/conf.d`.

Re: pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-735756777

Comment:
Also, the alsa backend doesn't work atm because the config is installed in `/usr/share/alsa/alsa.conf.d` which is not included by void's `/usr/share/alsa/alsa.conf`. According to it, the configs should be in `/usr/etc/alsa/conf.d`. I'm going to fix it.

Re: pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-735791105

Comment:
Hmm, actually I'm not sure how it should work. The package `alsa-plugins` is already shipping configs in `/usr/share/alsa/alsa.conf.d`. Maybe one is supposed to manually enable them via a symlink in `/etc/alsa/conf.d`?

Pipewire ships two configs: one to create the alsa device, and the other to make it the default. Imo automatically enabling both by installing `alsa-pipewire` is the simplest thing.

Re: pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-735756777

Comment:
Also, the alsa integration doesn't work atm because the config is installed in `/usr/share/alsa/alsa.conf.d` which is not included by void's `/usr/share/alsa/alsa.conf`. According to it, the configs should be in `/usr/etc/alsa/conf.d`. I'm going to fix it.

Re: [PR PATCH] [Updated] pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

There is an updated pull request by st3r4g against master on the void-packages repository

https://github.com/st3r4g/void-packages pipewire-0.3.17
https://github.com/void-linux/void-packages/pull/26822

pipewire: update to 0.3.17
Basic instructions to have pipewire replace pulseaudio that worked on my system with this version:
https://gist.github.com/st3r4g/6c681a28b0403b3b02636f510ff68039

A patch file from https://github.com/void-linux/void-packages/pull/26822.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.17-26822.patch --]
[-- Type: text/x-diff, Size: 1680 bytes --]

From 1511c7c3d329f69beded274fc67f09ca715ab969 Mon Sep 17 00:00:00 2001
From: Stefano Ragni <st3r4g@protonmail.com>
Date: Mon, 30 Nov 2020 10:40:34 +0100
Subject: [PATCH] pipewire: update to 0.3.17

Also move the alsa-pipewire configs to be picked up by alsa.conf
---
 srcpkgs/pipewire/template | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 930e4b6a0af..d3fcaad9622 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.12
+version=0.3.17
 revision=1
 build_style=meson
 configure_args="-Dman=true -Dgstreamer=true -Ddocs=true -Dsystemd=false
@@ -15,7 +15,7 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=98c71228aad2f8443e73a524106f32ca9a74e13c2bf55b65b1e06b72325892cd
+checksum=46d2f597506ef56b0be54498ab26b58bacdd7cae30f87f47836f1f717a0d05ac
 conf_files="/etc/pipewire/pipewire.conf"
 
 if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
@@ -24,6 +24,11 @@ if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
 fi
 
 post_install() {
+	# alsa.conf scans /usr/etc/alsa/conf.d
+	mkdir -p ${DESTDIR}/usr/etc/alsa
+	mv ${DESTDIR}/usr/share/alsa/alsa.conf.d ${DESTDIR}/usr/etc/alsa/conf.d
+	rm -d ${DESTDIR}/usr/share/alsa
+
 	vlicense LICENSE
 }
 
@@ -138,6 +143,7 @@ alsa-pipewire_package() {
 	short_desc+=" - ALSA client library"
 	pkg_install() {
 		vmove usr/lib/alsa-lib
+		vmove usr/etc/alsa/conf.d
 	}
 }
 

Re: [PR REVIEW] pipewire: update to 0.3.17

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#discussion_r532665440

Comment:
I don't think it is appropriate to install these in `/usr/etc/alsa` by default. There is a legitimate interest in installing this package without forcing the default behavior or the specific device configuration that is included. Let people make symlinks in `/etc/alsa/conf.d` to the contents of `/usr/share/alsa/alsa.conf.d` if they wish to enable these defaults.

Re: [PR REVIEW] pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#discussion_r532693871

Comment:
Ok, I'll revert. But then we need to mention this in our docs I think, because upstream doesn't say anything about it (see https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/README.md#running-alsa-applications). That's why I thought it should have worked ootb.

Re: [PR REVIEW] pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#discussion_r532693871

Comment:
Ok, I'll revert. But then we'll need to mention this in our docs I think, because upstream doesn't say anything about it (see https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/README.md#running-alsa-applications). That's why I thought it should have worked ootb.

Re: [PR REVIEW] pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#discussion_r532693871

Comment:
Ok, I'll revert. But then we'll need to mention this in our docs I think, because upstream doesn't say anything about it (see https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/README.md#running-alsa-applications). That's why I thought it should have worked ootb (after installing `alsa-pipewire` of course).

Re: [PR PATCH] [Updated] pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

There is an updated pull request by st3r4g against master on the void-packages repository

https://github.com/st3r4g/void-packages pipewire-0.3.17
https://github.com/void-linux/void-packages/pull/26822

pipewire: update to 0.3.17
Basic instructions to have pipewire replace pulseaudio that worked on my system with this version:
https://gist.github.com/st3r4g/6c681a28b0403b3b02636f510ff68039

A patch file from https://github.com/void-linux/void-packages/pull/26822.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.17-26822.patch --]
[-- Type: text/x-diff, Size: 1659 bytes --]

From ec6a581b70778403eb8ce96c26b62dc319c4990c Mon Sep 17 00:00:00 2001
From: Stefano Ragni <st3r4g@protonmail.com>
Date: Mon, 30 Nov 2020 10:40:34 +0100
Subject: [PATCH] pipewire: update to 0.3.17

Also move the alsa configs to alsa-pipewire
---
 srcpkgs/pipewire/template | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 930e4b6a0af..d3fcaad9622 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.12
+version=0.3.17
 revision=1
 build_style=meson
 configure_args="-Dman=true -Dgstreamer=true -Ddocs=true -Dsystemd=false
@@ -15,7 +15,7 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=98c71228aad2f8443e73a524106f32ca9a74e13c2bf55b65b1e06b72325892cd
+checksum=46d2f597506ef56b0be54498ab26b58bacdd7cae30f87f47836f1f717a0d05ac
 conf_files="/etc/pipewire/pipewire.conf"
 
 if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
@@ -24,6 +24,11 @@ if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
 fi
 
 post_install() {
+	# alsa.conf scans /usr/etc/alsa/conf.d
+	mkdir -p ${DESTDIR}/usr/etc/alsa
+	mv ${DESTDIR}/usr/share/alsa/alsa.conf.d ${DESTDIR}/usr/etc/alsa/conf.d
+	rm -d ${DESTDIR}/usr/share/alsa
+
 	vlicense LICENSE
 }
 
@@ -138,6 +143,7 @@ alsa-pipewire_package() {
 	short_desc+=" - ALSA client library"
 	pkg_install() {
 		vmove usr/lib/alsa-lib
+		vmove usr/etc/alsa/conf.d
 	}
 }
 

Re: [PR PATCH] [Updated] pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

There is an updated pull request by st3r4g against master on the void-packages repository

https://github.com/st3r4g/void-packages pipewire-0.3.17
https://github.com/void-linux/void-packages/pull/26822

pipewire: update to 0.3.17
Basic instructions to have pipewire replace pulseaudio that worked on my system with this version:
https://gist.github.com/st3r4g/6c681a28b0403b3b02636f510ff68039

A patch file from https://github.com/void-linux/void-packages/pull/26822.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.17-26822.patch --]
[-- Type: text/x-diff, Size: 1368 bytes --]

From 65fe9d0951fe1899bf8990d30f2a7a7b3b1ca15a Mon Sep 17 00:00:00 2001
From: Stefano Ragni <st3r4g@protonmail.com>
Date: Mon, 30 Nov 2020 10:40:34 +0100
Subject: [PATCH] pipewire: update to 0.3.17

Also move the alsa configs to alsa-pipewire
---
 srcpkgs/pipewire/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 930e4b6a0af..0469af7990e 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.12
+version=0.3.17
 revision=1
 build_style=meson
 configure_args="-Dman=true -Dgstreamer=true -Ddocs=true -Dsystemd=false
@@ -15,7 +15,7 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=98c71228aad2f8443e73a524106f32ca9a74e13c2bf55b65b1e06b72325892cd
+checksum=46d2f597506ef56b0be54498ab26b58bacdd7cae30f87f47836f1f717a0d05ac
 conf_files="/etc/pipewire/pipewire.conf"
 
 if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
@@ -138,6 +138,7 @@ alsa-pipewire_package() {
 	short_desc+=" - ALSA client library"
 	pkg_install() {
 		vmove usr/lib/alsa-lib
+		vmove usr/share/alsa/alsa.conf.d
 	}
 }
 

Re: pipewire: update to 0.3.17

[Javyre]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

New comment by Javyre on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-735885283

Comment:
Hey, I just tried out your template and was able to fully replace pulse!
Is pipewire supposed to be run as root? the only way I got it to work was running it as user, but when I do, I get `[W][001073505.341392][module-rtkit.c:502 idle_func()] could not make thread realtime: Permission denied` which seems to be important although non-fatal/

Re: pipewire: update to 0.3.17

[Javyre]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

New comment by Javyre on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-735885283

Comment:
Hey, I just tried out your template and was able to fully replace pulse!
Is pipewire supposed to be run as root? the only way I got it to work was running it as user, but when I do, I get `[W][001073505.341392][module-rtkit.c:502 idle_func()] could not make thread realtime: Permission denied` which seems to be important although non-fatal.

Re: [PR REVIEW] pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#discussion_r532723185

Comment:
nevermind, it is mentioned here: https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/INSTALL.md#alsa-plugin

Re: [PR REVIEW] pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#discussion_r532723929

Comment:
but distros (e.g. fedora) seem to ship the symlinks

Re: pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-735892258

Comment:
> Is pipewire supposed to be run as root?

No, as user.

> but when I do, I get `[W][001073505.341392][module-rtkit.c:502 idle_func()] could not make thread realtime: Permission denied` which seems to be important although non-fatal.

I haven't looked into that yet.

Re: pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-735892258

Comment:
> Is pipewire supposed to be run as root?

No, as user.

> but when I do, I get `[W][001073505.341392][module-rtkit.c:502 idle_func()] could not make thread realtime: Permission denied` which seems to be important although non-fatal.

I haven't looked into it yet.

Re: [PR REVIEW] pipewire: update to 0.3.17

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#discussion_r532740331

Comment:
Could INSTALLmd be `vdoc`'d?

@ahesford in what situation do you think one would one install `alsa-pipewire` and not want it to be on by default?

Re: pipewire: update to 0.3.17

[Javyre]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

New comment by Javyre on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-735905379

Comment:
I feel like it would be useful to have a runit service defined for pipewire.
Apparently the system daemon it generates [just runs it as user `pipewire`](https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/src/daemon/systemd/system/pipewire.service.in).

Re: [PR REVIEW] pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#discussion_r532758409

Comment:
it doesn't make sense to vdoc INSTALL.md imo, there's a lot of irrelevant info

Re: pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-735892258

Comment:
> Is pipewire supposed to be run as root?

No, as user.

> but when I do, I get `[W][001073505.341392][module-rtkit.c:502 idle_func()] could not make thread realtime: Permission denied` which seems to be important although non-fatal.

I haven't looked into it yet. EDIT: you have to install `rtkit`.

Re: [PR REVIEW] pipewire: update to 0.3.17

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#discussion_r533626461

Comment:
Because ALSA can be configured per-user and pipewire is designed to be run per-user, I can imagine situations where the package is installed to provide users with alsa emulation for pipewire *if they want it*, but not all users will want it.

This is probably more true on Void than other systems because launching the per-user daemon requires explicit construction of a per-user service management system. On systems like Fedora that use systemd, per-user services are possible by default.

If there is a consensus that the convenience of automatically enabling these options outweighs these concerns, then at least leave them in `/usr/share` and make symlinks in `/usr/etc`, so they can be disabled without destroying the contents.

Re: [PR REVIEW] pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#discussion_r533645456

Comment:
I don't want to block the update on this decision. We can think about adding the symlinks later.

Re: [PR REVIEW] pipewire: update to 0.3.17

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#discussion_r533658192

Comment:
Fair enough.

Re: [PR PATCH] [Merged]: pipewire: update to 0.3.17

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

There's a merged pull request on the void-packages repository

pipewire: update to 0.3.17
https://github.com/void-linux/void-packages/pull/26822

Description:
Basic instructions to have pipewire replace pulseaudio that worked on my system with this version:
https://gist.github.com/st3r4g/6c681a28b0403b3b02636f510ff68039

Re: pipewire: update to 0.3.17

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-736807074

Comment:
Whether or not some of these `libspa` packages are combined or rearranged in the future, it would be nice to come up with a sane set of dependencies so that pipewire is basically functional without requiring a bunch of non-obvious `libspa` dependencies be manually installed.

Re: pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-736808886

Comment:
yeah, exactly. I'm trying to determine a sane subset that should be installed by default.

Re: pipewire: update to 0.3.17

[gspe]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by gspe on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-737468999

Comment:
@ahesford can I propose this sub-package reorganization? https://github.com/gspe/void-packages/blob/pipewire/srcpkgs/pipewire/template

Re: pipewire: update to 0.3.17

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-737663357

Comment:
@gspe I don't really have an opinion on the right packages structure because I don't use pipewire. However, I will note that your `pipewire-jack-dropin` is only suitable for glibc because musl does not look to `/etc/ld.so.conf.d` for linker path configuration.

Re: pipewire: update to 0.3.17

[sirn]

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

New comment by sirn on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-738747692

Comment:
`libspa` is a module that can be turned on and off, e.g. ffmpeg for transcoding the stream, bluez for connecting to bluetooth audio, etc. so it was separated to make sure apps that only use pipewire for screen sharing didn't pull in everything else (pipewire were primarily used for screen sharing in e.g. Chrome/Flatpak/Gnome, and only gained audio support in 0.3) so I don't think merging all sub packages in is a good idea.

IIRC these are libspa that are required to get audio working. Would you think it might makes sense to add these to default dependencies?

* libspa-alsa
* libspa-audioconvert
* libspa-audiomixer
* libspa-control

Also might worth deprecating libpulseaudio-pipewire too since pipewire has since deprecated replacing libpulse and instead implementing the pulseaudio protocol via protocol-pulse

Re: pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 712 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-738761378

Comment:
> IIRC these are libspa that are required to get audio working

I'm curious about `libspa-control`, do you know what it does? I didn't notice any difference without it. But the name kinda suggests it is important.

> Also might worth deprecating libpulseaudio-pipewire too since pipewire has since deprecated replacing libpulse and instead implementing the pulseaudio protocol via protocol-pulse
Yes, on the next update we should remove the `-Dpipewire-pulseaudio=true` option (now defaults to false) and make the `libpulseaudio-pipewire` subpkg an empty metapackage.

Re: pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-738761378

Comment:
> IIRC these are libspa that are required to get audio working

I'm curious about `libspa-control`, do you know what it does? I didn't notice any difference without it. But the name kinda suggests it is important.

> Also might worth deprecating libpulseaudio-pipewire too since pipewire has since deprecated replacing libpulse and instead implementing the pulseaudio protocol via protocol-pulse

Yes, on the next update we should remove the `-Dpipewire-pulseaudio=true` option (now defaults to false) and make the `libpulseaudio-pipewire` subpkg an empty metapackage.

Re: pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-738761378

Comment:
> so it was separated to make sure apps that only use pipewire for screen sharing didn't pull in everything else (pipewire were primarily used for screen sharing in e.g. Chrome/Flatpak/Gnome, and only gained audio support in 0.3)

I think just `libpipewire` is needed for that though.

> IIRC these are libspa that are required to get audio working

I'm curious about `libspa-control`, do you know what it does? I didn't notice any difference without it. But the name kinda suggests it is important.

> Also might worth deprecating libpulseaudio-pipewire too since pipewire has since deprecated replacing libpulse and instead implementing the pulseaudio protocol via protocol-pulse

Yes, on the next update we should remove the `-Dpipewire-pulseaudio=true` option (now defaults to false) and make the `libpulseaudio-pipewire` subpkg an empty metapackage.

Re: pipewire: update to 0.3.17

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-738761378

Comment:
> so it was separated to make sure apps that only use pipewire for screen sharing didn't pull in everything else (pipewire were primarily used for screen sharing in e.g. Chrome/Flatpak/Gnome, and only gained audio support in 0.3)

I think just `libpipewire` is needed for that though. The spa plugins would go inside `pipewire` instead. Imho it's a bit confusing that some of these plugins are fundamental and others not.

> IIRC these are libspa that are required to get audio working

I'm curious about `libspa-control`, do you know what it does? I didn't notice any difference without it. But the name kinda suggests it is important.

> Also might worth deprecating libpulseaudio-pipewire too since pipewire has since deprecated replacing libpulse and instead implementing the pulseaudio protocol via protocol-pulse

Yes, on the next update we should remove the `-Dpipewire-pulseaudio=true` option (now defaults to false) and make the `libpulseaudio-pipewire` subpkg an empty metapackage.

Re: pipewire: update to 0.3.17

[sirn]

[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]

New comment by sirn on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-738779151

Comment:
> I think just `libpipewire` is needed for that though. The spa plugins would go inside `pipewire` instead. Imho it's a bit confusing that some of these plugins are fundamental and others not.

You're right. I think it was this way due to transitional reasons (during 0.2 to 0.3) 

> I'm curious about `libspa-control`, do you know what it does? I didn't notice any difference without it. But the name kinda suggests it is important.

I believe it provides mixer control, e.g. negotiating format and buffers size between components. Might not needed for pulseaudio protocol to work, but needed when doing some processing with SPAs (I believe).
 
> Yes, on the next update we should remove the `-Dpipewire-pulseaudio=true` option (now defaults to false) and make the `libpulseaudio-pipewire` subpkg an empty metapackage.

Yup! Quoting changelog:

>  - Many pulse-server improvements. There is now a pipewire-pulse binary that is the prefered solution for PulseAudio compatibility. The replacement libpulse libraries are now deprecated. This also makes audio in Flatpak work.

so we should be safe to deprecate libpulseaudio-pipewire in Void as well (@ahesford what do you think?)

Re: pipewire: update to 0.3.17

[gspe]

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

New comment by gspe on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-738817568

Comment:
Pipewire now is intended as replacement of both pulseaudio and jack (https://fedoraproject.org/wiki/Changes/DefaultPipeWire), so user need all libspa plugings to have a fully functional software.
I've just looked at how fedora package pipewire: https://pkgs.org/download/pipewire and adapted my version of the template: https://github.com/gspe/void-packages/blob/pipewire/srcpkgs/pipewire/template.

The only thing missed is that both pipewire and pipewire-pulse server need to be run as user service, and this with runit is not that simple to have

Re: pipewire: update to 0.3.17

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 2203 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/26822#issuecomment-738837331

Comment:
> The only thing missed is that both pipewire and pipewire-pulse server need to be run as user service, and this with runit is not that simple to have

@gspe The `pipewire-jack-plugin` is still unsuitable. First, `conflicts` are inappropriate in your proposal because there are no inherent conflicts with `jack`. Second, `ld.so.conf.d` is not recognized by musl, so this misses half of the archs supported by Void. (While musl does allow custom linker search paths, it does so through a file and isn't really compatible with packaging.) The right way to do this is probably declaring an actual conflict with `jack` (or, more likely, `libjack`) and installing the compatibility library or a symlink where `libjack` puts it. This would also require a `provides` mechanism so that XBPS won't attempt to force `libjack` to be installed when the pipewire conflict is currently installed.

Coalescing the `libspa*` packages is fine as long as the grouping makes sense. To the extent that these plugins are truly optional, they should remain separate to allow users to omit those pieces when desired. The "core" plugins can still be rolled into `libpipewire`, or else `libpipewire` can depend on the core `libspa*` packages if there is an argument for greater control (this allows users to `ignorepkg` to exclude some of the core packages if they really want, which is a better mechanism than `noextract`, which would be necessary to exclude plugins in the `libpipewire` package). Note that `libpipewire` should declare `replaces` for every `libspa*` package it assimilates, or else XBPS will not be able to manage a smooth transition.

The need for per-user runs is not a problem that Void attempts to solve, nor should it. There are many ways that users can ensure the server is launched when they need it, including our recommended [per-user service mechanism](https://docs.voidlinux.org/config/services/user-services.html) or launching from some X or Wayland startup script. When users adopt Void, they assume responsibility for solving this kind of problem.