* [PR PATCH] No need to specify /dev/random
@ 2020-12-05 13:14 firasuke
2020-12-05 19:44 ` [PR REVIEW] " ericonr
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: firasuke @ 2020-12-05 13:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 343 bytes --]
There is a new pull request by firasuke against master on the void-packages repository
https://github.com/firasuke/void-packages patch-1
https://github.com/void-linux/void-packages/pull/26961
No need to specify /dev/random
/dev/random is the default
A patch file from https://github.com/void-linux/void-packages/pull/26961.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-26961.patch --]
[-- Type: text/x-diff, Size: 813 bytes --]
From ee0e452655c410a4fae7e184ea5c8d6cd32c044a Mon Sep 17 00:00:00 2001
From: Firas Khalil Khana <firasuke@gmail.com>
Date: Sat, 5 Dec 2020 15:14:27 +0200
Subject: [PATCH] No need to specify /dev/random
/dev/random is the default
---
srcpkgs/dhcp/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/dhcp/template b/srcpkgs/dhcp/template
index 47fa43fb02e..6f44077c1dc 100644
--- a/srcpkgs/dhcp/template
+++ b/srcpkgs/dhcp/template
@@ -35,7 +35,7 @@ pre_configure() {
--with-srv6-lease-file=/var/lib/dhcp/dhcpd6.leases
--with-cli-lease-file=/var/lib/dhclient/dhclient.leases
--with-cli6-lease-file=/var/lib/dhclient/dhclient6.leases
- --with-randomdev=/dev/random"
+ --with-randomdev"
local cargs="$(echo $configure_args | tr '\n' ' ')"
# set real configure_args
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] No need to specify /dev/random
2020-12-05 13:14 [PR PATCH] No need to specify /dev/random firasuke
@ 2020-12-05 19:44 ` ericonr
2020-12-06 22:18 ` [PR REVIEW] dhcp: " firasuke
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-12-05 19:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 254 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26961#discussion_r536880341
Comment:
I'm not sure what this gets us. Would it be a guarantee so an upstream change to `randomdev` is propagated?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] dhcp: No need to specify /dev/random
2020-12-05 13:14 [PR PATCH] No need to specify /dev/random firasuke
2020-12-05 19:44 ` [PR REVIEW] " ericonr
@ 2020-12-06 22:18 ` firasuke
2020-12-06 22:56 ` Duncaen
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: firasuke @ 2020-12-06 22:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
New review comment by firasuke on void-packages repository
https://github.com/void-linux/void-packages/pull/26961#discussion_r537136305
Comment:
> Please follow the commit style: `dhcp: ....`
Done
> I'm not sure what this gets us. Would it be a guarantee so an upstream change to randomdev is propagated?
A tiny bit cleaner template file, and of course it doesn't guarantee what upstream does or doesn't do, but it's unlikely that the default value will change anytime soon (a better value would be `/dev/urandom` but then again we're not debating that).
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: dhcp: No need to specify /dev/random
2020-12-05 13:14 [PR PATCH] No need to specify /dev/random firasuke
2020-12-05 19:44 ` [PR REVIEW] " ericonr
2020-12-06 22:18 ` [PR REVIEW] dhcp: " firasuke
@ 2020-12-06 22:56 ` Duncaen
2020-12-06 22:56 ` Duncaen
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Duncaen @ 2020-12-06 22:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/26961#issuecomment-739579295
Comment:
Yea not sure if this change is worth it at all, the back and forth about the commit message etc. it really doesn't matter.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: dhcp: No need to specify /dev/random
2020-12-05 13:14 [PR PATCH] No need to specify /dev/random firasuke
` (2 preceding siblings ...)
2020-12-06 22:56 ` Duncaen
@ 2020-12-06 22:56 ` Duncaen
2020-12-07 17:59 ` firasuke
2020-12-07 17:59 ` [PR PATCH] [Closed]: " firasuke
5 siblings, 0 replies; 7+ messages in thread
From: Duncaen @ 2020-12-06 22:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/26961#issuecomment-739579295
Comment:
Yea not sure if this change is worth it at all, the back and forth about the commit message etc. (you changed the PR title, not the commit message) it really doesn't matter.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: dhcp: No need to specify /dev/random
2020-12-05 13:14 [PR PATCH] No need to specify /dev/random firasuke
` (3 preceding siblings ...)
2020-12-06 22:56 ` Duncaen
@ 2020-12-07 17:59 ` firasuke
2020-12-07 17:59 ` [PR PATCH] [Closed]: " firasuke
5 siblings, 0 replies; 7+ messages in thread
From: firasuke @ 2020-12-07 17:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 164 bytes --]
New comment by firasuke on void-packages repository
https://github.com/void-linux/void-packages/pull/26961#issuecomment-740081389
Comment:
Alright then, closing.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Closed]: dhcp: No need to specify /dev/random
2020-12-05 13:14 [PR PATCH] No need to specify /dev/random firasuke
` (4 preceding siblings ...)
2020-12-07 17:59 ` firasuke
@ 2020-12-07 17:59 ` firasuke
5 siblings, 0 replies; 7+ messages in thread
From: firasuke @ 2020-12-07 17:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
There's a closed pull request on the void-packages repository
dhcp: No need to specify /dev/random
https://github.com/void-linux/void-packages/pull/26961
Description:
/dev/random is the default
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-12-07 17:59 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-05 13:14 [PR PATCH] No need to specify /dev/random firasuke
2020-12-05 19:44 ` [PR REVIEW] " ericonr
2020-12-06 22:18 ` [PR REVIEW] dhcp: " firasuke
2020-12-06 22:56 ` Duncaen
2020-12-06 22:56 ` Duncaen
2020-12-07 17:59 ` firasuke
2020-12-07 17:59 ` [PR PATCH] [Closed]: " firasuke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).