[PR PATCH] gettext-devel: depends on tar

[PR PATCH] gettext-devel: depends on tar

[sgn]

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages gettext-devel-depends-on-tar
https://github.com/void-linux/void-packages/pull/27176

gettext-devel: depends on tar
/usr/bin/autopoint: line 497: tar: command not found

A patch file from https://github.com/void-linux/void-packages/pull/27176.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gettext-devel-depends-on-tar-27176.patch --]
[-- Type: text/x-diff, Size: 1105 bytes --]

From d54b7b6a8b067dd6208f7b655fba08f6d197be81 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Tue, 15 Dec 2020 16:20:17 +0700
Subject: [PATCH] gettext-devel: depends on tar

/usr/bin/autopoint: line 497: tar: command not found
---
 srcpkgs/gettext/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gettext/template b/srcpkgs/gettext/template
index 4e0667c1b8c..2acf96c95f8 100644
--- a/srcpkgs/gettext/template
+++ b/srcpkgs/gettext/template
@@ -1,7 +1,7 @@
 # Template file for 'gettext'
 pkgname=gettext
 version=0.21
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--disable-java --disable-native-java --disable-csharp
  --disable-libasprintf --enable-threads=posix --disable-rpath --without-emacs
@@ -45,7 +45,7 @@ gettext-devel-examples_package() {
 	}
 }
 gettext-devel_package() {
-	depends="gettext-libs>=${version}_${revision} xz"
+	depends="gettext-libs>=${version}_${revision} xz tar"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include

Re: gettext-devel: depends on tar

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27176#issuecomment-747610303

Comment:
Do you know in which situations it does? I haven't had issues with packages that use autopoint... Maybe it's required for generating a final tarball only?

Re: [PR PATCH] [Closed]: gettext-devel: depends on tar

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

There's a closed pull request on the void-packages repository

gettext-devel: depends on tar
https://github.com/void-linux/void-packages/pull/27176

Description:
/usr/bin/autopoint: line 497: tar: command not found

Re: gettext-devel: depends on tar

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27176#issuecomment-747610303

Comment:
Do you know in which situations it does? I haven't had issues with packages that use autopoint... Maybe it's required for generating a final tarball only?

(Fat finger, sorry)

Re: gettext-devel: depends on tar

[sgn]

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/27176#issuecomment-747770691

Comment:
> Do you know in which situations it does? I haven't had issues with packages that use autopoint... Maybe it's required for generating a final tarball only?
> 
> (Fat finger, sorry)

Look at the line 497, I think the answer is always. And it also needs `bzip2`

Re: [PR PATCH] [Updated] gettext-devel: depends on tar

[sgn]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages gettext-devel-depends-on-tar
https://github.com/void-linux/void-packages/pull/27176

gettext-devel: depends on tar
/usr/bin/autopoint: line 497: tar: command not found

A patch file from https://github.com/void-linux/void-packages/pull/27176.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gettext-devel-depends-on-tar-27176.patch --]
[-- Type: text/x-diff, Size: 1915 bytes --]

From 7474b8feaa90ab2c6c60dfd1f00e24f4cd7468a4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Tue, 15 Dec 2020 16:20:17 +0700
Subject: [PATCH] gettext-devel: depends on tar

/usr/bin/autopoint: line 497: tar: command not found
---
 srcpkgs/gettext/template | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/gettext/template b/srcpkgs/gettext/template
index 4e0667c1b8c..06079609ba0 100644
--- a/srcpkgs/gettext/template
+++ b/srcpkgs/gettext/template
@@ -1,7 +1,7 @@
 # Template file for 'gettext'
 pkgname=gettext
 version=0.21
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--disable-java --disable-native-java --disable-csharp
  --disable-libasprintf --enable-threads=posix --disable-rpath --without-emacs
@@ -9,6 +9,12 @@ configure_args="--disable-java --disable-native-java --disable-csharp
  --with-included-libxml --with-included-libunistring --disable-openmp
  --disable-curses --without-examples --enable-nls
  gl_cv_func_gettimeofday_clobber=no"
+# gettext will try to use xz bzip2 gzip to compress
+# /usr/share/gettext/archive.dir.tar.<ext>
+# Either:
+# - Have xz in hostmakedepends; or
+# - Let gettext-devel depends on bzip2
+hostmakedepends="xz"
 short_desc="Internationalized Message Handling Library and tools"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-3.0-or-later"
@@ -23,7 +29,7 @@ case "$XBPS_TARGET_MACHINE" in
 esac
 
 if [ "$CROSS_BUILD" ]; then
-	hostmakedepends="automake libtool"
+	hostmakedepends+=" automake libtool"
 	pre_configure() {
 		autoreconf -fi
 	}
@@ -45,7 +51,7 @@ gettext-devel-examples_package() {
 	}
 }
 gettext-devel_package() {
-	depends="gettext-libs>=${version}_${revision} xz"
+	depends="gettext-libs>=${version}_${revision} xz tar"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include

Re: [PR PATCH] [Merged]: gettext-devel: depends on tar

[sgn]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

There's a merged pull request on the void-packages repository

gettext-devel: depends on tar
https://github.com/void-linux/void-packages/pull/27176

Description:
/usr/bin/autopoint: line 497: tar: command not found