[PR PATCH] New package: jump-0.30.1

[PR PATCH] New package: jump-0.30.1

[aweagel]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

There is a new pull request by aweagel against master on the void-packages repository

https://github.com/aweagel/void-packages aweagel/new-pkg-jump
https://github.com/void-linux/void-packages/pull/27245

New package: jump-0.30.1


A patch file from https://github.com/void-linux/void-packages/pull/27245.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aweagel/new-pkg-jump-27245.patch --]
[-- Type: text/x-diff, Size: 1224 bytes --]

From 2169bcc996ad1601047dc7c71dd40d24be975e21 Mon Sep 17 00:00:00 2001
From: Arthur Weagel <aweagel@users.noreply.github.com>
Date: Thu, 17 Dec 2020 17:00:18 -0700
Subject: [PATCH] New package: jump-0.30.1

---
 srcpkgs/jump/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/jump/template

diff --git a/srcpkgs/jump/template b/srcpkgs/jump/template
new file mode 100644
index 00000000000..4d0e4a2b128
--- /dev/null
+++ b/srcpkgs/jump/template
@@ -0,0 +1,25 @@
+# Template file for 'jump'
+pkgname=jump
+version=0.30.1
+revision=1
+build_style=go
+go_import_path=github.com/gsamokovarov/jump
+go_package=github.com/gsamokovarov/jump/cmd/jump
+hostmakedepends="git"
+short_desc="Fuzzy directory jumper that learns your habits"
+maintainer="Arthur Weagel <arthur.contrib@gmail.com>"
+license="MIT"
+homepage="https://github.com/gsamokovarov/jump"
+changelog="https://github.com/gsamokovarov/jump/releases"
+distfiles="https://github.com/gsamokovarov/jump/archive/v${version}.tar.gz"
+checksum=76d6453246c047b49e669499dc1b6a7e4c4520653627461d84ad40c6afb45562
+
+post_install() {
+	vlicense LICENSE.txt
+	vdoc README.md
+
+	make man
+	for m in man/*.1; do
+		vman $m
+	done
+}

Re: New package: jump-0.30.1

[aweagel]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

New comment by aweagel on void-packages repository

https://github.com/void-linux/void-packages/pull/27245#issuecomment-748078540

Comment:
Given that I am relatively new to Void (and golang packaging) this PR should be viewed as more of a feature request than anything.

Just a happy `jump` user hoping to get the package included in the official repos :)

That said, perhaps someone who has more experience with `build_style=go` can help me with this one? Maybe @Vaelatern @the-maldridge or @thypon?

Re: New package: jump-0.30.1

[aweagel]

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]

New comment by aweagel on void-packages repository

https://github.com/void-linux/void-packages/pull/27245#issuecomment-748078540

Comment:
Given that I am relatively new to Void (and golang packaging) this PR should be viewed as more of a feature request than anything.

Just a happy `jump` user hoping to get the package included in the official repos :)

That said, perhaps someone who has more experience with `build_style=go` can help me with this one? Maybe @Vaelatern @the-maldridge or @thypon?

Here are some equivalent package definitions from other repos for reference:

- AUR package: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=jump
- Nix package: https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/system/jump/default.nix
- Homebrew package: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/jump.rb

Re: [PR REVIEW] New package: jump-0.30.1

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/27245#discussion_r545977875

Comment:
Ideally something plaintext

Re: [PR REVIEW] New package: jump-0.30.1

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New review comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/27245#discussion_r545980220

Comment:
Perhaps part of the problem is this doesn't exist.

Try removing go_package and see what happens?

Re: [PR PATCH] [Updated] New package: jump-0.30.1

[aweagel]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

There is an updated pull request by aweagel against master on the void-packages repository

https://github.com/aweagel/void-packages aweagel/new-pkg-jump
https://github.com/void-linux/void-packages/pull/27245

New package: jump-0.30.1


A patch file from https://github.com/void-linux/void-packages/pull/27245.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aweagel/new-pkg-jump-27245.patch --]
[-- Type: text/x-diff, Size: 1161 bytes --]

From 36f8485c62f5916b7fcde6c1966f84d13a5fcf7e Mon Sep 17 00:00:00 2001
From: Arthur Weagel <aweagel@users.noreply.github.com>
Date: Thu, 17 Dec 2020 17:00:18 -0700
Subject: [PATCH] New package: jump-0.30.1

---
 srcpkgs/jump/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/jump/template

diff --git a/srcpkgs/jump/template b/srcpkgs/jump/template
new file mode 100644
index 00000000000..1995b839290
--- /dev/null
+++ b/srcpkgs/jump/template
@@ -0,0 +1,23 @@
+# Template file for 'jump'
+pkgname=jump
+version=0.30.1
+revision=1
+build_style=go
+go_import_path=github.com/gsamokovarov/jump
+hostmakedepends="git"
+short_desc="Fuzzy directory jumper that learns your habits"
+maintainer="Arthur Weagel <arthur.contrib@gmail.com>"
+license="MIT"
+homepage="https://github.com/gsamokovarov/jump"
+changelog="https://github.com/gsamokovarov/jump/releases"
+distfiles="https://github.com/gsamokovarov/jump/archive/v${version}.tar.gz"
+checksum=76d6453246c047b49e669499dc1b6a7e4c4520653627461d84ad40c6afb45562
+
+post_install() {
+	vlicense LICENSE.txt
+	vdoc README.md
+
+	for m in man/*.1; do
+		vman $m
+	done
+}

Re: [PR REVIEW] New package: jump-0.30.1

[aweagel]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

New review comment by aweagel on void-packages repository

https://github.com/void-linux/void-packages/pull/27245#discussion_r546163258

Comment:
There is no `CHANGELOG` file, so this is the closest option I'm aware of (the author does provide some notes with each release). There's also the [atom feed version](https://github.com/gsamokovarov/jump/releases.atom) for the releases page if that's preferable.

Re: [PR REVIEW] New package: jump-0.30.1

[aweagel]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by aweagel on void-packages repository

https://github.com/void-linux/void-packages/pull/27245#discussion_r546163448

Comment:
@Vaelatern That did the trick! I've marked this PR as ready for review.

Re: [PR REVIEW] New package: jump-0.30.1

[aweagel]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

New review comment by aweagel on void-packages repository

https://github.com/void-linux/void-packages/pull/27245#discussion_r546163258

Comment:
There is no `CHANGELOG` file, so this is the closest option I'm aware of (the author does provide some notes with each release on this page).

There's also the [atom feed version](https://github.com/gsamokovarov/jump/releases.atom) of this page if that's preferable.

Re: [PR REVIEW] New package: jump-0.30.1

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New review comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/27245#discussion_r546432228

Comment:
Better to not have it at all if it doesn't have it.

Re: [PR REVIEW] New package: jump-0.30.1

[aweagel]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

New review comment by aweagel on void-packages repository

https://github.com/void-linux/void-packages/pull/27245#discussion_r546704096

Comment:
Hmm, I see this being done in lots of package definitions (see [hub](https://github.com/void-linux/void-packages/blob/master/srcpkgs/hub/template), [erlang](https://github.com/void-linux/void-packages/blob/master/srcpkgs/erlang/template), [mpv](https://github.com/void-linux/void-packages/blob/master/srcpkgs/mpv/template), [obs](https://github.com/void-linux/void-packages/blob/master/srcpkgs/mpv/template), [skaffold](https://github.com/void-linux/void-packages/blob/master/srcpkgs/skaffold/template), [sysdig](https://github.com/void-linux/void-packages/blob/master/srcpkgs/sysdig/template), etc).

Are you sure it's better to remove it, or would it make sense to follow the existing convention? I don't have a strong preference.

Re: [PR REVIEW] New package: jump-0.30.1

[aweagel]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

New review comment by aweagel on void-packages repository

https://github.com/void-linux/void-packages/pull/27245#discussion_r546704096

Comment:
Hmm, I see this being done in lots of package definitions (see [hub](https://github.com/void-linux/void-packages/blob/master/srcpkgs/hub/template), [erlang](https://github.com/void-linux/void-packages/blob/master/srcpkgs/erlang/template), [mpv](https://github.com/void-linux/void-packages/blob/master/srcpkgs/mpv/template), [obs](https://github.com/void-linux/void-packages/blob/master/srcpkgs/obs/template), [skaffold](https://github.com/void-linux/void-packages/blob/master/srcpkgs/skaffold/template), [sysdig](https://github.com/void-linux/void-packages/blob/master/srcpkgs/sysdig/template), etc).

Are you sure it's better to remove it, or would it make sense to follow the existing convention? I don't have a strong preference.

Re: [PR REVIEW] New package: jump-0.30.1

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New review comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/27245#discussion_r546999054

Comment:
Well, that wasn't the intention, but if this is where it is, that's where it is. I will not object further.

Re: [PR PATCH] [Merged]: New package: jump-0.30.1

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

There's a merged pull request on the void-packages repository

New package: jump-0.30.1
https://github.com/void-linux/void-packages/pull/27245

Description:

Re: New package: jump-0.30.1

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/27245#issuecomment-749338879

Comment:
Thank you for your contribution!