Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] python3-dkimpy: update to 1.0.5
@ 2020-12-25 20:36 paper42
  2020-12-29 15:04 ` [PR REVIEW] " ahesford
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: paper42 @ 2020-12-25 20:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages 0003-python3-dkimpy-update-to-1.0.5.patch
https://github.com/void-linux/void-packages/pull/27431

python3-dkimpy: update to 1.0.5


A patch file from https://github.com/void-linux/void-packages/pull/27431.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-0003-python3-dkimpy-update-to-1.0.5.patch-27431.patch --]
[-- Type: text/x-diff, Size: 1387 bytes --]

From 08f5a00438686ec2c98ad73927ad276075c402bc Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Fri, 25 Dec 2020 20:59:23 +0100
Subject: [PATCH] python3-dkimpy: update to 1.0.5

---
 srcpkgs/python3-dkimpy/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-dkimpy/template b/srcpkgs/python3-dkimpy/template
index 5969d1ca5c8..f461ce50142 100644
--- a/srcpkgs/python3-dkimpy/template
+++ b/srcpkgs/python3-dkimpy/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-dkimpy'
 pkgname=python3-dkimpy
-version=1.0.0
-revision=4
+version=1.0.5
+revision=1
 wrksrc="dkimpy-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -12,7 +12,7 @@ maintainer="Alexander Gehrke <void@qwertyuiop.de>"
 license="BSD-3-Clause"
 homepage="https://launchpad.net/dkimpy"
 distfiles="${PYPI_SITE}/d/dkimpy/dkimpy-${version}.tar.gz"
-checksum=56f37736b5527082f2389bacd804e31e9f0118043e26eff74198d5d12ae3908b
+checksum=9a2420bf09af686736773153fca32a02ae11ecbe24b540c26104628959f91121
 replaces="python-dkimpy>=0"
 provides="python-dkimpy-${version}_${revision}"
 
@@ -22,6 +22,6 @@ post_extract() {
 
 post_install() {
 	# This file is used for testing only
-	rm -f ${DESTDIR}/usr/lib/python3.?/site-packages/dkim/__main__.py
+	rm ${DESTDIR}/usr/lib/python3.?/site-packages/dkim/__main__.py
 	vlicense LICENSE
 }

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] python3-dkimpy: update to 1.0.5
  2020-12-25 20:36 [PR PATCH] python3-dkimpy: update to 1.0.5 paper42
@ 2020-12-29 15:04 ` ahesford
  2020-12-29 15:11 ` ericonr
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2020-12-29 15:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/27431#discussion_r549737236

Comment:
Why make this change? There is no need to break the build if this file disappears. Also, while you're editing this line, might as well make it
```bash
rm -f ${DESTDIR}/${py3_sitelib}/dkim/__main__.py
```

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] python3-dkimpy: update to 1.0.5
  2020-12-25 20:36 [PR PATCH] python3-dkimpy: update to 1.0.5 paper42
  2020-12-29 15:04 ` [PR REVIEW] " ahesford
@ 2020-12-29 15:11 ` ericonr
  2020-12-29 15:16 ` ahesford
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2020-12-29 15:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27431#discussion_r549739770

Comment:
I prefer to break the build, because if upstream stops installing that file we can just clean up the line, and we will realize that the line can be cleaned up at all. Otherwise it can stay there silently even when it no longer applies.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] python3-dkimpy: update to 1.0.5
  2020-12-25 20:36 [PR PATCH] python3-dkimpy: update to 1.0.5 paper42
  2020-12-29 15:04 ` [PR REVIEW] " ahesford
  2020-12-29 15:11 ` ericonr
@ 2020-12-29 15:16 ` ahesford
  2020-12-29 15:19 ` ericonr
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2020-12-29 15:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/27431#discussion_r549741650

Comment:
Ok, but I still prefer the `$py3_sitelib` change. Less typing and no globs.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] python3-dkimpy: update to 1.0.5
  2020-12-25 20:36 [PR PATCH] python3-dkimpy: update to 1.0.5 paper42
                   ` (2 preceding siblings ...)
  2020-12-29 15:16 ` ahesford
@ 2020-12-29 15:19 ` ericonr
  2020-12-29 16:41 ` [PR PATCH] [Updated] " paper42
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2020-12-29 15:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27431#discussion_r549742795

Comment:
Sure, I definitely agree with that part.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] python3-dkimpy: update to 1.0.5
  2020-12-25 20:36 [PR PATCH] python3-dkimpy: update to 1.0.5 paper42
                   ` (3 preceding siblings ...)
  2020-12-29 15:19 ` ericonr
@ 2020-12-29 16:41 ` paper42
  2020-12-29 16:42 ` [PR REVIEW] " paper42
  2021-01-05 20:33 ` [PR PATCH] [Merged]: " Chocimier
  6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2020-12-29 16:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages 0003-python3-dkimpy-update-to-1.0.5.patch
https://github.com/void-linux/void-packages/pull/27431

python3-dkimpy: update to 1.0.5


A patch file from https://github.com/void-linux/void-packages/pull/27431.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-0003-python3-dkimpy-update-to-1.0.5.patch-27431.patch --]
[-- Type: text/x-diff, Size: 1370 bytes --]

From 43a40d83e1e2fc98c4b410280d395a2162b2fd50 Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Fri, 25 Dec 2020 20:59:23 +0100
Subject: [PATCH] python3-dkimpy: update to 1.0.5

---
 srcpkgs/python3-dkimpy/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-dkimpy/template b/srcpkgs/python3-dkimpy/template
index 5969d1ca5c8..0993d589926 100644
--- a/srcpkgs/python3-dkimpy/template
+++ b/srcpkgs/python3-dkimpy/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-dkimpy'
 pkgname=python3-dkimpy
-version=1.0.0
-revision=4
+version=1.0.5
+revision=1
 wrksrc="dkimpy-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -12,7 +12,7 @@ maintainer="Alexander Gehrke <void@qwertyuiop.de>"
 license="BSD-3-Clause"
 homepage="https://launchpad.net/dkimpy"
 distfiles="${PYPI_SITE}/d/dkimpy/dkimpy-${version}.tar.gz"
-checksum=56f37736b5527082f2389bacd804e31e9f0118043e26eff74198d5d12ae3908b
+checksum=9a2420bf09af686736773153fca32a02ae11ecbe24b540c26104628959f91121
 replaces="python-dkimpy>=0"
 provides="python-dkimpy-${version}_${revision}"
 
@@ -22,6 +22,6 @@ post_extract() {
 
 post_install() {
 	# This file is used for testing only
-	rm -f ${DESTDIR}/usr/lib/python3.?/site-packages/dkim/__main__.py
+	rm ${DESTDIR}/${py3_sitelib}/dkim/__main__.py
 	vlicense LICENSE
 }

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] python3-dkimpy: update to 1.0.5
  2020-12-25 20:36 [PR PATCH] python3-dkimpy: update to 1.0.5 paper42
                   ` (4 preceding siblings ...)
  2020-12-29 16:41 ` [PR PATCH] [Updated] " paper42
@ 2020-12-29 16:42 ` paper42
  2021-01-05 20:33 ` [PR PATCH] [Merged]: " Chocimier
  6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2020-12-29 16:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/27431#discussion_r549771908

Comment:
thanks

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Merged]: python3-dkimpy: update to 1.0.5
  2020-12-25 20:36 [PR PATCH] python3-dkimpy: update to 1.0.5 paper42
                   ` (5 preceding siblings ...)
  2020-12-29 16:42 ` [PR REVIEW] " paper42
@ 2021-01-05 20:33 ` Chocimier
  6 siblings, 0 replies; 8+ messages in thread
From: Chocimier @ 2021-01-05 20:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

There's a merged pull request on the void-packages repository

python3-dkimpy: update to 1.0.5
https://github.com/void-linux/void-packages/pull/27431

Description:


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-01-05 20:34 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-25 20:36 [PR PATCH] python3-dkimpy: update to 1.0.5 paper42
2020-12-29 15:04 ` [PR REVIEW] " ahesford
2020-12-29 15:11 ` ericonr
2020-12-29 15:16 ` ahesford
2020-12-29 15:19 ` ericonr
2020-12-29 16:41 ` [PR PATCH] [Updated] " paper42
2020-12-29 16:42 ` [PR REVIEW] " paper42
2021-01-05 20:33 ` [PR PATCH] [Merged]: " Chocimier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).