* Re: [PR REVIEW] New package: hurl-1.0.0
2021-02-03 15:31 [PR PATCH] New package: hurl-1.0.0 juantascon
@ 2021-02-03 15:33 ` abenson
2021-02-03 15:34 ` abenson
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: abenson @ 2021-02-03 15:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 185 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/28439#discussion_r569512056
Comment:
You don't need to do the redirect here
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR REVIEW] New package: hurl-1.0.0
2021-02-03 15:31 [PR PATCH] New package: hurl-1.0.0 juantascon
2021-02-03 15:33 ` [PR REVIEW] " abenson
@ 2021-02-03 15:34 ` abenson
2021-02-03 15:37 ` abenson
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: abenson @ 2021-02-03 15:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/28439#discussion_r569512931
Comment:
This makes me think its would only generate the man pages and not actually build the binaries?
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR REVIEW] New package: hurl-1.0.0
2021-02-03 15:31 [PR PATCH] New package: hurl-1.0.0 juantascon
2021-02-03 15:33 ` [PR REVIEW] " abenson
2021-02-03 15:34 ` abenson
@ 2021-02-03 15:37 ` abenson
2021-02-03 16:06 ` [PR PATCH] [Updated] " juantascon
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: abenson @ 2021-02-03 15:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 286 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/28439#discussion_r569515627
Comment:
```
=> hurl-1.0.0_1: running do_build ...
/usr/bin/env: ‘python3’: No such file or directory
```
Probably missing `python3` here.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR PATCH] [Updated] New package: hurl-1.0.0
2021-02-03 15:31 [PR PATCH] New package: hurl-1.0.0 juantascon
` (2 preceding siblings ...)
2021-02-03 15:37 ` abenson
@ 2021-02-03 16:06 ` juantascon
2021-02-03 16:06 ` juantascon
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: juantascon @ 2021-02-03 16:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]
There is an updated pull request by juantascon against master on the void-packages repository
https://github.com/juantascon/void-packages hurl
https://github.com/void-linux/void-packages/pull/28439
New package: hurl-1.0.0
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28439.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hurl-28439.patch --]
[-- Type: text/x-diff, Size: 1288 bytes --]
From c1a952ebdea3aeed37a097a7fda8e92281e6d444 Mon Sep 17 00:00:00 2001
From: juantascon <juan@horlux.org>
Date: Wed, 3 Feb 2021 10:25:04 -0500
Subject: [PATCH] New package: hurl-1.0.0
---
srcpkgs/hurl/template | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
create mode 100644 srcpkgs/hurl/template
diff --git a/srcpkgs/hurl/template b/srcpkgs/hurl/template
new file mode 100644
index 00000000000..a47bc9226fa
--- /dev/null
+++ b/srcpkgs/hurl/template
@@ -0,0 +1,26 @@
+# Template file for 'hurl'
+pkgname=hurl
+version=1.0.0
+revision=1
+build_style=cargo
+hostmakedepends="pkg-config"
+makedepends="libxml2-devel libressl-devel python3"
+short_desc="Hurl, run and test HTTP requests. "
+maintainer="Juan Tascon <juan@horlux.org>"
+license="Apache-2.0"
+homepage="https://github.com/Orange-OpenSource/hurl"
+changelog="https://github.com/Orange-OpenSource/hurl/raw/master/CHANGELOG.md"
+distfiles="https://github.com/Orange-OpenSource/hurl/archive/${version}.tar.gz"
+checksum=3c1bbd3650a91d8434f9a57b0123246c3260e955a966feb2c63dedba94463ac1
+
+post_build() {
+ ./ci/man.sh
+}
+
+do_install() {
+ vbin "target/${RUST_TARGET}/release/hurl"
+ vbin "target/${RUST_TARGET}/release/hurlfmt"
+ vman target/man/hurl.1.gz
+ vman target/man/hurlfmt.1.gz
+ vdoc README.md
+}
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR PATCH] [Updated] New package: hurl-1.0.0
2021-02-03 15:31 [PR PATCH] New package: hurl-1.0.0 juantascon
` (3 preceding siblings ...)
2021-02-03 16:06 ` [PR PATCH] [Updated] " juantascon
@ 2021-02-03 16:06 ` juantascon
2021-02-16 6:47 ` ericonr
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: juantascon @ 2021-02-03 16:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]
There is an updated pull request by juantascon against master on the void-packages repository
https://github.com/juantascon/void-packages hurl
https://github.com/void-linux/void-packages/pull/28439
New package: hurl-1.0.0
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28439.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hurl-28439.patch --]
[-- Type: text/x-diff, Size: 1288 bytes --]
From 6415936f80f9b8c4e6093b2999e53b78979984f2 Mon Sep 17 00:00:00 2001
From: juantascon <juan@horlux.org>
Date: Wed, 3 Feb 2021 10:25:04 -0500
Subject: [PATCH] New package: hurl-1.0.0
---
srcpkgs/hurl/template | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
create mode 100644 srcpkgs/hurl/template
diff --git a/srcpkgs/hurl/template b/srcpkgs/hurl/template
new file mode 100644
index 00000000000..a47bc9226fa
--- /dev/null
+++ b/srcpkgs/hurl/template
@@ -0,0 +1,26 @@
+# Template file for 'hurl'
+pkgname=hurl
+version=1.0.0
+revision=1
+build_style=cargo
+hostmakedepends="pkg-config"
+makedepends="libxml2-devel libressl-devel python3"
+short_desc="Hurl, run and test HTTP requests. "
+maintainer="Juan Tascon <juan@horlux.org>"
+license="Apache-2.0"
+homepage="https://github.com/Orange-OpenSource/hurl"
+changelog="https://github.com/Orange-OpenSource/hurl/raw/master/CHANGELOG.md"
+distfiles="https://github.com/Orange-OpenSource/hurl/archive/${version}.tar.gz"
+checksum=3c1bbd3650a91d8434f9a57b0123246c3260e955a966feb2c63dedba94463ac1
+
+post_build() {
+ ./ci/man.sh
+}
+
+do_install() {
+ vbin "target/${RUST_TARGET}/release/hurl"
+ vbin "target/${RUST_TARGET}/release/hurlfmt"
+ vman target/man/hurl.1.gz
+ vman target/man/hurlfmt.1.gz
+ vdoc README.md
+}
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: New package: hurl-1.0.0
2021-02-03 15:31 [PR PATCH] New package: hurl-1.0.0 juantascon
` (4 preceding siblings ...)
2021-02-03 16:06 ` juantascon
@ 2021-02-16 6:47 ` ericonr
2022-05-03 2:14 ` github-actions
2022-05-17 2:14 ` [PR PATCH] [Closed]: " github-actions
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-02-16 6:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28439#issuecomment-779625380
Comment:
```
error[E0308]: mismatched types
--> packages/hurl/src/runner/xpath.rs:88:45
|
88 | let x = unsafe { CStr::from_ptr(c_s2) };
| ^^^^ expected `u8`, found `i8`
|
= note: expected raw pointer `*const u8`
found raw pointer `*const i8`
```
They don't test builds for ARM, this should have been detected a long while ago. Please report to upstream. chars have different default signedness on different platforms, so they should be using `c_char` from `std::os` or `libc`, not `u8` or `i8`.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: New package: hurl-1.0.0
2021-02-03 15:31 [PR PATCH] New package: hurl-1.0.0 juantascon
` (5 preceding siblings ...)
2021-02-16 6:47 ` ericonr
@ 2022-05-03 2:14 ` github-actions
2022-05-17 2:14 ` [PR PATCH] [Closed]: " github-actions
7 siblings, 0 replies; 9+ messages in thread
From: github-actions @ 2022-05-03 2:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/28439#issuecomment-1115549620
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR PATCH] [Closed]: New package: hurl-1.0.0
2021-02-03 15:31 [PR PATCH] New package: hurl-1.0.0 juantascon
` (6 preceding siblings ...)
2022-05-03 2:14 ` github-actions
@ 2022-05-17 2:14 ` github-actions
7 siblings, 0 replies; 9+ messages in thread
From: github-actions @ 2022-05-17 2:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]
There's a closed pull request on the void-packages repository
New package: hurl-1.0.0
https://github.com/void-linux/void-packages/pull/28439
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 9+ messages in thread