[PR PATCH] python3-grpcio: correct asm for boringssl

[PR PATCH] python3-grpcio: correct asm for boringssl

[sgn]

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages python3-grpcio-fix-boringssl
https://github.com/void-linux/void-packages/pull/28816

python3-grpcio: correct asm for boringssl
The line was changed to:

	if BUILD_WITH_BORING_SSL_ASM and not BUILD_WITH_SYSTEM_OPENSSL:

---

I'm not sure if we should switch to use system's {open,libre}ssl instead of bundled boringssl.
Also `re2-devel`.

A patch file from https://github.com/void-linux/void-packages/pull/28816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-grpcio-fix-boringssl-28816.patch --]
[-- Type: text/x-diff, Size: 1084 bytes --]

From 3f6f862e10d8eadb682ebb278db61189014082d9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Wed, 17 Feb 2021 20:24:28 +0700
Subject: [PATCH] python3-grpcio: correct asm for boringssl

The line was changed to:

	if BUILD_WITH_BORING_SSL_ASM and not BUILD_WITH_SYSTEM_OPENSSL:
---
 srcpkgs/python3-grpcio/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/python3-grpcio/template b/srcpkgs/python3-grpcio/template
index 76b88b3c8c4..749846e54cd 100644
--- a/srcpkgs/python3-grpcio/template
+++ b/srcpkgs/python3-grpcio/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-grpcio'
 pkgname=python3-grpcio
 version=1.35.0
-revision=1
+revision=2
 archs="x86_64* i686* aarch64* armv[67]* ppc64le*"
 wrksrc="${pkgname#*-}-${version}"
 build_style=python3-module
@@ -47,5 +47,5 @@ post_patch() {
 
 	vsed -i setup.py \
 		-e "s/asm_key = .*/asm_key = '${asm_key}'/" \
-		-e "s/if BUILD_WITH_BORING_SSL_ASM:/if False:/"
+		-e "s/if BUILD_WITH_BORING_SSL_ASM.*:/if False:/"
 }

Re: python3-grpcio: correct asm for boringssl

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28816#issuecomment-780609759

Comment:
I think we want to stick with our own Libre/OpenSSL, because BoringSSL has issues with some platforms.

@ahesford 

Re: python3-grpcio: correct asm for boringssl

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28816#issuecomment-780609759

Comment:
I think we want to stick with our own Libre/OpenSSL, because BoringSSL has issues with some platforms.

Re: python3-grpcio: correct asm for boringssl

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/28816#issuecomment-780633831

Comment:
Thanks for catching this. In fact the change that broke the ASM patch seems to be all that was necessary for `GRPC_PYTHON_BUILD_SYSTEM_OPENSSL` to work properly with our LibreSSL. I'm going to check the new build against my gRPC stuff and see if everything works as expected.

Re: [PR PATCH] [Closed]: python3-grpcio: correct asm for boringssl

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

There's a closed pull request on the void-packages repository

python3-grpcio: correct asm for boringssl
https://github.com/void-linux/void-packages/pull/28816

Description:
The line was changed to:

	if BUILD_WITH_BORING_SSL_ASM and not BUILD_WITH_SYSTEM_OPENSSL:

---

I'm not sure if we should switch to use system's {open,libre}ssl instead of bundled boringssl.
Also `re2-devel`.