[PR PATCH] podman: Add fuse-overlayfs to depends

[PR PATCH] podman: Add fuse-overlayfs to depends

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

There is a new pull request by kartikynwa against master on the void-packages repository

https://github.com/kartikynwa/void-packages podman-add-overlay
https://github.com/void-linux/void-packages/pull/29505

podman: Add fuse-overlayfs to depends
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Related to #29491 

A patch file from https://github.com/void-linux/void-packages/pull/29505.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-podman-add-overlay-29505.patch --]
[-- Type: text/x-diff, Size: 1171 bytes --]

From 4b8331590db5e52ce0488191f0509a78bc738360 Mon Sep 17 00:00:00 2001
From: Kartik Singh <kartik.ynwa@gmail.com>
Date: Tue, 16 Mar 2021 14:46:03 +0530
Subject: [PATCH] podman: Add fuse-overlayfs to depends

---
 srcpkgs/podman/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/podman/template b/srcpkgs/podman/template
index 470a811d86f6..1a186001f3db 100644
--- a/srcpkgs/podman/template
+++ b/srcpkgs/podman/template
@@ -1,7 +1,7 @@
 # Template file for 'podman'
 pkgname=podman
 version=3.0.1
-revision=1
+revision=2
 build_style=go
 go_import_path="github.com/containers/podman/v2"
 go_package="${go_import_path}/cmd/podman"
@@ -9,7 +9,7 @@ go_build_tags="seccomp apparmor containers_image_ostree_stub
  btrfs_noversion exclude_graphdriver_btrfs"
 hostmakedepends="pkg-config go-md2man"
 makedepends="gpgme-devel libseccomp-devel device-mapper-devel"
-depends="runc conmon cni-plugins slirp4netns containers.image"
+depends="runc conmon cni-plugins slirp4netns containers.image fuse-overlayfs"
 short_desc="Simple management tool for containers and images"
 maintainer="Cameron Nemo <cnemo@tutanota.com>"
 license="Apache-2.0"

Re: podman: Add fuse-overlayfs to depends

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/29505#issuecomment-801103153

Comment:
Maybe you can ask that author to add it to depends in their commit and force push. We can then close this PR and merge the other one.

17-Mar-2021 19:24:29 Andrew J. Hesford ***@***.***>:

> ***@***.**** approved this pull request.
> 
> See also #29530[https://github.com/void-linux/void-packages/pull/29530]. We can save a revbump if we coordinate both changes.
> 
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub[https://github.com/void-linux/void-packages/pull/29505#pullrequestreview-614333782], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AB33RLHYYYR63GIIFQQZDDDTECYBLANCNFSM4ZIE3RHA].
>  [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAFQAAABUCAYAAAAcaxDBAAAABHNCSVQICAgIfAhkiAAAADJJREFUeJztwQENAAAAwqD3T20ON6AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAB4NW6UAAFvMNJxAAAAAElFTkSuQmCC###24x24:true###][Tracking image][https://github.com/notifications/beacon/AB33RLFMD7A4ZXPSIEXWLX3TECYBLA5CNFSM4ZIE3RHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOESO72VQ.gif]
> 

Re: podman: Add fuse-overlayfs to depends

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/pull/29505#issuecomment-801269384

Comment:
This will change the default behaviour of `podman` and break existing installations that don't have a storage driver configured in `~/.config/containers/storage.conf`:
```
ERRO[0000] User-selected graph driver "overlay" overwritten by graph driver "vfs" from database - delete libpod local files to resolve 
ERRO[0000] User-selected graph driver "overlay" overwritten by graph driver "vfs" from database - delete libpod local files to resolve 
Error: vfs driver does not support overlay.mount_program options
```
The `vfs` driver ist the fallback driver. `fuse-overlayfs` is automatically selected if available for user installs. We could just let the user deal with this, print an install message or force the default via `/etc/containers/storage.conf`.

I'm fine with any of this and from my experience `fuse-overlayfs` looks like it could be the better default.

Re: podman: Add fuse-overlayfs to depends

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/29505#issuecomment-801620576

Comment:
> break existing installations

Yeah that could be problematic

Re: podman: Add fuse-overlayfs to depends

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/29505#issuecomment-802003827

Comment:
I'm not a heavy `podman` user and don't have a strong opinion, but it seems like the error is non-destructive. It might be worth the errors if `fuse-overlayfs` solves the excessive space problem. (I assume that, without overlayfs, the `vfs` driver just duplicates each layer to create the next one.)

This is probably worth an `INSTALL.msg` if the error completely prevents containers from starting. People might have configured services to automatically start containers and the reason for a failure might be overlooked.

Re: podman: Add fuse-overlayfs to depends

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 883 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/pull/29505#issuecomment-803235065

Comment:
@ahesford: Thoughts?
`INSTALL.msg`:
```
`fuse-overlayfs` has been added as a runtime dependency to podman.
podman will now prefer this storage driver to the `vfs` driver.

To switch to the new storage driver, podman has to be reset:

   # podman system reset

To keep the `vfs` fallback driver, add this to `/etc/containers/storoage.conf` 
or `~/.config/containers/storage.conf`:

    [storage]
    driver="vfs"

Otherwise podman will display an error and refuses any further operation.

Additionally the `btrfs` storage driver has been enabled. This driver also 
available for rootless operation. Reset podman and add the following to your 
`storage.conf` to switch to this driver:

    [storage]
    driver="btrfs"
```

Re: [PR PATCH] [Closed]: podman: Add fuse-overlayfs to depends

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

There's a closed pull request on the void-packages repository

podman: Add fuse-overlayfs to depends
https://github.com/void-linux/void-packages/pull/29505

Description:
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Related to #29491