Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] CONTRIBUTING.md: be clearer about "one commit per PR" rule.
@ 2021-03-18 17:30 ericonr
  2021-03-18 18:25 ` [PR REVIEW] " Chocimier
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: ericonr @ 2021-03-18 17:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages contr
https://github.com/void-linux/void-packages/pull/29568

CONTRIBUTING.md: be clearer about "one commit per PR" rule.


A patch file from https://github.com/void-linux/void-packages/pull/29568.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-contr-29568.patch --]
[-- Type: text/x-diff, Size: 2084 bytes --]

From b870cf1533d8f0e19f6c8e5d909dcff5df42dc33 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Thu, 18 Mar 2021 14:29:32 -0300
Subject: [PATCH] CONTRIBUTING.md: be clearer about "one commit per PR" rule.

---
 CONTRIBUTING.md | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 4cadfc6265b7..38a0f7826402 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -74,7 +74,7 @@ New packages will not be accepted unless they have been runtime tested.
 
 ### Starting a pull request
 
-Once you have successfully built the package, you can [create a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request).
+Once you have successfully built the package, you can [create a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request). Pull requests are also known as PRs.
 
 Most pull requests should only contain a single package and dependencies which are not part of void-packages yet.
 
@@ -99,11 +99,10 @@ comply with the our guidelines. At the moment not all packages comply with the r
 
 #### Review
 
-Most of the time your pull request will contain mistakes. It's nothing bad, it just happens.
+It's possible (and common) that a pull request will contain mistakes or reviewers will ask for additional tweaks.
+Reviewers will comment on your pull request and point out which changes are needed before the pull request can be merged.
 
-Reviewers will comment on your pull request and point out which changes are needed before the template can be included.
-
-We recommend having only a single commit for pull request, so if you need to make changes in commits but already have a pull request, use the following commands:
+Most PRs will have a single commit, as seen [above](#starting-a-pull-request), so if you need to make changes to the commit but already have a pull request, use the following commands:
 
     $ git add <file>
     $ git commit --amend

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-03-24  3:13 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18 17:30 [PR PATCH] CONTRIBUTING.md: be clearer about "one commit per PR" rule ericonr
2021-03-18 18:25 ` [PR REVIEW] " Chocimier
2021-03-18 19:05 ` [PR PATCH] [Updated] " ericonr
2021-03-18 19:06 ` [PR REVIEW] " ericonr
2021-03-18 19:18 ` Chocimier
2021-03-24  2:03 ` [PR PATCH] [Updated] " ericonr
2021-03-24  2:03 ` ericonr
2021-03-24  3:13 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).