Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] intel-gmmlib: add comment about -march used in compiler flags.
@ 2021-04-07 19:33 ericonr
  2021-04-07 20:08 ` ericonr
  2021-04-11  2:57 ` [PR PATCH] [Merged]: " ericonr
  0 siblings, 2 replies; 3+ messages in thread
From: ericonr @ 2021-04-07 19:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages gmmlib
https://github.com/void-linux/void-packages/pull/30074

intel-gmmlib: add comment about -march used in compiler flags.
Reported by sgn
Suggestion for "fix" by tornaria
Closes #29801

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30074.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gmmlib-30074.patch --]
[-- Type: text/x-diff, Size: 1324 bytes --]

From 0864c036fcebc810c8d0d398e2df31bbf0c09622 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Wed, 7 Apr 2021 16:31:51 -0300
Subject: [PATCH] intel-gmmlib: add comment about -march used in compiler
 flags.

Reported by sgn
Suggestion for "fix" by tornaria
Closes #29801
---
 srcpkgs/intel-gmmlib/template | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/srcpkgs/intel-gmmlib/template b/srcpkgs/intel-gmmlib/template
index de10b7059d95..ad6ba012fa90 100644
--- a/srcpkgs/intel-gmmlib/template
+++ b/srcpkgs/intel-gmmlib/template
@@ -5,6 +5,14 @@ revision=1
 archs="i686* x86_64*"
 wrksrc=gmmlib-intel-gmmlib-${version}
 build_style=cmake
+# We could add -DGMMLIB_ARCH=generic to make it use -march=generic
+# instead of their default of 'corei7', but it isn't necessary:
+# the baseline of CPUs supported by gmmlib all fit under 'corei7'.
+# They also add many '-msse*' flags, but they are all supported
+# as well. Since this library isn't a dependency for anything but
+# intel-media-driver, which is wholly optional and installed only on
+# systems with supported CPUs, it doesn't make sense to change the
+# compilers flag in use.
 configure_args="-Wno-dev"
 short_desc="Intel Graphics Memory Management Library"
 maintainer="Stefano Ragni <st3r4g@protonmail.com>"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: intel-gmmlib: add comment about -march used in compiler flags.
  2021-04-07 19:33 [PR PATCH] intel-gmmlib: add comment about -march used in compiler flags ericonr
@ 2021-04-07 20:08 ` ericonr
  2021-04-11  2:57 ` [PR PATCH] [Merged]: " ericonr
  1 sibling, 0 replies; 3+ messages in thread
From: ericonr @ 2021-04-07 20:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30074#issuecomment-815215408

Comment:
@sgn ?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: intel-gmmlib: add comment about -march used in compiler flags.
  2021-04-07 19:33 [PR PATCH] intel-gmmlib: add comment about -march used in compiler flags ericonr
  2021-04-07 20:08 ` ericonr
@ 2021-04-11  2:57 ` ericonr
  1 sibling, 0 replies; 3+ messages in thread
From: ericonr @ 2021-04-11  2:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]

There's a merged pull request on the void-packages repository

intel-gmmlib: add comment about -march used in compiler flags.
https://github.com/void-linux/void-packages/pull/30074

Description:
Reported by sgn
Suggestion for "fix" by tornaria
Closes #29801

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-11  2:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 19:33 [PR PATCH] intel-gmmlib: add comment about -march used in compiler flags ericonr
2021-04-07 20:08 ` ericonr
2021-04-11  2:57 ` [PR PATCH] [Merged]: " ericonr

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git