[PR PATCH] pinktrace: disable on arm*, enable on aarch64*

[PR PATCH] pinktrace: disable on arm*, enable on aarch64*

[paper42]

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pinktrace-arm
https://github.com/void-linux/void-packages/pull/32654

pinktrace: disable on arm*, enable on aarch64*
@thypon pinktrace 1.0.0 breaks when building for arm*, aarch64 is listed in supported architectures and builds fine

A patch file from https://github.com/void-linux/void-packages/pull/32654.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pinktrace-arm-32654.patch --]
[-- Type: text/x-diff, Size: 826 bytes --]

From 0bd32b21e0fde2c31dc8ea91378fc61f13292e4d Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Tue, 24 Aug 2021 19:48:44 +0200
Subject: [PATCH] pinktrace: disable on arm*, enable on aarch64*

---
 srcpkgs/pinktrace/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/pinktrace/template b/srcpkgs/pinktrace/template
index 49852488a0b3..1d90a03d1ff2 100644
--- a/srcpkgs/pinktrace/template
+++ b/srcpkgs/pinktrace/template
@@ -3,7 +3,8 @@ pkgname=pinktrace
 version=1.0.0
 revision=1
 # arch list taken from https://dev.exherbo.org/~alip/pinktrace/#supported_platforms
-archs="x86_64* i686* ppc* arm*"
+# build for arm* architectures is broken
+archs="x86_64* i686* ppc* aarch*"
 wrksrc="$pkgname-1-$version"
 build_style=gnu-configure
 configure_args="--enable-python"

Re: pinktrace: disable on arm*, enable on aarch64*

[paper42]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32654#issuecomment-904855982

Comment:
sydbox is also broken on arm* and i686*

Re: [PR PATCH] [Updated] pinktrace: disable on arm*, enable on aarch64*

[paper42]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pinktrace-arm
https://github.com/void-linux/void-packages/pull/32654

pinktrace: disable on arm*, enable on aarch64*
@thypon pinktrace 1.0.0 breaks when building for arm*, aarch64 is listed in supported architectures and builds fine

A patch file from https://github.com/void-linux/void-packages/pull/32654.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pinktrace-arm-32654.patch --]
[-- Type: text/x-diff, Size: 1812 bytes --]

From 6a2a743f34df2c9a2e75b5f26a6c13ecfe0bfadc Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Tue, 24 Aug 2021 19:48:44 +0200
Subject: [PATCH 1/2] pinktrace: disable on arm*, enable on aarch64*

---
 srcpkgs/pinktrace/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/pinktrace/template b/srcpkgs/pinktrace/template
index 49852488a0b3..99f2169693d5 100644
--- a/srcpkgs/pinktrace/template
+++ b/srcpkgs/pinktrace/template
@@ -3,7 +3,8 @@ pkgname=pinktrace
 version=1.0.0
 revision=1
 # arch list taken from https://dev.exherbo.org/~alip/pinktrace/#supported_platforms
-archs="x86_64* i686* ppc* arm*"
+# build for arm* architectures is broken
+archs="x86_64* i686* ppc* aarch64*"
 wrksrc="$pkgname-1-$version"
 build_style=gnu-configure
 configure_args="--enable-python"
@@ -16,6 +17,7 @@ license="MIT"
 homepage="http://dev.exherbo.org/~alip/pinktrace/"
 distfiles="http://git.exherbo.org/$pkgname-1.git/snapshot/$pkgname-1-$version.tar.gz"
 checksum=a963359c3a66d31f8ac5b75cdc41ff0c4886df48609338771a2016c712b2f48a
+make_check=ci-skip
 
 pre_configure() {
 	./autogen.sh

From b65835c3509adca5ec04906f34aac55b9734281e Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Tue, 24 Aug 2021 20:15:01 +0200
Subject: [PATCH 2/2] sydbox: disable on all archs exvept for x86_64

---
 srcpkgs/sydbox/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/sydbox/template b/srcpkgs/sydbox/template
index 1fdeffa9d69b..4414b317b29a 100644
--- a/srcpkgs/sydbox/template
+++ b/srcpkgs/sydbox/template
@@ -3,6 +3,7 @@ pkgname=sydbox
 version=1.2.1
 revision=1
 wrksrc="$pkgname-1-$version"
+archs="x86_64*"
 build_style=gnu-configure
 hostmakedepends="automake pkg-config libtool pinktrace-devel"
 makedepends="pinktrace-devel"

Re: pinktrace: disable on arm*, enable on aarch64*

[thypon]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by thypon on void-packages repository

https://github.com/void-linux/void-packages/pull/32654#issuecomment-904868358

Comment:
Wait, isn't it working correctly on aarch64?

Re: pinktrace: disable on arm*, enable on aarch64*

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1737 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32654#issuecomment-904871931

Comment:
> Wait, isn't it working correctly on aarch64?

```
syscall-special.c:62:3: warning: #warning is a GCC extension
   62 | # warning do not know the size of stat buffer for non-default ABIs
      |   ^~~~~~~
syscall-special.c:62:3: warning: #warning do not know the size of stat buffer for non-default ABIs [-Wcpp]
  CC       sydbox-syscall-filter.o
  CC       sydbox-syscall.o
syscall.c: In function 'seccomp_apply':
syscall.c:484:7: error: 'PINK_ABI_X86_64' undeclared (first use in this function); did you mean 'PINK_ARCH_X86_64'?
  484 |  case PINK_ABI_X86_64:
      |       ^~~~~~~~~~~~~~~
      |       PINK_ARCH_X86_64
syscall.c:484:7: note: each undeclared identifier is reported only once for each function it appears in
syscall.c:487:7: error: 'PINK_ABI_I386' undeclared (first use in this function); did you mean 'PINK_ARCH_I386'?
  487 |  case PINK_ABI_I386:
      |       ^~~~~~~~~~~~~
      |       PINK_ARCH_I386
syscall.c: In function 'sysinit_seccomp':
syscall.c:702:2: error: #error "Platform does not support seccomp filter yet"
  702 | #error "Platform does not support seccomp filter yet"
      |  ^~~~~
syscall.c:671:9: warning: unused variable 'i' [-Wunused-variable]
  671 |  size_t i;
      |         ^
At top level:
syscall.c:453:12: warning: 'apply_simple_filter' defined but not used [-Wunused-function]
  453 | static int apply_simple_filter(const sysentry_t *entry, int arch, int abi)
      |            ^~~~~~~~~~~~~~~~~~~
```

Would you line to take this PR? You know a lot more about these packages than I do. Feel free to push here.

Re: pinktrace: disable on arm*, enable on aarch64*

[thypon]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New comment by thypon on void-packages repository

https://github.com/void-linux/void-packages/pull/32654#issuecomment-904873214

Comment:
I'll take a look in a couple of hours, when I will join my workstation.

Re: pinktrace: disable on arm*, enable on aarch64*

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1775 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32654#issuecomment-904871931

Comment:
> Wait, isn't it working correctly on aarch64?

sydbox doesn't build, pinktrace does
```
syscall-special.c:62:3: warning: #warning is a GCC extension
   62 | # warning do not know the size of stat buffer for non-default ABIs
      |   ^~~~~~~
syscall-special.c:62:3: warning: #warning do not know the size of stat buffer for non-default ABIs [-Wcpp]
  CC       sydbox-syscall-filter.o
  CC       sydbox-syscall.o
syscall.c: In function 'seccomp_apply':
syscall.c:484:7: error: 'PINK_ABI_X86_64' undeclared (first use in this function); did you mean 'PINK_ARCH_X86_64'?
  484 |  case PINK_ABI_X86_64:
      |       ^~~~~~~~~~~~~~~
      |       PINK_ARCH_X86_64
syscall.c:484:7: note: each undeclared identifier is reported only once for each function it appears in
syscall.c:487:7: error: 'PINK_ABI_I386' undeclared (first use in this function); did you mean 'PINK_ARCH_I386'?
  487 |  case PINK_ABI_I386:
      |       ^~~~~~~~~~~~~
      |       PINK_ARCH_I386
syscall.c: In function 'sysinit_seccomp':
syscall.c:702:2: error: #error "Platform does not support seccomp filter yet"
  702 | #error "Platform does not support seccomp filter yet"
      |  ^~~~~
syscall.c:671:9: warning: unused variable 'i' [-Wunused-variable]
  671 |  size_t i;
      |         ^
At top level:
syscall.c:453:12: warning: 'apply_simple_filter' defined but not used [-Wunused-function]
  453 | static int apply_simple_filter(const sysentry_t *entry, int arch, int abi)
      |            ^~~~~~~~~~~~~~~~~~~
```

Would you line to take this PR? You know a lot more about these packages than I do. Feel free to push here.

Re: pinktrace: disable on arm*, enable on aarch64*

[q66]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/32654#issuecomment-904883155

Comment:
i fixed this already

Re: [PR PATCH] [Closed]: pinktrace: disable on arm*, enable on aarch64*

[q66]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

There's a closed pull request on the void-packages repository

pinktrace: disable on arm*, enable on aarch64*
https://github.com/void-linux/void-packages/pull/32654

Description:
@thypon pinktrace 1.0.0 breaks when building for arm*, aarch64 is listed in supported architectures and builds fine