[PR PATCH] sqlite: update to 3.38.1.

[PR PATCH] sqlite: update to 3.38.1.

[ologantr]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

There is a new pull request by ologantr against master on the void-packages repository

https://github.com/ologantr/void-packages sqlite-update
https://github.com/void-linux/void-packages/pull/36114

sqlite: update to 3.38.1.
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/36114.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sqlite-update-36114.patch --]
[-- Type: text/x-diff, Size: 1606 bytes --]

From f373bc478157b57418b584136f438057f2997631 Mon Sep 17 00:00:00 2001
From: ologantr <mrphyber@protonmail.com>
Date: Sat, 12 Mar 2022 21:24:39 +0100
Subject: [PATCH] sqlite: update to 3.38.1.

---
 common/shlibs           | 2 +-
 srcpkgs/sqlite/template | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index f26b9bab58fd..1956eeccda18 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -352,7 +352,7 @@ libpoppler-cpp.so.0 poppler-cpp-0.18.2_1
 libpoppler-qt5.so.1 poppler-qt5-0.31.0_1
 libtcl8.6.so tcl-8.6.0_1
 libtk8.6.so tk-8.6.1_3
-libsqlite3.so.0 sqlite-3.38.0_1
+libsqlite3.so.0 sqlite-3.38.1_1
 libIDL-2.so.0 libIDL-0.8.13_1
 libnspr4.so nspr-4.8_1
 libplc4.so nspr-4.8_1
diff --git a/srcpkgs/sqlite/template b/srcpkgs/sqlite/template
index 8760d30aee97..0ef5405dfa66 100644
--- a/srcpkgs/sqlite/template
+++ b/srcpkgs/sqlite/template
@@ -1,6 +1,6 @@
 # Template file for 'sqlite'
 pkgname=sqlite
-version=3.38.0
+version=3.38.1
 revision=1
 _amalgamationver=$(printf "%d%02d%02d00\n" ${version//./ })
 wrksrc="sqlite-autoconf-${_amalgamationver}"
@@ -13,7 +13,7 @@ license="Public Domain"
 homepage="https://sqlite.org/"
 changelog="https://www.sqlite.org/releaselog/${version//./_}.html"
 distfiles="${homepage}/2022/sqlite-autoconf-${_amalgamationver}.tar.gz"
-checksum=1c76e25dc63d9f3935e0f406aec520a33ee77cf54ea5147dffe1fae8369eff68
+checksum=8e3a8ceb9794d968399590d2ddf9d5c044a97dd83d38b9613364a245ec8a2fc4
 
 CFLAGS="-DSQLITE_ENABLE_DBSTAT_VTAB -DSQLITE_ENABLE_COLUMN_METADATA \
  -DSQLITE_ENABLE_UNLOCK_NOTIFY -DSQLITE_SECURE_DELETE \

Re: [PR REVIEW] sqlite: update to 3.38.1.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36114#discussion_r825431442

Comment:
Why is this necessary?

Re: [PR REVIEW] sqlite: update to 3.38.1.

[ologantr]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New review comment by ologantr on void-packages repository

https://github.com/void-linux/void-packages/pull/36114#discussion_r825500698

Comment:
I was trying to avoid making it lag behind. 
If it's unnecessary I can revert this bit.

Re: [PR REVIEW] sqlite: update to 3.38.1.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 842 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36114#discussion_r825503665

Comment:
common/shlibs list shlibs and packages in which they are in versions in which they first appeared. `xbps-src` will scan the package for required shlibs, look at this file and create a list of dependencies. Without this change, a new package/an updated one will depend on sqlite>=3.38.0, with this change it will depend on sqlite>=3.38.1.
If there is no good reason to do this, we shouldn't do it. This makes reverts hard and prevents partial updates. It would make sense if sqlite added some new symbols and packages built with this version would crash with the old one. Then we would want new packages (built with new sqlite) to also depend on the new sqlite version, but that's not this case.

Re: [PR REVIEW] sqlite: update to 3.38.1.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36114#discussion_r825503665

Comment:
`common/shlibs` list shlibs and packages in which they are in versions in which they first appeared. `xbps-src` will scan the package for required shlibs, look at this file and create a list of dependencies. Without this change, a new package/an updated one will depend on sqlite>=3.38.0, with this change it will depend on sqlite>=3.38.1.

If there is no good reason to do this, we shouldn't do it. This makes reverts hard and prevents partial updates. It would make sense if sqlite added some new symbols and packages built with this version would crash with the old one. Then we would want new packages (built with new sqlite) to also depend on the new sqlite version, but that's not this case.

Re: [PR PATCH] [Updated] sqlite: update to 3.38.1.

[ologantr]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

There is an updated pull request by ologantr against master on the void-packages repository

https://github.com/ologantr/void-packages sqlite-update
https://github.com/void-linux/void-packages/pull/36114

sqlite: update to 3.38.1.
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/36114.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sqlite-update-36114.patch --]
[-- Type: text/x-diff, Size: 1153 bytes --]

From a4a017107ceef2fe1ea7b7401e60a0c017d18e14 Mon Sep 17 00:00:00 2001
From: ologantr <mrphyber@protonmail.com>
Date: Sat, 12 Mar 2022 21:24:39 +0100
Subject: [PATCH] sqlite: update to 3.38.1.

---
 srcpkgs/sqlite/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/sqlite/template b/srcpkgs/sqlite/template
index 8760d30aee97..0ef5405dfa66 100644
--- a/srcpkgs/sqlite/template
+++ b/srcpkgs/sqlite/template
@@ -1,6 +1,6 @@
 # Template file for 'sqlite'
 pkgname=sqlite
-version=3.38.0
+version=3.38.1
 revision=1
 _amalgamationver=$(printf "%d%02d%02d00\n" ${version//./ })
 wrksrc="sqlite-autoconf-${_amalgamationver}"
@@ -13,7 +13,7 @@ license="Public Domain"
 homepage="https://sqlite.org/"
 changelog="https://www.sqlite.org/releaselog/${version//./_}.html"
 distfiles="${homepage}/2022/sqlite-autoconf-${_amalgamationver}.tar.gz"
-checksum=1c76e25dc63d9f3935e0f406aec520a33ee77cf54ea5147dffe1fae8369eff68
+checksum=8e3a8ceb9794d968399590d2ddf9d5c044a97dd83d38b9613364a245ec8a2fc4
 
 CFLAGS="-DSQLITE_ENABLE_DBSTAT_VTAB -DSQLITE_ENABLE_COLUMN_METADATA \
  -DSQLITE_ENABLE_UNLOCK_NOTIFY -DSQLITE_SECURE_DELETE \

Re: [PR PATCH] [Merged]: sqlite: update to 3.38.1.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

There's a merged pull request on the void-packages repository

sqlite: update to 3.38.1.
https://github.com/void-linux/void-packages/pull/36114

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture (x86_64-glibc)