[PR PATCH] New package: json-table-2.0.0

[PR PATCH] New package: json-table-2.0.0

[akhiljalagam]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

There is a new pull request by akhiljalagam against master on the void-packages repository

https://github.com/akhiljalagam/void-packages json-table
https://github.com/void-linux/void-packages/pull/38264

New package: json-table-2.0.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38264.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-json-table-38264.patch --]
[-- Type: text/x-diff, Size: 1067 bytes --]

From 22a620fbd45908530da4abb6302f40e9a4a6f13c Mon Sep 17 00:00:00 2001
From: akhil <akhil.j@outlook.in>
Date: Mon, 25 Jul 2022 12:51:38 +0530
Subject: [PATCH] New package: json-table-2.0.0

---
 srcpkgs/json-table/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/json-table/template

diff --git a/srcpkgs/json-table/template b/srcpkgs/json-table/template
new file mode 100644
index 000000000000..b520c6390c83
--- /dev/null
+++ b/srcpkgs/json-table/template
@@ -0,0 +1,17 @@
+# Template file for 'json-table'
+pkgname=json-table
+version=2.0.0
+revision=1
+build_style=gnu-makefile
+short_desc="Transform nested JSON data into tabular data in the shell"
+maintainer="akhil <akhil.j@outlook.in>"
+license="EPL-1.0"
+homepage="https://github.com/micha/json-table"
+changelog="https://github.com/micha/json-table/releases"
+distfiles="https://github.com/micha/json-table/archive/refs/tags/${version}.tar.gz"
+checksum=6e74d0b5b82d2f04c069302d0c477aa7993012602da5dffb600e472049388775
+
+do_install() {
+	vbin jt
+	vman jt.1
+}

Re: [PR REVIEW] New package: json-table-2.0.0

[meator]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

New review comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/38264#discussion_r928622031

Comment:
It's unfortunate that their `Makefile` doesn't respect [`$DESTDIR`](https://www.gnu.org/software/make/manual/html_node/DESTDIR.html). Well written `Makefile`s should support that. Might be worth telling the developers about it.

Re: [PR REVIEW] New package: json-table-2.0.0

[akhiljalagam]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New review comment by akhiljalagam on void-packages repository

https://github.com/void-linux/void-packages/pull/38264#discussion_r929147048

Comment:
yes. informed developer. https://github.com/micha/json-table/issues/14

Re: [PR REVIEW] New package: json-table-2.0.0

[meator]

[-- Attachment #1: Type: text/plain, Size: 763 bytes --]

New review comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/38264#discussion_r929213738

Comment:
If it would utilize `$DESTDIR`, than you wouldn't have to specify `do_install()` at all because it would be handled automatically by the `gnu-makefile` build style. Specifying a non-default install directory via `$DESTDIR` is essential for package managers because they install the important files to a "fake" Linux system which contains just the package and then process this "fake" system to make it usable with XBPS.

The page I linked (https://www.gnu.org/software/make/manual/html_node/DESTDIR.html) and [the Manual](https://github.com/void-linux/void-packages/blob/master/Manual.md) contains more information.

Re: New package: json-table-2.0.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/38264#issuecomment-1288314682

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: json-table-2.0.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]

There's a closed pull request on the void-packages repository

New package: json-table-2.0.0
https://github.com/void-linux/void-packages/pull/38264

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->