* Re: [PR REVIEW] flowblade: updated dependencies
2022-11-09 15:55 [PR PATCH] flowblade: updated dependencies Relected
@ 2022-11-09 16:00 ` paper42
2022-11-09 16:07 ` Relected
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: paper42 @ 2022-11-09 16:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40415#discussion_r1018127965
Comment:
I don't see a reason for this, all of the added dependencies are already dependencies through a package that's already in $depends.
also, commit message is wrong and $revision should be increased
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR REVIEW] flowblade: updated dependencies
2022-11-09 15:55 [PR PATCH] flowblade: updated dependencies Relected
2022-11-09 16:00 ` [PR REVIEW] " paper42
@ 2022-11-09 16:07 ` Relected
2022-11-09 16:11 ` [PR PATCH] [Updated] " Relected
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Relected @ 2022-11-09 16:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
New review comment by Relected on void-packages repository
https://github.com/void-linux/void-packages/pull/40415#discussion_r1018136132
Comment:
>I don't see a reason for this, all of the added dependencies are already dependencies through a package that's already in $depends.
ok but flowblade was not launching and it was saying that module "mlt "was missing, then after installing mlt-python3 it also said that module "gi" was missing, which could be fixed by installing libgirepository
also librsvg mlt-data and sox were also on the dependency page of flowblade so i added them as well while i was at it
>commit message is wrong and $revision should be increased
my bad, im going to fix that quickly
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR PATCH] [Updated] flowblade: updated dependencies
2022-11-09 15:55 [PR PATCH] flowblade: updated dependencies Relected
2022-11-09 16:00 ` [PR REVIEW] " paper42
2022-11-09 16:07 ` Relected
@ 2022-11-09 16:11 ` Relected
2022-11-09 17:16 ` [PR REVIEW] " paper42
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Relected @ 2022-11-09 16:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
There is an updated pull request by Relected against master on the void-packages repository
https://github.com/Relected/void-packages master
https://github.com/void-linux/void-packages/pull/40415
flowblade: updated dependencies
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
-->
Notes: updated dependencies to meet new requirements and avoid potential confusion, nothing major.
A patch file from https://github.com/void-linux/void-packages/pull/40415.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-40415.patch --]
[-- Type: text/x-diff, Size: 1770 bytes --]
From 0fb1c340d530053fc93a887fea4fe10790d40bb2 Mon Sep 17 00:00:00 2001
From: Relected <m7md11xd@gmail.com>
Date: Wed, 9 Nov 2022 17:09:03 +0200
Subject: [PATCH 1/2] updated dep
---
srcpkgs/flowblade/template | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/srcpkgs/flowblade/template b/srcpkgs/flowblade/template
index f1a43ae189ed..b9596131c7c4 100644
--- a/srcpkgs/flowblade/template
+++ b/srcpkgs/flowblade/template
@@ -7,8 +7,7 @@ build_style=python3-module
make_install_args="--install-lib=${DESTDIR}/usr/share/flowblade"
hostmakedepends="python3-setuptools"
# https://github.com/jliljebl/flowblade/blob/master/flowblade-trunk/docs/DEPENDENCIES.md
-depends="frei0r-plugins gmic mlt-python3 python3-Pillow python3-dbus gtk+3
- python3-gobject python3-numpy swh-plugins"
+depends="frei0r-plugins gmic libgirepository librsvg mlt-data mlt-python3 python3-Pillow python3-dbus gtk+3 python3-gobject python3-numpy sox swh-plugins"
short_desc="Non-linear video editor for Linux"
maintainer="shizonic <realtiaz@gmail.com>"
license="GPL-3.0-or-later"
From 7485a30e78806f7e581d614d4f1055bd879b8159 Mon Sep 17 00:00:00 2001
From: Relected <m7md11xd@gmail.com>
Date: Wed, 9 Nov 2022 18:08:32 +0200
Subject: [PATCH 2/2] flowblade: updated dependencies
---
srcpkgs/flowblade/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/flowblade/template b/srcpkgs/flowblade/template
index b9596131c7c4..677a3ee31e7e 100644
--- a/srcpkgs/flowblade/template
+++ b/srcpkgs/flowblade/template
@@ -1,7 +1,7 @@
# Template file for 'flowblade'
pkgname=flowblade
version=2.8.0.3
-revision=1
+revision=2
build_wrksrc=flowblade-trunk
build_style=python3-module
make_install_args="--install-lib=${DESTDIR}/usr/share/flowblade"
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR REVIEW] flowblade: updated dependencies
2022-11-09 15:55 [PR PATCH] flowblade: updated dependencies Relected
` (2 preceding siblings ...)
2022-11-09 16:11 ` [PR PATCH] [Updated] " Relected
@ 2022-11-09 17:16 ` paper42
2022-12-16 15:45 ` [PR PATCH] [Updated] " Relected
2022-12-16 15:46 ` [PR PATCH] [Closed]: " Relected
5 siblings, 0 replies; 7+ messages in thread
From: paper42 @ 2022-11-09 17:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40415#discussion_r1018213572
Comment:
> > I don't see a reason for this, all of the added dependencies are already dependencies through a package that's already in $depends.
>
> ok but flowblade was not launching and it was saying that module "mlt "was missing, then after installing mlt-python3 it also said that module "gi" was missing, which could be fixed by installing libgirepository
`mlt-python3` is already a dependency, I have no idea how you could install `flowblade` without `mlt-python3` getting installed as a dependency. `gi` missing means you were missing python3-gobject which is also already a dependency.
> also librsvg mlt-data and sox were also on the dependency page of flowblade so i added them as well while i was at it
All of these are already dependencies, just not directly.
> > commit message is wrong and $revision should be increased
>
> my bad, im going to fix that quickly
Please read CONTRIBUTING.md, this PR should contain only one commit because it touches only one package.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR PATCH] [Updated] flowblade: updated dependencies
2022-11-09 15:55 [PR PATCH] flowblade: updated dependencies Relected
` (3 preceding siblings ...)
2022-11-09 17:16 ` [PR REVIEW] " paper42
@ 2022-12-16 15:45 ` Relected
2022-12-16 15:46 ` [PR PATCH] [Closed]: " Relected
5 siblings, 0 replies; 7+ messages in thread
From: Relected @ 2022-12-16 15:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
There is an updated pull request by Relected against master on the void-packages repository
https://github.com/Relected/void-packages master
https://github.com/void-linux/void-packages/pull/40415
flowblade: updated dependencies
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
-->
Notes: updated dependencies to meet new requirements and avoid potential confusion, nothing major.
A patch file from https://github.com/void-linux/void-packages/pull/40415.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-40415.patch --]
[-- Type: text/x-diff, Size: 1770 bytes --]
From 0fb1c340d530053fc93a887fea4fe10790d40bb2 Mon Sep 17 00:00:00 2001
From: Relected <m7md11xd@gmail.com>
Date: Wed, 9 Nov 2022 17:09:03 +0200
Subject: [PATCH 1/2] updated dep
---
srcpkgs/flowblade/template | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/srcpkgs/flowblade/template b/srcpkgs/flowblade/template
index f1a43ae189ed..b9596131c7c4 100644
--- a/srcpkgs/flowblade/template
+++ b/srcpkgs/flowblade/template
@@ -7,8 +7,7 @@ build_style=python3-module
make_install_args="--install-lib=${DESTDIR}/usr/share/flowblade"
hostmakedepends="python3-setuptools"
# https://github.com/jliljebl/flowblade/blob/master/flowblade-trunk/docs/DEPENDENCIES.md
-depends="frei0r-plugins gmic mlt-python3 python3-Pillow python3-dbus gtk+3
- python3-gobject python3-numpy swh-plugins"
+depends="frei0r-plugins gmic libgirepository librsvg mlt-data mlt-python3 python3-Pillow python3-dbus gtk+3 python3-gobject python3-numpy sox swh-plugins"
short_desc="Non-linear video editor for Linux"
maintainer="shizonic <realtiaz@gmail.com>"
license="GPL-3.0-or-later"
From 7485a30e78806f7e581d614d4f1055bd879b8159 Mon Sep 17 00:00:00 2001
From: Relected <m7md11xd@gmail.com>
Date: Wed, 9 Nov 2022 18:08:32 +0200
Subject: [PATCH 2/2] flowblade: updated dependencies
---
srcpkgs/flowblade/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/flowblade/template b/srcpkgs/flowblade/template
index b9596131c7c4..677a3ee31e7e 100644
--- a/srcpkgs/flowblade/template
+++ b/srcpkgs/flowblade/template
@@ -1,7 +1,7 @@
# Template file for 'flowblade'
pkgname=flowblade
version=2.8.0.3
-revision=1
+revision=2
build_wrksrc=flowblade-trunk
build_style=python3-module
make_install_args="--install-lib=${DESTDIR}/usr/share/flowblade"
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR PATCH] [Closed]: flowblade: updated dependencies
2022-11-09 15:55 [PR PATCH] flowblade: updated dependencies Relected
` (4 preceding siblings ...)
2022-12-16 15:45 ` [PR PATCH] [Updated] " Relected
@ 2022-12-16 15:46 ` Relected
5 siblings, 0 replies; 7+ messages in thread
From: Relected @ 2022-12-16 15:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 448 bytes --]
There's a closed pull request on the void-packages repository
flowblade: updated dependencies
https://github.com/void-linux/void-packages/pull/40415
Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
-->
Notes: updated dependencies to meet new requirements and avoid potential confusion, nothing major.
^ permalink raw reply [flat|nested] 7+ messages in thread