[PR PATCH] python3: skip more tests

[PR PATCH] python3: skip more tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

There is a new pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages py3t
https://github.com/void-linux/void-packages/pull/41983

python3: skip more tests
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-musl)

@ahesford These tests fail for me on musl with `XBPS_CHECK_PKGS=yes`.
is it ok to exclude them, so that I can look for new failures related to openssl3?

A patch file from https://github.com/void-linux/void-packages/pull/41983.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-py3t-41983.patch --]
[-- Type: text/x-diff, Size: 2434 bytes --]

From 3efb1503803d69a69fc28b47d5f172eac824839b Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Mon, 30 Jan 2023 17:17:14 -0500
Subject: [PATCH] python3: skip more tests

---
 srcpkgs/python3/template | 34 ++++++++++++++++++----------------
 1 file changed, 18 insertions(+), 16 deletions(-)

diff --git a/srcpkgs/python3/template b/srcpkgs/python3/template
index 972a3cf5a2ec..38c4d10fec19 100644
--- a/srcpkgs/python3/template
+++ b/srcpkgs/python3/template
@@ -73,23 +73,25 @@ do_configure() {
 }
 
 do_check() {
+	local _fail
+
 	# Tests ignored due to expected failures:
-	# test_chown_*: relies on sane group membership not found in xbps-src
-	# test_getspnam_exception: expects shadow passwd db unreadable by user
-	# test_find_library_with_*: expects functionality patched out for musl
-	# test_openssl_version: LibreSSL version and OpenSSL_version_num disagree
-	# test_shared_ciphers: SSL advertises unexpected ciphers
-	# test_freeze_simple_script: requires in-tree expat, which we removed
-	#
-	# Test ignored due to failures for unknown reasons:
-	# test_session*: anomalies in SSL session handling
-	# test_localtime_daylight_*_dst_true: overflow in datetime.time.mktime
-	local opts="-i test_chown_* -i test_getspnam_exception \
-		-i test_find_library_with_* -i test_openssl_version \
-		-i test_shared_ciphers -i test_session* \
-		-i test_localtime_daylight_*_dst_true \
-		-i test_freeze_simple_script"
-	make ${makejobs} EXTRATESTOPTS="${opts}" quicktest
+	_fail="test_chown_*" # relies on sane group membership not found in xbps-src
+	_fail="$_fail test_getspnam_exception" # expects shadow passwd db unreadable by user
+	_fail="$_fail test_find_library_with_*" # expects functionality patched out for musl
+	_fail="$_fail test_openssl_version" # LibreSSL version and OpenSSL_version_num disagree
+	_fail="$_fail test_shared_ciphers" # SSL advertises unexpected ciphers
+	_fail="$_fail test_freeze_simple_script" # requires in-tree expat, which we removed
+
+	# musl failures:
+	_fail="$_fail test__locale test_c_locale_coercion test_locale test_os test_re"
+
+	# Tests ignored due to failures for unknown reasons:
+	_fail="$_fail test_ctypes test_tools"
+	_fail="$_fail test_session*" # anomalies in SSL session handling
+	_fail="$_fail test_localtime_daylight_*_dst_true" # overflow in datetime.time.mktime
+
+	make quicktest TESTOPTS="${makejobs} --exclude ${_fail}"
 }
 
 do_install() {

Re: python3: skip more tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/41983#issuecomment-1409446808

Comment:
#37681 

Re: [PR PATCH] [Updated] python3: skip more tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages py3t
https://github.com/void-linux/void-packages/pull/41983

python3: skip more tests
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-musl)

@ahesford These tests fail for me on musl with `XBPS_CHECK_PKGS=yes`.
is it ok to exclude them, so that I can look for new failures related to openssl3?

A patch file from https://github.com/void-linux/void-packages/pull/41983.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-py3t-41983.patch --]
[-- Type: text/x-diff, Size: 2487 bytes --]

From 9942845b3e9d9659f89cef49023ba8b02b475b5f Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Mon, 30 Jan 2023 17:17:14 -0500
Subject: [PATCH] python3: skip more tests

---
 srcpkgs/python3/template | 37 +++++++++++++++++++++----------------
 1 file changed, 21 insertions(+), 16 deletions(-)

diff --git a/srcpkgs/python3/template b/srcpkgs/python3/template
index 972a3cf5a2ec..88852170a9cd 100644
--- a/srcpkgs/python3/template
+++ b/srcpkgs/python3/template
@@ -73,23 +73,28 @@ do_configure() {
 }
 
 do_check() {
+	local _fail
+
 	# Tests ignored due to expected failures:
-	# test_chown_*: relies on sane group membership not found in xbps-src
-	# test_getspnam_exception: expects shadow passwd db unreadable by user
-	# test_find_library_with_*: expects functionality patched out for musl
-	# test_openssl_version: LibreSSL version and OpenSSL_version_num disagree
-	# test_shared_ciphers: SSL advertises unexpected ciphers
-	# test_freeze_simple_script: requires in-tree expat, which we removed
-	#
-	# Test ignored due to failures for unknown reasons:
-	# test_session*: anomalies in SSL session handling
-	# test_localtime_daylight_*_dst_true: overflow in datetime.time.mktime
-	local opts="-i test_chown_* -i test_getspnam_exception \
-		-i test_find_library_with_* -i test_openssl_version \
-		-i test_shared_ciphers -i test_session* \
-		-i test_localtime_daylight_*_dst_true \
-		-i test_freeze_simple_script"
-	make ${makejobs} EXTRATESTOPTS="${opts}" quicktest
+	_fail="test_chown_*" # relies on sane group membership not found in xbps-src
+	_fail="$_fail test_getspnam_exception" # expects shadow passwd db unreadable by user
+	_fail="$_fail test_find_library_with_*" # expects functionality patched out for musl
+	_fail="$_fail test_openssl_version" # LibreSSL version and OpenSSL_version_num disagree
+	_fail="$_fail test_shared_ciphers" # SSL advertises unexpected ciphers
+	_fail="$_fail test_freeze_simple_script" # requires in-tree expat, which we removed
+
+	# musl failures:
+	_fail="$_fail test__locale test_c_locale_coercion test_locale test_os test_re"
+
+	# Tests ignored due to failures for unknown reasons:
+	_fail="$_fail test_ctypes test_tools"
+	_fail="$_fail test_session*" # anomalies in SSL session handling
+	_fail="$_fail test_localtime_daylight_*_dst_true" # overflow in datetime.time.mktime
+
+	# aarch64 failure:
+	_fail="$_fail test_spwd"
+
+	make quicktest TESTOPTS="${makejobs} --exclude ${_fail}"
 }
 
 do_install() {

Re: python3: skip more tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/41983#issuecomment-1409530181

Comment:
one more failure on aarch64 with XBPS_CHECK_PKGS=full

Re: [PR REVIEW] python3: skip more tests

[paper42]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41983#discussion_r1091283124

Comment:
disable these tests conditionally

Re: [PR REVIEW] python3: skip more tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New review comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/41983#discussion_r1091344841

Comment:
Done.

Re: [PR PATCH] [Updated] python3: skip more tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages py3t
https://github.com/void-linux/void-packages/pull/41983

python3: skip more tests
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-musl)

@ahesford These tests fail for me on musl with `XBPS_CHECK_PKGS=yes`.
is it ok to exclude them, so that I can look for new failures related to openssl3?

A patch file from https://github.com/void-linux/void-packages/pull/41983.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-py3t-41983.patch --]
[-- Type: text/x-diff, Size: 2541 bytes --]

From 69c656d43262a1b8dc2dab9a3ff24697bad45742 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Mon, 30 Jan 2023 17:17:14 -0500
Subject: [PATCH] python3: skip more tests

---
 srcpkgs/python3/template | 39 +++++++++++++++++++++++----------------
 1 file changed, 23 insertions(+), 16 deletions(-)

diff --git a/srcpkgs/python3/template b/srcpkgs/python3/template
index 972a3cf5a2ec..a667fde5934d 100644
--- a/srcpkgs/python3/template
+++ b/srcpkgs/python3/template
@@ -73,23 +73,30 @@ do_configure() {
 }
 
 do_check() {
+	local _fail
+
 	# Tests ignored due to expected failures:
-	# test_chown_*: relies on sane group membership not found in xbps-src
-	# test_getspnam_exception: expects shadow passwd db unreadable by user
-	# test_find_library_with_*: expects functionality patched out for musl
-	# test_openssl_version: LibreSSL version and OpenSSL_version_num disagree
-	# test_shared_ciphers: SSL advertises unexpected ciphers
-	# test_freeze_simple_script: requires in-tree expat, which we removed
-	#
-	# Test ignored due to failures for unknown reasons:
-	# test_session*: anomalies in SSL session handling
-	# test_localtime_daylight_*_dst_true: overflow in datetime.time.mktime
-	local opts="-i test_chown_* -i test_getspnam_exception \
-		-i test_find_library_with_* -i test_openssl_version \
-		-i test_shared_ciphers -i test_session* \
-		-i test_localtime_daylight_*_dst_true \
-		-i test_freeze_simple_script"
-	make ${makejobs} EXTRATESTOPTS="${opts}" quicktest
+	_fail="test_chown_*" # relies on sane group membership not found in xbps-src
+	_fail="$_fail test_getspnam_exception" # expects shadow passwd db unreadable by user
+	_fail="$_fail test_find_library_with_*" # expects functionality patched out for musl
+	_fail="$_fail test_openssl_version" # LibreSSL version and OpenSSL_version_num disagree
+	_fail="$_fail test_shared_ciphers" # SSL advertises unexpected ciphers
+	_fail="$_fail test_freeze_simple_script" # requires in-tree expat, which we removed
+
+	# musl failures:
+	if [ "${XBPS_TARGET_LIBC}" = "musl" ]; then
+		_fail="$_fail test__locale test_c_locale_coercion test_locale test_os test_re"
+	fi
+
+	# Tests ignored due to failures for unknown reasons:
+	_fail="$_fail test_ctypes test_tools"
+	_fail="$_fail test_session*" # anomalies in SSL session handling
+	_fail="$_fail test_localtime_daylight_*_dst_true" # overflow in datetime.time.mktime
+
+	# aarch64 failure:
+	_fail="$_fail test_spwd"
+
+	make quicktest TESTOPTS="${makejobs} --exclude ${_fail}"
 }
 
 do_install() {

Re: python3: skip more tests

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/41983#issuecomment-1416831750

Comment:
Some of the tests you added were required because you changed the means by which tests were ignored and the globs no longer worked. Ignoring `os` and `re` tests is a pretty heavy solution that we can avoid with more targeted exclusions. In 82e468a29d7ff0df06abf32107626c0610f53804 I pushed some changes that make checks pass for me on `x86_64{,-musl}` and `i686`.

If you encounter other tests that get in the way of your OpenSSL work, please amend this PR to reconcile differences with the current state of the template.

Re: python3: skip more tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/41983#issuecomment-1419632160

Comment:
This is also fine, thanks. It now passes tests on x86_64-musl and aarch64, as well as with openssl3.

Re: [PR PATCH] [Closed]: python3: skip more tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

There's a closed pull request on the void-packages repository

python3: skip more tests
https://github.com/void-linux/void-packages/pull/41983

Description:
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-musl)

@ahesford These tests fail for me on musl with `XBPS_CHECK_PKGS=yes`.
is it ok to exclude them, so that I can look for new failures related to openssl3?