* [PR PATCH] gnumeric: remove useless vsed.
@ 2023-03-09 18:00 mhmdanas
2023-03-09 18:26 ` [PR PATCH] [Updated] " mhmdanas
2023-03-11 7:28 ` [PR PATCH] [Merged]: " classabbyamp
0 siblings, 2 replies; 3+ messages in thread
From: mhmdanas @ 2023-03-09 18:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]
There is a new pull request by mhmdanas against master on the void-packages repository
https://github.com/mhmdanas/void-packages gnumeric-remove-useless-vsed
https://github.com/void-linux/void-packages/pull/42678
gnumeric: remove useless vsed.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
@Duncaen
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/42678.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnumeric-remove-useless-vsed-42678.patch --]
[-- Type: text/x-diff, Size: 828 bytes --]
From 51e7312658b9a159ea90e2de8b9f3250f2f64a63 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 9 Mar 2023 17:41:33 +0000
Subject: [PATCH] gnumeric: remove useless vsed.
---
srcpkgs/gnumeric/template | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/srcpkgs/gnumeric/template b/srcpkgs/gnumeric/template
index bb5db0bfb433..b8d1cf9cc4c4 100644
--- a/srcpkgs/gnumeric/template
+++ b/srcpkgs/gnumeric/template
@@ -22,12 +22,8 @@ if [ "$CROSS_BUILD" ]; then
configure_args+=" --without-perl"
fi
-post_patch() {
- vsed -i -e 's/DATADIRNAME=lib/DATADIRNAME=share/' configure
-}
-
gnumeric-devel_package() {
- depends="gnumeric>=${version}_${revision}"
+ depends="${sourcepkg}>=${version}_${revision}"
short_desc+=" - development files"
pkg_install() {
vmove usr/include
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PR PATCH] [Updated] gnumeric: remove useless vsed.
2023-03-09 18:00 [PR PATCH] gnumeric: remove useless vsed mhmdanas
@ 2023-03-09 18:26 ` mhmdanas
2023-03-11 7:28 ` [PR PATCH] [Merged]: " classabbyamp
1 sibling, 0 replies; 3+ messages in thread
From: mhmdanas @ 2023-03-09 18:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
There is an updated pull request by mhmdanas against master on the void-packages repository
https://github.com/mhmdanas/void-packages gnumeric-remove-useless-vsed
https://github.com/void-linux/void-packages/pull/42678
gnumeric: remove useless vsed.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
@Duncaen
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/42678.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnumeric-remove-useless-vsed-42678.patch --]
[-- Type: text/x-diff, Size: 1235 bytes --]
From 8d1d0729a27fd8ce31d431a85ef98aa78822fe83 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 9 Mar 2023 17:41:33 +0000
Subject: [PATCH] gnumeric: remove useless vsed.
---
srcpkgs/gnumeric/template | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/gnumeric/template b/srcpkgs/gnumeric/template
index bb5db0bfb433..e4bdab9765df 100644
--- a/srcpkgs/gnumeric/template
+++ b/srcpkgs/gnumeric/template
@@ -12,6 +12,8 @@ homepage="http://gnumeric.org/"
changelog="https://github.com/GNOME/gnumeric/raw/master/NEWS"
distfiles="${GNOME_SITE}/gnumeric/${version%.*}/gnumeric-${version}.tar.xz"
checksum=c69a09cd190b622acca476bbc3d4c03d68d7ccf59bba61bf036ce60885f9fb65
+# FIXME: many tests fail.
+make_check=no
# This isn't a direct dependency but when soname bumping perl it will
# cause build failures
@@ -22,12 +24,8 @@ if [ "$CROSS_BUILD" ]; then
configure_args+=" --without-perl"
fi
-post_patch() {
- vsed -i -e 's/DATADIRNAME=lib/DATADIRNAME=share/' configure
-}
-
gnumeric-devel_package() {
- depends="gnumeric>=${version}_${revision}"
+ depends="${sourcepkg}>=${version}_${revision}"
short_desc+=" - development files"
pkg_install() {
vmove usr/include
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PR PATCH] [Merged]: gnumeric: remove useless vsed.
2023-03-09 18:00 [PR PATCH] gnumeric: remove useless vsed mhmdanas
2023-03-09 18:26 ` [PR PATCH] [Updated] " mhmdanas
@ 2023-03-11 7:28 ` classabbyamp
1 sibling, 0 replies; 3+ messages in thread
From: classabbyamp @ 2023-03-11 7:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]
There's a merged pull request on the void-packages repository
gnumeric: remove useless vsed.
https://github.com/void-linux/void-packages/pull/42678
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
@Duncaen
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-11 7:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-09 18:00 [PR PATCH] gnumeric: remove useless vsed mhmdanas
2023-03-09 18:26 ` [PR PATCH] [Updated] " mhmdanas
2023-03-11 7:28 ` [PR PATCH] [Merged]: " classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).