[PR PATCH] new package: moar

[PR PATCH] new package: moar

[DiegoMagdaleno]

[-- Attachment #1: Type: text/plain, Size: 741 bytes --]

There is a new pull request by DiegoMagdaleno against master on the void-packages repository

https://github.com/DiegoMagdaleno/void-packages master
https://github.com/void-linux/void-packages/pull/43142

new package: moar
Uncomment relevant sections and delete options which are not applicable

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc )

A patch file from https://github.com/void-linux/void-packages/pull/43142.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-43142.patch --]
[-- Type: text/x-diff, Size: 1793 bytes --]

From 6c6b66c8aa5df01a9a1c1a9af21478d060dbffe4 Mon Sep 17 00:00:00 2001
From: Diego Magdaleno <38844659+DiegoMagdaleno@users.noreply.github.com>
Date: Fri, 31 Mar 2023 08:40:06 -0600
Subject: [PATCH 1/2] Add moar package

---
 srcpkgs/moar/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/moar/template

diff --git a/srcpkgs/moar/template b/srcpkgs/moar/template
new file mode 100644
index 000000000000..cec35536519e
--- /dev/null
+++ b/srcpkgs/moar/template
@@ -0,0 +1,14 @@
+# Template file for 'moar'
+pkgname=moar
+version=1.13.0
+revision=0
+build_style=go
+go_import_path=github.com/walles/moar
+hostmakedepends="git"
+short_desc="Drop-in replacement for the less pager"
+maintainer="Diego Magdaleno <diegomagdaleno@pm.me>"
+license="BSD"
+homepage="https://github.com/walles/moar"
+changelog="https://github.com/waller/moar/releases"
+distfiles="https://github.com/walles/moar/archive/refs/tags/v${version}.tar.gz"
+checksum=65eac0d4f8a40f0198a93f0888a60a28e8466b2ee9d0437f143db5c25d5e9319

From 95b007d4bed81b0e4e879f0c0a7dae48497d751f Mon Sep 17 00:00:00 2001
From: Diego Magdaleno <38844659+DiegoMagdaleno@users.noreply.github.com>
Date: Fri, 31 Mar 2023 08:55:32 -0600
Subject: [PATCH 2/2] Install man pages

---
 srcpkgs/moar/template | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/srcpkgs/moar/template b/srcpkgs/moar/template
index cec35536519e..5e7f5932e701 100644
--- a/srcpkgs/moar/template
+++ b/srcpkgs/moar/template
@@ -12,3 +12,7 @@ homepage="https://github.com/walles/moar"
 changelog="https://github.com/waller/moar/releases"
 distfiles="https://github.com/walles/moar/archive/refs/tags/v${version}.tar.gz"
 checksum=65eac0d4f8a40f0198a93f0888a60a28e8466b2ee9d0437f143db5c25d5e9319
+
+post_install() {
+  vman moar.1
+}

Re: new package: moar

[abenson]

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43142#issuecomment-1492080081

Comment:
Please [squash the commits](https://www.git-tower.com/learn/git/faq/git-squash) into a single commit, [amend the commit message](https://www.atlassian.com/git/tutorials/rewriting-history) to "New package: moar-1.13.0" and force push (`git push -f`) when done.

Re: [PR REVIEW] new package: moar

[abenson]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43142#discussion_r1154592658

Comment:
`revision` should start at 1.

Re: [PR REVIEW] new package: moar

[paper42]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43142#discussion_r1154592208

Comment:
why is this necessary?

Re: [PR REVIEW] new package: moar

[abenson]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43142#discussion_r1154594738

Comment:
`BSD-2-Clause`

Re: [PR REVIEW] new package: moar

[abenson]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43142#discussion_r1154595066

Comment:
Need to include the license.

`vlicense LICENSE`

Re: [PR REVIEW] new package: moar

[abenson]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43142#discussion_r1154598227

Comment:
Remove the `hostmakedepends` line.

Add `go_ldfags="-X main.versionString=${version}"`

Re: [PR PATCH] [Updated] new package: moar

[DiegoMagdaleno]

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

There is an updated pull request by DiegoMagdaleno against master on the void-packages repository

https://github.com/DiegoMagdaleno/void-packages master
https://github.com/void-linux/void-packages/pull/43142

new package: moar
Uncomment relevant sections and delete options which are not applicable

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc )

A patch file from https://github.com/void-linux/void-packages/pull/43142.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-43142.patch --]
[-- Type: text/x-diff, Size: 2952 bytes --]

From 6c6b66c8aa5df01a9a1c1a9af21478d060dbffe4 Mon Sep 17 00:00:00 2001
From: Diego Magdaleno <38844659+DiegoMagdaleno@users.noreply.github.com>
Date: Fri, 31 Mar 2023 08:40:06 -0600
Subject: [PATCH 1/3] Add moar package

---
 srcpkgs/moar/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/moar/template

diff --git a/srcpkgs/moar/template b/srcpkgs/moar/template
new file mode 100644
index 000000000000..cec35536519e
--- /dev/null
+++ b/srcpkgs/moar/template
@@ -0,0 +1,14 @@
+# Template file for 'moar'
+pkgname=moar
+version=1.13.0
+revision=0
+build_style=go
+go_import_path=github.com/walles/moar
+hostmakedepends="git"
+short_desc="Drop-in replacement for the less pager"
+maintainer="Diego Magdaleno <diegomagdaleno@pm.me>"
+license="BSD"
+homepage="https://github.com/walles/moar"
+changelog="https://github.com/waller/moar/releases"
+distfiles="https://github.com/walles/moar/archive/refs/tags/v${version}.tar.gz"
+checksum=65eac0d4f8a40f0198a93f0888a60a28e8466b2ee9d0437f143db5c25d5e9319

From 95b007d4bed81b0e4e879f0c0a7dae48497d751f Mon Sep 17 00:00:00 2001
From: Diego Magdaleno <38844659+DiegoMagdaleno@users.noreply.github.com>
Date: Fri, 31 Mar 2023 08:55:32 -0600
Subject: [PATCH 2/3] Install man pages

---
 srcpkgs/moar/template | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/srcpkgs/moar/template b/srcpkgs/moar/template
index cec35536519e..5e7f5932e701 100644
--- a/srcpkgs/moar/template
+++ b/srcpkgs/moar/template
@@ -12,3 +12,7 @@ homepage="https://github.com/walles/moar"
 changelog="https://github.com/waller/moar/releases"
 distfiles="https://github.com/walles/moar/archive/refs/tags/v${version}.tar.gz"
 checksum=65eac0d4f8a40f0198a93f0888a60a28e8466b2ee9d0437f143db5c25d5e9319
+
+post_install() {
+  vman moar.1
+}

From 93045e80fd495bffad57eac4385ec65388a80ecb Mon Sep 17 00:00:00 2001
From: Diego Magdaleno <diegomagdaleno@protonmail.com>
Date: Fri, 31 Mar 2023 18:39:24 -0600
Subject: [PATCH 3/3] [Fix] Apply the suggested fixes

---
 srcpkgs/moar/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/moar/template b/srcpkgs/moar/template
index 5e7f5932e701..03921fee8908 100644
--- a/srcpkgs/moar/template
+++ b/srcpkgs/moar/template
@@ -1,13 +1,13 @@
 # Template file for 'moar'
 pkgname=moar
 version=1.13.0
-revision=0
+revision=1
 build_style=go
 go_import_path=github.com/walles/moar
-hostmakedepends="git"
+go_ldflags="-X main.versionString=${version}"
 short_desc="Drop-in replacement for the less pager"
 maintainer="Diego Magdaleno <diegomagdaleno@pm.me>"
-license="BSD"
+license="BSD-2-Clause"
 homepage="https://github.com/walles/moar"
 changelog="https://github.com/waller/moar/releases"
 distfiles="https://github.com/walles/moar/archive/refs/tags/v${version}.tar.gz"
@@ -15,4 +15,5 @@ checksum=65eac0d4f8a40f0198a93f0888a60a28e8466b2ee9d0437f143db5c25d5e9319
 
 post_install() {
   vman moar.1
+  vlicense LICENSE
 }

Re: [PR PATCH] [Updated] new package: moar

[DiegoMagdaleno]

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

There is an updated pull request by DiegoMagdaleno against master on the void-packages repository

https://github.com/DiegoMagdaleno/void-packages master
https://github.com/void-linux/void-packages/pull/43142

new package: moar
Uncomment relevant sections and delete options which are not applicable

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc )

A patch file from https://github.com/void-linux/void-packages/pull/43142.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-43142.patch --]
[-- Type: text/x-diff, Size: 1119 bytes --]

From c928d8638d01750fdd25e8266e35cf84821a1f1e Mon Sep 17 00:00:00 2001
From: Diego Magdaleno <diegomagdaleno@protonmail.com>
Date: Fri, 31 Mar 2023 18:42:06 -0600
Subject: [PATCH] New package: moar-1.13.0

---
 srcpkgs/moar/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/moar/template

diff --git a/srcpkgs/moar/template b/srcpkgs/moar/template
new file mode 100644
index 000000000000..03921fee8908
--- /dev/null
+++ b/srcpkgs/moar/template
@@ -0,0 +1,19 @@
+# Template file for 'moar'
+pkgname=moar
+version=1.13.0
+revision=1
+build_style=go
+go_import_path=github.com/walles/moar
+go_ldflags="-X main.versionString=${version}"
+short_desc="Drop-in replacement for the less pager"
+maintainer="Diego Magdaleno <diegomagdaleno@pm.me>"
+license="BSD-2-Clause"
+homepage="https://github.com/walles/moar"
+changelog="https://github.com/waller/moar/releases"
+distfiles="https://github.com/walles/moar/archive/refs/tags/v${version}.tar.gz"
+checksum=65eac0d4f8a40f0198a93f0888a60a28e8466b2ee9d0437f143db5c25d5e9319
+
+post_install() {
+  vman moar.1
+  vlicense LICENSE
+}

Re: new package: moar

[DiegoMagdaleno]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by DiegoMagdaleno on void-packages repository

https://github.com/void-linux/void-packages/pull/43142#issuecomment-1492761363

Comment:
I have successfully squashed the commits and applied the suggested changes :)

Re: new package: moar

[atweiden]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New comment by atweiden on void-packages repository

https://github.com/void-linux/void-packages/pull/43142#issuecomment-1493256695

Comment:
`/usr/bin/moar` conflicts with the same from MoarVM.

Re: new package: moar

[DiegoMagdaleno]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New comment by DiegoMagdaleno on void-packages repository

https://github.com/void-linux/void-packages/pull/43142#issuecomment-1497593800

Comment:
@atweiden How would you fix said issue? Adding it as a conflicts or changing the binary name?

Re: new package: moar

[atweiden]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New comment by atweiden on void-packages repository

https://github.com/void-linux/void-packages/pull/43142#issuecomment-1498284570

Comment:
I’d prefer doing `conflicts=MoarVM`. Keep the binary name — `/usr/bin/moar` is a good one.

Re: [PR PATCH] [Updated] new package: moar

[DiegoMagdaleno]

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

There is an updated pull request by DiegoMagdaleno against master on the void-packages repository

https://github.com/DiegoMagdaleno/void-packages master
https://github.com/void-linux/void-packages/pull/43142

new package: moar
Uncomment relevant sections and delete options which are not applicable

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc )

A patch file from https://github.com/void-linux/void-packages/pull/43142.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-43142.patch --]
[-- Type: text/x-diff, Size: 2041 bytes --]

From c928d8638d01750fdd25e8266e35cf84821a1f1e Mon Sep 17 00:00:00 2001
From: Diego Magdaleno <diegomagdaleno@protonmail.com>
Date: Fri, 31 Mar 2023 18:42:06 -0600
Subject: [PATCH 1/2] New package: moar-1.13.0

---
 srcpkgs/moar/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/moar/template

diff --git a/srcpkgs/moar/template b/srcpkgs/moar/template
new file mode 100644
index 000000000000..03921fee8908
--- /dev/null
+++ b/srcpkgs/moar/template
@@ -0,0 +1,19 @@
+# Template file for 'moar'
+pkgname=moar
+version=1.13.0
+revision=1
+build_style=go
+go_import_path=github.com/walles/moar
+go_ldflags="-X main.versionString=${version}"
+short_desc="Drop-in replacement for the less pager"
+maintainer="Diego Magdaleno <diegomagdaleno@pm.me>"
+license="BSD-2-Clause"
+homepage="https://github.com/walles/moar"
+changelog="https://github.com/waller/moar/releases"
+distfiles="https://github.com/walles/moar/archive/refs/tags/v${version}.tar.gz"
+checksum=65eac0d4f8a40f0198a93f0888a60a28e8466b2ee9d0437f143db5c25d5e9319
+
+post_install() {
+  vman moar.1
+  vlicense LICENSE
+}

From 1e2a17dfbbb943812c8f6904be0ca0d471daf0aa Mon Sep 17 00:00:00 2001
From: Diego Magdaleno <diegomagdaleno@protonmail.com>
Date: Thu, 6 Apr 2023 09:36:10 -0600
Subject: [PATCH 2/2] [Fix] Apply the suggested fixes

---
 srcpkgs/moar/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/moar/template b/srcpkgs/moar/template
index 03921fee8908..f42ad560e112 100644
--- a/srcpkgs/moar/template
+++ b/srcpkgs/moar/template
@@ -10,10 +10,11 @@ maintainer="Diego Magdaleno <diegomagdaleno@pm.me>"
 license="BSD-2-Clause"
 homepage="https://github.com/walles/moar"
 changelog="https://github.com/waller/moar/releases"
+conflicts="MoarVM"
 distfiles="https://github.com/walles/moar/archive/refs/tags/v${version}.tar.gz"
 checksum=65eac0d4f8a40f0198a93f0888a60a28e8466b2ee9d0437f143db5c25d5e9319
 
 post_install() {
-  vman moar.1
-  vlicense LICENSE
+	vman moar.1
+	vlicense LICENSE
 }

Re: [PR PATCH] [Updated] new package: moar

[DiegoMagdaleno]

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

There is an updated pull request by DiegoMagdaleno against master on the void-packages repository

https://github.com/DiegoMagdaleno/void-packages master
https://github.com/void-linux/void-packages/pull/43142

new package: moar
Uncomment relevant sections and delete options which are not applicable

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc )

A patch file from https://github.com/void-linux/void-packages/pull/43142.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-43142.patch --]
[-- Type: text/x-diff, Size: 1137 bytes --]

From b1b53abf95809d89c244689b67930d7757011ebb Mon Sep 17 00:00:00 2001
From: Diego Magdaleno <diegomagdaleno@protonmail.com>
Date: Thu, 6 Apr 2023 09:36:52 -0600
Subject: [PATCH] New package: moar-1.13.0

---
 srcpkgs/moar/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/moar/template

diff --git a/srcpkgs/moar/template b/srcpkgs/moar/template
new file mode 100644
index 000000000000..f42ad560e112
--- /dev/null
+++ b/srcpkgs/moar/template
@@ -0,0 +1,20 @@
+# Template file for 'moar'
+pkgname=moar
+version=1.13.0
+revision=1
+build_style=go
+go_import_path=github.com/walles/moar
+go_ldflags="-X main.versionString=${version}"
+short_desc="Drop-in replacement for the less pager"
+maintainer="Diego Magdaleno <diegomagdaleno@pm.me>"
+license="BSD-2-Clause"
+homepage="https://github.com/walles/moar"
+changelog="https://github.com/waller/moar/releases"
+conflicts="MoarVM"
+distfiles="https://github.com/walles/moar/archive/refs/tags/v${version}.tar.gz"
+checksum=65eac0d4f8a40f0198a93f0888a60a28e8466b2ee9d0437f143db5c25d5e9319
+
+post_install() {
+	vman moar.1
+	vlicense LICENSE
+}

Re: [PR PATCH] [Updated] new package: moar

[DiegoMagdaleno]

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

There is an updated pull request by DiegoMagdaleno against master on the void-packages repository

https://github.com/DiegoMagdaleno/void-packages master
https://github.com/void-linux/void-packages/pull/43142

new package: moar
Uncomment relevant sections and delete options which are not applicable

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc )

A patch file from https://github.com/void-linux/void-packages/pull/43142.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-43142.patch --]
[-- Type: text/x-diff, Size: 1137 bytes --]

From 1cdfe43a00ca0bd41d349aa433ad631e8d67fb6e Mon Sep 17 00:00:00 2001
From: Diego Magdaleno <diegomagdaleno@protonmail.com>
Date: Thu, 6 Apr 2023 09:40:03 -0600
Subject: [PATCH] New package: moar-1.13.0

---
 srcpkgs/moar/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/moar/template

diff --git a/srcpkgs/moar/template b/srcpkgs/moar/template
new file mode 100644
index 000000000000..381454967d4e
--- /dev/null
+++ b/srcpkgs/moar/template
@@ -0,0 +1,20 @@
+# Template file for 'moar'
+pkgname=moar
+version=1.13.0
+revision=1
+build_style=go
+go_import_path=github.com/walles/moar
+go_ldflags="-X main.versionString=${version}"
+short_desc="Drop-in replacement for the less pager"
+maintainer="Diego Magdaleno <diegomagdaleno@pm.me>"
+license="BSD-2-Clause"
+homepage="https://github.com/walles/moar"
+changelog="https://github.com/waller/moar/releases"
+distfiles="https://github.com/walles/moar/archive/refs/tags/v${version}.tar.gz"
+checksum=65eac0d4f8a40f0198a93f0888a60a28e8466b2ee9d0437f143db5c25d5e9319
+conflicts="MoarVM"
+
+post_install() {
+	vman moar.1
+	vlicense LICENSE
+}

Re: new package: moar

[DiegoMagdaleno]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New comment by DiegoMagdaleno on void-packages repository

https://github.com/void-linux/void-packages/pull/43142#issuecomment-1499406816

Comment:
I think the package doesn't have issues anymore :)

Re: [PR PATCH] [Merged]: new package: moar

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

There's a merged pull request on the void-packages repository

new package: moar
https://github.com/void-linux/void-packages/pull/43142

Description:
Uncomment relevant sections and delete options which are not applicable

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc )