[PR PATCH] common/build-helper/rust.sh: link to libgit2 and libsqlite3 dynamically

[PR PATCH] common/build-helper/rust.sh: link to libgit2 and libsqlite3 dynamically

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 973 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages build-style/cargo
https://github.com/void-linux/void-packages/pull/45462

common/build-helper/rust.sh: link to libgit2 and libsqlite3 dynamically
libgit2 upstream: https://github.com/rust-lang/git2-rs/commit/59a81cac9ada22b5ea6ca2841f5bd1229f1dd659
libsqlite3 upstream: https://github.com/rusqlite/rusqlite/commit/b4604f2421315040133717f48f616200e10507a8

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

Neither crates has a release since inclusion of these overrides so don't know what the testing strategy here. Probably one or two packages will have broken builds which needs the respective `-devel` packages in the `makedepends`.

A patch file from https://github.com/void-linux/void-packages/pull/45462.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-build-style/cargo-45462.patch --]
[-- Type: text/x-diff, Size: 904 bytes --]

From f66cf8fb6f7f5b17c3b6eb42681b2fb4cb9c35be Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Mon, 7 Aug 2023 01:04:55 +0530
Subject: [PATCH] common/build-helper/rust.sh: link to libgit2 and libsqlite3
 dynamically

libgit2 upstream: https://github.com/rust-lang/git2-rs/commit/59a81cac9ada22b5ea6ca2841f5bd1229f1dd659
libsqlite3 upstream: https://github.com/rusqlite/rusqlite/commit/b4604f2421315040133717f48f616200e10507a8
---
 common/build-helper/rust.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/common/build-helper/rust.sh b/common/build-helper/rust.sh
index f689f7c7f9d96..02d5af9638d5f 100644
--- a/common/build-helper/rust.sh
+++ b/common/build-helper/rust.sh
@@ -57,3 +57,9 @@ export ZSTD_SYS_USE_PKG_CONFIG=1
 
 # onig-sys
 export RUSTONIG_SYSTEM_LIBONIG=1
+
+# libsqlite3-sys
+export LIBSQLITE3_SYS_USE_PKG_CONFIG=1
+
+# libgit2-sys
+export LIBGIT2_NO_VENDOR=1

Re: common/build-helper/rust.sh: link to libgit2 and libsqlite3 dynamically

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/45462#issuecomment-1793604630

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Updated] common/build-helper/rust.sh: link to libgit2 and libsqlite3 dynamically

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 978 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages build-style/cargo
https://github.com/void-linux/void-packages/pull/45462

common/build-helper/rust.sh: link to libgit2 and libsqlite3 dynamically
libgit2 upstream: https://github.com/rust-lang/git2-rs/commit/59a81cac9ada22b5ea6ca2841f5bd1229f1dd659
libsqlite3 upstream: https://github.com/rusqlite/rusqlite/commit/b4604f2421315040133717f48f616200e10507a8

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

Neither crates has a release since inclusion of these overrides so don't know what the testing strategy here. Probably one or two packages will have broken builds which needs the respective `-devel` packages in the `makedepends`.

A patch file from https://github.com/void-linux/void-packages/pull/45462.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-build-style/cargo-45462.patch --]
[-- Type: text/x-diff, Size: 904 bytes --]

From 03ad71a109e32abcfaeddef102f64a6e00223aad Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Mon, 7 Aug 2023 01:04:55 +0530
Subject: [PATCH] common/build-helper/rust.sh: link to libgit2 and libsqlite3
 dynamically

libgit2 upstream: https://github.com/rust-lang/git2-rs/commit/59a81cac9ada22b5ea6ca2841f5bd1229f1dd659
libsqlite3 upstream: https://github.com/rusqlite/rusqlite/commit/b4604f2421315040133717f48f616200e10507a8
---
 common/build-helper/rust.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/common/build-helper/rust.sh b/common/build-helper/rust.sh
index 96ec351d545d9..5f2489c93ea95 100644
--- a/common/build-helper/rust.sh
+++ b/common/build-helper/rust.sh
@@ -61,3 +61,9 @@ export ZSTD_SYS_USE_PKG_CONFIG=1
 
 # onig-sys
 export RUSTONIG_SYSTEM_LIBONIG=1
+
+# libsqlite3-sys
+export LIBSQLITE3_SYS_USE_PKG_CONFIG=1
+
+# libgit2-sys
+export LIBGIT2_NO_VENDOR=1

Re: [PR PATCH] [Merged]: common/build-helper/rust.sh: link to libgit2 and libsqlite3 dynamically

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

There's a merged pull request on the void-packages repository

common/build-helper/rust.sh: link to libgit2 and libsqlite3 dynamically
https://github.com/void-linux/void-packages/pull/45462

Description:
libgit2 upstream: https://github.com/rust-lang/git2-rs/commit/59a81cac9ada22b5ea6ca2841f5bd1229f1dd659
libsqlite3 upstream: https://github.com/rusqlite/rusqlite/commit/b4604f2421315040133717f48f616200e10507a8

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

Neither crates has a release since inclusion of these overrides so don't know what the testing strategy here. Probably one or two packages will have broken builds which needs the respective `-devel` packages in the `makedepends`.