Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] qmk: depend on python3-pyserial
@ 2023-08-21  0:18 klardotsh
  2023-08-21  1:43 ` [PR PATCH] [Merged]: " sgn
  0 siblings, 1 reply; 2+ messages in thread
From: klardotsh @ 2023-08-21  0:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1802 bytes --]

There is a new pull request by klardotsh against master on the void-packages repository

https://github.com/klardotsh/void-packages klardotsh/qmk-pyserial
https://github.com/void-linux/void-packages/pull/45692

qmk: depend on python3-pyserial
#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

```
# Context: have qmk-1.1.2_1 installed, plus all of its deps

(woods) qmk_firmware  » klardotsh/main » qmk compile -kb boardsource/unicorne -km default
Could not find module pyserial!
Would you like to install the required Python modules? [y/n] n

Please run `/usr/bin/python3 -m pip install -r /home/j/src/mine/qmk_firmware/requirements.txt` to install required python dependencies.

# Installed python3-pyserial in another window...

(woods) qmk_firmware  » klardotsh/main » qmk compile -kb boardsource/unicorne -km default
Ψ Compiling keymap with make --jobs=1 boardsource/unicorne:default
...
```

A patch file from https://github.com/void-linux/void-packages/pull/45692.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-klardotsh/qmk-pyserial-45692.patch --]
[-- Type: text/x-diff, Size: 1150 bytes --]

From 13738bb619150bc2389e946cbcc8eb54c2aa3bee Mon Sep 17 00:00:00 2001
From: Josh Klar <josh@klar.sh>
Date: Sun, 20 Aug 2023 17:11:32 -0700
Subject: [PATCH] qmk: depend on python3-pyserial

---
 srcpkgs/qmk/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/qmk/template b/srcpkgs/qmk/template
index 45859116530b3..a87069fb820d6 100644
--- a/srcpkgs/qmk/template
+++ b/srcpkgs/qmk/template
@@ -1,7 +1,7 @@
 # Template file for 'qmk'
 pkgname=qmk
 version=1.1.2
-revision=1
+revision=2
 build_style=python3-pep517
 hostmakedepends="python3-wheel"
 # This includes the requirements from requirements.txt in the qmk_firmware
@@ -9,7 +9,7 @@ hostmakedepends="python3-wheel"
 depends="avr-gcc avrdude cross-arm-none-eabi dfu-programmer dfu-util
  python3-Pygments python3-appdirs python3-argcomplete python3-colorama
  python3-dotty-dict python3-hid python3-hjson python3-jsonschema python3-milc
- python3-nose2 python3-usb python3-yapf"
+ python3-nose2 python3-pyserial python3-usb python3-yapf"
 short_desc="Program to help users work with QMK Firmware"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: qmk: depend on python3-pyserial
  2023-08-21  0:18 [PR PATCH] qmk: depend on python3-pyserial klardotsh
@ 2023-08-21  1:43 ` sgn
  0 siblings, 0 replies; 2+ messages in thread
From: sgn @ 2023-08-21  1:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1632 bytes --]

There's a merged pull request on the void-packages repository

qmk: depend on python3-pyserial
https://github.com/void-linux/void-packages/pull/45692

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

```
# Context: have qmk-1.1.2_1 installed, plus all of its deps

(woods) qmk_firmware  » klardotsh/main » qmk compile -kb boardsource/unicorne -km default
Could not find module pyserial!
Would you like to install the required Python modules? [y/n] n

Please run `/usr/bin/python3 -m pip install -r /home/j/src/mine/qmk_firmware/requirements.txt` to install required python dependencies.

# Installed python3-pyserial in another window...

(woods) qmk_firmware  » klardotsh/main » qmk compile -kb boardsource/unicorne -km default
Ψ Compiling keymap with make --jobs=1 boardsource/unicorne:default
...
```

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-21  1:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-21  0:18 [PR PATCH] qmk: depend on python3-pyserial klardotsh
2023-08-21  1:43 ` [PR PATCH] [Merged]: " sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).