* Re: [PR PATCH] [Updated] ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
@ 2023-09-27 9:27 ` sogaiu
2023-09-27 10:08 ` sogaiu
` (24 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-27 9:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]
There is an updated pull request by sogaiu against master on the void-packages repository
https://github.com/sogaiu/void-packages update-ibus-hangul
https://github.com/void-linux/void-packages/pull/46271
ibus-hangul: update to 1.5.5
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
#### Notes
Apparently, [recent versions of Python no longer have `gettext.bind_textdomain_codeset`](https://docs.python.org/3.10/library/gettext.html#gettext.bind_textdomain_codeset).
For recent Pythons, ibus-hangul 1.5.3's `ibus-setup-hangul` can crash with:
```
$ ibus-setup-hangul
Traceback (most recent call last):
File "/usr/share/ibus-hangul/setup/main.py", line 298, in <module>
gettext.bind_textdomain_codeset(config.gettext_package, "UTF-8")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'gettext' has no attribute 'bind_textdomain_codeset'
```
A [PR for ibus-hangul to address this](https://github.com/libhangul/ibus-hangul/issues/93) was merged some time back and [the 1.5.4 release included the relevant code](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.4).
There was [another release (1.5.5)](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.5) since then and this PR is an update to that one.
A patch file from https://github.com/void-linux/void-packages/pull/46271.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-ibus-hangul-46271.patch --]
[-- Type: text/x-diff, Size: 1853 bytes --]
From 615948deae274c7e409ad95211a96ab582eb9f0b Mon Sep 17 00:00:00 2001
From: sogaiu <983021772@users.noreply.github.com>
Date: Wed, 27 Sep 2023 01:18:29 +0900
Subject: [PATCH] ibus-hangul: update to 1.5.5
---
srcpkgs/ibus-hangul/template | 10 +++++-----
srcpkgs/ibus-hangul/update | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/srcpkgs/ibus-hangul/template b/srcpkgs/ibus-hangul/template
index 66f1dd5527882..bf8cec311f7d3 100644
--- a/srcpkgs/ibus-hangul/template
+++ b/srcpkgs/ibus-hangul/template
@@ -1,18 +1,18 @@
# Template file for 'ibus-hangul'
pkgname=ibus-hangul
-version=1.5.3
+version=1.5.5
revision=1
build_style=gnu-configure
configure_args="--libexec=/usr/lib/ibus --with-python=/usr/bin/python3"
hostmakedepends="gettext libtool pkg-config swig"
-makedepends="ibus-devel libhangul-devel"
+makedepends="gtk+3-devel ibus-devel libhangul-devel"
depends="ibus librsvg python3-gobject"
short_desc="Korean input engine for IBus"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="GPL-2.0-or-later"
-homepage="https://github.com/choehwanjin/ibus-hangul"
-distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.gz"
-checksum=5e661cd77a327b1eafacd537f7d839a61a374e951bd382044e799371855a0090
+homepage="https://github.com/libhangul/ibus-hangul"
+distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.xz"
+checksum=a5aac88286cd18960229860e3e1a778978a7aeaa484ad9acfa48284b87fdc3bb
if [ "$CROSS_BUILD" ]; then
hostmakedepends+=" python3"
diff --git a/srcpkgs/ibus-hangul/update b/srcpkgs/ibus-hangul/update
index 608f1c0bc1995..4ba8a7ba970f8 100644
--- a/srcpkgs/ibus-hangul/update
+++ b/srcpkgs/ibus-hangul/update
@@ -1 +1 @@
-site="https://github.com/choehwanjin/ibus-hangul/releases"
+site="https://github.com/libhangul/ibus-hangul/releases"
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
2023-09-27 9:27 ` [PR PATCH] [Updated] " sogaiu
@ 2023-09-27 10:08 ` sogaiu
2023-09-27 10:09 ` sogaiu
` (23 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-27 10:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1737102176
Comment:
I've updated the `update` file to point to a more appropriate location.
Running `xbps-src` with `-Q` to get the checking to occur showed that there is a failing test. I added `dbus` to `checkdepends` and the result is a slightly shorter error.
The content of `tests/test-suite.log` is:
```
=============================================
ibus-hangul 1.5.5: tests/test-suite.log
=============================================
# TOTAL: 1
# PASS: 0
# SKIP: 0
# XFAIL: 0
# FAIL: 1
# XPASS: 0
# ERROR: 0
.. contents:: :depth: 2
FAIL: ibus-hangul
=================
TAP version 13
# random seed: R02S88717f854347403b1b81a7e895f1b454
(././ibus-hangul:18285): Gtk-WARNING **: 10:00:26.181: cannot open display:
./runtest: line 20: 18285 Trace/breakpoint trap $builddir/$tst
FAIL ibus-hangul (exit status: 133)
```
Perhaps there needs to be some kind of Xorg running to get this test to execute?
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
2023-09-27 9:27 ` [PR PATCH] [Updated] " sogaiu
2023-09-27 10:08 ` sogaiu
@ 2023-09-27 10:09 ` sogaiu
2023-09-27 14:00 ` [PR REVIEW] " sgn
` (22 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-27 10:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1737102176
Comment:
I've updated the `update` file to point to a more appropriate location.
Running `xbps-src` with `-Q` to get the checking to occur showed that there is a failing test. I added `dbus` to `checkdepends` (though not pushed yet) and the result is a slightly shorter error.
The content of `tests/test-suite.log` is:
```
=============================================
ibus-hangul 1.5.5: tests/test-suite.log
=============================================
# TOTAL: 1
# PASS: 0
# SKIP: 0
# XFAIL: 0
# FAIL: 1
# XPASS: 0
# ERROR: 0
.. contents:: :depth: 2
FAIL: ibus-hangul
=================
TAP version 13
# random seed: R02S88717f854347403b1b81a7e895f1b454
(././ibus-hangul:18285): Gtk-WARNING **: 10:00:26.181: cannot open display:
./runtest: line 20: 18285 Trace/breakpoint trap $builddir/$tst
FAIL ibus-hangul (exit status: 133)
```
Perhaps there needs to be some kind of Xorg running to get this test to execute?
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PR REVIEW] ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (2 preceding siblings ...)
2023-09-27 10:09 ` sogaiu
@ 2023-09-27 14:00 ` sgn
2023-09-27 14:00 ` [PR PATCH] [Updated] " sgn
` (21 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sgn @ 2023-09-27 14:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 262 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#discussion_r1338662787
Comment:
```suggestion
checksum=a5aac88286cd18960229860e3e1a778978a7aeaa484ad9acfa48284b87fdc3bb
make_check_pre=xvfb-run
```
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PR PATCH] [Updated] ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (3 preceding siblings ...)
2023-09-27 14:00 ` [PR REVIEW] " sgn
@ 2023-09-27 14:00 ` sgn
2023-09-28 1:12 ` sogaiu
` (20 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sgn @ 2023-09-27 14:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]
There is an updated pull request by sgn against master on the void-packages repository
https://github.com/sogaiu/void-packages update-ibus-hangul
https://github.com/void-linux/void-packages/pull/46271
ibus-hangul: update to 1.5.5
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
#### Notes
Apparently, [recent versions of Python no longer have `gettext.bind_textdomain_codeset`](https://docs.python.org/3.10/library/gettext.html#gettext.bind_textdomain_codeset).
For recent Pythons, ibus-hangul 1.5.3's `ibus-setup-hangul` can crash with:
```
$ ibus-setup-hangul
Traceback (most recent call last):
File "/usr/share/ibus-hangul/setup/main.py", line 298, in <module>
gettext.bind_textdomain_codeset(config.gettext_package, "UTF-8")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'gettext' has no attribute 'bind_textdomain_codeset'
```
A [PR for ibus-hangul to address this](https://github.com/libhangul/ibus-hangul/issues/93) was merged some time back and [the 1.5.4 release included the relevant code](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.4).
There was [another release (1.5.5)](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.5) since then and this PR is an update to that one.
A patch file from https://github.com/void-linux/void-packages/pull/46271.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-ibus-hangul-46271.patch --]
[-- Type: text/x-diff, Size: 2714 bytes --]
From 615948deae274c7e409ad95211a96ab582eb9f0b Mon Sep 17 00:00:00 2001
From: sogaiu <983021772@users.noreply.github.com>
Date: Wed, 27 Sep 2023 01:18:29 +0900
Subject: [PATCH 1/2] ibus-hangul: update to 1.5.5
---
srcpkgs/ibus-hangul/template | 10 +++++-----
srcpkgs/ibus-hangul/update | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/srcpkgs/ibus-hangul/template b/srcpkgs/ibus-hangul/template
index 66f1dd5527882..bf8cec311f7d3 100644
--- a/srcpkgs/ibus-hangul/template
+++ b/srcpkgs/ibus-hangul/template
@@ -1,18 +1,18 @@
# Template file for 'ibus-hangul'
pkgname=ibus-hangul
-version=1.5.3
+version=1.5.5
revision=1
build_style=gnu-configure
configure_args="--libexec=/usr/lib/ibus --with-python=/usr/bin/python3"
hostmakedepends="gettext libtool pkg-config swig"
-makedepends="ibus-devel libhangul-devel"
+makedepends="gtk+3-devel ibus-devel libhangul-devel"
depends="ibus librsvg python3-gobject"
short_desc="Korean input engine for IBus"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="GPL-2.0-or-later"
-homepage="https://github.com/choehwanjin/ibus-hangul"
-distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.gz"
-checksum=5e661cd77a327b1eafacd537f7d839a61a374e951bd382044e799371855a0090
+homepage="https://github.com/libhangul/ibus-hangul"
+distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.xz"
+checksum=a5aac88286cd18960229860e3e1a778978a7aeaa484ad9acfa48284b87fdc3bb
if [ "$CROSS_BUILD" ]; then
hostmakedepends+=" python3"
diff --git a/srcpkgs/ibus-hangul/update b/srcpkgs/ibus-hangul/update
index 608f1c0bc1995..4ba8a7ba970f8 100644
--- a/srcpkgs/ibus-hangul/update
+++ b/srcpkgs/ibus-hangul/update
@@ -1 +1 @@
-site="https://github.com/choehwanjin/ibus-hangul/releases"
+site="https://github.com/libhangul/ibus-hangul/releases"
From 4eec69447d4f81efadb7c373a8b37379bfb7d5ea Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<sgn.danh@gmail.com>
Date: Wed, 27 Sep 2023 21:00:55 +0700
Subject: [PATCH 2/2] Update srcpkgs/ibus-hangul/template
---
srcpkgs/ibus-hangul/template | 1 +
1 file changed, 1 insertion(+)
diff --git a/srcpkgs/ibus-hangul/template b/srcpkgs/ibus-hangul/template
index bf8cec311f7d3..987adef4b6f16 100644
--- a/srcpkgs/ibus-hangul/template
+++ b/srcpkgs/ibus-hangul/template
@@ -13,6 +13,7 @@ license="GPL-2.0-or-later"
homepage="https://github.com/libhangul/ibus-hangul"
distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.xz"
checksum=a5aac88286cd18960229860e3e1a778978a7aeaa484ad9acfa48284b87fdc3bb
+make_check_pre=xvfb-run
if [ "$CROSS_BUILD" ]; then
hostmakedepends+=" python3"
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PR PATCH] [Updated] ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (4 preceding siblings ...)
2023-09-27 14:00 ` [PR PATCH] [Updated] " sgn
@ 2023-09-28 1:12 ` sogaiu
2023-09-28 1:22 ` sogaiu
` (19 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-28 1:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]
There is an updated pull request by sogaiu against master on the void-packages repository
https://github.com/sogaiu/void-packages update-ibus-hangul
https://github.com/void-linux/void-packages/pull/46271
ibus-hangul: update to 1.5.5
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
#### Notes
Apparently, [recent versions of Python no longer have `gettext.bind_textdomain_codeset`](https://docs.python.org/3.10/library/gettext.html#gettext.bind_textdomain_codeset).
For recent Pythons, ibus-hangul 1.5.3's `ibus-setup-hangul` can crash with:
```
$ ibus-setup-hangul
Traceback (most recent call last):
File "/usr/share/ibus-hangul/setup/main.py", line 298, in <module>
gettext.bind_textdomain_codeset(config.gettext_package, "UTF-8")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'gettext' has no attribute 'bind_textdomain_codeset'
```
A [PR for ibus-hangul to address this](https://github.com/libhangul/ibus-hangul/issues/93) was merged some time back and [the 1.5.4 release included the relevant code](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.4).
There was [another release (1.5.5)](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.5) since then and this PR is an update to that one.
A patch file from https://github.com/void-linux/void-packages/pull/46271.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-ibus-hangul-46271.patch --]
[-- Type: text/x-diff, Size: 1973 bytes --]
From b682ebe6b3909273734578db32786f9a6577530d Mon Sep 17 00:00:00 2001
From: sogaiu <983021772@users.noreply.github.com>
Date: Wed, 27 Sep 2023 01:18:29 +0900
Subject: [PATCH] ibus-hangul: update to 1.5.5
---
srcpkgs/ibus-hangul/template | 15 ++++++++++-----
srcpkgs/ibus-hangul/update | 2 +-
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/srcpkgs/ibus-hangul/template b/srcpkgs/ibus-hangul/template
index 66f1dd5527882..bcbf0d8160771 100644
--- a/srcpkgs/ibus-hangul/template
+++ b/srcpkgs/ibus-hangul/template
@@ -1,19 +1,24 @@
# Template file for 'ibus-hangul'
pkgname=ibus-hangul
-version=1.5.3
+version=1.5.5
revision=1
build_style=gnu-configure
configure_args="--libexec=/usr/lib/ibus --with-python=/usr/bin/python3"
hostmakedepends="gettext libtool pkg-config swig"
-makedepends="ibus-devel libhangul-devel"
+makedepends="gtk+3-devel ibus-devel libhangul-devel"
depends="ibus librsvg python3-gobject"
short_desc="Korean input engine for IBus"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="GPL-2.0-or-later"
-homepage="https://github.com/choehwanjin/ibus-hangul"
-distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.gz"
-checksum=5e661cd77a327b1eafacd537f7d839a61a374e951bd382044e799371855a0090
+homepage="https://github.com/libhangul/ibus-hangul"
+distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.xz"
+checksum=a5aac88286cd18960229860e3e1a778978a7aeaa484ad9acfa48284b87fdc3bb
if [ "$CROSS_BUILD" ]; then
hostmakedepends+=" python3"
fi
+
+pre_configure() {
+ # tests contain interactive tests
+ vsed -e '/tests/d' -i Makefile.in
+}
diff --git a/srcpkgs/ibus-hangul/update b/srcpkgs/ibus-hangul/update
index 608f1c0bc1995..4ba8a7ba970f8 100644
--- a/srcpkgs/ibus-hangul/update
+++ b/srcpkgs/ibus-hangul/update
@@ -1 +1 @@
-site="https://github.com/choehwanjin/ibus-hangul/releases"
+site="https://github.com/libhangul/ibus-hangul/releases"
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (5 preceding siblings ...)
2023-09-28 1:12 ` sogaiu
@ 2023-09-28 1:22 ` sogaiu
2023-09-28 1:25 ` sogaiu
` (18 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-28 1:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 5054 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1738310464
Comment:
Apparently tests in the `tests` directory require user interaction:
```
options="!check" # test requires user interaction
```
via: https://git.alpinelinux.org/aports/tree/community/ibus-hangul/APKBUILD#n16
I disabled processing for `tests`, but this doesn't mean there is no testing (see output below).
Perhaps that's good enough?
```
=> ibus-hangul-1.5.5_1: running do_check ...
Making check in src
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
make test-ustring
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
Making check in src
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
make test-ustring
make[2]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
cc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -MT test_ustring-test-ustring.o -MD -MP -MF .deps/test_ustring-test-ustring.Tpo -c -o test_ustring-test-ustring.o `test -f 'test-ustring.c' || echo './'`test-ustring.c
cc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -MT test_ustring-ustring.o -MD -MP -MF .deps/test_ustring-ustring.Tpo -c -o test_ustring-ustring.o `test -f 'ustring.c' || echo './'`ustring.c
mv -f .deps/test_ustring-test-ustring.Tpo .deps/test_ustring-test-ustring.Po
mv -f .deps/test_ustring-ustring.Tpo .deps/test_ustring-ustring.Po
/bin/sh ../libtool --tag=CC --mode=link cc -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lhangul -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o test-ustring test_ustring-test-ustring.o test_ustring-ustring.o -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0
libtool: link: cc -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,--as-needed -o test-ustring test_ustring-test-ustring.o test_ustring-ustring.o -lhangul -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -pthread
make[2]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make check-TESTS check-local
make[2]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
./test-ustring
TAP version 13
# random seed: R02Sb2314b360bf457fcb20c6ef52d73dea8
1..1
# Start of ibus-hangul tests
# Start of ustring tests
ok 1 /ibus-hangul/ustring/compare
# End of ustring tests
# End of ibus-hangul tests
make[3]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
PASS: test-ustring
============================================================================
Testsuite summary for ibus-hangul 1.5.5
============================================================================
# TOTAL: 1
# PASS: 1
# SKIP: 0
# XFAIL: 0
# FAIL: 0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make[2]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
Making check in setup
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/setup'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/setup'
Making check in icons
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/icons'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/icons'
Making check in data
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/data'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/data'
Making check in m4
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/m4'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/m4'
Making check in po
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/po'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/po'
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5'
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5'
```
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (6 preceding siblings ...)
2023-09-28 1:22 ` sogaiu
@ 2023-09-28 1:25 ` sogaiu
2023-09-28 1:26 ` sogaiu
` (17 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-28 1:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 5275 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1738310464
Comment:
Apparently tests in the `tests` directory require user interaction:
```
options="!check" # test requires user interaction
```
via: https://git.alpinelinux.org/aports/tree/community/ibus-hangul/APKBUILD#n16
I also observed that once I'd fulfilled various dependencies and bits for the `tests` testing to run, `./xbps-src -Q pkg ibus-hangul` would hang, so may be that's some evidence that is consistent with the above claim.
I disabled processing for `tests`, but this doesn't mean there is no testing (see output below).
Perhaps that's good enough?
```
=> ibus-hangul-1.5.5_1: running do_check ...
Making check in src
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
make test-ustring
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
Making check in src
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
make test-ustring
make[2]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
cc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -MT test_ustring-test-ustring.o -MD -MP -MF .deps/test_ustring-test-ustring.Tpo -c -o test_ustring-test-ustring.o `test -f 'test-ustring.c' || echo './'`test-ustring.c
cc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -MT test_ustring-ustring.o -MD -MP -MF .deps/test_ustring-ustring.Tpo -c -o test_ustring-ustring.o `test -f 'ustring.c' || echo './'`ustring.c
mv -f .deps/test_ustring-test-ustring.Tpo .deps/test_ustring-test-ustring.Po
mv -f .deps/test_ustring-ustring.Tpo .deps/test_ustring-ustring.Po
/bin/sh ../libtool --tag=CC --mode=link cc -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lhangul -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o test-ustring test_ustring-test-ustring.o test_ustring-ustring.o -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0
libtool: link: cc -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,--as-needed -o test-ustring test_ustring-test-ustring.o test_ustring-ustring.o -lhangul -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -pthread
make[2]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make check-TESTS check-local
make[2]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
./test-ustring
TAP version 13
# random seed: R02Sb2314b360bf457fcb20c6ef52d73dea8
1..1
# Start of ibus-hangul tests
# Start of ustring tests
ok 1 /ibus-hangul/ustring/compare
# End of ustring tests
# End of ibus-hangul tests
make[3]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
PASS: test-ustring
============================================================================
Testsuite summary for ibus-hangul 1.5.5
============================================================================
# TOTAL: 1
# PASS: 1
# SKIP: 0
# XFAIL: 0
# FAIL: 0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make[2]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
Making check in setup
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/setup'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/setup'
Making check in icons
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/icons'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/icons'
Making check in data
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/data'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/data'
Making check in m4
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/m4'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/m4'
Making check in po
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/po'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/po'
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5'
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5'
```
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (7 preceding siblings ...)
2023-09-28 1:25 ` sogaiu
@ 2023-09-28 1:26 ` sogaiu
2023-09-28 1:27 ` sogaiu
` (16 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-28 1:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 5292 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1738310464
Comment:
Apparently tests in the `tests` directory require user interaction:
```
options="!check" # test requires user interaction
```
via: https://git.alpinelinux.org/aports/tree/community/ibus-hangul/APKBUILD#n16
I also observed that once I'd fulfilled various dependencies and bits for the `tests` testing to run, `./xbps-src -Q pkg ibus-hangul` would hang after some point, so may be that's some evidence that is consistent with the above claim.
I disabled processing for `tests`, but this doesn't mean there is no testing (see output below).
Perhaps that's good enough?
```
=> ibus-hangul-1.5.5_1: running do_check ...
Making check in src
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
make test-ustring
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
Making check in src
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
make test-ustring
make[2]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
cc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -MT test_ustring-test-ustring.o -MD -MP -MF .deps/test_ustring-test-ustring.Tpo -c -o test_ustring-test-ustring.o `test -f 'test-ustring.c' || echo './'`test-ustring.c
cc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -MT test_ustring-ustring.o -MD -MP -MF .deps/test_ustring-ustring.Tpo -c -o test_ustring-ustring.o `test -f 'ustring.c' || echo './'`ustring.c
mv -f .deps/test_ustring-test-ustring.Tpo .deps/test_ustring-test-ustring.Po
mv -f .deps/test_ustring-ustring.Tpo .deps/test_ustring-ustring.Po
/bin/sh ../libtool --tag=CC --mode=link cc -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lhangul -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o test-ustring test_ustring-test-ustring.o test_ustring-ustring.o -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0
libtool: link: cc -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,--as-needed -o test-ustring test_ustring-test-ustring.o test_ustring-ustring.o -lhangul -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -pthread
make[2]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make check-TESTS check-local
make[2]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
./test-ustring
TAP version 13
# random seed: R02Sb2314b360bf457fcb20c6ef52d73dea8
1..1
# Start of ibus-hangul tests
# Start of ustring tests
ok 1 /ibus-hangul/ustring/compare
# End of ustring tests
# End of ibus-hangul tests
make[3]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
PASS: test-ustring
============================================================================
Testsuite summary for ibus-hangul 1.5.5
============================================================================
# TOTAL: 1
# PASS: 1
# SKIP: 0
# XFAIL: 0
# FAIL: 0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make[2]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
Making check in setup
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/setup'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/setup'
Making check in icons
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/icons'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/icons'
Making check in data
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/data'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/data'
Making check in m4
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/m4'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/m4'
Making check in po
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/po'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/po'
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5'
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5'
```
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (8 preceding siblings ...)
2023-09-28 1:26 ` sogaiu
@ 2023-09-28 1:27 ` sogaiu
2023-09-28 1:28 ` sogaiu
` (15 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-28 1:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 5341 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1738310464
Comment:
Apparently tests in the `tests` directory require user interaction:
```
options="!check" # test requires user interaction
```
via: https://git.alpinelinux.org/aports/tree/community/ibus-hangul/APKBUILD#n16 (blob: 8468839d0250d4e56ebb3328524dd7ad887af050)
I also observed that once I'd fulfilled various dependencies and bits for the `tests` testing to run, `./xbps-src -Q pkg ibus-hangul` would hang after some point, so may be that's some evidence that is consistent with the above claim.
I disabled processing for `tests`, but this doesn't mean there is no testing (see output below).
Perhaps that's good enough?
```
=> ibus-hangul-1.5.5_1: running do_check ...
Making check in src
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
make test-ustring
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
Making check in src
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
make test-ustring
make[2]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
cc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -MT test_ustring-test-ustring.o -MD -MP -MF .deps/test_ustring-test-ustring.Tpo -c -o test_ustring-test-ustring.o `test -f 'test-ustring.c' || echo './'`test-ustring.c
cc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -MT test_ustring-ustring.o -MD -MP -MF .deps/test_ustring-ustring.Tpo -c -o test_ustring-ustring.o `test -f 'ustring.c' || echo './'`ustring.c
mv -f .deps/test_ustring-test-ustring.Tpo .deps/test_ustring-test-ustring.Po
mv -f .deps/test_ustring-ustring.Tpo .deps/test_ustring-ustring.Po
/bin/sh ../libtool --tag=CC --mode=link cc -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lhangul -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o test-ustring test_ustring-test-ustring.o test_ustring-ustring.o -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0
libtool: link: cc -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,--as-needed -o test-ustring test_ustring-test-ustring.o test_ustring-ustring.o -lhangul -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -pthread
make[2]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make check-TESTS check-local
make[2]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
./test-ustring
TAP version 13
# random seed: R02Sb2314b360bf457fcb20c6ef52d73dea8
1..1
# Start of ibus-hangul tests
# Start of ustring tests
ok 1 /ibus-hangul/ustring/compare
# End of ustring tests
# End of ibus-hangul tests
make[3]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
PASS: test-ustring
============================================================================
Testsuite summary for ibus-hangul 1.5.5
============================================================================
# TOTAL: 1
# PASS: 1
# SKIP: 0
# XFAIL: 0
# FAIL: 0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make[2]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
Making check in setup
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/setup'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/setup'
Making check in icons
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/icons'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/icons'
Making check in data
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/data'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/data'
Making check in m4
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/m4'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/m4'
Making check in po
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/po'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/po'
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5'
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5'
```
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (9 preceding siblings ...)
2023-09-28 1:27 ` sogaiu
@ 2023-09-28 1:28 ` sogaiu
2023-09-28 1:39 ` sogaiu
` (14 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-28 1:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 5348 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1738310464
Comment:
Apparently tests in the `tests` directory require user interaction:
```
options="!check" # test requires user interaction
```
via: https://git.alpinelinux.org/aports/tree/community/ibus-hangul/APKBUILD#n16 (blob: 8468839d0250d4e56ebb3328524dd7ad887af050)
I also observed that once I'd fulfilled various dependencies and bits for the `tests` testing to run, `./xbps-src -Q pkg ibus-hangul` would hang after some point, so may be that's some evidence that is consistent with the above claim.
I disabled processing for `tests`, but this doesn't mean there is no testing at all (see output below).
Perhaps that's good enough?
```
=> ibus-hangul-1.5.5_1: running do_check ...
Making check in src
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
make test-ustring
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
Making check in src
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
make test-ustring
make[2]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
cc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -MT test_ustring-test-ustring.o -MD -MP -MF .deps/test_ustring-test-ustring.Tpo -c -o test_ustring-test-ustring.o `test -f 'test-ustring.c' || echo './'`test-ustring.c
cc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -MT test_ustring-ustring.o -MD -MP -MF .deps/test_ustring-ustring.Tpo -c -o test_ustring-ustring.o `test -f 'ustring.c' || echo './'`ustring.c
mv -f .deps/test_ustring-test-ustring.Tpo .deps/test_ustring-test-ustring.Po
mv -f .deps/test_ustring-ustring.Tpo .deps/test_ustring-ustring.Po
/bin/sh ../libtool --tag=CC --mode=link cc -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lhangul -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o test-ustring test_ustring-test-ustring.o test_ustring-ustring.o -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0
libtool: link: cc -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,--as-needed -o test-ustring test_ustring-test-ustring.o test_ustring-ustring.o -lhangul -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -pthread
make[2]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make check-TESTS check-local
make[2]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
./test-ustring
TAP version 13
# random seed: R02Sb2314b360bf457fcb20c6ef52d73dea8
1..1
# Start of ibus-hangul tests
# Start of ustring tests
ok 1 /ibus-hangul/ustring/compare
# End of ustring tests
# End of ibus-hangul tests
make[3]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
PASS: test-ustring
============================================================================
Testsuite summary for ibus-hangul 1.5.5
============================================================================
# TOTAL: 1
# PASS: 1
# SKIP: 0
# XFAIL: 0
# FAIL: 0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make[2]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
Making check in setup
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/setup'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/setup'
Making check in icons
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/icons'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/icons'
Making check in data
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/data'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/data'
Making check in m4
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/m4'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/m4'
Making check in po
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/po'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/po'
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5'
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5'
```
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (10 preceding siblings ...)
2023-09-28 1:28 ` sogaiu
@ 2023-09-28 1:39 ` sogaiu
2023-09-28 4:31 ` sogaiu
` (13 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-28 1:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 5403 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1738310464
Comment:
Apparently tests in the `tests` directory require user interaction:
```
options="!check" # test requires user interaction
```
via: https://git.alpinelinux.org/aports/tree/community/ibus-hangul/APKBUILD#n16 (blob: 8468839d0250d4e56ebb3328524dd7ad887af050)
I also observed that once I'd fulfilled various dependencies [1] and bits for the `tests` testing to run, `./xbps-src -Q pkg ibus-hangul` would hang after some point, so may be that's some evidence that is consistent with the above claim.
I disabled processing for `tests`, but this doesn't mean there is no testing at all (see output below).
Perhaps that's good enough?
```
=> ibus-hangul-1.5.5_1: running do_check ...
Making check in src
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
make test-ustring
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
Making check in src
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
make test-ustring
make[2]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
cc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -MT test_ustring-test-ustring.o -MD -MP -MF .deps/test_ustring-test-ustring.Tpo -c -o test_ustring-test-ustring.o `test -f 'test-ustring.c' || echo './'`test-ustring.c
cc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -MT test_ustring-ustring.o -MD -MP -MF .deps/test_ustring-ustring.Tpo -c -o test_ustring-ustring.o `test -f 'ustring.c' || echo './'`ustring.c
mv -f .deps/test_ustring-test-ustring.Tpo .deps/test_ustring-test-ustring.Po
mv -f .deps/test_ustring-ustring.Tpo .deps/test_ustring-ustring.Po
/bin/sh ../libtool --tag=CC --mode=link cc -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lhangul -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o test-ustring test_ustring-test-ustring.o test_ustring-ustring.o -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0
libtool: link: cc -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,--as-needed -o test-ustring test_ustring-test-ustring.o test_ustring-ustring.o -lhangul -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -pthread
make[2]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make check-TESTS check-local
make[2]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
./test-ustring
TAP version 13
# random seed: R02Sb2314b360bf457fcb20c6ef52d73dea8
1..1
# Start of ibus-hangul tests
# Start of ustring tests
ok 1 /ibus-hangul/ustring/compare
# End of ustring tests
# End of ibus-hangul tests
make[3]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
PASS: test-ustring
============================================================================
Testsuite summary for ibus-hangul 1.5.5
============================================================================
# TOTAL: 1
# PASS: 1
# SKIP: 0
# XFAIL: 0
# FAIL: 0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make[2]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
Making check in setup
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/setup'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/setup'
Making check in icons
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/icons'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/icons'
Making check in data
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/data'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/data'
Making check in m4
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/m4'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/m4'
Making check in po
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/po'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/po'
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5'
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5'
```
---
[1] Thanks to sgn for the xvfb-run hint.
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (11 preceding siblings ...)
2023-09-28 1:39 ` sogaiu
@ 2023-09-28 4:31 ` sogaiu
2023-09-28 7:47 ` [PR PATCH] [Updated] " sogaiu
` (12 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-28 4:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 5436 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1738310464
Comment:
Apparently tests in the `tests` directory require user interaction:
```
options="!check" # test requires user interaction
```
via: https://git.alpinelinux.org/aports/tree/community/ibus-hangul/APKBUILD#n16 (blob: 8468839d0250d4e56ebb3328524dd7ad887af050)
I also observed that once I'd fulfilled various dependencies [1] and bits for the `tests` testing to run, `./xbps-src -Q pkg ibus-hangul` would hang after some point, so may be that's some evidence that is consistent with the above claim about requiring user interaction.
I disabled processing for `tests`, but this doesn't mean there is no testing at all (see output below).
Perhaps that's good enough?
```
=> ibus-hangul-1.5.5_1: running do_check ...
Making check in src
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
make test-ustring
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
Making check in src
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
make test-ustring
make[2]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
cc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -MT test_ustring-test-ustring.o -MD -MP -MF .deps/test_ustring-test-ustring.Tpo -c -o test_ustring-test-ustring.o `test -f 'test-ustring.c' || echo './'`test-ustring.c
cc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -MT test_ustring-ustring.o -MD -MP -MF .deps/test_ustring-ustring.Tpo -c -o test_ustring-ustring.o `test -f 'ustring.c' || echo './'`ustring.c
mv -f .deps/test_ustring-test-ustring.Tpo .deps/test_ustring-test-ustring.Po
mv -f .deps/test_ustring-ustring.Tpo .deps/test_ustring-ustring.Po
/bin/sh ../libtool --tag=CC --mode=link cc -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lhangul -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o test-ustring test_ustring-test-ustring.o test_ustring-ustring.o -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0
libtool: link: cc -pthread -I/usr/include/ibus-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/hangul-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/ibus-hangul-1.5.5=. -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,--as-needed -o test-ustring test_ustring-test-ustring.o test_ustring-ustring.o -lhangul -libus-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -pthread
make[2]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make check-TESTS check-local
make[2]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
./test-ustring
TAP version 13
# random seed: R02Sb2314b360bf457fcb20c6ef52d73dea8
1..1
# Start of ibus-hangul tests
# Start of ustring tests
ok 1 /ibus-hangul/ustring/compare
# End of ustring tests
# End of ibus-hangul tests
make[3]: Entering directory '/builddir/ibus-hangul-1.5.5/src'
PASS: test-ustring
============================================================================
Testsuite summary for ibus-hangul 1.5.5
============================================================================
# TOTAL: 1
# PASS: 1
# SKIP: 0
# XFAIL: 0
# FAIL: 0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make[2]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/src'
Making check in setup
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/setup'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/setup'
Making check in icons
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/icons'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/icons'
Making check in data
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/data'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/data'
Making check in m4
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/m4'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/m4'
Making check in po
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5/po'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5/po'
make[1]: Entering directory '/builddir/ibus-hangul-1.5.5'
make[1]: Leaving directory '/builddir/ibus-hangul-1.5.5'
```
---
[1] Thanks to sgn for the xvfb-run hint.
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PR PATCH] [Updated] ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (12 preceding siblings ...)
2023-09-28 4:31 ` sogaiu
@ 2023-09-28 7:47 ` sogaiu
2023-09-28 7:49 ` sogaiu
` (11 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-28 7:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]
There is an updated pull request by sogaiu against master on the void-packages repository
https://github.com/sogaiu/void-packages update-ibus-hangul
https://github.com/void-linux/void-packages/pull/46271
ibus-hangul: update to 1.5.5
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
#### Notes
Apparently, [recent versions of Python no longer have `gettext.bind_textdomain_codeset`](https://docs.python.org/3.10/library/gettext.html#gettext.bind_textdomain_codeset).
For recent Pythons, ibus-hangul 1.5.3's `ibus-setup-hangul` can crash with:
```
$ ibus-setup-hangul
Traceback (most recent call last):
File "/usr/share/ibus-hangul/setup/main.py", line 298, in <module>
gettext.bind_textdomain_codeset(config.gettext_package, "UTF-8")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'gettext' has no attribute 'bind_textdomain_codeset'
```
A [PR for ibus-hangul to address this](https://github.com/libhangul/ibus-hangul/issues/93) was merged some time back and [the 1.5.4 release included the relevant code](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.4).
There was [another release (1.5.5)](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.5) since then and this PR is an update to that one.
A patch file from https://github.com/void-linux/void-packages/pull/46271.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-ibus-hangul-46271.patch --]
[-- Type: text/x-diff, Size: 1959 bytes --]
From f50f7ad0aff8c73969d12c0a6cbc58a6fbf7c841 Mon Sep 17 00:00:00 2001
From: sogaiu <983021772@users.noreply.github.com>
Date: Wed, 27 Sep 2023 01:18:29 +0900
Subject: [PATCH] ibus-hangul: update to 1.5.5
---
srcpkgs/ibus-hangul/template | 15 ++++++++++-----
srcpkgs/ibus-hangul/update | 2 +-
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/srcpkgs/ibus-hangul/template b/srcpkgs/ibus-hangul/template
index 66f1dd5527882..e556e4d6ca34b 100644
--- a/srcpkgs/ibus-hangul/template
+++ b/srcpkgs/ibus-hangul/template
@@ -1,19 +1,24 @@
# Template file for 'ibus-hangul'
pkgname=ibus-hangul
-version=1.5.3
+version=1.5.5
revision=1
build_style=gnu-configure
configure_args="--libexec=/usr/lib/ibus --with-python=/usr/bin/python3"
hostmakedepends="gettext libtool pkg-config swig"
-makedepends="ibus-devel libhangul-devel"
+makedepends="gtk+3-devel ibus-devel libhangul-devel"
depends="ibus librsvg python3-gobject"
short_desc="Korean input engine for IBus"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="GPL-2.0-or-later"
-homepage="https://github.com/choehwanjin/ibus-hangul"
-distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.gz"
-checksum=5e661cd77a327b1eafacd537f7d839a61a374e951bd382044e799371855a0090
+homepage="https://github.com/libhangul/ibus-hangul"
+distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.xz"
+checksum=a5aac88286cd18960229860e3e1a778978a7aeaa484ad9acfa48284b87fdc3bb
if [ "$CROSS_BUILD" ]; then
hostmakedepends+=" python3"
fi
+
+pre_configure() {
+ # tests contain interactive tests
+ vsed -e '/tests/d' -i Makefile.in
+}
diff --git a/srcpkgs/ibus-hangul/update b/srcpkgs/ibus-hangul/update
index 608f1c0bc1995..4ba8a7ba970f8 100644
--- a/srcpkgs/ibus-hangul/update
+++ b/srcpkgs/ibus-hangul/update
@@ -1 +1 @@
-site="https://github.com/choehwanjin/ibus-hangul/releases"
+site="https://github.com/libhangul/ibus-hangul/releases"
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PR PATCH] [Updated] ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (13 preceding siblings ...)
2023-09-28 7:47 ` [PR PATCH] [Updated] " sogaiu
@ 2023-09-28 7:49 ` sogaiu
2023-09-28 7:50 ` sogaiu
` (10 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-28 7:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]
There is an updated pull request by sogaiu against master on the void-packages repository
https://github.com/sogaiu/void-packages update-ibus-hangul
https://github.com/void-linux/void-packages/pull/46271
ibus-hangul: update to 1.5.5
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
#### Notes
Apparently, [recent versions of Python no longer have `gettext.bind_textdomain_codeset`](https://docs.python.org/3.10/library/gettext.html#gettext.bind_textdomain_codeset).
For recent Pythons, ibus-hangul 1.5.3's `ibus-setup-hangul` can crash with:
```
$ ibus-setup-hangul
Traceback (most recent call last):
File "/usr/share/ibus-hangul/setup/main.py", line 298, in <module>
gettext.bind_textdomain_codeset(config.gettext_package, "UTF-8")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'gettext' has no attribute 'bind_textdomain_codeset'
```
A [PR for ibus-hangul to address this](https://github.com/libhangul/ibus-hangul/issues/93) was merged some time back and [the 1.5.4 release included the relevant code](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.4).
There was [another release (1.5.5)](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.5) since then and this PR is an update to that one.
A patch file from https://github.com/void-linux/void-packages/pull/46271.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-ibus-hangul-46271.patch --]
[-- Type: text/x-diff, Size: 1969 bytes --]
From 62377f412a746ba5416e822c5bcd64908e538a12 Mon Sep 17 00:00:00 2001
From: sogaiu <983021772@users.noreply.github.com>
Date: Wed, 27 Sep 2023 01:18:29 +0900
Subject: [PATCH] ibus-hangul: update to 1.5.5
---
srcpkgs/ibus-hangul/template | 15 ++++++++++-----
srcpkgs/ibus-hangul/update | 2 +-
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/srcpkgs/ibus-hangul/template b/srcpkgs/ibus-hangul/template
index 66f1dd5527882..9c1fd58934f44 100644
--- a/srcpkgs/ibus-hangul/template
+++ b/srcpkgs/ibus-hangul/template
@@ -1,19 +1,24 @@
# Template file for 'ibus-hangul'
pkgname=ibus-hangul
-version=1.5.3
+version=1.5.5
revision=1
build_style=gnu-configure
configure_args="--libexec=/usr/lib/ibus --with-python=/usr/bin/python3"
hostmakedepends="gettext libtool pkg-config swig"
-makedepends="ibus-devel libhangul-devel"
+makedepends="gtk+3-devel ibus-devel libhangul-devel"
depends="ibus librsvg python3-gobject"
short_desc="Korean input engine for IBus"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="GPL-2.0-or-later"
-homepage="https://github.com/choehwanjin/ibus-hangul"
-distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.gz"
-checksum=5e661cd77a327b1eafacd537f7d839a61a374e951bd382044e799371855a0090
+homepage="https://github.com/libhangul/ibus-hangul"
+distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.xz"
+checksum=a5aac88286cd18960229860e3e1a778978a7aeaa484ad9acfa48284b87fdc3bb
if [ "$CROSS_BUILD" ]; then
hostmakedepends+=" python3"
fi
+
+pre_configure() {
+ # tests directory contain interactive tests
+ vsed -e '/tests/d' -i Makefile.in
+}
diff --git a/srcpkgs/ibus-hangul/update b/srcpkgs/ibus-hangul/update
index 608f1c0bc1995..4ba8a7ba970f8 100644
--- a/srcpkgs/ibus-hangul/update
+++ b/srcpkgs/ibus-hangul/update
@@ -1 +1 @@
-site="https://github.com/choehwanjin/ibus-hangul/releases"
+site="https://github.com/libhangul/ibus-hangul/releases"
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PR PATCH] [Updated] ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (14 preceding siblings ...)
2023-09-28 7:49 ` sogaiu
@ 2023-09-28 7:50 ` sogaiu
2023-09-28 8:36 ` sogaiu
` (9 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-28 7:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]
There is an updated pull request by sogaiu against master on the void-packages repository
https://github.com/sogaiu/void-packages update-ibus-hangul
https://github.com/void-linux/void-packages/pull/46271
ibus-hangul: update to 1.5.5
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
#### Notes
Apparently, [recent versions of Python no longer have `gettext.bind_textdomain_codeset`](https://docs.python.org/3.10/library/gettext.html#gettext.bind_textdomain_codeset).
For recent Pythons, ibus-hangul 1.5.3's `ibus-setup-hangul` can crash with:
```
$ ibus-setup-hangul
Traceback (most recent call last):
File "/usr/share/ibus-hangul/setup/main.py", line 298, in <module>
gettext.bind_textdomain_codeset(config.gettext_package, "UTF-8")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'gettext' has no attribute 'bind_textdomain_codeset'
```
A [PR for ibus-hangul to address this](https://github.com/libhangul/ibus-hangul/issues/93) was merged some time back and [the 1.5.4 release included the relevant code](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.4).
There was [another release (1.5.5)](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.5) since then and this PR is an update to that one.
A patch file from https://github.com/void-linux/void-packages/pull/46271.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-ibus-hangul-46271.patch --]
[-- Type: text/x-diff, Size: 1970 bytes --]
From 78dfcbb534c314d8c9ab504a48926ff80c571c79 Mon Sep 17 00:00:00 2001
From: sogaiu <983021772@users.noreply.github.com>
Date: Wed, 27 Sep 2023 01:18:29 +0900
Subject: [PATCH] ibus-hangul: update to 1.5.5
---
srcpkgs/ibus-hangul/template | 15 ++++++++++-----
srcpkgs/ibus-hangul/update | 2 +-
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/srcpkgs/ibus-hangul/template b/srcpkgs/ibus-hangul/template
index 66f1dd5527882..91603d0353340 100644
--- a/srcpkgs/ibus-hangul/template
+++ b/srcpkgs/ibus-hangul/template
@@ -1,19 +1,24 @@
# Template file for 'ibus-hangul'
pkgname=ibus-hangul
-version=1.5.3
+version=1.5.5
revision=1
build_style=gnu-configure
configure_args="--libexec=/usr/lib/ibus --with-python=/usr/bin/python3"
hostmakedepends="gettext libtool pkg-config swig"
-makedepends="ibus-devel libhangul-devel"
+makedepends="gtk+3-devel ibus-devel libhangul-devel"
depends="ibus librsvg python3-gobject"
short_desc="Korean input engine for IBus"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="GPL-2.0-or-later"
-homepage="https://github.com/choehwanjin/ibus-hangul"
-distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.gz"
-checksum=5e661cd77a327b1eafacd537f7d839a61a374e951bd382044e799371855a0090
+homepage="https://github.com/libhangul/ibus-hangul"
+distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.xz"
+checksum=a5aac88286cd18960229860e3e1a778978a7aeaa484ad9acfa48284b87fdc3bb
if [ "$CROSS_BUILD" ]; then
hostmakedepends+=" python3"
fi
+
+pre_configure() {
+ # tests directory contains interactive tests
+ vsed -e '/tests/d' -i Makefile.in
+}
diff --git a/srcpkgs/ibus-hangul/update b/srcpkgs/ibus-hangul/update
index 608f1c0bc1995..4ba8a7ba970f8 100644
--- a/srcpkgs/ibus-hangul/update
+++ b/srcpkgs/ibus-hangul/update
@@ -1 +1 @@
-site="https://github.com/choehwanjin/ibus-hangul/releases"
+site="https://github.com/libhangul/ibus-hangul/releases"
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PR PATCH] [Updated] ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (15 preceding siblings ...)
2023-09-28 7:50 ` sogaiu
@ 2023-09-28 8:36 ` sogaiu
2023-09-29 2:01 ` sogaiu
` (8 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-28 8:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]
There is an updated pull request by sogaiu against master on the void-packages repository
https://github.com/sogaiu/void-packages update-ibus-hangul
https://github.com/void-linux/void-packages/pull/46271
ibus-hangul: update to 1.5.5
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
#### Notes
Apparently, [recent versions of Python no longer have `gettext.bind_textdomain_codeset`](https://docs.python.org/3.10/library/gettext.html#gettext.bind_textdomain_codeset).
For recent Pythons, ibus-hangul 1.5.3's `ibus-setup-hangul` can crash with:
```
$ ibus-setup-hangul
Traceback (most recent call last):
File "/usr/share/ibus-hangul/setup/main.py", line 298, in <module>
gettext.bind_textdomain_codeset(config.gettext_package, "UTF-8")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'gettext' has no attribute 'bind_textdomain_codeset'
```
A [PR for ibus-hangul to address this](https://github.com/libhangul/ibus-hangul/issues/93) was merged some time back and [the 1.5.4 release included the relevant code](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.4).
There was [another release (1.5.5)](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.5) since then and this PR is an update to that one.
A patch file from https://github.com/void-linux/void-packages/pull/46271.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-ibus-hangul-46271.patch --]
[-- Type: text/x-diff, Size: 2009 bytes --]
From b8e4227a54e365c56562f4b02fafbbf57e94f755 Mon Sep 17 00:00:00 2001
From: sogaiu <983021772@users.noreply.github.com>
Date: Wed, 27 Sep 2023 01:18:29 +0900
Subject: [PATCH] ibus-hangul: update to 1.5.5
---
srcpkgs/ibus-hangul/template | 15 ++++++++++-----
srcpkgs/ibus-hangul/update | 3 ++-
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/srcpkgs/ibus-hangul/template b/srcpkgs/ibus-hangul/template
index 66f1dd5527882..91603d0353340 100644
--- a/srcpkgs/ibus-hangul/template
+++ b/srcpkgs/ibus-hangul/template
@@ -1,19 +1,24 @@
# Template file for 'ibus-hangul'
pkgname=ibus-hangul
-version=1.5.3
+version=1.5.5
revision=1
build_style=gnu-configure
configure_args="--libexec=/usr/lib/ibus --with-python=/usr/bin/python3"
hostmakedepends="gettext libtool pkg-config swig"
-makedepends="ibus-devel libhangul-devel"
+makedepends="gtk+3-devel ibus-devel libhangul-devel"
depends="ibus librsvg python3-gobject"
short_desc="Korean input engine for IBus"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="GPL-2.0-or-later"
-homepage="https://github.com/choehwanjin/ibus-hangul"
-distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.gz"
-checksum=5e661cd77a327b1eafacd537f7d839a61a374e951bd382044e799371855a0090
+homepage="https://github.com/libhangul/ibus-hangul"
+distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.xz"
+checksum=a5aac88286cd18960229860e3e1a778978a7aeaa484ad9acfa48284b87fdc3bb
if [ "$CROSS_BUILD" ]; then
hostmakedepends+=" python3"
fi
+
+pre_configure() {
+ # tests directory contains interactive tests
+ vsed -e '/tests/d' -i Makefile.in
+}
diff --git a/srcpkgs/ibus-hangul/update b/srcpkgs/ibus-hangul/update
index 608f1c0bc1995..01b241319fa0c 100644
--- a/srcpkgs/ibus-hangul/update
+++ b/srcpkgs/ibus-hangul/update
@@ -1 +1,2 @@
-site="https://github.com/choehwanjin/ibus-hangul/releases"
+site="https://github.com/libhangul/ibus-hangul/releases"
+pattern='Version \K[\d.]+(?=</a>)'
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (16 preceding siblings ...)
2023-09-28 8:36 ` sogaiu
@ 2023-09-29 2:01 ` sogaiu
2023-09-29 2:57 ` sogaiu
` (7 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-29 2:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1740214054
Comment:
I think I've addressed the issues made apparent by `xlint` and have added a summary of changes to the original / first comment of this PR.
---
This was my first PR to void-packages and I found the documentation (README, Manual, and Contributing docs) and existing package files to be very helpful.
Some factors that contributed to repeated force-pushing included:
* I wasn't diligent enough in running `xlint`
* I didn't learn quickly enough to use `-Q` to get checking to work locally
* The update was more complicated than expected, perhaps partly because the most recent version and related information had changed in various not-so-common ways. Among other things, it involved:
* Changes in archive format
* Repository URL change
* An additional dependency
* Disabling of interactive testing
In any case, it was a helpful learning experience.
Thanks to @sgn for reviewing and patience.
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (17 preceding siblings ...)
2023-09-29 2:01 ` sogaiu
@ 2023-09-29 2:57 ` sogaiu
2023-09-29 2:59 ` sogaiu
` (6 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-29 2:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1740244778
Comment:
I see the following output for "Lint templates":
```
Run rv=0
Error: b8e4227a5: authored by noreply email
Linting srcpkgs/ibus-hangul/template...
Verifying update-check of ibus-hangul:
using ibus-hangul/update overrides
fetching https://github.com/libhangul/ibus-hangul/releases and scanning with Version \K[\d.]+(?=</a>)
found version 1.5.0
found version 1.5.1
found version 1.5.2
found version 1.5.3
found version 1.5.4
found version 1.5.5
Error: Process completed with exit code 1.
```
It's unclear to me what the issue is.
I did see this text:
> maintainer A string in the form of name <user@domain>. The email for this field must be a valid email that you can be reached at. Packages using users.noreply.github.com emails will not be accepted.
mentioned [here](https://github.com/void-linux/void-packages/blob/master/Manual.md#mandatory-variables), but IIUC, that has to do with the `maintainer` field.
Any help?
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (18 preceding siblings ...)
2023-09-29 2:57 ` sogaiu
@ 2023-09-29 2:59 ` sogaiu
2023-09-29 3:02 ` sogaiu
` (5 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-29 2:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1740244778
Comment:
I see the following output for "Lint templates":
```
Run rv=0
Error: b8e4227a5: authored by noreply email
Linting srcpkgs/ibus-hangul/template...
Verifying update-check of ibus-hangul:
using ibus-hangul/update overrides
fetching https://github.com/libhangul/ibus-hangul/releases and scanning with Version \K[\d.]+(?=</a>)
found version 1.5.0
found version 1.5.1
found version 1.5.2
found version 1.5.3
found version 1.5.4
found version 1.5.5
Error: Process completed with exit code 1.
```
It's unclear to me what the issue is -- though perhaps it has to do with:
> Error: b8e4227a5: authored by noreply email
I did see this text:
> maintainer A string in the form of name <user@domain>. The email for this field must be a valid email that you can be reached at. Packages using users.noreply.github.com emails will not be accepted.
mentioned [here](https://github.com/void-linux/void-packages/blob/master/Manual.md#mandatory-variables), but IIUC, that has to do with the `maintainer` field.
Any help?
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (19 preceding siblings ...)
2023-09-29 2:59 ` sogaiu
@ 2023-09-29 3:02 ` sogaiu
2023-09-29 15:54 ` sogaiu
` (4 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-29 3:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1740244778
Comment:
I see the following output for "Lint templates":
```
Run rv=0
Error: b8e4227a5: authored by noreply email
Linting srcpkgs/ibus-hangul/template...
Verifying update-check of ibus-hangul:
using ibus-hangul/update overrides
fetching https://github.com/libhangul/ibus-hangul/releases and scanning with Version \K[\d.]+(?=</a>)
found version 1.5.0
found version 1.5.1
found version 1.5.2
found version 1.5.3
found version 1.5.4
found version 1.5.5
Error: Process completed with exit code 1.
```
It's unclear to me what the issue is -- though perhaps it has to do with:
> Error: b8e4227a5: authored by noreply email
I did see this text:
> maintainer A string in the form of name <user@domain>. The email for this field must be a valid email that you can be reached at. Packages using users.noreply.github.com emails will not be accepted.
mentioned [here](https://github.com/void-linux/void-packages/blob/master/Manual.md#mandatory-variables), but IIUC, that has to do with the `maintainer` field.
I did find this code:
https://github.com/void-linux/void-packages/blob/02c85a0f60fcb5b4f9c4cbaf79575fc57fe856d2/common/scripts/lint-commits#L35-L36
Any help?
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (20 preceding siblings ...)
2023-09-29 3:02 ` sogaiu
@ 2023-09-29 15:54 ` sogaiu
2023-09-30 9:31 ` sgn
` (3 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-29 15:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1741113046
Comment:
If there is a requirement about the email address related to the commit be of a certain persuasion, perhaps it would be better if someone else submit this or similar PR.
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (21 preceding siblings ...)
2023-09-29 15:54 ` sogaiu
@ 2023-09-30 9:31 ` sgn
2023-09-30 9:33 ` sogaiu
` (2 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: sgn @ 2023-09-30 9:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 172 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1741725104
Comment:
You need to commit by a real email
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (22 preceding siblings ...)
2023-09-30 9:31 ` sgn
@ 2023-09-30 9:33 ` sogaiu
2023-09-30 9:33 ` [PR PATCH] [Closed]: " sogaiu
2023-09-30 9:34 ` sogaiu
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-30 9:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1741725578
Comment:
Thanks for the explanation.
I'm not prepared to do that, so perhaps it would be better if someone else submit a different PR.
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PR PATCH] [Closed]: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (23 preceding siblings ...)
2023-09-30 9:33 ` sogaiu
@ 2023-09-30 9:33 ` sogaiu
2023-09-30 9:34 ` sogaiu
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-30 9:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1704 bytes --]
There's a closed pull request on the void-packages repository
ibus-hangul: update to 1.5.5
https://github.com/void-linux/void-packages/pull/46271
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures: armv6l (cross-build)
#### Notes
Apparently, [recent versions of Python no longer have `gettext.bind_textdomain_codeset`](https://docs.python.org/3.10/library/gettext.html#gettext.bind_textdomain_codeset).
For recent Pythons, ibus-hangul 1.5.3's `ibus-setup-hangul` can crash with:
```
$ ibus-setup-hangul
Traceback (most recent call last):
File "/usr/share/ibus-hangul/setup/main.py", line 298, in <module>
gettext.bind_textdomain_codeset(config.gettext_package, "UTF-8")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'gettext' has no attribute 'bind_textdomain_codeset'
```
A [PR for ibus-hangul to address this](https://github.com/libhangul/ibus-hangul/issues/93) was merged some time back and [the 1.5.4 release included the relevant code](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.4).
There was [another release (1.5.5)](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.5) since then and this PR is an update to that one.
---
#### Summary of Changes
* `template`
* Update `version` and `checksum`
* Update `makedepends` to include `gtk+3-devel`
* Update `homepage`
* Update `distfiles` to use `.xz`
* Add `pre_configure` to skip the interactive tests in `tests` directory
* `update`
* Update `site`
* Add `pattern`
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: ibus-hangul: update to 1.5.5
2023-09-26 16:35 [PR PATCH] ibus-hangul: update to 1.5.5 sogaiu
` (24 preceding siblings ...)
2023-09-30 9:33 ` [PR PATCH] [Closed]: " sogaiu
@ 2023-09-30 9:34 ` sogaiu
25 siblings, 0 replies; 27+ messages in thread
From: sogaiu @ 2023-09-30 9:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
New comment by sogaiu on void-packages repository
https://github.com/void-linux/void-packages/pull/46271#issuecomment-1741725578
Comment:
Thanks for the explanation.
I'm not prepared to do that, so perhaps it would be better if someone else submitted a different PR.
^ permalink raw reply [flat|nested] 27+ messages in thread