[ISSUE] cmake style removes subdir from git top tree, how to handle repo with CMakeLists.txt in the subdir of the git repo?

[ISSUE] cmake style removes subdir from git top tree, how to handle repo with CMakeLists.txt in the subdir of the git repo?

[michalszmidt]

[-- Attachment #1: Type: text/plain, Size: 1889 bytes --]

New issue by michalszmidt on void-packages repository

https://github.com/void-linux/void-packages/issues/47761

Description:
<!--
  if you are creating a bug report or package request, please fill out one of the forms here:
  https://github.com/void-linux/void-packages/issues/new/choose

  Don't request an update of a package, We have a script for that:
  https://repo-default.voidlinux.org/void-updates/void-updates.txt
  However, a quality pull request may help.
-->

```ini
# Templaet file for Koi

pkgname=Koi
version=0.2.4
revision=1
build_style=cmake
configure_args="-DCMAKE_INSTALL_PREFIX=/usr"
hostmakedepends="pkg-config"
makedepends="extra-cmake-modules kcoreaddons-devel qt5-core qt5-dbus qt5-test qt5-core qt5-network kwidgetsaddons-devel hicolor-icon-theme kpackage-devel kcoreaddons-devel kconfig-devel desktop-file-utils fdupes"
short_desc="Switch between light and dark themes on KDE Plasma"
maintainer="Michał Szmidt <michal.sz@disroot.org>"
license="LGPL-3.0"
homepage="https://github.com/baduhai/Koi"
distfiles="https://github.com/baduhai/Koi/archive/refs/tags/${version}.tar.gz"
checksum=e8c976f4f635bed614124fa6afb8853cc9669ec9132c16b140cc64fb4be0166b
```

[This cmake project](https://github.com/baduhai/Koi) has CMakeLists.txt in the src subdir of the git repo, I opened issue addressing it.

https://github.com/baduhai/Koi/issues/77

I could not find any way to make xbps-src handle it correctly

I have tried:
1. According to https://github.com/void-linux/void-packages/issues/20878 I've set up `build_wrksrc` var. It ended with error `could not enter build_wrksrc`. This is weird as when I did `ls -lah` in there `src/` has been deleted (dunno what phase it was).
2. Trying to `mv src/* .` with similar issue of `src/` subdir being deleted in some previous stage.

Does cmake build style delete subdirs from git top tree?

Re: cmake style removes subdir from git top tree, how to handle repo with CMakeLists.txt in the subdir of the git repo?

[sgn]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/47761#issuecomment-1857203935

Comment:
`build_wrksrc=src` ???

Re: [ISSUE] [CLOSED] cmake style removes subdir from git top tree, how to handle repo with CMakeLists.txt in the subdir of the git repo?

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1892 bytes --]

Closed issue by michalszmidt on void-packages repository

https://github.com/void-linux/void-packages/issues/47761

Description:
<!--
  if you are creating a bug report or package request, please fill out one of the forms here:
  https://github.com/void-linux/void-packages/issues/new/choose

  Don't request an update of a package, We have a script for that:
  https://repo-default.voidlinux.org/void-updates/void-updates.txt
  However, a quality pull request may help.
-->

```ini
# Templaet file for Koi

pkgname=Koi
version=0.2.4
revision=1
build_style=cmake
configure_args="-DCMAKE_INSTALL_PREFIX=/usr"
hostmakedepends="pkg-config"
makedepends="extra-cmake-modules kcoreaddons-devel qt5-core qt5-dbus qt5-test qt5-core qt5-network kwidgetsaddons-devel hicolor-icon-theme kpackage-devel kcoreaddons-devel kconfig-devel desktop-file-utils fdupes"
short_desc="Switch between light and dark themes on KDE Plasma"
maintainer="Michał Szmidt <michal.sz@disroot.org>"
license="LGPL-3.0"
homepage="https://github.com/baduhai/Koi"
distfiles="https://github.com/baduhai/Koi/archive/refs/tags/${version}.tar.gz"
checksum=e8c976f4f635bed614124fa6afb8853cc9669ec9132c16b140cc64fb4be0166b
```

[This cmake project](https://github.com/baduhai/Koi) has CMakeLists.txt in the src subdir of the git repo, I opened issue addressing it.

https://github.com/baduhai/Koi/issues/77

I could not find any way to make xbps-src handle it correctly

I have tried:
1. According to https://github.com/void-linux/void-packages/issues/20878 I've set up `build_wrksrc` var. It ended with error `could not enter build_wrksrc`. This is weird as when I did `ls -lah` in there `src/` has been deleted (dunno what phase it was).
2. Trying to `mv src/* .` with similar issue of `src/` subdir being deleted in some previous stage.

Does cmake build style delete subdirs from git top tree?

Re: [ISSUE] [CLOSED] cmake style removes subdir from git top tree, how to handle repo with CMakeLists.txt in the subdir of the git repo?

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1892 bytes --]

Closed issue by michalszmidt on void-packages repository

https://github.com/void-linux/void-packages/issues/47761

Description:
<!--
  if you are creating a bug report or package request, please fill out one of the forms here:
  https://github.com/void-linux/void-packages/issues/new/choose

  Don't request an update of a package, We have a script for that:
  https://repo-default.voidlinux.org/void-updates/void-updates.txt
  However, a quality pull request may help.
-->

```ini
# Templaet file for Koi

pkgname=Koi
version=0.2.4
revision=1
build_style=cmake
configure_args="-DCMAKE_INSTALL_PREFIX=/usr"
hostmakedepends="pkg-config"
makedepends="extra-cmake-modules kcoreaddons-devel qt5-core qt5-dbus qt5-test qt5-core qt5-network kwidgetsaddons-devel hicolor-icon-theme kpackage-devel kcoreaddons-devel kconfig-devel desktop-file-utils fdupes"
short_desc="Switch between light and dark themes on KDE Plasma"
maintainer="Michał Szmidt <michal.sz@disroot.org>"
license="LGPL-3.0"
homepage="https://github.com/baduhai/Koi"
distfiles="https://github.com/baduhai/Koi/archive/refs/tags/${version}.tar.gz"
checksum=e8c976f4f635bed614124fa6afb8853cc9669ec9132c16b140cc64fb4be0166b
```

[This cmake project](https://github.com/baduhai/Koi) has CMakeLists.txt in the src subdir of the git repo, I opened issue addressing it.

https://github.com/baduhai/Koi/issues/77

I could not find any way to make xbps-src handle it correctly

I have tried:
1. According to https://github.com/void-linux/void-packages/issues/20878 I've set up `build_wrksrc` var. It ended with error `could not enter build_wrksrc`. This is weird as when I did `ls -lah` in there `src/` has been deleted (dunno what phase it was).
2. Trying to `mv src/* .` with similar issue of `src/` subdir being deleted in some previous stage.

Does cmake build style delete subdirs from git top tree?

Re: cmake style removes subdir from git top tree, how to handle repo with CMakeLists.txt in the subdir of the git repo?

[sgn]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/47761#issuecomment-1857207703

Comment:
```bash
# Templaet file for Koi
pkgname=Koi
version=0.2.4
revision=1
build_wrksrc=src
build_style=cmake
hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools hicolor-icon-theme  desktop-file-utils fdupes"
makedepends=" kcoreaddons-devel qt5-devel kwidgetsaddons-devel kpackage-devel kcoreaddons-devel kconfig-devel"
short_desc="Switch between light and dark themes on KDE Plasma"
maintainer="Michał Szmidt <michal.sz@disroot.org>"
license="LGPL-3.0"
homepage="https://github.com/baduhai/Koi"
distfiles="https://github.com/baduhai/Koi/archive/refs/tags/${version}.tar.gz"
checksum=e8c976f4f635bed614124fa6afb8853cc9669ec9132c16b140cc64fb4be0166b
```

Re: cmake style removes subdir from git top tree, how to handle repo with CMakeLists.txt in the subdir of the git repo?

[michalszmidt]

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

New comment by michalszmidt on void-packages repository

https://github.com/void-linux/void-packages/issues/47761#issuecomment-1861519914

Comment:
> ```shell
> # Templaet file for Koi
> pkgname=Koi
> version=0.2.4
> revision=1
> build_wrksrc=src
> build_style=cmake
> hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools hicolor-icon-theme  desktop-file-utils fdupes"
> makedepends=" kcoreaddons-devel qt5-devel kwidgetsaddons-devel kpackage-devel kcoreaddons-devel kconfig-devel"
> short_desc="Switch between light and dark themes on KDE Plasma"
> maintainer="Michał Szmidt <michal.sz@disroot.org>"
> license="LGPL-3.0"
> homepage="https://github.com/baduhai/Koi"
> distfiles="https://github.com/baduhai/Koi/archive/refs/tags/${version}.tar.gz"
> checksum=e8c976f4f635bed614124fa6afb8853cc9669ec9132c16b140cc64fb4be0166b
> ```

Fails with:

```
/void-packages/common/xbps-src/shutils/common.sh: line 69: cd: src: No such file or directory
=> ERROR: Koi-0.2.4_1: cannot access build_wrksrc directory [src]

```

Re: cmake style removes subdir from git top tree, how to handle repo with CMakeLists.txt in the subdir of the git repo?

[sgn]

[-- Attachment #1: Type: text/plain, Size: 2285 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/47761#issuecomment-1862014545

Comment:
What are you talking about??
Did you screw up with xbps-src? Did you do anything?

```
=> Koi-0.2.4_1: installing target dependencies: kcoreaddons-devel-5.112.0_1 qt5-devel-5.15.11+20231124_1 kwidgetsaddons-devel-5.112.0_1 kpackage-devel-5.112.0_1 kcoreaddons-devel-5.112.0_1 kconfig-devel-5.112.0_1 ...
=> Koi-0.2.4_1: running do-fetch hook: 00-distfiles ...
=> Koi-0.2.4_1: running do-extract hook: 00-distfiles ...
=> Koi-0.2.4_1: extracting distfile(s), please wait...
=> Koi-0.2.4_1: running do-patch hook: 00-patches ...
=> Koi-0.2.4_1: running pre-configure hook: 00-gnu-configure-asneeded ...
=> Koi-0.2.4_1: running pre-configure hook: 01-override-config ...
=> Koi-0.2.4_1: running pre-configure hook: 02-script-wrapper ...
=> Koi-0.2.4_1: running do_configure ...
-- The CXX compiler identification is GNU 12.2.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/lib/ccache/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done (0.2s)
-- Generating done (0.0s)
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_INSTALL_LIBDIR
    CMAKE_INSTALL_SBINDIR
    CMAKE_INSTALL_SYSCONFDIR


-- Build files have been written to: /builddir/Koi-0.2.4/src/build
=> Koi-0.2.4_1: running pre-build hook: 02-script-wrapper ...
=> Koi-0.2.4_1: running do_build ...
[1/17] Automatic MOC and UIC for target koi
[2/17] Automatic RCC for resources/resources.qrc
[3/17] Building CXX object CMakeFiles/koi.dir/libs/SunRise.cpp.o
[4/17] Building CXX object CMakeFiles/koi.dir/icons.cpp.o
[5/17] Building CXX object CMakeFiles/koi.dir/colorscheme.cpp.o
[6/17] Building CXX object CMakeFiles/koi.dir/kvantumstyle.cpp.o
[7/17] Building CXX object CMakeFiles/koi.dir/plasmastyle.cpp.o
[8/17] Building CXX object CMakeFiles/koi.dir/koi_autogen/3YJK5W5UP7/qrc_resources.cpp.o
[9/17] Building CXX object CMakeFiles/koi.dir/about.cpp.o
[10/17] Building CXX object CMakeFiles/koi.dir/license.cpp.o
[11/17] Building CXX object CMakeFiles/koi.dir/gtk.cpp.o

```

Re: cmake style removes subdir from git top tree, how to handle repo with CMakeLists.txt in the subdir of the git repo?

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/issues/47761#issuecomment-1862108420

Comment:
you probably need to `xbps-src clean`

Re: cmake style removes subdir from git top tree, how to handle repo with CMakeLists.txt in the subdir of the git repo?

[michalszmidt]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New comment by michalszmidt on void-packages repository

https://github.com/void-linux/void-packages/issues/47761#issuecomment-1862858889

Comment:
Right, it must have broke. I'll set up it again, thanks a lot!