* [PR PATCH] virtualbox-ose: Include UnattendedTemplates
@ 2024-01-12 21:44 meator
2024-01-12 21:46 ` [PR REVIEW] " classabbyamp
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: meator @ 2024-01-12 21:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
There is a new pull request by meator against master on the void-packages repository
https://github.com/meator/void-packages virtualbox
https://github.com/void-linux/void-packages/pull/48188
virtualbox-ose: Include UnattendedTemplates
These templates enable VirtualBox to do unattended installs. It fails with an error message complaining about missing
`/usr/share/virtualbox/UnattendedTemplates` without it.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/48188.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-virtualbox-48188.patch --]
[-- Type: text/x-diff, Size: 1138 bytes --]
From 154e1536f3216ea5c7417624fb5562df69d0974a Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Fri, 12 Jan 2024 22:36:44 +0100
Subject: [PATCH] virtualbox-ose: Include UnattendedTemplates
These templates enable VirtualBox to do unattended installs. It fails
with an error message complaining about missing
/usr/share/virtualbox/UnattendedTemplates without it.
---
srcpkgs/virtualbox-ose/template | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/virtualbox-ose/template b/srcpkgs/virtualbox-ose/template
index c0cf9f0136c2a..fa973e475ea93 100644
--- a/srcpkgs/virtualbox-ose/template
+++ b/srcpkgs/virtualbox-ose/template
@@ -1,7 +1,7 @@
# Template file for 'virtualbox-ose'
pkgname=virtualbox-ose
version=7.0.12a
-revision=1
+revision=2
short_desc="General-purpose full virtualizer for x86 hardware"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-only, CDDL-1.0"
@@ -116,6 +116,9 @@ do_install() {
vsv vboxwebsrv
vdoc ${FILESDIR}/README.voidlinux
+
+ # UnattendedTemplates
+ vcopy UnattendedTemplates usr/share/virtualbox
}
virtualbox-ose-dkms_package() {
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] virtualbox-ose: Include UnattendedTemplates
2024-01-12 21:44 [PR PATCH] virtualbox-ose: Include UnattendedTemplates meator
@ 2024-01-12 21:46 ` classabbyamp
2024-01-12 21:59 ` [PR PATCH] [Updated] " meator
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2024-01-12 21:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/48188#discussion_r1450953650
Comment:
```suggestion
```
self-explanatory
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] virtualbox-ose: Include UnattendedTemplates
2024-01-12 21:44 [PR PATCH] virtualbox-ose: Include UnattendedTemplates meator
2024-01-12 21:46 ` [PR REVIEW] " classabbyamp
@ 2024-01-12 21:59 ` meator
2024-01-12 22:00 ` meator
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: meator @ 2024-01-12 21:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]
There is an updated pull request by meator against master on the void-packages repository
https://github.com/meator/void-packages virtualbox
https://github.com/void-linux/void-packages/pull/48188
virtualbox-ose: Include UnattendedTemplates
These templates enable VirtualBox to do unattended installs. It fails with an error message complaining about missing
`/usr/share/virtualbox/UnattendedTemplates` without it.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/48188.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-virtualbox-48188.patch --]
[-- Type: text/x-diff, Size: 1113 bytes --]
From 0dc7648dc765d29a3bb321c952cebbf226834836 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Fri, 12 Jan 2024 22:36:44 +0100
Subject: [PATCH] virtualbox-ose: Include UnattendedTemplates
These templates enable VirtualBox to do unattended installs. It fails
with an error message complaining about missing
/usr/share/virtualbox/UnattendedTemplates without it.
---
srcpkgs/virtualbox-ose/template | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/virtualbox-ose/template b/srcpkgs/virtualbox-ose/template
index c0cf9f0136c2a..46c5e2f3d6b92 100644
--- a/srcpkgs/virtualbox-ose/template
+++ b/srcpkgs/virtualbox-ose/template
@@ -1,7 +1,7 @@
# Template file for 'virtualbox-ose'
pkgname=virtualbox-ose
version=7.0.12a
-revision=1
+revision=2
short_desc="General-purpose full virtualizer for x86 hardware"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-only, CDDL-1.0"
@@ -116,6 +116,8 @@ do_install() {
vsv vboxwebsrv
vdoc ${FILESDIR}/README.voidlinux
+
+ vcopy UnattendedTemplates usr/share/virtualbox
}
virtualbox-ose-dkms_package() {
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] virtualbox-ose: Include UnattendedTemplates
2024-01-12 21:44 [PR PATCH] virtualbox-ose: Include UnattendedTemplates meator
2024-01-12 21:46 ` [PR REVIEW] " classabbyamp
2024-01-12 21:59 ` [PR PATCH] [Updated] " meator
@ 2024-01-12 22:00 ` meator
2024-01-12 22:37 ` meator
2024-01-14 6:46 ` [PR PATCH] [Merged]: " sgn
4 siblings, 0 replies; 6+ messages in thread
From: meator @ 2024-01-12 22:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]
There is an updated pull request by meator against master on the void-packages repository
https://github.com/meator/void-packages virtualbox
https://github.com/void-linux/void-packages/pull/48188
virtualbox-ose: Include UnattendedTemplates
These templates enable VirtualBox to do unattended installs. It fails with an error message complaining about missing
`/usr/share/virtualbox/UnattendedTemplates` without it.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
[ci skip] I will provide build testing soon.
A patch file from https://github.com/void-linux/void-packages/pull/48188.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-virtualbox-48188.patch --]
[-- Type: text/x-diff, Size: 1113 bytes --]
From 0d0b747569535c3133ed94f5d75c8408a49b0947 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Fri, 12 Jan 2024 22:36:44 +0100
Subject: [PATCH] virtualbox-ose: Include UnattendedTemplates
These templates enable VirtualBox to do unattended installs. It fails
with an error message complaining about missing
/usr/share/virtualbox/UnattendedTemplates without it.
---
srcpkgs/virtualbox-ose/template | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/virtualbox-ose/template b/srcpkgs/virtualbox-ose/template
index c0cf9f0136c2a..46c5e2f3d6b92 100644
--- a/srcpkgs/virtualbox-ose/template
+++ b/srcpkgs/virtualbox-ose/template
@@ -1,7 +1,7 @@
# Template file for 'virtualbox-ose'
pkgname=virtualbox-ose
version=7.0.12a
-revision=1
+revision=2
short_desc="General-purpose full virtualizer for x86 hardware"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-only, CDDL-1.0"
@@ -116,6 +116,8 @@ do_install() {
vsv vboxwebsrv
vdoc ${FILESDIR}/README.voidlinux
+
+ vcopy UnattendedTemplates usr/share/virtualbox
}
virtualbox-ose-dkms_package() {
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: virtualbox-ose: Include UnattendedTemplates
2024-01-12 21:44 [PR PATCH] virtualbox-ose: Include UnattendedTemplates meator
` (2 preceding siblings ...)
2024-01-12 22:00 ` meator
@ 2024-01-12 22:37 ` meator
2024-01-14 6:46 ` [PR PATCH] [Merged]: " sgn
4 siblings, 0 replies; 6+ messages in thread
From: meator @ 2024-01-12 22:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 275 bytes --]
New comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/48188#issuecomment-1890071832
Comment:
There aren't many architectures to test because the template supports only x86_64. I have tested it on this architecture and it works.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: virtualbox-ose: Include UnattendedTemplates
2024-01-12 21:44 [PR PATCH] virtualbox-ose: Include UnattendedTemplates meator
` (3 preceding siblings ...)
2024-01-12 22:37 ` meator
@ 2024-01-14 6:46 ` sgn
4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2024-01-14 6:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]
There's a merged pull request on the void-packages repository
virtualbox-ose: Include UnattendedTemplates
https://github.com/void-linux/void-packages/pull/48188
Description:
These templates enable VirtualBox to do unattended installs. It fails with an error message complaining about missing
`/usr/share/virtualbox/UnattendedTemplates` without it.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
[ci skip] I will provide build testing soon.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-01-14 6:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-12 21:44 [PR PATCH] virtualbox-ose: Include UnattendedTemplates meator
2024-01-12 21:46 ` [PR REVIEW] " classabbyamp
2024-01-12 21:59 ` [PR PATCH] [Updated] " meator
2024-01-12 22:00 ` meator
2024-01-12 22:37 ` meator
2024-01-14 6:46 ` [PR PATCH] [Merged]: " sgn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).